Re: [ovs-dev] [PATCH v3 11/18] datapath: conntrack NAT helper compat code for Linux 4.5 and earlier.

2016-06-20 Thread Jesse Gross
On Mon, Jun 20, 2016 at 2:58 PM, Jarno Rajahalme wrote: > Thanks for the review Jesse, responses below: > >> On Jun 20, 2016, at 2:39 PM, Jesse Gross wrote: >> >> On Fri, Jun 17, 2016 at 6:44 PM, Jarno Rajahalme wrote: >>> diff --git

Re: [ovs-dev] [PATCH v3 11/18] datapath: conntrack NAT helper compat code for Linux 4.5 and earlier.

2016-06-20 Thread Jarno Rajahalme
Thanks for the review Jesse, responses below: > On Jun 20, 2016, at 2:39 PM, Jesse Gross wrote: > > On Fri, Jun 17, 2016 at 6:44 PM, Jarno Rajahalme wrote: >> diff --git a/datapath/conntrack.c b/datapath/conntrack.c >> index 4b3b78e..40e9843 100644 >> ---

Re: [ovs-dev] [PATCH v3 11/18] datapath: conntrack NAT helper compat code for Linux 4.5 and earlier.

2016-06-20 Thread Jesse Gross
On Fri, Jun 17, 2016 at 6:44 PM, Jarno Rajahalme wrote: > diff --git a/datapath/conntrack.c b/datapath/conntrack.c > index 4b3b78e..40e9843 100644 > --- a/datapath/conntrack.c > +++ b/datapath/conntrack.c > @@ -337,6 +338,38 @@ static int ovs_ct_helper(struct sk_buff *skb, u16

[ovs-dev] [PATCH v3 11/18] datapath: conntrack NAT helper compat code for Linux 4.5 and earlier.

2016-06-17 Thread Jarno Rajahalme
Upstream commit: commit 264619055bd52bc2278af848472176642d759874 Author: Jarno Rajahalme Date: Thu Mar 10 10:54:17 2016 -0800 netfilter: Allow calling into nat helper without skb_dst. NAT checksum recalculation code assumes existence of skb_dst, which