Re: [ovs-dev] [PATCH v3 2/3] datapath-windows: Add multiple switch internal ports

2016-08-12 Thread Alin Serdean
- yes, the assert is needed for roleover >+ASSERT(switchContext->countInternalVports >= 0); >+OvsInternalAdapterDown(vport->portNo, >vport->netCfgInstanceId); > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Al

Re: [ovs-dev] [PATCH v3 2/3] datapath-windows: Add multiple switch internal ports

2016-08-12 Thread Alin Serdean
ct: Re: [ovs-dev] [PATCH v3 2/3] datapath-windows: Add multiple > switch internal ports > > > > >-if (status == NDIS_STATUS_SUCCESS) { > > Sai: Could switchFwdInfo.vport be NULL is status == > NDIS_STATUS_SUCCESS? [Alin Serdean] Yes status can be SUCCESS and the swit

Re: [ovs-dev] [PATCH v3 2/3] datapath-windows: Add multiple switch internal ports

2016-08-09 Thread Sairam Venugopal
Hi Alin, I took a preliminary look at the patch and have added some review comments. I was mainly concerned about the use of switchContext->internalPortId when we no longer have switchContext->internalVport and we can have multiple internal ports. Thanks, Sairam On 8/2/16, 12:47 PM, "Alin

Re: [ovs-dev] [PATCH v3 2/3] datapath-windows: Add multiple switch internal ports

2016-08-07 Thread Alin Serdean
t; Subiect: Re: [ovs-dev] [PATCH v3 2/3] datapath-windows: Add multiple > switch internal ports > > Hi Alin, > > I keep getting this error (different GUID( when I try to add a bridge - > 'ovs-vsctl add-br br-pif' > > OvsAddIpInterfaceNotification:647 Fail to get IF entry f

[ovs-dev] [PATCH v3 2/3] datapath-windows: Add multiple switch internal ports

2016-08-02 Thread Alin Serdean
This patch adds multiple internal ports support to the windows datapath. All tunnels types have been updated to accommodate this new functionality. Signed-off-by: Alin Gabriel Serdean Co-authored-by: Sorin Vinturis Acked-by: