___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
nitpick, could we move this deletion to next commit?
Make sense. I moved it.
Acked-by: Alex Wang al...@nicira.com
Thanks for the review. Pushed to master.
/* ctl_fatal() also logs the error, so it is preferred in this file. */
@@ -250,9 +247,8 @@ struct ctl_table_class {
* entry. */
On Thu, Jul 9, 2015 at 1:27 PM, Andy Zhou az...@nicira.com wrote:
Both get_table() and set_cloum() APIs are mostly used within db-ctl-base
library. This patch makes both private to the library.
Add a new ctl_set_colum() API for library client.
The changes are cleanups. No functional
Acked-by: Alex Wang al...@nicira.com
On Thu, Jul 9, 2015 at 1:27 PM, Andy Zhou az...@nicira.com wrote:
Instead, client now pass it via the modified ctl_init() API.
Siigned-off-by: Andy Zhou az...@nicira.com
---
lib/db-ctl-base.c | 8 +++-
lib/db-ctl-base.h | 8 ++--
Acked-by: Alex Wang al...@nicira.com
On Thu, Jul 9, 2015 at 1:27 PM, Andy Zhou az...@nicira.com wrote:
This file follows a convention that all static functions are grouped
towards the beginning, ahead of public functions. Re-arrange the code
to confirm to this convention. No functional
This file follows a convention that all static functions are grouped
towards the beginning, ahead of public functions. Re-arrange the code
to confirm to this convention. No functional changes.
Signed-off-by: Andy Zhou az...@nicira.com
---
lib/db-ctl-base.c | 166
Both get_table() and set_cloum() APIs are mostly used within db-ctl-base
library. This patch makes both private to the library.
Add a new ctl_set_colum() API for library client.
The changes are cleanups. No functional changes.
Signed-off-by: Andy Zhou az...@nicira.com
---
lib/db-ctl-base.c
Minor cleanups in db-ctl-base library, and in prepare for ovsdb join related
changes in the library.
v1-v2:
Drop the first patch that has been committed.
group static functions together
Fix comments
Andy Zhou (3):
db-ctl-base: do not expose get_table() API
db-ctl-base: do not
Instead, client now pass it via the modified ctl_init() API.
Siigned-off-by: Andy Zhou az...@nicira.com
---
lib/db-ctl-base.c | 8 +++-
lib/db-ctl-base.h | 8 ++--
utilities/ovs-vsctl.c | 4 ++--
vtep/vtep-ctl.c | 4 ++--
4 files changed, 13 insertions(+), 11 deletions(-)
Looks Good.
On Tue, Feb 8, 2011 at 4:00 PM, Ben Pfaff b...@nicira.com wrote:
---
ovsdb/ovsdb-tool.1.in | 7 +++
ovsdb/ovsdb-tool.c | 15 +++
ovsdb/ovsdb.c | 17 +
ovsdb/ovsdb.h | 3 +++
tests/ovsdb-tool.at | 22
I tested the xenserver version but not the Debian version.
---
debian/openvswitch-switch.init | 13 -
xenserver/etc_init.d_openvswitch | 15 ---
2 files changed, 16 insertions(+), 12 deletions(-)
diff --git a/debian/openvswitch-switch.init
On Tue, Feb 8, 2011 at 4:02 PM, Ethan Jackson et...@nicira.com wrote:
I'll review this series unless someone else really wants to.
But Justin is so *fond* of the database...
--
I don't normally do acked-by's. I think it's my way of avoiding
getting blamed when it all blows up.
13 matches
Mail list logo
