Re: [ovs-dev] [PATCH] netdev-provider: Apply batch object to netdev provider.

1. We can use batch API: Example1: -for (i = 0; i < cnt; i++) { -dp_packet_delete(pkts[i]); -} +dp_packet_delete_batch(batch, may_steal); Example2: -for (i = 0; i < cnt; i++) { -int cutlen = dp_packet_get_cutlen(pkts[i]); - -

Re: [ovs-dev] [PATCH] netdev-provider: Apply batch object to netdev provider.

On Fri, Jun 24, 2016 at 04:11:47PM -0700, William Tu wrote: > This patch applies the packet batch object to the netdev providers, > including dummy, Linux, BSD, and DPDK. > > Tested-at: https://travis-ci.org/williamtu/ovs-travis/builds/140135888 > Signed-off-by: William Tu

Re: [ovs-dev] [PATCH] FAQ: Describe how to use "learn" as a primitive.

On Sun, Jun 19, 2016 at 02:42:29PM -0500, Ryan Moats wrote: > "dev" wrote on 06/19/2016 12:24:11 PM: > > > From: Ben Pfaff > > To: dev@openvswitch.org > > Cc: Ben Pfaff > > Date: 06/19/2016 12:24 PM > > Subject: [ovs-dev] [PATCH] FAQ:

[ovs-dev] Cooperation with the great company

Hello! We are looking for employees working remotely. My name is Lourdes, am the personnel manager of a large International company. Most of the work you can do from home, that is, at a distance. Salary is $2500-$5000. If you are interested in this offer, please visit Our Site Best

[ovs-dev] Career growth

Hello! We are looking for employees working remotely. My name is Sonja, am the personnel manager of a large International company. Most of the work you can do from home, that is, at a distance. Salary is $2500-$5000. If you are interested in this offer, please visit Our Site Best

Re: [ovs-dev] [PATCH V3] ipfix: Export user specified virtual observation ID

Thanks! On Sat, Jun 25, 2016 at 04:34:49AM +, Daniel Ye wrote: > OK, I got it and I will handle this. > > Bests, > Daniel > > > On Jun 25, 2016, at 12:22 PM, Ben Pfaff wrote: > > > > On Sat, Jun 25, 2016 at 04:12:04AM +, Daniel Ye wrote: > >> It’s because of the "packet

Re: [ovs-dev] [PATCH] netdev-linux: Do not log a warning if the device is down.

On Fri, Jun 10, 2016 at 03:52:16PM -0700, Daniele Di Proietto wrote: > In the userspace datapath we use tap devices as internal netdev. The > datapath doesn't consider whether a device is up or down before sending > to it, and so far this hasn't been a problem. > > Since Linux upstream commit

Re: [ovs-dev] [PATCH V3] ipfix: Export user specified virtual observation ID

OK, I got it and I will handle this. Bests, Daniel > On Jun 25, 2016, at 12:22 PM, Ben Pfaff wrote: > > On Sat, Jun 25, 2016 at 04:12:04AM +, Daniel Ye wrote: >> It’s because of the "packet send error" statistic. The test of checking >> IPFIX statistics set collector as

[ovs-dev] [PATCH v2] sset: New function sset_from_delimited_string().

This simplifies code in a couple of places. Signed-off-by: Ben Pfaff --- v1->v2: Fix compile errors. lib/sset.c| 21 - lib/sset.h| 3 +++ ovn/utilities/ovn-sbctl.c | 10 ++ ovsdb/replication.c | 12 +--- 4

Re: [ovs-dev] [PATCH] sset: New function sset_from_delimited_string().

On Fri, Jun 24, 2016 at 05:16:03PM -0700, Ben Pfaff wrote: > This simplifies code in a couple of places. > > Signed-off-by: Ben Pfaff Oops, this doesn't build. I'll send v2. ___ dev mailing list dev@openvswitch.org

[ovs-dev] [PATCH] util: New function nullable_xstrdup().

It's a pretty common pattern so create a function for it. Signed-off-by: Ben Pfaff --- lib/dpif-netdev.c| 6 ++ lib/jsonrpc.c| 2 +- lib/ovsdb-error.c| 6 +++--- lib/syslog-libc.c| 4 ++-- lib/util.c | 8

Re: [ovs-dev] [PATCH V3] ipfix: Export user specified virtual observation ID

On Sat, Jun 25, 2016 at 04:12:04AM +, Daniel Ye wrote: > It’s because of the "packet send error" statistic. The test of checking IPFIX > statistics set collector as “127.0.0.1:4739”. > Test code: > - > dnl Sample every packet using

Re: [ovs-dev] [PATCH V3] ipfix: Export user specified virtual observation ID

Hi Ben, It’s because of the "packet send error" statistic. The test of checking IPFIX statistics set collector as “127.0.0.1:4739”. Test code: - dnl Sample every packet using bridge-based sampling. AT_CHECK([ovs-vsctl -- set bridge br0

Re: [ovs-dev] [PATCH V3] ipfix: Export user specified virtual observation ID

The tests under "make check" try to be environment independent. Do you know what factor of your environment caused the failures? Perhaps we can fix it. On Sat, Jun 25, 2016 at 01:11:04AM +, Wenyu Zhang wrote: > It is caused by an environment issue. > Clear the environment and rerun the

Re: [ovs-dev] [PATCH V3] ipfix: Export user specified virtual observation ID

On Fri, Jun 24, 2016 at 05:10:07PM -0700, Wenyu Zhang wrote: > In virtual network, users want more info about the virtual point to observe > the traffic. > It should be a string to provide clear info, not a simple interger ID. > > Introduce "other-config: virtual_obs_id" in IPFIX, which is a

Re: [ovs-dev] [OVN] Potential scalability bug in ovn-northd on creating and binding large number of lports

On Fri, Jun 24, 2016 at 08:52:07PM -0700, Ben Pfaff wrote: > On Thu, Jun 23, 2016 at 01:56:59PM -0400, Hui Kang wrote: > > > > Hi, > > In our scalability test for OVN, we observed an in-scalable behaviour of > > the > > ovn-northd process: the time binding a logical port increases as # of large >

Re: [ovs-dev] [OVN] Potential scalability bug in ovn-northd on creating and binding large number of lports

On Thu, Jun 23, 2016 at 01:56:59PM -0400, Hui Kang wrote: > > Hi, > In our scalability test for OVN, we observed an in-scalable behaviour of > the > ovn-northd process: the time binding a logical port increases as # of large > port increasing, regardless of whether logical ports belong to the

Re: [ovs-dev] [OVN] Potential scalability bug in ovn-northd on creating and binding large number of lports

Ryan Moats/Omaha/IBM wrote on 06/24/2016 10:51:10 PM: > From: Ryan Moats/Omaha/IBM > To: Hui Kang/Watson/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 06/24/2016 10:51 PM > Subject: Re: [ovs-dev] [OVN] Potential scalability bug in ovn-northd > on creating and binding large number of lports > >

Re: [ovs-dev] [OVN] Potential scalability bug in ovn-northd on creating and binding large number of lports

"dev" wrote on 06/23/2016 12:56:59 PM: > From: Hui Kang/Watson/IBM@IBMUS > To: dev@openvswitch.org > Date: 06/23/2016 12:57 PM > Subject: [ovs-dev] [OVN] Potential scalability bug in ovn-northd on > creating and binding large number of lports > Sent by: "dev"

Re: [ovs-dev] [PATCH 0/4] Restore ovn-controller binding functionality.

Ben Pfaff wrote on 06/24/2016 09:03:13 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org, Russell Bryant > Date: 06/24/2016 09:03 PM > Subject: Re: [PATCH 0/4] Restore ovn-controller binding functionality. > > On Fri,

Re: [ovs-dev] [PATCH] debian: Fix upgrade from OVS-2.5 to newer OVS.

On Wed, Jun 22, 2016 at 11:30:16AM -0700, Guru Shetty wrote: > On 17 June 2016 at 12:42, Joe Stringer wrote: > > > Commit 0dcc739e7a28 ("debian: Move ovs-lib to openvswitch-common.") > > shifted a file between debian packages, but didn't update the > > destination package

Re: [ovs-dev] [PATCH] debian: Fix upgrade from OVS-2.5 to newer OVS.

dpkg is a pretty low-level tool that users wouldn't ordinarily use. Users should ordinarily be using "apt" or something else that does proper sequencing based on dependencies. On Tue, Jun 21, 2016 at 11:43:53AM -0700, Daniele Di Proietto wrote: > This looks good to me according to the debian

Re: [ovs-dev] [PATCH 0/4] Restore ovn-controller binding functionality.

On Fri, Jun 24, 2016 at 07:57:40PM -0500, Ryan Moats wrote: > > > Ben Pfaff wrote on 06/24/2016 06:05:16 PM: > > > From: Ben Pfaff > > To: Ryan Moats/Omaha/IBM@IBMUS > > Cc: dev@openvswitch.org, Russell Bryant > > Date: 06/24/2016 06:05 PM > >

Re: [ovs-dev] [PATCH v4 17/17] conntrack: Add 'dl_type' parameter to conntrack_execute().

On 24/06/2016 17:07, "Joe Stringer" wrote: >On 10 June 2016 at 15:47, Daniele Di Proietto wrote: >> Now that dpif_execute has a 'flow' member, it's pretty easy to access a >> the flow (or the matching megaflow) in dp_execute_cb(). >> >> This means

Re: [ovs-dev] [PATCH v4 15/17] system-tests: Add ping through conntrack test.

On 24/06/2016 15:41, "Joe Stringer" wrote: >On 10 June 2016 at 15:47, Daniele Di Proietto wrote: >> Signed-off-by: Daniele Di Proietto > >Thanks, I didn't realise this basic test would actually be really >helpful if there's

Re: [ovs-dev] [PATCH v4 12/17] flow: Generate checksum in flow_compose().

On 24/06/2016 15:37, "Joe Stringer" wrote: >On 10 June 2016 at 15:47, Daniele Di Proietto wrote: >> This is useful to test the connection tracker, which performs checksum >> verification. >> >> Signed-off-by: Daniele Di Proietto

Re: [ovs-dev] [PATCH v4 11/17] flow: Fill udp_len in flow_compose_l4().

On 24/06/2016 15:31, "Joe Stringer" wrote: >On 10 June 2016 at 15:47, Daniele Di Proietto wrote: >> It will be used by connection tracking tests. >> >> Signed-off-by: Daniele Di Proietto > >LGTM. A little surprised this isn't

Re: [ovs-dev] [PATCH v5] ovn: Add software l2 gateway.

> On Jun 23, 2016, at 12:34 PM, Russell Bryant wrote: > > This patch implements one approach to using ovn-controller to implement > a software l2 gateway between logical and physical networks. > > A new logical port type called "l2gateway" is introduced here. It is very >

[ovs-dev] [PATCH] datapath-windows: Conntrack - Fix variable initialization

Initialize the variable pktMdLabel. Signed-off-by: Sairam Venugopal --- datapath-windows/ovsext/Conntrack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath-windows/ovsext/Conntrack.c b/datapath-windows/ovsext/Conntrack.c index ebfdeef..bb28b65

[ovs-dev] [PATCH] datapath-windows: Cleanup conntrack-tcp.c

Update the code to use tcp->flags. This keeps the kernel conntrack-tcp.c file in sync with userspace version. This patch also addresses an warning - 'Comparison of a boolean expression with an integer other than 0 or 1' - (tcp_flags & (TCP_ACK|TCP_RST)) == (TCP_ACK|TCP_RST)) Signed-off-by:

Re: [ovs-dev] [PATCH V3] ipfix: Export user specified virtual observation ID

It is caused by an environment issue. Clear the environment and rerun the tests, all tests passed now. iPhone ? 2016?6?258:35?Wenyu Zhang > ??? All tests passed except following two cases? 1055: ofproto-dpif - Bridge IPFIX statistics check

Re: [ovs-dev] [PATCH 0/4] Restore ovn-controller binding functionality.

Ben Pfaff wrote on 06/24/2016 06:05:16 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org, Russell Bryant > Date: 06/24/2016 06:05 PM > Subject: Re: [PATCH 0/4] Restore ovn-controller binding functionality. > > On

Re: [ovs-dev] [PATCH V2] ipfix: Export user specified virtual observation ID

I have fixed the issue, and sent out a new patch. Due to the result of this feature only can been seen in the exported IPFIX packet, the test case for it may be a big work. We may consider it with other IPFIX features tests a litter later. 发自我的 iPhone > 在 2016年6月25日，上午6:20，Wenyu Zhang

Re: [ovs-dev] [PATCH V3] ipfix: Export user specified virtual observation ID

All tests passed except following two cases? 1055: ofproto-dpif - Bridge IPFIX statistics checkFAILED (ofproto-dpif.at:5975) 1058: ofproto-dpif - Flow IPFIX statistics check FAILED (ofproto-dpif.at:6140) The errors exist without this

Re: [ovs-dev] [PATCH v4 05/17] conntrack: Periodically delete expired connections.

On 24 June 2016 at 16:42, Daniele Di Proietto wrote: > Thanks for your comments Joe, replies inline > > > > On 24/06/2016 15:29, "Joe Stringer" wrote: > >>On 10 June 2016 at 15:47, Daniele Di Proietto wrote: >>> This commit adds a

Re: [ovs-dev] [PATCH 4/4] ovsdb: Add unixctl commands for OVSDB replication

On Fri, Jun 24, 2016 at 04:44:05PM -0700, Ben Pfaff wrote: > From: Mario Cabrera > > Set and get the server to replicate from: > > ovsdb-server/set-remote-ovsdb-server {server} > ovsdb-server/get-remote-ovsdb-server > > Set and get the replicated table

[ovs-dev] [PATCH] sset: New function sset_from_delimited_string().

This simplifies code in a couple of places. Signed-off-by: Ben Pfaff --- lib/sset.c| 21 - lib/sset.h| 3 +++ ovn/utilities/ovn-sbctl.c | 10 ++ ovsdb/replication.c | 12 +--- 4 files changed, 26

[ovs-dev] [PATCH V3] ipfix: Export user specified virtual observation ID

In virtual network, users want more info about the virtual point to observe the traffic. It should be a string to provide clear info, not a simple interger ID. Introduce "other-config: virtual_obs_id" in IPFIX, which is a string configured by user. Introduce an enterprise IPFIX entity

Re: [ovs-dev] [PATCH v4 17/17] conntrack: Add 'dl_type' parameter to conntrack_execute().

On 10 June 2016 at 15:47, Daniele Di Proietto wrote: > Now that dpif_execute has a 'flow' member, it's pretty easy to access a > the flow (or the matching megaflow) in dp_execute_cb(). > > This means that's not necessary anymore for the connection tracker to > reextract

Re: [ovs-dev] [PATCH 3/4] ovsdb: Add table exclusion functionality to OVSDB replication

On Fri, Jun 24, 2016 at 04:44:04PM -0700, Ben Pfaff wrote: > From: Mario Cabrera > > A blacklist of tables that will be excluded from replication can be > specified by the following option: > > --sync-exclude-tables=db:table[,db:table]… > > Where 'table' corresponds to a

Re: [ovs-dev] [PATCH 2/4] ovsdb: Introduce OVSDB replication feature

On Fri, Jun 24, 2016 at 04:44:03PM -0700, Ben Pfaff wrote: > From: Mario Cabrera > > Replication is enabled by using the following option when starting the > database server: > > --sync-from=server > > Where 'server' can take any form described in the ovsdb-client(1) >

Re: [ovs-dev] [PATCH 1/4] docs: OVSDB replication design document

On Fri, Jun 24, 2016 at 04:44:02PM -0700, Ben Pfaff wrote: > From: Mario Cabrera > > The database replication functionality is designed to provide "fail > over" characteristics. There are two participating databases, one of > which is the "active" database and the other is

[ovs-dev] [PATCH 3/4] ovsdb: Add table exclusion functionality to OVSDB replication

From: Mario Cabrera A blacklist of tables that will be excluded from replication can be specified by the following option: --sync-exclude-tables=db:table[,db:table]… Where 'table' corresponds to a table name, and 'db' corresponds to the database name where the table

[ovs-dev] [PATCH 4/4] ovsdb: Add unixctl commands for OVSDB replication

From: Mario Cabrera Set and get the server to replicate from: ovsdb-server/set-remote-ovsdb-server {server} ovsdb-server/get-remote-ovsdb-server Set and get the replicated table blacklist: ovsdb-server/set-sync-excluded-tables {DB:table,...}

[ovs-dev] [PATCH 1/4] docs: OVSDB replication design document

From: Mario Cabrera The database replication functionality is designed to provide "fail over" characteristics. There are two participating databases, one of which is the "active" database and the other is the "stand by" database. Replication happens exclusively from the

[ovs-dev] [PATCH 2/4] ovsdb: Introduce OVSDB replication feature

From: Mario Cabrera Replication is enabled by using the following option when starting the database server: --sync-from=server Where 'server' can take any form described in the ovsdb-client(1) manpage as an active connection. If this option is specified, the replication

Re: [ovs-dev] [PATCH v4 16/17] conntrack: Track ICMP type and code.

On 10 June 2016 at 15:47, Daniele Di Proietto wrote: > From the connection tracker perspective, an ICMP connection is a tuple > identified by source ip address, destination ip address and ICMP id. > > While this allows basic ICMP traffic (pings) to work, it doesn't take >

Re: [ovs-dev] [PATCH v4 05/17] conntrack: Periodically delete expired connections.

Thanks for your comments Joe, replies inline On 24/06/2016 15:29, "Joe Stringer" wrote: >On 10 June 2016 at 15:47, Daniele Di Proietto wrote: >> This commit adds a thread that periodically removes expired connections. >> >> The expiration time of a

Re: [ovs-dev] [PATCH] datapath:backport: openvswitch: Add packet len info to upcall.

On Fri, Jun 24, 2016 at 3:50 PM, William Tu wrote: > Upstream commit: > commit b95e5928fcc76d156352570858abdea7b2628efd > Author: William Tu > Date: Mon Jun 20 07:26:17 2016 -0700 > > The commit f2a4d086ed4c ("openvswitch: Add packet

[ovs-dev] [PATCH] netdev-provider: Apply batch object to netdev provider.

This patch applies the packet batch object to the netdev providers, including dummy, Linux, BSD, and DPDK. Tested-at: https://travis-ci.org/williamtu/ovs-travis/builds/140135888 Signed-off-by: William Tu --- lib/netdev-bsd.c | 9 -- lib/netdev-dpdk.c | 81

[ovs-dev] [PATCH V11] Function tracer to trace all function calls

From: Nirapada Ghosh In some circumstances, we might need to figure out where in code, the CPU time is being spent most, so as to pinpoint the bottleneck and thereby resolve it with proper changes. Using '-finstrument-functions' flag, that can be achieved, and this patch

Re: [ovs-dev] [PATCH 0/4] Restore ovn-controller binding functionality.

On Fri, Jun 24, 2016 at 04:26:24PM -0500, Ryan Moats wrote: > Ben Pfaff wrote on 06/24/2016 04:16:14 PM: > > I applied it before I saw these messages. > > > > If it doesn't do the job, and there's no obvious further fix, it's just > > one more revert, no big deal. > > No worries -

Re: [ovs-dev] [PATCH V2] ipfix: Export user specified virtual observation ID

Sorry for the stupid mistake. I am working on it，and will verify it by running check. 发自我的 iPhone > 在 2016年6月25日，上午4:43，Ben Pfaff 写道： > >> On Fri, Jun 24, 2016 at 05:25:57AM -0700, Wenyu Zhang wrote: >> In virtual network, users want more info about the virtual point to observe

[ovs-dev] [PATCH] datapath:backport: openvswitch: Add packet len info to upcall.

Upstream commit: commit b95e5928fcc76d156352570858abdea7b2628efd Author: William Tu Date: Mon Jun 20 07:26:17 2016 -0700 The commit f2a4d086ed4c ("openvswitch: Add packet truncation support.") introduces packet truncation before sending to userspace

Re: [ovs-dev] [PATCH v4 15/17] system-tests: Add ping through conntrack test.

On 10 June 2016 at 15:47, Daniele Di Proietto wrote: > Signed-off-by: Daniele Di Proietto Thanks, I didn't realise this basic test would actually be really helpful if there's something fundamentally going wrong in a setup. One minor comment below.

Re: [ovs-dev] [PATCH v4 12/17] flow: Generate checksum in flow_compose().

On 10 June 2016 at 15:47, Daniele Di Proietto wrote: > This is useful to test the connection tracker, which performs checksum > verification. > > Signed-off-by: Daniele Di Proietto The comment above flow_compose() that says that checksums are

Re: [ovs-dev] [PATCH v4 11/17] flow: Fill udp_len in flow_compose_l4().

On 10 June 2016 at 15:47, Daniele Di Proietto wrote: > It will be used by connection tracking tests. > > Signed-off-by: Daniele Di Proietto LGTM. A little surprised this isn't part of another patch, is there something particular you want to

Re: [ovs-dev] [PATCH v4 05/17] conntrack: Periodically delete expired connections.

On 10 June 2016 at 15:47, Daniele Di Proietto wrote: > This commit adds a thread that periodically removes expired connections. > > The expiration time of a connection can be expressed by: > > expiration = now + timeout > > For each possible 'timeout' value (there aren't

Re: [ovs-dev] [PATCH V2] ipfix: Export user specified virtual observation ID

Thanks for your catch. Iam working on it. 发自我的 iPhone > 在 2016年6月25日，上午4:55，William Tu 写道： > > Hi Wenyu, > > I was debugging a little bit and the issue is a NULL pointer deference > of be_cfg at virtual_obs_id = smap_get(_cfg->other_config, > "virtual_obs_id"); > >

Re: [ovs-dev] [PATCH] FAQ: Update support for NAT and Geneve.

Thanks, applied to master. On Fri, Jun 24, 2016 at 3:07 PM, Nithin Raju wrote: > Acked-by: Nithin Raju > > -Original Message- > From: dev on behalf of Jesse Gross > > Date: Friday, June 24, 2016 at

Re: [ovs-dev] [PATCH] FAQ: Update support for NAT and Geneve.

Acked-by: Nithin Raju -Original Message- From: dev on behalf of Jesse Gross Date: Friday, June 24, 2016 at 2:58 PM To: "dev@openvswitch.org" Subject: [ovs-dev] [PATCH] FAQ: Update support for NAT

Re: [ovs-dev] [PATCH] ovn-sbctl: Change lport-(un)bind to lsp-(un)bind.

> On Jun 24, 2016, at 1:37 PM, Russell Bryant wrote: > > A previous commit changed the command names in ovn-nbctl from lport-* to > lsp-*. Change lport-bind and lport-unbind in ovn-sbctl to match. > > Signed-off-by: Russell Bryant > --- >

Re: [ovs-dev] [PATCH 2/2] datapath-windows: Address minor alignment issues in Stt code.

On 24 June 2016 at 14:57, Nithin Raju wrote: > Acked-by: Nithin Raju > Thank you, applied! > > -Original Message- > From: dev on behalf of Yin Lin > > Date: Friday, June 24, 2016 at 2:44 PM > To:

[ovs-dev] [PATCH] FAQ: Update support for NAT and Geneve.

Signed-off-by: Jesse Gross --- FAQ.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/FAQ.md b/FAQ.md index cc4fdf6..9f3dc61 100644 --- a/FAQ.md +++ b/FAQ.md @@ -192,13 +192,13 @@ A: Open vSwitch supports different datapaths on different platforms.

Re: [ovs-dev] [PATCH 2/2] datapath-windows: Address minor alignment issues in Stt code.

Acked-by: Nithin Raju -Original Message- From: dev on behalf of Yin Lin Date: Friday, June 24, 2016 at 2:44 PM To: "dev@openvswitch.org" Cc: Yin Lin Subject: [ovs-dev] [PATCH 2/2]

Re: [ovs-dev] [PATCH v10][PATCH 1/2] datapath-windows: Add Geneve support

Nope. Nithin, can you approve the second patch. It’s a minor whitespace alignment patch. From: Guru Shetty [mailto:g...@ovn.org] Sent: Friday, June 24, 2016 2:48 PM To: Yin Lin Cc: ovs dev Subject: Re: [ovs-dev] [PATCH v10][PATCH 1/2] datapath-windows:

Re: [ovs-dev] [PATCH v10][PATCH 1/2] datapath-windows: Add Geneve support

On 24 June 2016 at 14:44, Yin Lin wrote: > Signed-off-by: Yin Lin > Thank you. I added Nithin's Ack and applied it. Is the second patch of this series reviewed? > --- > datapath-windows/automake.mk | 2 + > datapath-windows/ovsext/Actions.c

Re: [ovs-dev] [PATCH 0/4] Fix IP refragmentation in upcall/execute path.

On Wed, Jun 22, 2016 at 6:00 PM, Joe Stringer wrote: > When the backport of ip_do_fragment() was done, it seemed as though the > upstream version of this function could always be trusted, provided we ensure > that we cannot trigger the ICMP response checks inside the upstream >

Re: [ovs-dev] [PATCH] netdev-dpdk: Fix using uninitialized link_status.

On 24/06/2016 06:54, "Aaron Conole" wrote: >Ilya Maximets writes: > >> 'rte_eth_link_get_nowait()' works only with physical ports. >> In case of vhost-user port, 'link' will stay uninitialized and there >> will be random messages in log about link

[ovs-dev] [PATCH v10][PATCH 1/2] datapath-windows: Add Geneve support

Signed-off-by: Yin Lin --- datapath-windows/automake.mk | 2 + datapath-windows/ovsext/Actions.c | 72 ++- datapath-windows/ovsext/Debug.h| 1 + datapath-windows/ovsext/DpInternal.h | 29 ++- datapath-windows/ovsext/Flow.c | 179

[ovs-dev] [PATCH 2/2] datapath-windows: Address minor alignment issues in Stt code.

Signed-off-by: Yin Lin --- datapath-windows/ovsext/Stt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath-windows/ovsext/Stt.c b/datapath-windows/ovsext/Stt.c index 0bac5f2..5aaf6fe 100644 --- a/datapath-windows/ovsext/Stt.c +++

Re: [ovs-dev] [PATCH 3/4] compat: Backport ip_do_fragment().

On 24 June 2016 at 14:33, Jesse Gross wrote: > On Wed, Jun 22, 2016 at 6:00 PM, Joe Stringer wrote: >> diff --git a/datapath/linux/compat/include/net/ip.h >> b/datapath/linux/compat/include/net/ip.h >> index 29a4d43a1151..581e912cf2dd 100644 >> ---

Re: [ovs-dev] [PATCH] datapath-windows: Remove double semi-colon(; ) in Tunnel.c

On 24 June 2016 at 14:19, Sairam Venugopal wrote: > Found by inspection. > > Signed-off-by: Sairam Venugopal > Applied, thanks! > --- > datapath-windows/ovsext/Tunnel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [ovs-dev] [PATCH 3/4] compat: Backport ip_do_fragment().

On Wed, Jun 22, 2016 at 6:00 PM, Joe Stringer wrote: > diff --git a/datapath/linux/compat/include/net/ip.h > b/datapath/linux/compat/include/net/ip.h > index 29a4d43a1151..581e912cf2dd 100644 > --- a/datapath/linux/compat/include/net/ip.h > +++

Re: [ovs-dev] [PATCH 2/4] compat: ipv4: Pass struct net through ip_fragment.

On 24 June 2016 at 14:00, Jesse Gross wrote: > On Wed, Jun 22, 2016 at 6:00 PM, Joe Stringer wrote: >> diff --git a/acinclude.m4 b/acinclude.m4 >> index 52d0209ab88a..8760948fcf9b 100644 >> --- a/acinclude.m4 >> +++ b/acinclude.m4 >> @@ -408,7 +408,8 @@

Re: [ovs-dev] [PATCH 0/4] Restore ovn-controller binding functionality.

Ben Pfaff wrote on 06/24/2016 04:16:14 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org, Russell Bryant > Date: 06/24/2016 04:16 PM > Subject: Re: [PATCH 0/4] Restore ovn-controller binding functionality. > > On Fri,

Re: [ovs-dev] [PATCH 4/4] ovn: Test that port state goes up and down.

Russell Bryant wrote on 06/24/2016 02:52:11 PM: > From: Russell Bryant > To: dev@openvswitch.org > Cc: Ryan Moats/Omaha/IBM@IBMUS, b...@ovn.org, Russell Bryant > Date: 06/24/2016 02:52 PM > Subject: [PATCH 4/4] ovn: Test that port state goes

Re: [ovs-dev] FW: Subject: [ovsdb-idl 1/1] Fix issues detected in Partial Map Update feature

On Mon, Jun 20, 2016 at 03:15:07PM +, Lutz, Arnoldo wrote: > Please find below a patch fixing a memory leak detected in partial map update > feature. > It seems the original mail got lost and it hasn't been checked. I applied this patch to master. It had a cast that wasn't needed, so I

Re: [ovs-dev] [PATCH 2/2] test: Add more pmd tests.

On 23/06/2016 14:56, "Ben Pfaff" wrote: >On Tue, Jun 07, 2016 at 02:08:45PM -0700, Daniele Di Proietto wrote: >> These tests stress the pmd thread and multiqueue handling in >> dpif-netdev. >> >> Signed-off-by: Daniele Di Proietto > >I barely skimmed

[ovs-dev] [PATCH] datapath-windows: Remove double semi-colon(; ) in Tunnel.c

Found by inspection. Signed-off-by: Sairam Venugopal --- datapath-windows/ovsext/Tunnel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath-windows/ovsext/Tunnel.c b/datapath-windows/ovsext/Tunnel.c index 97d2020..e583468 100644 ---

Re: [ovs-dev] [PATCH 1/2] netdev-dummy: Allow configuring the numa_id for testing purposes.

On 23/06/2016 14:53, "Ben Pfaff" wrote: >On Tue, Jun 07, 2016 at 02:08:44PM -0700, Daniele Di Proietto wrote: >> This commit introduces an (undocumented) option for dummy Interfaces to >> specify a dummy numa_id, to which the device belongs. It will be used >> to test the pmd

Re: [ovs-dev] [PATCH 0/4] Restore ovn-controller binding functionality.

On Fri, Jun 24, 2016 at 03:07:26PM -0500, Ryan Moats wrote: > Ben Pfaff wrote on 06/24/2016 02:59:30 PM: > > > From: Ben Pfaff > > To: Russell Bryant > > Cc: dev@openvswitch.org, Ryan Moats/Omaha/IBM@IBMUS > > Date: 06/24/2016 03:00 PM > > Subject:

[ovs-dev] [PATCH] ovs-bugtool: Port to python3.

Fix python2-specific code in ovs-bugtool: * python2 long() is the same as python2 int() and python3 int(). Convert the long() to int(). * raw_input() was renamed to input(). Use python-six's input() on python2. * Drop lambda tuple unpacking, we can go back to regular lambda syntax. * file() can

Re: [ovs-dev] [PATCH] datapath-windows: Handle memory allocation failure for event creation

Hi Alin, Thanks for the review. We currently post only 1 event at a time. Hence the return statement instead of continue. The previous continue tries to match the current event to the right queue based on the Type and Queue Mask. Regard, Sairam On 6/22/16, 7:40 AM, "Alin Serdean"

Re: [ovs-dev] Fix port binding update on OVS port delete events

Ben Pfaff wrote on 06/24/2016 04:12:27 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 06/24/2016 04:12 PM > Subject: Re: [ovs-dev] Fix port binding update on OVS port delete events > > On Fri, Jun 24, 2016 at 03:39:28PM

Re: [ovs-dev] Fix port binding update on OVS port delete events

On Fri, Jun 24, 2016 at 03:39:28PM -0500, Ryan Moats wrote: > Patch "Convert binding_run to incremental processing." introduced > a bug where the port binding table is not correctly updated when > an OVS port is deleted. Fix this by > - persisting the lport shash used to record OVS ports > -

Re: [ovs-dev] Getting error while configuring OVS 2.5.90(unstable release) with DPDK 16.4

2016-06-23 9:40 GMT-07:00 Joe Stringer : > On 23 June 2016 at 05:47, Thiyagu Subramanyam wrote: > > Hi All, > > > > I am trying to use Openvswitch in user space using DPDK. So that i > need > > to install DPDK first in user space and then to configure OVS

[ovs-dev] [Patch v9][PATCH 1/2] datapath-windows: Add Geneve support

Signed-off-by: Yin Lin --- datapath-windows/automake.mk | 2 + datapath-windows/ovsext/Actions.c | 72 ++- datapath-windows/ovsext/Debug.h| 1 + datapath-windows/ovsext/DpInternal.h | 29 ++- datapath-windows/ovsext/Flow.c | 179

[ovs-dev] [PATCH 2/2] datapath-windows: Address minor alignment issues in Stt code.

Signed-off-by: Yin Lin --- datapath-windows/ovsext/Stt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath-windows/ovsext/Stt.c b/datapath-windows/ovsext/Stt.c index 0bac5f2..5aaf6fe 100644 --- a/datapath-windows/ovsext/Stt.c +++

Re: [ovs-dev] [PATCH 2/4] compat: ipv4: Pass struct net through ip_fragment.

On Wed, Jun 22, 2016 at 6:00 PM, Joe Stringer wrote: > diff --git a/acinclude.m4 b/acinclude.m4 > index 52d0209ab88a..8760948fcf9b 100644 > --- a/acinclude.m4 > +++ b/acinclude.m4 > @@ -408,7 +408,8 @@ AC_DEFUN([OVS_CHECK_LINUX_COMPAT], [ >

Re: [ovs-dev] [PATCH V2] ipfix: Export user specified virtual observation ID

Hi Wenyu, I was debugging a little bit and the issue is a NULL pointer deference of be_cfg at virtual_obs_id = smap_get(_cfg->other_config, "virtual_obs_id"); Maybe adding if (valid_be_cfg) check before the deference? I will leave you to fix it. Also I hope you can add a test case to this

Re: [ovs-dev] [PATCH] acinclude: check for numa library

Thanks, this certainly makes the error more explicit. Applied to master! 2016-06-20 2:53 GMT-07:00 Loftus, Ciara : > > > > Numa library is needed for NUMA aware vHost User functionality. > > Incase of missing numa package, the OVS DPDK configuration fails with > >

Re: [ovs-dev] [PATCH v1] Add new column compute_types to OVN_Southbound

On Fri, Jun 24, 2016 at 4:37 PM, Amitabha Biswas wrote: > On Jun 24, 2016, at 6:41 AM, Russell Bryant wrote: > > > On Wed, Jun 22, 2016 at 5:55 PM, Amitabha Biswas > wrote: > >> > On Jun 22, 2016, at 2:30 PM, Guru Shetty

Re: [ovs-dev] [PATCH] bridge: Fix crash in bridge_configure_ipfix().

Please discard this, Ben just reverted the change that introduced this. On 24/06/2016 13:46, "Daniele Di Proietto" wrote: >'be_cfg' may be NULL at that point. > >Found by testsuite. > >1051: ofproto-dpif - Flow IPFIX sanity check FAILED >(ofproto-dpif.at:6002)

Re: [ovs-dev] [PATCH] Fix port binding update on OVS port delete events

Ryan Moats/Omaha/IBM@IBMUS wrote on 06/24/2016 03:39:28 PM: > From: Ryan Moats/Omaha/IBM@IBMUS > To: dev@openvswitch.org > Cc: b...@ovn.org, russ...@ovn.org, Ryan Moats/Omaha/IBM@IBMUS > Date: 06/24/2016 03:39 PM > Subject: [PATCH] Fix port binding update on OVS port delete events > > Patch

Re: [ovs-dev] [PATCH v1] Add new column compute_types to OVN_Southbound

> On Jun 24, 2016, at 6:41 AM, Russell Bryant wrote: > > > On Wed, Jun 22, 2016 at 5:55 PM, Amitabha Biswas > wrote: > > On Jun 22, 2016, at 2:30 PM, Guru Shetty > > wrote: > > > > > > > >

[ovs-dev] [PATCH] bridge: Fix crash in bridge_configure_ipfix().

'be_cfg' may be NULL at that point. Found by testsuite. 1051: ofproto-dpif - Flow IPFIX sanity check FAILED (ofproto-dpif.at:6002) 1052: ofproto-dpif - Flow IPFIX sanity check - tunnel set FAILED (ofproto-dpif.at:6041) 0 0x006ae830 in hmap_first_with_hash (hmap=0x110,

Re: [ovs-dev] [PATCH V2] ipfix: Export user specified virtual observation ID

On Fri, Jun 24, 2016 at 05:25:57AM -0700, Wenyu Zhang wrote: > In virtual network, users want more info about the virtual point to observe > the traffic. > It should be a string to provide clear info, not a simple interger ID. > > Introduce "other-config: virtual_obs_id" in IPFIX, which is a

[ovs-dev] [PATCH] Fix port binding update on OVS port delete events

Patch "Convert binding_run to incremental processing." introduced a bug where the port binding table is not correctly updated when an OVS port is deleted. Fix this by - persisting the lport shash used to record OVS ports - change get_local_iface_ids to return a bool indicating if the persisted

[ovs-dev] [PATCH] ovn-sbctl: Change lport-(un)bind to lsp-(un)bind.

A previous commit changed the command names in ovn-nbctl from lport-* to lsp-*. Change lport-bind and lport-unbind in ovn-sbctl to match. Signed-off-by: Russell Bryant --- ovn/utilities/ovn-sbctl.c| 12 ++-- tests/ovn-controller-vtep.at | 10 +-

  1   2   >