Ubuntu 14.04 with kernel 3.13 fails to set a GRE tunnel's mac address after
device state is up. The patch adds mac address setting in ADD_NATIVE_TUNNEL
as an optional configuration parameter so that we can set the mac address,
then bring up the device.
Signed-off-by: William Tu
This will allow run() and wait() methods to be shared between different
classes and still perform class-specific work.
Signed-off-by: Daniele Di Proietto
---
lib/netdev-bsd.c | 6 +++---
lib/netdev-dummy.c| 4 ++--
lib/netdev-linux.c| 6 +++---
Also, netdev-dummy needs to call netdev_change_seq_changed() in
set_mtu().
Signed-off-by: Daniele Di Proietto
---
lib/netdev-dummy.c| 5 -
tests/ofproto-dpif.at | 30 ++
2 files changed, 34 insertions(+), 1 deletion(-)
diff --git
"internal" netdevs are treated specially in OVS (e.g. for MTU), but
the dummy datapath remaps both "system" and "internal" devices to the
same "dummy" netdev class, so there's no way to discern those in tests.
This commit adds a new "dummy-internal" netdev type, which will be used
by the dummy
On 09/08/2016 23:55, "Ilya Maximets" wrote:
>Hi, Daniele.
>Maybe I'm not the very right person to review such things, but I'm
>actually used this patch since it appeared in your github and it
>looks good to me. Also, I wanted to remove this non-working
I pushed the reviewed patches to master and I'll post another series for the
unit tests.
Thanks,
Daniele
On 09/08/2016 09:56, "Daniele Di Proietto" wrote:
>Thanks for all the series and the reviews, I will push this when the
>dependencies (patch 2 and patch 6) are
Thanks for updatin this, applied to master
2016-08-11 4:10 GMT-07:00 Ian Stokes :
> Add support for policing to userspace features and set DPDK v16.07 as
> the supported DPDK version for release 2.6.x.
>
> Signed-off-by: Ian Stokes
> ---
> FAQ.md |
2016-08-10 8:53 GMT-07:00 Aaron Conole :
> Ciara Loftus writes:
>
> > This commit provides the ability to 'listen' on DPDK ports and save
> > packets to a pcap file with a DPDK app that uses the librte_pdump
> > library. One such app is the 'pdump' app
This patch updates the documentation on how to set up OVS with multiple
NICs.
Also update the documentation to show users how new internal ports are
created
Signed-off-by: Alin Gabriel Serdean
Acked-by: Paul Boca
---
v4: Address
I missed a couple of comments. Here are my comments:
>-OvsCopyPortParamsFromVport(virtExtVport, );
>+char convertString[256];
>+RtlZeroMemory(convertString, 256);
> NdisReleaseRWLock(switchContext->dispatchLock, );
Sai - Do you need to release this lock here for
This patch updates the documentation on how to set up OVS with multiple
NICs.
Also update the documentation to show users how new internal ports are
created
Signed-off-by: Alin Gabriel Serdean
Acked-by: Paul Boca
---
v4: Address
This patch updates the following commands in the vswitch:
ovs-vsctl add-br br-test
ovs-vsctl del-br br-test
ovs-vsctl add-br br-test:
This command will now create an internal port on the MSFT virtual switch
using the WMI interface from Msvm_VirtualEthernetSwitchManagementService
I tried simulating your use case since there is no real test case
at the moment and found a missed check in my suggested incremental
patch.
I added the additional 2 lines
+if (tunnel_scope_key):
+tunnel_key = tunnel_scope_key
in the following context
+
I just applied the same fix, sorry for breaking it
Daniele
2016-08-12 17:52 GMT-07:00 Ben Pfaff :
> Signed-off-by: Ben Pfaff
> ---
> lib/dpif-netdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
>
On 12/08/2016 16:24, "Joe Stringer" wrote:
>On 12 August 2016 at 15:44, Daniele Di Proietto wrote:
>> Use the appropriate format specifier for size_t, otherwise the 32-bit
>> build fails.
>>
>> Reported-at:
Signed-off-by: Ben Pfaff
---
lib/dpif-netdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index c1564bd..96504f5 100644
--- a/lib/dpif-netdev.c
+++ b/lib/dpif-netdev.c
@@ -4911,7 +4911,7 @@ dpcls_create_subtable(struct
Thanks for the explanation.
I applied this to master, adding the extra explanation below to the
commit message.
On Mon, Aug 01, 2016 at 05:56:02AM +, Weglicki, MichalX wrote:
> Hello,
>
> So in general the problem is that during clean up procedure of distcheck:
>
> rmdir: failed to remove
Thanks for the patch, I tried it and it makes possible to restart vswitchd
and qemu.
I believe that now vhost_server_id and vhost_client_id are not constant for
the lifetime of the struct and must be protected with dev->mutex.
The following incremental on top of your patch does that and remove
> On Aug 8, 2016, at 11:21 AM, Ben Pfaff wrote:
>
> This makes it more convenient to access a 128-bit value stored in an
> mf_subvalue.
>
> Signed-off-by: Ben Pfaff
Acked-by: Justin Pettit
--Justin
On 12 August 2016 at 15:44, Daniele Di Proietto wrote:
> Use the appropriate format specifier for size_t, otherwise the 32-bit
> build fails.
>
> Reported-at: https://travis-ci.org/openvswitch/ovs/jobs/151938383
> Fixes: 3453b4d62a98("dpif-netdev: dpcls per in_port with
Ben Pfaff wrote on 08/12/2016 04:48:26 PM:
> From: Ben Pfaff
> To: Ryan Moats/Omaha/IBM@IBMUS
> Cc: dev@openvswitch.org
> Date: 08/12/2016 04:48 PM
> Subject: Re: [ovs-dev] [PATCH] ovn-controller: Remove flows created
> for now deleted SB database rows.
>
> On Fri,
On 11 August 2016 at 23:34, Gurucharan Shetty wrote:
> The schema prevented one from setting more than one load balancer
> to a switch. This removes that anamoly.
>
> Signed-off-by: Gurucharan Shetty
The system tests part looks good to me. Did you have someone in
On 12 August 2016 at 02:48, Gurucharan Shetty wrote:
> The client and servers are in the same subnet.
>
> (This would not have worked without the recent
> IPv6 patches that let packets to loop back)
>
> Signed-off-by: Gurucharan Shetty
A couple of minor comments
Use the appropriate format specifier for size_t, otherwise the 32-bit
build fails.
Reported-at: https://travis-ci.org/openvswitch/ovs/jobs/151938383
Fixes: 3453b4d62a98("dpif-netdev: dpcls per in_port with sorted
subtables")
Signed-off-by: Daniele Di Proietto
---
I have added the ack from Antonio given to the previous version.
I fixed a couple minor sparse warnings about conversions between odp_port_t
and uint32_t
I removed an 'inline' attribute from a function to silence a sparse
warning. I think that's a sparse bug, I'm going to report it.
Not a big
2016-08-11 1:48 GMT-07:00 Jan Scheurich :
> Hi Daniele,
>
>
>
> Thanks for the review. I will send v5 asap.
>
> A few answers inline below.
>
>
>
> BR, Jan
>
>
>
> *From:* Daniele Di Proietto [mailto:diproiet...@ovn.org]
> *Sent:* Thursday, 11 August, 2016 02:59
>
On Fri, Aug 12, 2016 at 02:47:09PM -0700, Ben Pfaff wrote:
> On Thu, Jul 28, 2016 at 05:12:04PM -0500, Ryan Moats wrote:
> >
> > Ben Pfaff wrote on 07/28/2016 04:23:57 PM:
> >
> > > From: Ben Pfaff
> > > To: Ryan Moats/Omaha/IBM@IBMUS
> > > Cc: dev@openvswitch.org
>
On Thu, Jul 28, 2016 at 05:12:04PM -0500, Ryan Moats wrote:
>
> Ben Pfaff wrote on 07/28/2016 04:23:57 PM:
>
> > From: Ben Pfaff
> > To: Ryan Moats/Omaha/IBM@IBMUS
> > Cc: dev@openvswitch.org
> > Date: 07/28/2016 04:24 PM
> > Subject: Re: [ovs-dev] [PATCH]
Hi Terry,
Terry Wilson writes:
> On Thu, Aug 11, 2016 at 8:53 PM, Aaron Conole wrote:
>> I've been working on a better solution - it occurred to me that since
>> this is being done for linux-only anyway, I might as well do this with
>> systemd. I can
Hi Sai,
Thanks a lot for the review!
Comments inlined.
Alin.
> -Original Message-
> From: Sairam Venugopal [mailto:vsai...@vmware.com]
> Sent: Wednesday, August 10, 2016 1:16 AM
> To: Alin Serdean ;
> dev@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH
On Thu, Aug 11, 2016 at 8:53 PM, Aaron Conole wrote:
> I've been working on a better solution - it occurred to me that since
> this is being done for linux-only anyway, I might as well do this with
> systemd. I can get almost everything done with no C code changes, thus
>
On Tue, Jul 26, 2016 at 02:51:08PM -0300, Flavio Leitner wrote:
> The current ifcfg file lacks support for OVS DPDK Bond.
>
> Reviewed-by: Aaron Conole
> Signed-off-by: Flavio Leitner
I have a feeling that no one was really comfortable with applying this.
On Thu, Jul 28, 2016 at 10:34:12AM +0800, nickcooper-zhangtonghao wrote:
>
> > On Jul 28, 2016, at 5:01 AM, Ben Pfaff wrote:
> >
> > On Mon, Jul 25, 2016 at 09:19:00AM -0700, nickcooper-zhangtonghao wrote:
> >> Deletion of a logical router port, which may be an other
> >> router
On Thu, Aug 11, 2016 at 05:20:34PM -0700, Jesse Gross wrote:
> Currently metadata transmitted by OVN over Geneve tunnels is
> unprotected by any checksum other than the one provided by the link
> layer - this includes both the VNI and data stored in options. Turning
> on UDP checksums which cover
On Thu, Aug 11, 2016 at 05:20:33PM -0700, Jesse Gross wrote:
> Originally, processing of encapsulations simply iterated over all tables on
> every wakeup and would replace anything that changed. This is somewhat
> inefficient but it captured all changes.
>
> Incremental processing avoided the
The schema prevented one from setting more than one load balancer
to a switch. This removes that anomaly.
(The test has a slightly unrelated change where it increases the
number of connections to get rid of some occasional unit test failures.)
Signed-off-by: Gurucharan Shetty
---
The client and servers are in the same subnet.
(This would not have worked without the recent
IPv6 patches that let packets to loop back)
Signed-off-by: Gurucharan Shetty
---
tests/system-ovn.at | 118
1 file changed, 118
In cases where a DNAT IP is moved to a new router or the SNAT IP is reused
with a new mac address, the NAT IPs become unreachable because the external
switches/routers have stale ARP entries. This commit
aims to fix the problem by sending GARPs for NAT IPs via locanet
A new options key
On 12 August 2016 at 11:15, Joe Stringer wrote:
> On 11 August 2016 at 23:34, Gurucharan Shetty wrote:
> > The client and servers are in the same subnet.
> >
> > (This would not have worked without the recent
> > IPv6 patches that let packets to loop back)
> >
> >
On 11 August 2016 at 23:34, Gurucharan Shetty wrote:
> The client and servers are in the same subnet.
>
> (This would not have worked without the recent
> IPv6 patches that let packets to loop back)
>
> Signed-off-by: Gurucharan Shetty
This test should be skipped for
On Fri, Aug 12, 2016 at 1:31 PM, Joe Stringer wrote:
> On 12 August 2016 at 10:30, Russell Bryant wrote:
> > Update the release process document to use markdown formatting for the
> > table used to describe the 6 month release schedule. This will make it
> > be
Upstream commit:
commit 5ef9f289c4e698054e5687edb54f0da3cdc9173a
Author: Ian Wienand
Date: Wed Aug 3 15:44:57 2016 +1000
OVS: Ignore negative headroom value
net_device->ndo_set_rx_headroom (introduced in
871b642adebe300be2e50aa5f65a418510f636ec)
Upstream commit:
commit 4b5b9ba553f9aa5f484ab972fc9b58061885ceca
Author: Martynas Pumputis
Date: Tue Aug 9 16:24:50 2016 +0100
openvswitch: do not ignore netdev errors when creating tunnel vports
The creation of a tunnel vport (geneve, gre, vxlan)
On 12 August 2016 at 10:21, Alin Serdean
wrote:
> Sorry I forgot about it!
>
>
>
> Thanks for the review I will respin the patch and add you as co-author.
>
It is already applied. Thanks!
>
>
> Thanks,
>
> Alin.
>
>
>
> *From:* Guru Shetty [mailto:g...@ovn.org]
On 12 August 2016 at 10:30, Russell Bryant wrote:
> Update the release process document to use markdown formatting for the
> table used to describe the 6 month release schedule. This will make it
> be formatted correctly when converted to HTML on github and
> openvswitch.org.
>
Update the release process document to use markdown formatting for the
table used to describe the 6 month release schedule. This will make it
be formatted correctly when converted to HTML on github and
openvswitch.org.
Signed-off-by: Russell Bryant
---
On 29 July 2016 at 15:26, Chandra S Vejendla wrote:
> In cases where a DNAT IP is moved to a new router or the SNAT IP is reused
> with a new mac address, the NAT IPs become unreachable because the external
> switches/routers have stale ARP entries. This commit
> aims to fix
On 12 August 2016 at 00:39, Alin Serdean
wrote:
> On Windows if a file path contains ":" we can safely say it is an absolute
> file name.
>
> This patch allows file_name checks to report correctly when using
> "abs_file_name".
>
> Found by testing.
>
>
On 12 August 2016 at 09:37, pravin shelar wrote:
> On Thu, Aug 11, 2016 at 10:33 PM, Joe Stringer wrote:
>> On 11 August 2016 at 19:43, Pravin B Shelar wrote:
>>> Older kernel skb_scrub_packet() has bug which resets skb mark for
>>> all packet. It
Sorry I forgot about it!
Thanks for the review I will respin the patch and add you as co-author.
Thanks,
Alin.
From: Guru Shetty [mailto:g...@ovn.org]
Sent: Friday, August 12, 2016 7:59 PM
To: Alin Serdean
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] Windows:
Thanks for the review.
Comments inlined.
Alin.
-Original Message-
From: Sairam Venugopal [mailto:vsai...@vmware.com]
Sent: Friday, August 12, 2016 7:46 PM
To: Alin Serdean ; dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH] stream-windows: Disconnect
On 12 August 2016 at 00:39, Alin Serdean
wrote:
> On Windows if a file path contains ":" we can safely say it is an absolute
> file name.
>
> This patch allows file_name checks to report correctly when using
> "abs_file_name".
>
> Found by testing.
>
>
On Fri, Aug 12, 2016 at 08:40:12PM +0900, Nam Bong Ha wrote:
> Is linear search a searching method for vswitchd flow table?
No. Read the NSDI paper:
http://openvswitch.org/support/papers/nsdi2015.pdf
___
dev mailing list
dev@openvswitch.org
Hi Alin,
How do you typically run into this issue? Do you also need to call into
CloseHandle(p->fd)?
Thanks,
Sairam
On 8/12/16, 12:46 AM, "Alin Serdean"
wrote:
>Disconnect named pipes that failed connection.
>
>Found by testing.
>
>Signed-off-by: Alin Gabriel
On Thu, Aug 11, 2016 at 10:33 PM, Joe Stringer wrote:
> On 11 August 2016 at 19:43, Pravin B Shelar wrote:
>> Older kernel skb_scrub_packet() has bug which resets skb mark for
>> all packet. It is fixed during 3.18 release where it is reset
>> only for packets
The client and servers are in the same subnet.
(This would not have worked without the recent
IPv6 patches that let packets to loop back)
Signed-off-by: Gurucharan Shetty
---
tests/system-ovn.at | 117
1 file changed, 117
The schema prevented one from setting more than one load balancer
to a switch. This removes that anamoly.
Signed-off-by: Gurucharan Shetty
---
ovn/northd/ovn-northd.c | 38 +++---
ovn/ovn-nb.ovsschema| 6 +++---
tests/system-ovn.at | 19
Acked-by: Sairam Venugopal
On 8/12/16, 12:39 AM, "Alin Serdean"
wrote:
>On Windows if a file path contains ":" we can safely say it is an absolute
>file name.
>
>This patch allows file_name checks to report correctly when using
Only devices of type "DPDK_DEV_ETH" use the netdev_dpdk_set_config
function, so no need to check for the device type within the function.
Fixes: 9fd39370c12c ("netdev-dpdk: Add Flow Control support.")
Signed-off-by: Ciara Loftus
---
lib/netdev-dpdk.c | 27
On 08/12/2016 05:57 PM, Ciara Loftus wrote:
Signed-off-by: Ciara Loftus
It is a necessary fix, specially if hotplug will be introduced.
Acked-by: Mauricio Vásquez B
---
lib/netdev-dpdk.c | 5 +++--
1 file changed, 3 insertions(+), 2
Signed-off-by: Ciara Loftus
---
lib/netdev-dpdk.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index 9a1f7cd..329b4ea 100644
--- a/lib/netdev-dpdk.c
+++ b/lib/netdev-dpdk.c
@@ -648,7 +648,7 @@
Ensure that rows created for deleted port binding and
multicast group rows are cleared when doing full processing.
Signed-off-by: Ryan Moats
---
v1->v2:
- replace use of ssets for storing UUIDs as strings with hmaps for
storing the UUID structs themselves
- include an
8%òMW¸²ÂzjÌÍq#2ª¤laÆUZnÒ5ñ*Q¬Aî².ʪPnNÜß
óf:ûçutbÐ Å $($`Q
SàzòùxE¹)Ù15ì%îL£ÂCIq©bXgMQ$)iÛ%¦üuM¬¿^Äå|>aÆiXî,¼¦ØB¬ý_A}ÛܱÓjìJ×mεºQÎX'ª5Ú÷SóÍÃÐRÊ_s-[i`*xLF&ôã[øX1Oó¯£Ç3Òuð*áÒTÌÅ«yæÊпËß¹G´ûÁÃÁ`°³ïÆp¾ºýL
4ef¡Ò~·ëøÝm|¬¯àÚ3Öc8bE3ô[Z¬p.*/ñÄ0`R\C¥ûM
Hi
Is linear search a searching method for vswitchd flow table?
I filled the following command to vswitchd flow table.
Experiment 1.
(in_port1, priority=65000)
ovs-ofctl add-flow s1 "table=0 priority=65000 in_port=1 actions=ouitput:2"
ovs-ofctl add-flow s1 "table=0 priority=3 in_port=3
This E-mail was sent from "CUKPR0329001" (Aficio MP C305).
Scan Date: 17.11.2015 09:08:40 (+)
Queries to:
kË2þAý2¯¾5§5ÒS"¤~e$í?໦XKz?â¢ë¥éeIOÙ>÷V±Ü52©ÒçzvLD.ýËPÛN¥éØ.ep&¥&ÈκÃ).²Àþ¾ÜÌ´Z3ÂèÝV!¹è©Íê¿EFz
M×ê§ýnárC0iðß3):8
¢íäÇH#wQòæ>ÒVÙ,é?pH(²>ã¸x]ÊBf?ÒHZ9½Ûµ)¿Mwø4îo6®ÌhBJÛ%øë®ð·Ê[ý-©]aõÉxpJ¾L3üf¼ßqÓËëI§ÜQ}÷å4êWèolúξGè½ÏIó®bDq
;'äÉ©#Ïâ!¶õõ
The original message was received at Sun, 1 Jan 2006 04:16:33 +0530 from
120.155.48.138
- The following addresses had permanent fatal errors -
dev@openvswitch.org
___
dev mailing list
dev@openvswitch.org
Hi guys,
I'm really excited about the new re-work for jumbo frame support in ovs w/
dpdk.
Any chance to push the patch series by the week end?
Cheers
Federico
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
The original message was received at Fri, 12 Aug 2016 15:07:46 +0700
from openvswitch.org [72.235.255.146]
- The following addresses had permanent fatal errors -
___
dev mailing list
dev@openvswitch.org
Hi,
I still think that from an OpenFlow perspective it is conceptually broken to
have the same OXM or NXM fields refer to packet header fields in the case they
are part of the packet header and to some kind of "metadata" fields if they are
not. It's basically the same problem as I
From: LI Zong Kai
This patch tries to implement Router Solicitation (RS) responder, which will
reply Router Advertisement (RA) message, for SLAAC on ovn-northd side.
It tries to build lflows per each Logical Router Port, who have IPv6 networks
and set their 'slaac' column to
From: LI Zong Kai
This patch tries to implement Router Solicitation (RS) responder, who will
reply Router Advertisement (RA) message, for SLAAC on ovn-controller side.
It parses lflows which have:
- match: inport == LRP_NAME && ip6.dst == ff02::2 && nd_rs
(nd_rs:
This serial patches try to support Stateless Address Autoconfiguration (SLAAC)
for IPv6, via Router Solicitation (RS) responder, who will reply Router
Advertisement (RA) message for received RS message.
User case:
After this serial patches, a user can follow the following steps to let all
From: LI Zong Kai
This patch introduces methods to compose a Router Advertisement (RA) packet,
introduces flags for RA, and renames ovs_nd_opt to ovs_nd_lla_opt to specify
it's Source/Target Link-layer Address option.
The packet, composed by new introduced methods,
Disconnect named pipes that failed connection.
Found by testing.
Signed-off-by: Alin Gabriel Serdean
---
lib/stream-windows.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/stream-windows.c b/lib/stream-windows.c
index e0fe012..637920b 100644
---
This patch allows online compacting to be done under Windows.
To achieve the above we need to close all file handles before trying to
rename the file, switch from rename to MoveFileEx (because rename/MoveFile
fails if the destination exists), reopen the right type of log after the
rename.
From: Babu Shanmugam
* Rebased v7 on top of the master
Babu Shanmugam (2):
Check and allocate free qdisc queue id for ports with qos parameters
DSCP marking on packets egressing VIF interface
include/ovn/actions.h| 7 ++
ovn/controller/binding.c | 239
From: Babu Shanmugam
ovn-northd sets 'ip.dscp' to the DSCP value
Signed-off-by: Babu Shanmugam
---
ovn/lib/logical-fields.c | 2 +-
ovn/northd/ovn-northd.c | 13 +
ovn/ovn-nb.xml | 6
ovn/ovn-sb.xml | 5
From: Babu Shanmugam
ovn-northd processes the list of Port_Bindings and hashes the list of
queues per chassis. When it finds a port with qos_parameters and without
a queue_id, it allocates a free queue for the chassis that this port belongs.
The queue_id information is
I see. I am trying to specify these actions via openflow messages. Is there
any example that I could look at? I am guessing at least the test code
should have something.
Thanks!
Joji
On Thu, Aug 11, 2016 at 6:14 PM, Joe Stringer wrote:
> On 11 August 2016 at 17:21, Joji Mekkatt
80 matches
Mail list logo