Re: [ovs-dev] [patch v11 2/2] DSCP marking on packets egressing VIF interface

On Wed, Aug 31, 2016 at 12:11 AM, wrote: > ovn-northd sets 'ip.dscp' to the DSCP value > If we were to go with DSCP based on port as the initial functionality, your changes look good. A couple of nits below, and the first patch (which I have not looked at) needs a rebase

[ovs-dev] Returned mail: Data format error

ãn4³`"UAåŠw¾ý}–Ð.½³J}¬wLv¼Éð­17LY‘Ò]3½*Ïe\™]%¾òciØ®úYô?©zª3ˆQNކ)93ÓJÅ5£¥>¿Ê®íÎ8¼'sCW¡Ó«A"ò>µuºƒ/'ݜŽï‰¨ž¥Ç‰×^¾4­f {Sá`²aJÞµ_ÀQkávïÔލJ8cÃgF‹e6R²IÓ]Úw˜œ×nõöÒ í‡Éó– h¥‡¹)Ñ­kœo:b[Üx<±ïý²ÎwÃA8Beþ,xÇÞ&žD&2ÃÔZ¦0Tࡤ8,æBZª )LŸ%³–w–j¸ÙÐS^Š ì†ùÍÌ>ãÞöÕ"¹GXI­¨T‡´1/Q¸¿&¹ê‘S -:÷²0V 

[ovs-dev] Scanned image from mx23...@openvswitch.com

Reply to: off...@openvswitch.com Device Name: mx23...@openvswitch.com Device Model: MX-2310U Location: Reception File Format: PDF MMR(G4) Resolution: 200dpi x 200dpi Attached file is scanned image in PDF format. Use Acrobat(R)Reader(R) or Adobe(R)Reader(R) of Adobe

[ovs-dev] Scanned image from mx23...@openvswitch.com

Reply to: off...@openvswitch.com Device Name: mx23...@openvswitch.com Device Model: MX-2310U Location: Reception File Format: PDF MMR(G4) Resolution: 200dpi x 200dpi Attached file is scanned image in PDF format. Use Acrobat(R)Reader(R) or Adobe(R)Reader(R) of Adobe

[ovs-dev] Scanned image from mx23...@openvswitch.com

Reply to: off...@openvswitch.com Device Name: mx23...@openvswitch.com Device Model: MX-2310U Location: Reception File Format: PDF MMR(G4) Resolution: 200dpi x 200dpi Attached file is scanned image in PDF format. Use Acrobat(R)Reader(R) or Adobe(R)Reader(R) of Adobe

[ovs-dev] (no subject)

촄þÌíÑåŸôOŒ†*>6É*çM¶29QÛno&$N|‡‰a¶ÀøEÛa <Ÿ¸¦2#k{ƒj¼ê‚V¨Ïõßß\–D–“´Ÿ 0I ,qÐûœ ¢œÖe…÷?ú™GϪ­æ¯úg£"À?òŽ…ñ^×ãò笲*0 MñØuÖ§6§¹ÌV™wIq#¿£Û"p‹Öšjâ*½öαaYÆTU×¥ÙÍø’¥‰´Ï“gõ[ÝJ vi>Èjׇ(]vœ6[ЩsŸ 1t삒¿ßça«ôFZ.\OžeÖ&?]À•¸DÀ}&J‡GöÖôpd³ zÝó$ú£9¹õ2 °G£ºÍVo}"¿«©äþxknO-_í°â[—ð¹^A•;Éá#ÐTOá:¾O(‹K2‹‡¾NŽñúôN¹Ž_’…

Re: [ovs-dev] [PATCH] datapath: Use pre-routing hook for conntrack.

On Thu, Sep 1, 2016 at 5:01 PM, Joe Stringer wrote: > The upstream code uses NF_INET_PRE_ROUTING hook for the nf_conntrack_in() > call, which does deeper (eg l4proto) validation. It was previously > thought that using the NF_INET_ROUTING hook for this function on older > kernels

Re: [ovs-dev] please help review patch "allow DHCPv6 respond multiple IA Address Options"

On Thu, Sep 1, 2016 at 6:05 PM, Numan Siddique wrote: > > > On Wed, Aug 31, 2016 at 8:44 AM, Zong Kai Li wrote: >> >> On Tue, Aug 30, 2016 at 8:28 PM, Numan Siddique >> wrote: >> > >> > >> > On Tue, Aug 30, 2016 at 9:40 AM, Ben Pfaff

[ovs-dev] Delivery reports about your e-mail

Dear user of openvswitch.org, administration of openvswitch.org would like to let you know that. Your account was used to send a large amount of spam during this week. Probably, your computer was compromised and now contains a hidden proxy server. We recommend that you follow the instructions

[ovs-dev] Scanned image from mx23...@openvswitch.com

Reply to: off...@openvswitch.com Device Name: mx23...@openvswitch.com Device Model: MX-2310U Location: Reception File Format: PDF MMR(G4) Resolution: 200dpi x 200dpi Attached file is scanned image in PDF format. Use Acrobat(R)Reader(R) or Adobe(R)Reader(R) of Adobe

Re: [ovs-dev] [PATCH] ovn: fix ovn-northd leaks in build_acl

Hi Russell, I updated the patch with a Signed-off-by, but it landed here as new on patchworks, https://patchwork.ozlabs.org/patch/665079/ instead of updating the original here: https://patchwork.ozlabs.org/patch/661079/ On Thu, Sep 1, 2016 at 4:50 PM, Russell Bryant wrote: > >

[ovs-dev] [PATCH] ovn: fix ovn-northd leaks in build_acl

The following leaks are due to missing ds_destroy in a few places in build_acl. 5,850 bytes in 50 blocks are definitely lost in loss record 93 of 93 at 0x4C29BFD: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) by 0x4C2BACB: realloc (in

[ovs-dev] [PATCH] datapath: Use pre-routing hook for conntrack.

The upstream code uses NF_INET_PRE_ROUTING hook for the nf_conntrack_in() call, which does deeper (eg l4proto) validation. It was previously thought that using the NF_INET_ROUTING hook for this function on older kernels would trigger kernel panics due to a dependency on the unpopulated skb->dev,

Re: [ovs-dev] [PATCH] ovn: fix ovn-northd leaks in build_acl

On Fri, Aug 19, 2016 at 9:06 PM, Ramu Ramamurthy wrote: > From: Ramu Ramamurthy > > The following leaks are due to missing ds_destroy in a few > places in build_acl. > > 5,850 bytes in 50 blocks are definitely lost in loss record 93 of 93 >

[ovs-dev] Scanned image from mx23...@openvswitch.com

Reply to: off...@openvswitch.com Device Name: mx23...@openvswitch.com Device Model: MX-2310U Location: Reception File Format: PDF MMR(G4) Resolution: 200dpi x 200dpi Attached file is scanned image in PDF format. Use Acrobat(R)Reader(R) or Adobe(R)Reader(R) of Adobe

Re: [ovs-dev] [PATCH v2 08/15] connmgr: Make connmgr_wants_packet_in_on_miss() lock-free.

> On Sep 1, 2016, at 4:35 PM, Jarno Rajahalme wrote: > > >> On Aug 29, 2016, at 2:49 PM, Ben Pfaff wrote: >> >> On Mon, Aug 22, 2016 at 04:31:34PM -0700, Jarno Rajahalme wrote: >>> Make connmgr_wants_packet_in_on_miss() use an atomic int instead of a >>> list

Re: [ovs-dev] [PATCH] ovn: fix ovn-northd leaks in build_acl

"dev" wrote on 08/19/2016 08:06:50 PM: > From: Ramu Ramamurthy > To: dev@openvswitch.org > Cc: Suryanarayan Ramamurthy/San Jose/IBM@IBMUS > Date: 08/19/2016 08:07 PM > Subject: [ovs-dev] [PATCH] ovn: fix ovn-northd leaks in build_acl >

Re: [ovs-dev] [PATCH v2 08/15] connmgr: Make connmgr_wants_packet_in_on_miss() lock-free.

> On Aug 29, 2016, at 2:49 PM, Ben Pfaff wrote: > > On Mon, Aug 22, 2016 at 04:31:34PM -0700, Jarno Rajahalme wrote: >> Make connmgr_wants_packet_in_on_miss() use an atomic int instead of a >> list traversal taking the 'ofproto_mutex'. This allows >>

[ovs-dev] Scanned image from mx23...@openvswitch.com

Reply to: off...@openvswitch.com Device Name: mx23...@openvswitch.com Device Model: MX-2310U Location: Reception File Format: PDF MMR(G4) Resolution: 200dpi x 200dpi Attached file is scanned image in PDF format. Use Acrobat(R)Reader(R) or Adobe(R)Reader(R) of Adobe

[ovs-dev] Scanned image from mx23...@openvswitch.com

Reply to: off...@openvswitch.com Device Name: mx23...@openvswitch.com Device Model: MX-2310U Location: Reception File Format: PDF MMR(G4) Resolution: 200dpi x 200dpi Attached file is scanned image in PDF format. Use Acrobat(R)Reader(R) or Adobe(R)Reader(R) of Adobe

[ovs-dev] Scanned image from mx23...@openvswitch.com

Reply to: off...@openvswitch.com Device Name: mx23...@openvswitch.com Device Model: MX-2310U Location: Reception File Format: PDF MMR(G4) Resolution: 200dpi x 200dpi Attached file is scanned image in PDF format. Use Acrobat(R)Reader(R) or Adobe(R)Reader(R) of Adobe

Re: [ovs-dev] [PATCH v2] ovs-monitor-ipsec: Fix flake8-check semicolon error

On 31 August 2016 at 09:58, Ben Pfaff wrote: > On Wed, Aug 31, 2016 at 09:33:24AM -0700, Amitabha Biswas wrote: >> Fixes: 19cd0a87 >> >> Signed-off-by: Amitabha Biswas >> Acked-by: Numan Siddique > > Thanks, applied to master. I think this

[ovs-dev] [PATCH] datapath-windows: Encapsulate packet when src port is tunnel port

If a packet arrives on a tunnel port and is again transmitted on a tunnel port, the packet needs to be encapsulated. Eg: Sample flow which arrives on a tunnel port and gets encapsulated again. eth(src=00:15:5d:ae:b7:b1,dst=ff:ff:ff:ff:ff:ff),in_port(5),eth_type(0x0806),

Re: [ovs-dev] [PATCH 1/3] check-kernel: add recheck support

On 1 September 2016 at 13:14, Lance Richardson wrote: > Support "make check-kernel RECHECK=yes", similar to existing support > for "make check RECHECK=yes". > > Signed-off-by: Lance Richardson Thanks a lot, applied to master and branch-2.6 .

Re: [ovs-dev] [PATCH 3/3] rhel: add option to run kernel datapath test when building rpms

> From: "Joe Stringer" > To: "Lance Richardson" > Cc: "ovs dev" > Sent: Thursday, September 1, 2016 4:51:19 PM > Subject: Re: [ovs-dev] [PATCH 3/3] rhel: add option to run kernel datapath > test when building rpms > > On 1 September 2016

Re: [ovs-dev] [PATCH v2 05/15] ofproto: Change rule's 'removed' member to a tri-state 'state'.

> On Aug 29, 2016, at 2:40 PM, Ben Pfaff wrote: > > On Mon, Aug 22, 2016 at 04:31:31PM -0700, Jarno Rajahalme wrote: >> As a rule may not be re-inserted to ofproto data structures, it is >> cleaner to have three states for the rule, rather than just two. This >> will be useful

Re: [ovs-dev] [PATCH 3/3] rhel: add option to run kernel datapath test when building rpms

On 1 September 2016 at 13:14, Lance Richardson wrote: > Add ability to execute kernel datapath tests when building rpms. > These tests are disabled by default, and can optionally be run > by providing "--with check_datapath_kernel" on the rpmbuild command > line. This is

Re: [ovs-dev] [PATCH] INSTALL.Windows.md : Updated the kernel datapath project solution file name

On 31 August 2016 at 13:33, Anand Kumar wrote: > Singed-off-by : Anand Kumar > Thanks you! I applied this and added you to AUTHORS. > --- > INSTALL.Windows.md | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [ovs-dev] [PATCH v2] datapath-windows: add assert in OvsHashFlow()

On 31 August 2016 at 23:45, Nithin Raju wrote: > Signed-off-by: Nithin Raju > Applied. > --- > datapath-windows/ovsext/Flow.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/datapath-windows/ovsext/Flow.c b/datapath-windows/ovsext/ > Flow.c >

[ovs-dev] [PATCH net-next v21 4/4] openvswitch: report error on VLAN nlattr in ovs_key_from_nlattrs()

With 802.1ad support these are parsed and set upfront by parse_vlan_from_nlattrs() before ovs_key_from_nlattrs() is ever called. As such we should never see a VLAN attribute in ovs_key_from_nlattrs(). Signed-off-by: Eric Garver --- net/openvswitch/flow_netlink.c | 19

[ovs-dev] [PATCH net-next v21 2/4] vlan: Check for vlan ethernet types for 8021.q or 802.1ad

This is to simplify using double tagged vlans. This function allows all valid vlan ethertypes to be checked in a single function call. Also replace some instances that check for both ETH_P_8021Q and ETH_P_8021AD. Patch based on one originally by Thomas F Herbert. Signed-off-by: Thomas F Herbert

[ovs-dev] [PATCH net-next v21 0/4] openvswitch: add 802.1ad support

This series adds 802.1ad support to openvswitch. It is a continuation of the work originally started by Thomas F Herbert - hence the large rev number. The extra VLAN is implemented by using an additional level of the OVS_KEY_ATTR_ENCAP netlink attribute. In OVS flow speak, this looks like

[ovs-dev] [PATCH net-next v21 3/4] openvswitch: 802.1AD Flow handling, actions, vlan parsing, netlink attributes

Add support for 802.1ad including the ability to push and pop double tagged vlans. Add support for 802.1ad to netlink parsing and flow conversion. Uses double nested encap attributes to represent double tagged vlan. Inner TPID encoded along with ctci in nested attributes. This is based on Thomas

[ovs-dev] [PATCH net-next v21 1/4] openvswitch: 802.1ad uapi changes.

From: Thomas F Herbert openvswitch: Add support for 8021.AD Change the description of the VLAN tpid field. Signed-off-by: Thomas F Herbert --- include/uapi/linux/openvswitch.h | 17 + 1 file changed, 9 insertions(+), 8

Re: [ovs-dev] [PATCH] learn: learn_spec fixes.

> On Sep 1, 2016, at 1:18 PM, Ben Pfaff wrote: > > On Thu, Sep 01, 2016 at 01:10:37PM -0700, Jarno Rajahalme wrote: >> Avoid using nested zero-sized arrays to allow compilation with MSVC. >> Also, make sure the immediate data is accessed only if it exists, and >> that the size is

Re: [ovs-dev] [PATCHv2 0/4] Replace ukeys for deleted flows

On 31 August 2016 at 11:06, Joe Stringer wrote: > Recent bugs[1] have highlighted a particular situation where we may handle > significant traffic in userspace via the upcall mechanism either due to flow > table changes, or when bugs in translation logic result in unexpected

Re: [ovs-dev] [PATCH] learn: learn_spec fixes.

On Thu, Sep 01, 2016 at 01:18:55PM -0700, Ben Pfaff wrote: > On Thu, Sep 01, 2016 at 01:10:37PM -0700, Jarno Rajahalme wrote: > > Avoid using nested zero-sized arrays to allow compilation with MSVC. > > Also, make sure the immediate data is accessed only if it exists, and > > that the size is

Re: [ovs-dev] [PATCH] learn: learn_spec fixes.

On Thu, Sep 01, 2016 at 01:10:37PM -0700, Jarno Rajahalme wrote: > Avoid using nested zero-sized arrays to allow compilation with MSVC. > Also, make sure the immediate data is accessed only if it exists, and > that the size is always calculated from struct learn_spec field > 'n_bits'. > >

[ovs-dev] [PATCH 2/3] rhel: build source rpm packages

Build source RPM packages for rpm-fedora and rpm-fedora-kmod targets. Signed-off-by: Lance Richardson --- rhel/automake.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rhel/automake.mk b/rhel/automake.mk index a3c180c..541f3fc 100644 ---

[ovs-dev] [PATCH 3/3] rhel: add option to run kernel datapath test when building rpms

Add ability to execute kernel datapath tests when building rpms. These tests are disabled by default, and can optionally be run by providing "--with check_datapath_kernel" on the rpmbuild command line. This is intended to facilitate automated testing, and should not be used in production

[ovs-dev] [PATCH 0/3] support kernel datapath check when building rpms

Add ability to (optionally) run kernel datapath checks when building source rpms. - Support RECHECK=yes for "make check-kernel" - Generate source RPMs for fedora-rpm and fedora-rpm-kmod targets - Run "make check-kernel" when building RPMS if "--with check_datapath_kernel" option is

[ovs-dev] [PATCH 1/3] check-kernel: add recheck support

Support "make check-kernel RECHECK=yes", similar to existing support for "make check RECHECK=yes". Signed-off-by: Lance Richardson --- tests/automake.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/automake.mk b/tests/automake.mk index

Re: [ovs-dev] broken build windows

> On Sep 1, 2016, at 9:27 AM, Ben Pfaff wrote: > > On Thu, Sep 01, 2016 at 02:57:23PM +, Alin Serdean wrote: >> "error C2233: 'specs' : arrays of objects containing zero-size arrays are >> illegal" >> >> https://ci.appveyor.com/project/blp/ovs >> >> I think it was caused by

[ovs-dev] [PATCH] learn: learn_spec fixes.

Avoid using nested zero-sized arrays to allow compilation with MSVC. Also, make sure the immediate data is accessed only if it exists, and that the size is always calculated from struct learn_spec field 'n_bits'. Reported-by: Alin Serdean Signed-off-by: Jarno

Re: [ovs-dev] [PATCH] ovn-controller: Fix memory leak in recv_S_TLV_TABLE_REQUESTED().

On Thu, Sep 01, 2016 at 02:27:55PM -0400, Flavio Fernandes wrote: > > > On Sep 1, 2016, at 1:02 PM, Ben Pfaff wrote: > > > > Nothing freed 'reply'. This fixes the problem. > > > > Most of this patch is moving coding around. The essential change is that > > breaking the code

Re: [ovs-dev] [PATCH] ofproto: Do not override internal port MTU.

On Thu, Sep 01, 2016 at 05:17:44PM +, Daniele Di Proietto wrote: > Let me try to sum up the problem further > > 1) Behavior on master, before commit 47bf118665a3("ofproto: Always set MTU > for new internal ports."): > > a) When an internal interface is added, or its MTU has changed we

[ovs-dev] [PATCH v2] tun-metadata: Manage tunnel TLV mapping table on a per-bridge basis.

When using tunnel TLVs (at the moment, this means Geneve options), a controller must first map the class and type onto an appropriate OXM field so that it can be used in OVS flow operations. This table is managed using OpenFlow extensions. The original code that added support for TLVs made the

Re: [ovs-dev] [replication SMv2 7/7] ovsdb: Replication usability improvements

> > I tested the v3 version pulling from your github, and I am not seeing an >> crashes. >> > > > Thanks for testing. I added your name to tested-by in the V3 patch. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] tun-metadata: Manage tunnel TLV mapping table on a per-bridge basis.

On Tue, Aug 30, 2016 at 1:17 PM, Ben Pfaff wrote: > On Tue, Aug 23, 2016 at 02:28:27PM -0700, Jesse Gross wrote: >> When using tunnel TLVs (at the moment, this means Geneve options), a >> controller must first map the class and type onto an appropriate OXM >> field so that it can be

[ovs-dev] [PATCH v2] ovn: log dhcp responses for debugging

Add a few messages at INFO to help debug the vif lifecycle. A logsearch on mac or ip helps debug what happened to the vif and when. This helps easily correlate logs across CMS and ovn. Logs appear like this: 2016-09-01T18:15:48Z|00014|binding|INFO|Claiming lport

Re: [ovs-dev] [PATCH] ovn-controller: Fix memory leak in recv_S_TLV_TABLE_REQUESTED().

> On Sep 1, 2016, at 1:02 PM, Ben Pfaff wrote: > > Nothing freed 'reply'. This fixes the problem. > > Most of this patch is moving coding around. The essential change is that > breaking the code that works with 'reply' out into a separate function > makes it possible to catch

Re: [ovs-dev] [PATCH] ofproto: Do not override internal port MTU.

On Thu, Sep 1, 2016 at 10:17 AM, Daniele Di Proietto wrote: > Let me try to sum up the problem further > > 1) Behavior on master, before commit 47bf118665a3("ofproto: Always set MTU > for new internal ports."): > > a) When an internal interface is added, or its MTU

Re: [ovs-dev] [PATCH] INSTALL.Windows.md : Updated the kernel datapath project solution file name

Acked-by: Sairam Venugopal On 8/31/16, 1:33 PM, "Anand Kumar" wrote: >Singed-off-by : Anand Kumar >--- > INSTALL.Windows.md | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/INSTALL.Windows.md

Re: [ovs-dev] [PATCH] datapath-windows: add assert in OvsHashFlow()

Acked-by: Sairam Venugopal On 8/31/16, 11:41 PM, "Nithin Raju" wrote: >Also fix a minor indentation issue in User.c > >Signed-off-by: Nithin Raju >--- > datapath-windows/ovsext/Flow.c | 1 + > datapath-windows/ovsext/User.c | 2 +- > 2

Re: [ovs-dev] [PATCH] datapath-windows: Fixed tcp flags byte order in conntrack

Acked-by: Sairam Venugopal On 8/29/16, 12:11 PM, "Paul Boca" wrote: >In user mode the flags are interpreted as little endian. >This fix makes the kernel mode compatible with user mode. > >Signed-off-by: Paul-Daniel Boca

Re: [ovs-dev] [PATCH] ovn-controller: Fix memory leak in recv_S_TLV_TABLE_REQUESTED().

Ben Pfaff wrote on 09/01/2016 12:02:53 PM: > From: Ben Pfaff > To: dev@openvswitch.org > Cc: Ben Pfaff , Ryan Moats/Omaha/IBM@IBMUS > Date: 09/01/2016 12:04 PM > Subject: [PATCH] ovn-controller: Fix memory leak in > recv_S_TLV_TABLE_REQUESTED(). > >

Re: [ovs-dev] [PATCH] ofproto: Do not override internal port MTU.

Let me try to sum up the problem further 1) Behavior on master, before commit 47bf118665a3("ofproto: Always set MTU for new internal ports."): a) When an internal interface is added, or its MTU has changed we only change its MTU if it is bigger than the bridge minimum b) When a non

Re: [ovs-dev] [PATCH] ovn-controller: Fix leak in patched_datapaths processing.

On Thu, Sep 01, 2016 at 12:58:52PM -0400, Russell Bryant wrote: > On Thu, Sep 1, 2016 at 12:42 PM, Ben Pfaff wrote: > > > Nothing freed 'key', which was dynamically allocated. This commit changes > > 'key' so that it is no longer dynamically allocated. > > > > Reported-by: Ryan

Re: [ovs-dev] [PATCH] Close memory leak when processing S_TLV_TABLE_REQUESTED.

On Thu, Sep 01, 2016 at 08:57:51AM -0500, Ryan Moats wrote: > Found by running valgrind on "ovn-controller - > Chassis external_ids" unit test case: > 24 bytes in 1 blocks are definitely lost in loss record 102 of 180 > at 0x4C2DBB6: malloc (vg_replace_malloc.c:299) > by 0x4916A4:

Re: [ovs-dev] ovn-controller: Fix leak in patched_datapaths processing.

> On Sep 1, 2016, at 12:42 PM, Ben Pfaff wrote: > > Nothing freed 'key', which was dynamically allocated. This commit changes > 'key' so that it is no longer dynamically allocated. > > Reported-by: Ryan Moats > Signed-off-by: Ben Pfaff

Re: [ovs-dev] [PATCH] ofproto: Do not override internal port MTU.

Hi Joe, Thanks for your comments replies inline On 31/08/2016 18:48, "Joe Stringer" wrote: >On 31 August 2016 at 14:52, Daniele Di Proietto wrote: >> Open vSwitch controls the MTU of internal ports and sets it to the >> minimum of physical ports MTU

Re: [ovs-dev] [PATCH] Fix leak in patched_datapaths processing.

On Thu, Sep 01, 2016 at 09:29:24AM -0500, Ryan Moats wrote: > When unpersisting patch_datapaths, missed that the key field > needed to be freed to avoid a memory leak. This patch fixes > same. > > Signed-off-by: Ryan Moats I don't see a reason to be doing dynamic allocation

[ovs-dev] [PATCH] ovn-controller: Fix leak in patched_datapaths processing.

Nothing freed 'key', which was dynamically allocated. This commit changes 'key' so that it is no longer dynamically allocated. Reported-by: Ryan Moats Signed-off-by: Ben Pfaff --- ovn/controller/ovn-controller.c | 4 ++-- ovn/controller/ovn-controller.h | 2 +-

Re: [ovs-dev] broken build windows

On Thu, Sep 01, 2016 at 02:57:23PM +, Alin Serdean wrote: > "error C2233: 'specs' : arrays of objects containing zero-size arrays are > illegal" > > https://ci.appveyor.com/project/blp/ovs > > I think it was caused by commit: >

Re: [ovs-dev] [PATCH] ipsec: Do not allow ipsec_gre tunnel traffic to exit unencrypted

On 30 August 2016 at 02:21, Jesse Gross wrote: > On Mon, Aug 29, 2016 at 11:57 AM, Ansis Atteka wrote: > > If ipsec_gre tunnel configuration is changed in OVSDB, > > then GRE packets may sometimes exit unencrypted until > > per-tunnel IPsec policies are

Re: [ovs-dev] [PATCH v3] ovn-nbctl: Add LB commands.

> On Sep 1, 2016, at 11:04 PM, Guru Shetty wrote: > > +AT_SETUP([ovn-nbctl - LBs]) > +OVN_NBCTL_TEST_START > + > +dnl Add two LBs > +AT_CHECK([ovn-nbctl lb-add lb0 30.0.0.10:80 > 192.168.10.10:80 ,192.168.10.20:80 >

Re: [ovs-dev] [PATCH] Fix leak in patched_datapaths processing.

> On Sep 1, 2016, at 10:29 AM, Ryan Moats wrote: > > When unpersisting patch_datapaths, missed that the key field > needed to be freed to avoid a memory leak. This patch fixes > same. > > Signed-off-by: Ryan Moats Acked-by: Flavio Fernandes

Re: [ovs-dev] [PATCH v3 2/5] ovn: Introduce l3 gateway router.

Thank, Guru. Best Regards Steve Ruan(阮诗新) Tel: (86-021)60928749, Address: 5/F, Building 10, 399 Ke Yuan Road, Zhangjiang High-Tech Park, Shanghai 201203, PRC 上海浦东新区张江高科园区科苑路399号10号楼6楼 From: Guru Shetty To: Shi Xin Ruan/China/IBM@IBMCN Cc: Amitabha Biswas

Re: [ovs-dev] [PATCH v3] ovn-nbctl: Add LB commands.

On 1 September 2016 at 04:59, nickcooper-zhangtonghao < nickcooper-zhangtong...@opencloud.tech> wrote: > This patch provides the command line to create a load balancer. > You can create a load balancer independently and add it > to multiple switches. Add a name column for the load balancer. >

[ovs-dev] broken build windows

"error C2233: 'specs' : arrays of objects containing zero-size arrays are illegal" https://ci.appveyor.com/project/blp/ovs I think it was caused by commit: https://github.com/openvswitch/ovs/commit/dfe191d5faa60d34a64e3bd1040fd6fa02b4889c ___ dev

Re: [ovs-dev] [PATCH v3 2/5] ovn: Introduce l3 gateway router.

On 1 September 2016 at 00:23, Shi Xin Ruan wrote: > Thanks, Amitabha. > > I have 1 more question: is it possible create a l3 gateway router without > SNAT/DNAT? > So traffic from GTRP will not be SNAT, but directly forward to provider > network. > I know distribute router

Re: [ovs-dev] [PATCH] Close memory leak when processing S_TLV_TABLE_REQUESTED.

> On Sep 1, 2016, at 9:57 AM, Ryan Moats wrote: > > Found by running valgrind on "ovn-controller - > Chassis external_ids" unit test case: > 24 bytes in 1 blocks are definitely lost in loss record 102 of 180 > at 0x4C2DBB6: malloc (vg_replace_malloc.c:299) > by

[ovs-dev] [PATCH] Fix leak in patched_datapaths processing.

When unpersisting patch_datapaths, missed that the key field needed to be freed to avoid a memory leak. This patch fixes same. Signed-off-by: Ryan Moats --- ovn/controller/ovn-controller.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ovn/controller/ovn-controller.c

[ovs-dev] [PATCH] Close memory leak when processing S_TLV_TABLE_REQUESTED.

Found by running valgrind on "ovn-controller - Chassis external_ids" unit test case: 24 bytes in 1 blocks are definitely lost in loss record 102 of 180 at 0x4C2DBB6: malloc (vg_replace_malloc.c:299) by 0x4916A4: xmalloc (util.c:112) by 0x47278C: decode_tlv_table_mappings

[ovs-dev] DELIVERY REPORTS ABOUT YOUR E-MAIL

___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH v3] ovn-nbctl: Add LB commands.

This patch provides the command line to create a load balancer. You can create a load balancer independently and add it to multiple switches. Add a name column for the load balancer. With --add-duplicate, the command really creates a new load balancer with a duplicate name. This name has no

Re: [ovs-dev] [PATCH] datapath-windows: Fixed tcp flags byte order in conntrack

Acked-by: Alin Gabriel Serdean > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Paul Boca > Sent: Monday, August 29, 2016 10:11 PM > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH] datapath-windows: Fixed tcp flags

[ovs-dev] Returned mail: see transcript for details

Your message was undeliverable due to the following reason: Your message was not delivered because the destination computer was not reachable within the allowed queue period. The amount of time a message is queued before it is returned depends on local configura- tion parameters. Most likely

[ovs-dev] [patch v2] ovn: ovn-ctl support to start ovn db servers in backup mode

From: Babu Shanmugam This patch adds support to start_ovsdb() function in ovn-ctl to start the ovn db servers in backup mode. This can be done in the following ways 1. Use parameters --ovn-nb-sync-from-addr and --ovn-sb-sync-from-addr to set the addresses of the active

Re: [ovs-dev] [PATCH v2] datapath-windows: add assert in OvsHashFlow()

Acked-by: Alin Gabriel Serdean > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Nithin Raju > Sent: Thursday, September 1, 2016 9:45 AM > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH v2] datapath-windows: add

Re: [ovs-dev] [PATCH] INSTALL.Windows.md : Updated the kernel datapath project solution file name

Acked-by: Alin Gabriel Serdean > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Anand > Kumar > Sent: Wednesday, August 31, 2016 11:33 PM > To: dev@openvswitch.org > Cc: Anand Kumar > Subject:

Re: [ovs-dev] [patch v1] ovn: ovn-ctl support to start ovn db servers in backup mode

On Thu, Sep 1, 2016 at 3:29 PM, Numan Siddique wrote: > > > On Thu, Sep 1, 2016 at 10:51 AM, wrote: > >> From: Babu Shanmugam >> >> This patch adds support to start_ovsdb() function in ovn-ctl to start the >> ovn db servers in

[ovs-dev] Returned mail: see transcript for details

The message could not be delivered ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] please help review patch "allow DHCPv6 respond multiple IA Address Options"

On Wed, Aug 31, 2016 at 8:44 AM, Zong Kai Li wrote: > On Tue, Aug 30, 2016 at 8:28 PM, Numan Siddique > wrote: > > > > > > On Tue, Aug 30, 2016 at 9:40 AM, Ben Pfaff wrote: > >> > >> The patch will get reviewed, there's no need to ask

Re: [ovs-dev] [patch v1] ovn: ovn-ctl support to start ovn db servers in backup mode

On Thu, Sep 1, 2016 at 10:51 AM, wrote: > From: Babu Shanmugam > > This patch adds support to start_ovsdb() function in ovn-ctl to start the > ovn db servers in backup mode. This can be done in the following ways > 1. Use parameters

[ovs-dev] [PATCH RFC v3] ovn-northd: add default_dhcpvx_options for Logical_Switch

This patch adds default_dhcpv4_options and default_dhcpv6_options columns for Logical_Switch, which should help CMS not to calculate and set dhcpv4_options and dhcpv6_options columns for lswitch ports on lswitchs one by one, when most of lswitch ports on the same lswitch are using the

Re: [ovs-dev] [PATCH v3 2/5] ovn: Introduce l3 gateway router.

Thanks, Amitabha. I have 1 more question: is it possible create a l3 gateway router without SNAT/DNAT? So traffic from GTRP will not be SNAT, but directly forward to provider network. I know distribute router can do this, but I want a centralized router. Thanks again. Best Regards Steve

[ovs-dev] [PATCH v2] datapath-windows: add assert in OvsHashFlow()

Signed-off-by: Nithin Raju --- datapath-windows/ovsext/Flow.c | 1 + 1 file changed, 1 insertion(+) diff --git a/datapath-windows/ovsext/Flow.c b/datapath-windows/ovsext/Flow.c index 439fb28..2e8b42b 100644 --- a/datapath-windows/ovsext/Flow.c +++

Re: [ovs-dev] [PATCH v3 2/5] ovn: Introduce l3 gateway router.

Hi Steve, Here is the link to the networking-ovn patch: https://review.openstack.org/#/c/346646/ Thanks Amitabha From: "Shi Xin Ruan" To: Gurucharan Shetty Cc: dev@openvswitch.org Date: 08/31/2016 10:51 PM Subject:Re: [ovs-dev] [PATCH

[ovs-dev] [PATCH] datapath-windows: add assert in OvsHashFlow()

Also fix a minor indentation issue in User.c Signed-off-by: Nithin Raju --- datapath-windows/ovsext/Flow.c | 1 + datapath-windows/ovsext/User.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/datapath-windows/ovsext/Flow.c

Re: [ovs-dev] [PATCH] datapath-windows: remove invalid ASSERT in Flow.c

Ok. Thanks for the review. -Original Message- From: dev on behalf of Yin Lin Date: Wednesday, August 31, 2016 at 5:05 PM To: Nithin Raju Cc: "dev@openvswitch.org" Subject: Re: [ovs-dev] [PATCH]