Re: [ovs-dev] [PATCH] ipf: Only add fragments to batch of same dl_type.

2024-05-16 Thread Simon Horman
Hi Mike, On Wed, May 15, 2024 at 12:24:33PM -0400, Mike Pattrick wrote: > When conntrack is reassembling packet fragments, the same reassembly > context can be shared across multiple threads handling different packets > simultaneously. Once a full packet is assembled, it is added to a packet >

Re: [ovs-dev] vlog: Destroy async_append first then close log_fd.

2024-05-15 Thread Simon Horman
On Wed, May 15, 2024 at 11:28:21AM +0800, hepeng via dev wrote: > From: Peng He > > async_append stores log_fd, it should be destructed before log_fd > is closed. > > Signed-off-by: Peng He Acked-by: Simon Horman ___

Re: [ovs-dev] [PATCH v2] table: Fix freeing global variable.

2024-05-15 Thread Simon Horman
ibc.so.6+0x2b038) > #10 0xaeb50110 in __libc_start_main (/usr/lib64/libc.so.6+ > 0x2b110) > #11 0x40906c in _start (/usr/local/bin/ovsdb-client+0x40906c) > > Fixes: cb139fa8b3a1 ("table: New function table_format() for f

Re: [ovs-dev] [PATCH v2] conntrack: Fully initialize conn struct before insertion.

2024-05-13 Thread Simon Horman
ar NAT or all-zero SNAT. > > Fix it by initializing early the connections fields. > > Fixes: 1116459b3ba8 ("conntrack: Remove nat_conn introducing key > directionality.") > Reported-at: https://issues.redhat.com/browse/FDP-616 > Signed-off-by: Mike Pattrick > Co-authored-

Re: [ovs-dev] [PATCH] Subject: conntrack: Fully initialize conn struct before insertion.

2024-05-13 Thread Simon Horman
ar NAT or all-zero SNAT. > > Fix it by initializing early the connections fields. > > Fixes: 1116459b3ba8 ("conntrack: Remove nat_conn introducing key > directionality.") > Reported-at: https://issues.redhat.com/browse/FDP-616 > Signed-off-by: Mike Pattrick > Co-authored-

Re: [ovs-dev] [Patch] ovsdb-client: Add missing arg to help for 'dump'.

2024-05-13 Thread Simon Horman
On Fri, May 10, 2024 at 01:31:10PM +0200, martin.kal...@canonical.com wrote: > Thanks for the merge and backports Simon. > > On Tue, 2024-05-07 at 17:26 +0100, Simon Horman wrote: > > On Tue, May 07, 2024 at 03:16:25PM +0100, Simon Horman wrote: > > > On Fri, May 03,

Re: [ovs-dev] [PATCH v2] utilities: Correct deletion reason in flow_reval_monitor.py.

2024-05-09 Thread Simon Horman
fproto-dpif-upcall.c > @@ -1,3 +1,4 @@ > + > /* Copyright (c) 2009, 2010, 2011, 2012, 2013, 2014, 2015, 2016 Nicira, Inc. > * > * Licensed under the Apache License, Version 2.0 (the "License"); Nit: this hunk seems unrelated to the rest of the patch. Otherwise, this

Re: [ovs-dev] [PATCH] ci: Set platform parameter when building DPDK.

2024-05-09 Thread Simon Horman
On Tue, May 07, 2024 at 05:04:34PM +0200, David Marchand wrote: > This change has no impact, since -Dmachine=default gets converted by > DPDK into -Dplatform=generic (since v21.08, see the link to DPDK commit > below). Yet, switch to explicitly setting -Dplatform and avoid the > following warning:

Re: [ovs-dev] [PATCH] ci: Set platform parameter when building DPDK.

2024-05-07 Thread Simon Horman
2024-04-18T14:50:17.0770596Z WARNING: Running the setup command as > `meson [options]` instead of `meson setup [options]` is ambiguous > and deprecated. > > Link: https://git.dpdk.org/dpdk/commit/?id=bf66003b51ec > Signed-off-by: David Marchand Acked-by: Simon Horm

Re: [ovs-dev] [Patch] ovsdb-client: Add missing arg to help for 'dump'.

2024-05-07 Thread Simon Horman
On Tue, May 07, 2024 at 03:16:25PM +0100, Simon Horman wrote: > On Fri, May 03, 2024 at 02:22:27PM +0200, martin.kal...@canonical.com wrote: ... > Thanks, > > Sorry for the confusion on my part. > Now that I can see it again I have applied it to main. > > - ovsdb-cl

Re: [ovs-dev] [Patch] ovsdb-client: Add missing arg to help for 'dump'.

2024-05-07 Thread Simon Horman
Martin. > > [0] > https://patchwork.ozlabs.org/project/openvswitch/patch/2024050043.357669-1-martin.kal...@canonical.com/ > > On Fri, 2024-05-03 at 13:16 +0100, Simon Horman wrote: > > On Wed, May 01, 2024 at 01:50:36PM +0100, Simon Horman wrote: > > > On Wed,

Re: [ovs-dev] [Patch] ovsdb-client: Add missing arg to help for 'dump'.

2024-05-03 Thread Simon Horman
On Wed, May 01, 2024 at 01:50:36PM +0100, Simon Horman wrote: > On Wed, May 01, 2024 at 01:10:43PM +0200, Martin Kalcok wrote: > > Help text for 'ovsdb-client dump' does not mention that it's capable > > of dumping specific table's contents if user supplies table's name > >

Re: [ovs-dev] [PATCH v2 1/2] test-conntrack: Add per zone benchmark tool.

2024-05-03 Thread Simon Horman
On Wed, Apr 24, 2024 at 02:44:47PM +0200, Felix Huettner via dev wrote: > The current test-conntrack benchmark command runs with multiple threads > against a single conntrack zone. We now add a new benchmark-zones > command that allows us to check the performance between multiple zones. > > We in

Re: [ovs-dev] [PATCH v3] hash, jhash: Fix unaligned access to the hash remainder.

2024-05-03 Thread Simon Horman
oject/issues/90848 > Fixes: db5a101931c5 ("clang: Fix the alignment warning.") > Signed-off-by: Ales Musil > --- > v3: Do partial revert of db5a101931c5 instead of simple cast. Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] sparse: Add additional define for sparse on GCC >= 14.

2024-05-03 Thread Simon Horman
-mirror/gcc/commit/aea8e4105553cd16799f2134d15420ccf182d732 > Tested-by: Dumitru Ceara > Signed-off-by: Ales Musil Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] Documentation: Update Pacemaker main page link.

2024-05-03 Thread Simon Horman
On Wed, May 01, 2024 at 01:39:58PM +0200, Eelco Chaudron wrote: > > > On 1 May 2024, at 12:54, Simon Horman wrote: > > > Update link to pacemaker main page as the existing link is broken. > > Also, use HTTPS. > > > > Broken link flagged by make check-docs

Re: [ovs-dev] [Patch] ovsdb-client: Add missing arg to help for 'dump'.

2024-05-01 Thread Simon Horman
On Wed, May 01, 2024 at 01:10:43PM +0200, Martin Kalcok wrote: > Help text for 'ovsdb-client dump' does not mention that it's capable > of dumping specific table's contents if user supplies table's name > as a third positional argument. > > Signed-off-by: Martin Kalcok Acked-b

Re: [ovs-dev] [PATCH RFC] route-table: Add support for v4 via v6 route.

2024-05-01 Thread Simon Horman
On Wed, May 01, 2024 at 11:59:02AM +0100, Simon Horman wrote: > On Wed, May 01, 2024 at 11:57:46AM +0100, Simon Horman wrote: > > On Fri, Apr 26, 2024 at 10:16:31PM -0700, William Tu via dev wrote: > > > Add route-table that support ipv4 dst via ipv6. BGP unnumbered i

Re: [ovs-dev] [PATCH] netdev-tc-offloads: Don't offload header modification on ip fragments.

2024-05-01 Thread Simon Horman
IP fragments. > > Since TC already applies fragmentation bit masking, this patch simply > needs to prevent these packets from being processed through TC. > > Signed-off-by: Eelco Chaudron Acked-by: Simon Horman ___ dev mailing list

Re: [ovs-dev] [PATCH] netdev-tc-offloads: Don't offload header modification on ip fragments.

2024-05-01 Thread Simon Horman
On Tue, Apr 30, 2024 at 02:42:45PM +0200, Eelco Chaudron wrote: > Greetings, Intel team! > > The self-test conducted as part of this patch has revealed an issue with the > AVX512 checksumming code. Since it was agreed upon that your team would > maintain this code upon its inclusion, could you

Re: [ovs-dev] [PATCH v2] ofproto-dpif-rid: Fix duplicate entries.

2024-05-01 Thread Simon Horman
On Tue, Apr 30, 2024 at 05:36:09PM +0800, wushao...@chinatelecom.cn wrote: > From: Shaohua Wu > > In scenarios with multiple PMDs, there may be > simultaneous requests for recirc_id from multiple > PMD threads.In recirc_alloc_id_ctx, we first check > if there is a duplicate entry in the

Re: [ovs-dev] [PATCH v2 2/2] conntrack: Key connections by zone.

2024-05-01 Thread Simon Horman
thout commiting of around 6% to 23% > * a significant performance improvement for flushing a full zone of > around 75% to 99% > * an even more significant improvement for flushing empty zones since we > no longer need to check any unrelated connections Very nice numbers indeed. > [1] 9ec849e8aa869b646c372fac552ae2609a4b5f66 > > Signed-off-by: Felix Huettner Acked-by: Simon Horman ... ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2 1/2] test-conntrack: Add per zone benchmark tool.

2024-05-01 Thread Simon Horman
t the entries of a >single zone > > Signed-off-by: Felix Huettner > --- > v1->v2: fix formatting Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH RFC] route-table: Add support for v4 via v6 route.

2024-05-01 Thread Simon Horman
On Wed, May 01, 2024 at 11:57:46AM +0100, Simon Horman wrote: > On Fri, Apr 26, 2024 at 10:16:31PM -0700, William Tu via dev wrote: > > Add route-table that support ipv4 dst via ipv6. BGP unnumbered is mechanism > > that allows BGP to establish peering sessions without the nee

Re: [ovs-dev] [PATCH RFC] route-table: Add support for v4 via v6 route.

2024-05-01 Thread Simon Horman
v br-phy src 100.87.18.6 > > Currently OVS can only support either all-ipv4 or all-ipv6, the patch > adds support for such use case. > > Reported-at: > https://mail.openvswitch.org/pipermail/ovs-discuss/2024-January/052908.html > Signe

[ovs-dev] [PATCH] Documentation: Update Pacemaker main page link.

2024-05-01 Thread Simon Horman
Update link to pacemaker main page as the existing link is broken. Also, use HTTPS. Broken link flagged by make check-docs Signed-off-by: Simon Horman --- Documentation/topics/integration.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/topics

Re: [ovs-dev] [PATCH] socket: Don't fail when AF_UNIX connect() returns EAGAIN.

2024-05-01 Thread Simon Horman
andled the same way - by returning the `fd` and > letting the caller to complete connection asynchronously. > > [1]: > https://pubs.opengroup.org/onlinepubs/9699919799.2016edition/functions/connect.html > [2]: see `connect(2)` on Linux for details > > Signed-off-by: Ihar

Re: [ovs-dev] [PATCH v3] docs: Document manual cluster recovery procedure.

2024-05-01 Thread Simon Horman
Ihar Hrachyshka > > --- > > v1: initial version. > v2: remove --force mentioned in ovsdb-server(1). > v3: multiple language and markup changes suggested by Ilya. Thanks for the updates Ihar, this version looks good to me. Acked-by: Simon Horman ... __

Re: [ovs-dev] [PATCH] dpctl: fix segfault on ct-{set,del}-limits

2024-04-26 Thread Simon Horman
On Fri, Apr 26, 2024 at 09:59:50AM +0100, Simon Horman wrote: > On Thu, Apr 25, 2024 at 11:52:55AM +0100, Kevin Traynor wrote: > > On 22/04/2024 13:37, Paolo Valerio wrote: > > > When no parameters other than the datapath are specified a segfault > > > occurs. >

Re: [ovs-dev] [PATCH 1/1] netdev-dpdk: Improve error print to the user for flow control error.

2024-04-26 Thread Simon Horman
On Wed, Apr 17, 2024 at 10:54:14AM +0300, Roi Dayan wrote: > When failing to get flow control parameters use VLOG_WARN_BUF() > to expose the error string in ovs-vsctl show. > > Signed-off-by: Roi Dayan > Suggested-by: Simon Horman > Acked-by: Eli Britstein Thanks Roi

Re: [ovs-dev] [PATCH] dpctl: fix segfault on ct-{set,del}-limits

2024-04-26 Thread Simon Horman
On Thu, Apr 25, 2024 at 11:52:55AM +0100, Kevin Traynor wrote: > On 22/04/2024 13:37, Paolo Valerio wrote: > > When no parameters other than the datapath are specified a segfault > > occurs. > > > > Fix it by checking the argument access is inside the bounds. > > > > Signed-off-by: Paolo Valerio

Re: [ovs-dev] [PATCH] GitHub: Add Coverity scan as a daily GitHub action.

2024-04-26 Thread Simon Horman
add the following two actions secrets > to the GitHub openvswitch project: > > - COVERITY_SCAN_TOKEN; The secret token from the project page > - COVERITY_SCAN_EMAIL; The maintainer's email alias > > Signed-off-by: Eelco Chaudron Hi Eelco, I'm fine with this patch in it's c

Re: [ovs-dev] selftests: openvswitch: Questions about possible enhancements

2024-04-26 Thread Simon Horman
On Thu, Apr 25, 2024 at 12:21:51PM -0700, Jakub Kicinski wrote: > On Thu, 25 Apr 2024 19:57:19 +0100 Simon Horman wrote: > > openvswitch.sh does not appear to have any dependencies on Open vSwitch > > user-space. My understanding is that, rather, it makes use of > > tools/

Re: [ovs-dev] selftests: openvswitch: Questions about possible enhancements

2024-04-25 Thread Simon Horman
+ Aaron On Thu, Apr 25, 2024 at 09:26:37AM +0100, Simon Horman wrote: > On Wed, Apr 24, 2024 at 05:30:00PM -0700, Jakub Kicinski wrote: > > On Wed, 24 Apr 2024 17:44:05 +0100 Simon Horman wrote: > > > I have recently been exercising the Open vSwitch kernel selftest

Re: [ovs-dev] selftests: openvswitch: Questions about possible enhancements

2024-04-25 Thread Simon Horman
On Wed, Apr 24, 2024 at 05:30:00PM -0700, Jakub Kicinski wrote: > On Wed, 24 Apr 2024 17:44:05 +0100 Simon Horman wrote: > > I have recently been exercising the Open vSwitch kernel selftests, > > using vng, > > Speaking of ovs tests, we currently don't run them in CI (and s

Re: [ovs-dev] selftests: openvswitch: Questions about possible enhancements

2024-04-25 Thread Simon Horman
On Wed, Apr 24, 2024 at 02:14:09PM -0400, Aaron Conole wrote: > Simon Horman writes: > > > Hi Aaron, Jakub, all, > > > > I have recently been exercising the Open vSwitch kernel selftests, > > using vng, something like this: > > > > TESTDI

Re: [ovs-dev] selftests: openvswitch: Questions about possible enhancements

2024-04-25 Thread Simon Horman
On Wed, Apr 24, 2024 at 01:59:29PM -0400, Benjamin Poirier wrote: > On 2024-04-24 18:37 +0100, Simon Horman wrote: > > On Wed, Apr 24, 2024 at 05:44:05PM +0100, Simon Horman wrote: > > > Hi Aaron, Jakub, all, > > > > > > I have recently been exercisi

Re: [ovs-dev] selftests: openvswitch: Questions about possible enhancements

2024-04-24 Thread Simon Horman
On Wed, Apr 24, 2024 at 05:44:05PM +0100, Simon Horman wrote: > Hi Aaron, Jakub, all, > > I have recently been exercising the Open vSwitch kernel selftests, > using vng, something like this: > > TESTDIR="tools/testing/selftests/net/openvswitch" > >

[ovs-dev] selftests: openvswitch: Questions about possible enhancements

2024-04-24 Thread Simon Horman
Hi Aaron, Jakub, all, I have recently been exercising the Open vSwitch kernel selftests, using vng, something like this: TESTDIR="tools/testing/selftests/net/openvswitch" vng -v --run . --user root --cpus 2 \ --overlay-rwdir "$PWD" -- \ "modprobe

Re: [ovs-dev] [PATCH 1/1] netdev-dpdk: Fix possible memory leak configuring VF MAC address.

2024-04-24 Thread Simon Horman
On Tue, Apr 23, 2024 at 11:33:15AM +0100, Simon Horman wrote: > On Wed, Apr 17, 2024 at 10:43:11AM +0300, Roi Dayan wrote: > > > > > > On 16/04/2024 18:48, Simon Horman wrote: > > > On Tue, Apr 16, 2024 at 04:21:48PM +0300, Roi Dayan via dev wrote: > > >

Re: [ovs-dev] [PATCH net-next] net: openvswitch: Release reference to netdev

2024-04-23 Thread Simon Horman
ner.pl my.patch I'd wait for feedback from Jakub on if a repost is needed (because for one thing it's not good to repost within 24h.) The above notwithstanding, Reviewed-by: Simon Horman > --- > net/openvswitch/vport-netdev.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) >

Re: [ovs-dev] [PATCH 1/3] ovsdb-idl: Add python keyword to persistent UUID test.

2024-04-23 Thread Simon Horman
On Thu, Apr 11, 2024 at 11:46:01AM +0100, Simon Horman wrote: > On Wed, Apr 10, 2024 at 04:38:24PM -0500, Terry Wilson wrote: > > The Python persistent UUID tests should have the keyword "python" > > added so that TESTSUITEFLAGS="-k python" will not mi

Re: [ovs-dev] [PATCH] socket: Increase listen backlog to 64 everywhere.

2024-04-23 Thread Simon Horman
On Fri, Apr 12, 2024 at 10:33:18AM +0100, Simon Horman wrote: > On Fri, Apr 12, 2024 at 02:45:17AM +, Ihar Hrachyshka wrote: > > Before the patch, the size of the backlog depended on the type of socket > > (UNIX vs INET) as well as on the language (C vs Python), specifically: &g

Re: [ovs-dev] [PATCH] dpctl: fix segfault on ct-{set,del}-limits

2024-04-23 Thread Simon Horman
On Mon, Apr 22, 2024 at 02:37:41PM +0200, Paolo Valerio wrote: > When no parameters other than the datapath are specified a segfault > occurs. > > Fix it by checking the argument access is inside the bounds. > > Signed-off-by: Paolo Valerio Acke

Re: [ovs-dev] [PATCH] rhel/systemd: Set ovsdb-server timeout to 5 minutes

2024-04-23 Thread Simon Horman
tever reason it takes too long is problematic. Addressing > > the root cause (compaction, too many calls, some other bug(s) etc) is > > good, but extending the timeout seems like an easy backstop. > > I agree with Jon's assessment - regardless of any action taken on compaction > or preventing growth in the first place, we should consider the proposed > timeout increase as a backstop against getting stuck in an infinite loop. > > Ilya (or another maintainer) - can I get an opinion on this? Yes, I agree that the timeout increase is a good idea. Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 1/1] netdev-dpdk: Fix possible memory leak configuring VF MAC address.

2024-04-23 Thread Simon Horman
On Wed, Apr 17, 2024 at 10:43:11AM +0300, Roi Dayan wrote: > > > On 16/04/2024 18:48, Simon Horman wrote: > > On Tue, Apr 16, 2024 at 04:21:48PM +0300, Roi Dayan via dev wrote: > >> VLOG_WARN_BUF() is allocating memory for the error string and should > >> e

Re: [ovs-dev] [PATCH 1/1] netdev-dpdk: Improve error print to the user for flow control error.

2024-04-23 Thread Simon Horman
On Wed, Apr 17, 2024 at 10:54:14AM +0300, Roi Dayan wrote: > When failing to get flow control parameters use VLOG_WARN_BUF() > to expose the error string in ovs-vsctl show. > > Signed-off-by: Roi Dayan > Suggested-by: Simon Horman > Acked-by: Eli Britstein Acke

Re: [ovs-dev] [PATCH 1/1] netdev-dpdk: Fix possible memory leak configuring VF MAC address.

2024-04-16 Thread Simon Horman
'%s'.", netdev_get_name(netdev), vf_mac); > } else if (!eth_addr_equals(dev->requested_hwaddr, mac)) { > dev->requested_hwaddr = mac; > netdev_request_reconfigure(netdev); Thanks Roi, I agree that this change makes sense as the allocated value

Re: [ovs-dev] [PATCH] checkpatch: Allow rST manpages to be added.

2024-04-12 Thread Simon Horman
On Wed, Apr 10, 2024 at 03:45:55PM +0200, Eelco Chaudron wrote: > > > On 9 Apr 2024, at 9:19, Adrian Moreno wrote: > > > The current __check_doc_is_listed() verifies that the new .rst file is > > listed in Documentation/automake.mk with the full path (i.e: > > "{directory}/{filename}"). > > > >

Re: [ovs-dev] [PATCH] docs: Document manual cluster recovery procedure.

2024-04-12 Thread Simon Horman
Ihar Hrachyshka Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] socket: Increase listen backlog to 64 everywhere.

2024-04-12 Thread Simon Horman
://mail.openvswitch.org/pipermail/ovs-discuss/2024-April/053049.html > > Signed-off-by: Ihar Hrachyshka > Acked-by: Eelco Chaudron Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] appveyor: Fix too wide OpenSSL version regexp.

2024-04-12 Thread Simon Horman
penSSL 3.0.") > Signed-off-by: Ilya Maximets Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 0/2] ci: Remove reference to master branch.

2024-04-11 Thread Simon Horman
On Wed, Apr 10, 2024 at 03:09:19PM +0100, Simon Horman wrote: > The OvS primary development branch has been renamed main > so there is no longer any need for CI configuration to > refer to master. > > Signed-off-by: Simon Horman > > --- > Simon Horman (2): >

Re: [ovs-dev] [PATCH 1/3] ovsdb-idl: Add python keyword to persistent UUID test.

2024-04-11 Thread Simon Horman
rt to specify the uuid for row > insert.") > Signed-off-by: Terry Wilson Acked-by: Simon Horman Tested-by: Simon Horman ... ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 3/3] github: Update python to 3.12.

2024-04-11 Thread Simon Horman
ecomes > a race against older python versions reaching end of their life and > packages dropping support of these versions. This may cause unexpected > CI failures. So, not doing that for now. > > Signed-off-by: Ilya Maximets Acked-by: Simon Horman ___

Re: [ovs-dev] [PATCH 2/3] ovsdb-dot: Fix flake8 issues.

2024-04-11 Thread Simon Horman
gt; > Files added to flake8-check to avoid future issues. > > Signed-off-by: Ilya Maximets Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 1/3] ovsdb-doc: Fix syntax warning with Python 3.12 and flake8 issues.

2024-04-11 Thread Simon Horman
the future. This means also fixing all the other issues with the > script like unused imports and variables, long lines, missing empty > lines, wildcarded imports. Also cleaning up one place that handles > compatibility with Python 2 types, since we do not support Python 2 > for a long

Re: [ovs-dev] [PATCH] python: Remove hacking dependency and use recent flake8.

2024-04-10 Thread Simon Horman
OVN a while ago: > https://github.com/ovn-org/ovn/commit/271186fa7d76 > > Signed-off-by: Dumitru Ceara Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] vlog: Log stack trace on vlog_abort.

2024-04-10 Thread Simon Horman
> > If this change is accepted, I'd also suggest backporting it to 3.3. > It is a debug-only change that touches only the code executed under > fatal failure conditions, so should be safe enough. Backporting > will allow us easier debugging in to-be-LTS release. And a

Re: [ovs-dev] [PATCH branch-2.17] xenserver: Fix tests with Python 3.12.

2024-04-10 Thread Simon Horman
: VLAN on bondok 2352: non-VLAN, non-bond ok Acked-by: Simon Horman Tested-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn v2] treewide: Rename references from OvS master to main.

2024-04-10 Thread Simon Horman
On Wed, Apr 10, 2024 at 03:45:53PM +0200, Ales Musil wrote: > There was recent switch in OvS from master to main branch. > Use main in all the references across OVN code base. > > Signed-off-by: Ales Musil > --- > v2: Add the missing two references. Acke

[ovs-dev] [PATCH 1/2] appveyor: Remove reference to master branch.

2024-04-10 Thread Simon Horman
The OvS primary development branch has been renamed main so there is no longer any need for this CI configuration to refer to master. Signed-off-by: Simon Horman --- appveyor.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/appveyor.yml b/appveyor.yml index 050c7dead786..baa844753962

[ovs-dev] [PATCH 2/2] github: Remove reference to master branch.

2024-04-10 Thread Simon Horman
The OvS primary development branch has been renamed main so there is no longer any need for this CI configuration to refer to master. Signed-off-by: Simon Horman --- .github/workflows/build-and-test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build

[ovs-dev] [PATCH 0/2] ci: Remove reference to master branch.

2024-04-10 Thread Simon Horman
The OvS primary development branch has been renamed main so there is no longer any need for CI configuration to refer to master. Signed-off-by: Simon Horman --- Simon Horman (2): appveyor: Remove reference to master branch. github: Remove reference to master branch. .github

[ovs-dev] [ANN] Primary OVS branch renamed as main development branch as main.

2024-04-10 Thread Simon Horman
Hi, I would like to announce that the primary development branch for OvS has been renamed main. The rename occurred a little earlier today. OVS is currently hosted on GitHub. We can expect the following behaviour after the rename: * GitHub pull requests against master should have been

Re: [ovs-dev] [PATCH ovn] ci: Rename OvS master branch to main.

2024-04-10 Thread Simon Horman
On Wed, Apr 10, 2024 at 03:26:25PM +0200, Ales Musil wrote: > There was recent switch in OvS from master to main branch. > Use main instead in ovn-fake-mutlinode tests. > > Signed-off-by: Ales Musil Acked-by: Simon Horman ___ dev ma

Re: [ovs-dev] [PATCH v3] Documentation: Updates for rename of primary development branch as main.

2024-04-10 Thread Simon Horman
On Wed, Apr 10, 2024 at 12:07:12PM +0100, Simon Horman wrote: > On Tue, Apr 09, 2024 at 07:28:08PM +0200, Ilya Maximets wrote: > > On 4/5/24 15:57, Simon Horman wrote: > > > Recently OVS adopted a policy of using the inclusive naming word list v1 > > > [1,

Re: [ovs-dev] [PATCH] checkpatch: Allow rST manpages to be added.

2024-04-10 Thread Simon Horman
g as follows even though the patch does add the file to > RST_MANPAGES: > > """ > WARNING: New doc ovs-flowviz.8.rst not listed in > Documentation/automake.mk > """ > > Fix it by making the {dir}/ part of the docre regexp optional. > > Sig

Re: [ovs-dev] [PATCH v3] Documentation: Updates for rename of primary development branch as main.

2024-04-10 Thread Simon Horman
On Tue, Apr 09, 2024 at 07:28:08PM +0200, Ilya Maximets wrote: > On 4/5/24 15:57, Simon Horman wrote: > > Recently OVS adopted a policy of using the inclusive naming word list v1 > > [1, 2]. > > > > In keeping with this policy rename the primary development branch

[ovs-dev] [PATCH v3] Documentation: Updates for rename of primary development branch as main.

2024-04-05 Thread Simon Horman
), and fetch -p will remove (prune) the old branch (master) [1] df5e5cf4318a ("Documentation: Add section on inclusive language.") [2] https://inclusivenaming.org/word-lists/ Signed-off-by: Simon Horman --- Changes in v3: - This patch only updates documentation. Update the patch prefix and d

Re: [ovs-dev] [PATCH v2] Rename primary development branch as main.

2024-04-05 Thread Simon Horman
On Fri, Apr 05, 2024 at 11:57:17AM +0200, Ilya Maximets wrote: > On 4/2/24 16:44, Simon Horman wrote: > > Recently OVS adopted a policy of using the inclusive naming word list v1 > > [1, 2]. > > > > In keeping with this policy rename the primary development branch

Re: [ovs-dev] [PATCH] [PATCH v2] ofproto: Fix mod flow table name not to take effect.

2024-04-03 Thread Simon Horman
On Wed, Apr 03, 2024 at 03:11:36PM +0800, Yuhao zhou via dev wrote: > From: "zhouyuhao.philozhou" > > When mod a flow table's name with table's prefix name, there > will be no change. Because when check whether the new and old > name are the same, only compare the length of the new name. > >

Re: [ovs-dev] [PATCH] checkpatch: Add additional words to extra_keywords.

2024-04-02 Thread Simon Horman
On Tue, Apr 02, 2024 at 03:21:16PM +0200, Eelco Chaudron wrote: > This patch add another set of keywords based on the results > of the last thousand committed patches. > > Signed-off-by: Eelco Chaudron Acked-by: Simon Horman ___ dev ma

[ovs-dev] [PATCH v2] Rename primary development branch as main.

2024-04-02 Thread Simon Horman
(prune) the old branch (master) [1] df5e5cf4318a ("Documentation: Add section on inclusive language.") [2] https://inclusivenaming.org/word-lists/ Signed-off-by: Simon Horman --- Changes in v2: - Keep two blank lines between versions. - Drop bogus update to OpenSSL hashes URL in ap

Re: [ovs-dev] [PATCH v2] Documentation: Update references to kernel datapath in OVS tree.

2024-04-02 Thread Simon Horman
On Thu, Mar 28, 2024 at 03:25:56PM +0100, Ilya Maximets wrote: > On 3/22/24 16:56, Simon Horman wrote: > > The Kernel datapath is no longer present in the primary development > > branch of the OVS tree. Update documentation to more clearly reflect > > this. > >

Re: [ovs-dev] [PATCH] appveyor: Prepare for rename of primary development branch.

2024-04-02 Thread Simon Horman
On Thu, Mar 28, 2024 at 01:02:18PM +0100, Ilya Maximets wrote: > On 3/22/24 16:11, Simon Horman wrote: > > Recently OVS adopted a policy of using the inclusive naming word list v1 > > [1, 2]. And in keeping with this policy it is intended to rename the > > primary developme

Re: [ovs-dev] [PATCH] ovs-tcpdump:Solve the problem of residual mirror port

2024-03-27 Thread Simon Horman
On Thu, Mar 21, 2024 at 08:33:37PM +0800, yangchang wrote: > Before creating an mirror port, it is necessary to first check whether the > original port exists. > Otherwise, when the original port does not exist, the created mirror port > will remain. > > Signed-off-by: yangchang Hi, Thanks

Re: [ovs-dev] [PATCH] Userspace: Software fallback for UDP encapsulated TCP segmentation.

2024-03-27 Thread Simon Horman
On Tue, Feb 20, 2024 at 11:08:55PM -0500, Mike Pattrick wrote: > When sending packets that are flagged as requiring segmentation to an > interface that doens't support this feature, send the packet to the TSO > software fallback instead of dropping it. > > Signed-off-by: Mike Pattrick Hi Mike,

Re: [ovs-dev] [PATCH v5] tunnel: Allow UDP zero checksum with IPv6 tunnels.

2024-03-27 Thread Simon Horman
> v5: Addressed identified nit's Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v4] tunnel: Allow UDP zero checksum with IPv6 tunnels.

2024-03-27 Thread Simon Horman
On Thu, Mar 21, 2024 at 05:08:06PM -0400, Mike Pattrick wrote: > This patch adopts the proposed RFC 6935 by allowing null UDP checksums > even if the tunnel protocol is IPv6. This is already supported by Linux > through the udp6zerocsumtx tunnel option. It is disabled by default and > IPv6 tunnels

[ovs-dev] [PATCH v2] Documentation: Update references to kernel datapath in OVS tree.

2024-03-22 Thread Simon Horman
than one upstream networking maintainer these days. Signed-off-by: Simon Horman --- Changes in v2: - Rather than removing documentation update it to make it clearer that the datapath is not present since version 3.0. - Link to v1: https://lore.kernel.org/r/20240321-dei-kernel-dp-doc-v1-1-f8cd82869

[ovs-dev] [PATCH] appveyor: Prepare for rename of primary development branch.

2024-03-22 Thread Simon Horman
-lists/ [3] https://mail.openvswitch.org/pipermail/ovs-dev/2024-March/412686.html Signed-off-by: Simon Horman --- * Exercised successfully using Appveyor with this patch applied to a main and master branch. --- appveyor.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/appv

Re: [ovs-dev] [PATCH] Documentation: Remove references to kernel datapath in OVS tree.

2024-03-22 Thread Simon Horman
On Thu, Mar 21, 2024 at 06:23:43PM +0100, Ilya Maximets wrote: > On 3/21/24 11:03, Simon Horman wrote: > > The Kernel datapath is no longer present in the primary development > > branch of the OVS tree. Remove references to this in the documentation. > > > >

Re: [ovs-dev] [PATCH] Rename primary development branch as main.

2024-03-22 Thread Simon Horman
r branch in one > of the CI workflows. Hi Ilya, thanks for your review and increasing visibility of this change. > On 3/21/24 11:09, Simon Horman wrote: > > Recently OVS adopted a policy of using the inclusive naming word list v1 > > [1, 2]. > > > > In keeping wi

Re: [ovs-dev] [PATCH] Rename primary development branch as main.

2024-03-21 Thread Simon Horman
On Thu, Mar 21, 2024 at 10:09:20AM +, Simon Horman wrote: ... > diff --git a/appveyor.yml b/appveyor.yml ... > @@ -23,7 +23,7 @@ install: > New-Item -ItemType Directory -Force -Path C:\ovs-build-downloads > > # Find and download the latest stable OpenSSl 3

[ovs-dev] [PATCH] Rename primary development branch as main.

2024-03-21 Thread Simon Horman
(prune) the old branch (master) [1] df5e5cf ("Documentation: Add section on inclusive language.") [2] https://inclusivenaming.org/word-lists/ Signed-off-by: Simon Horman --- Notes: * Now is the time to raise any concerns regarding this patch. I plan to repost in approximat

[ovs-dev] [PATCH] Documentation: Remove references to kernel datapath in OVS tree.

2024-03-21 Thread Simon Horman
The Kernel datapath is no longer present in the primary development branch of the OVS tree. Remove references to this in the documentation. Signed-off-by: Simon Horman --- Documentation/faq/releases.rst | 3 --- Documentation/internals/contributing/backporting

Re: [ovs-dev] [PATCH net-next 2/3] net: openvswitch: remove unnecessary linux/genetlink.h include

2024-03-18 Thread Simon Horman
itch/meter.h includes > linux/genetlink.h but for no apparent reason (for struct genl_family > perhaps? it's not necessary, types of externs do not need > to be known). > > Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman ___

Re: [ovs-dev] [PATCH branch-2.17] conntrack: Fix flush not flushing all elements.

2024-03-08 Thread Simon Horman
On Wed, Mar 06, 2024 at 07:06:39PM +, Simon Horman wrote: > From: Xavier Simonart > > On netdev datapath, when a ct element was cleaned, the cmap > could be shrinked, potentially causing some elements to be skipped > in the flush iteration. > > Fixes: 967bb5c5cd90

Re: [ovs-dev] [PATCH branch-3.0] conntrack: Fix flush not flushing all elements.

2024-03-08 Thread Simon Horman
On Wed, Mar 06, 2024 at 07:00:50PM +, Simon Horman wrote: > From: Xavier Simonart > > On netdev datapath, when a ct element was cleaned, the cmap > could be shrinked, potentially causing some elements to be skipped > in the flush iteration. > > Fixes: 967bb5c5cd90

Re: [ovs-dev] [PATCH branch-3.1] conntrack: Fix flush not flushing all elements.

2024-03-08 Thread Simon Horman
On Wed, Mar 06, 2024 at 06:21:36PM +, 'Simon Horman' wrote: > From: Xavier Simonart > > On netdev datapath, when a ct element was cleaned, the cmap > could be shrinked, potentially causing some elements to be skipped > in the flush iteration. > > Fixes: 967bb5c5cd90

Re: [ovs-dev] [PATCH branch-3.2 0/2] conntrack: Fix flush not flushing all elements.

2024-03-08 Thread Simon Horman
On Wed, Mar 06, 2024 at 06:11:08PM +, 'Simon Horman' wrote: > Backport to branch-3.2 of: > > - conntrack: Fix flush not flushing all elements. > https://github.com/openvswitch/ovs/commit/6c082a8310d5 > > Including dependency which is not present in branch-3.2. App

[ovs-dev] [PATCH branch-2.17] conntrack: Fix flush not flushing all elements.

2024-03-06 Thread Simon Horman
Signed-off-by: Simon Horman --- Changes in backport * Resolved minor conflict in conntrack.c * The test has been updated to avoid using ovs-ofctl compose-packet --bare which does not exist until OVS v3.3. Instead frames are constructed using printf. * Updated test so a full tuple is passed to d

[ovs-dev] [PATCH branch-3.0] conntrack: Fix flush not flushing all elements.

2024-03-06 Thread Simon Horman
Signed-off-by: Simon Horman --- The test has been updated to avoid using ovs-ofctl compose-packet --bare which does not exist until OVS v3.3. Instead frames are constructed using printf. --- lib/conntrack.c | 14 +++--- lib/conntrack.h | 2 +- tests/system-traff

Re: [ovs-dev] [PATCH branch-3.1] conntrack: Fix flush not flushing all elements.

2024-03-06 Thread Simon Horman
+ Xavier Simonart Mike Pattrick On Wed, Mar 06, 2024 at 06:21:36PM +, 'Simon Horman' wrote: > From: Xavier Simonart > > On netdev datapath, when a ct element was cleaned, the cmap > could be shrinked, potentially causing some elements to be skipped &g

[ovs-dev] [PATCH branch-3.1] conntrack: Fix flush not flushing all elements.

2024-03-06 Thread 'Simon Horman'
Signed-off-by: Simon Horman --- The test has been updated to avoid using ovs-ofctl compose-packet --bare which does not exist until OVS v3.3. Instead frames are constructed using printf. --- lib/conntrack.c | 14 lib/conntrack.h | 2 +- tests/system-traff

Re: [ovs-dev] [PATCH branch-3.2 0/2] conntrack: Fix flush not flushing all elements.

2024-03-06 Thread Simon Horman
+ Aaron Conole Frode Nordahl Mike Pattrick Paolo Valerio Xavier Simonart On Wed, Mar 06, 2024 at 06:11:08PM +, 'Simon Horman' wrote: > Backport to branch-3.20 of: s/branch-3.20/branch-3.2/ > - conntrack: Fix flush not flushing all elements. > https://github.com/op

[ovs-dev] [PATCH branch-3.2 1/2] conntrack: Remove nat_conn introducing key directionality.

2024-03-06 Thread 'Simon Horman'
-by: Paolo Valerio Signed-off-by: Paolo Valerio Tested-by: Frode Nordahl Acked-by: Ilya Maximets Acked-by: Aaron Conole Signed-off-by: Aaron Conole Signed-off-by: Simon Horman --- This patch is included in this series as a dependency as although it is present in branches for older releases

[ovs-dev] [PATCH branch-3.2 0/2] conntrack: Fix flush not flushing all elements.

2024-03-06 Thread 'Simon Horman'
Backport to branch-3.20 of: - conntrack: Fix flush not flushing all elements. https://github.com/openvswitch/ovs/commit/6c082a8310d5 Including dependency which is not present in branch-3.2. --- Peng He (1): conntrack: Remove nat_conn introducing key directionality. Xavier Simonart (1):

[ovs-dev] [PATCH branch-3.2 2/2] conntrack: Fix flush not flushing all elements.

2024-03-06 Thread 'Simon Horman'
Signed-off-by: Simon Horman --- The test has been updated to avoid using ovs-ofctl compose-packet --bare which does not exist until OVS v3.3. Instead frames are constructed using printf. --- lib/conntrack.c | 14 lib/conntrack.h | 2 +- tests/system-traff

  1   2   3   4   5   6   7   8   9   10   >