Re: [ovs-dev] [PATCH nf-next v9 8/8] openvswitch: Interface with NAT.

2016-03-10 Thread Thomas Graf
responding OVS userspace patch series includes test cases (in > > tests/system-traffic.at) that also serve as example uses. > > > > This work extends on a branch by Thomas Graf at > > https://github.com/tgraf/ovs/tree/nat. > > Thomas, I guess there was not signoff in th

Re: [ovs-dev] [PATCH net 1/2] vxlan: Relax the MTU constraint on vxlan devices

2016-01-10 Thread Thomas Graf
On 01/09/16 at 10:39am, roopa wrote: > On 1/6/16, 5:33 AM, David Wragg wrote: > > Allow the MTU of vxlan devices without an underlying device to be set to > > larger values (up to a maximum based on IP packet limits and vxlan > > overhead). > > > > Previously, their MTUs could not be set to higher

Re: [ovs-dev] [PATCH net 0/2] vxlan: Set a large MTU on ovs-created vxlan devices

2016-01-10 Thread Thomas Graf
On 01/08/16 at 10:29pm, Hannes Frederic Sowa wrote: > On 07.01.2016 19:40, Thomas Graf wrote: > >I think you are worried about an ICMP error from a hop which does not > >decrement TTL. I think that's a good point and I think we should only > >send an ICMP error if t

Re: [ovs-dev] [PATCH net 2/2] vxlan: Set a large MTU on ovs-created vxlan devices

2016-01-07 Thread Thomas Graf
On 01/06/16 at 01:33pm, David Wragg wrote: > Prior to 4.3, vxlan vports could transmit vxlan packets of any size, > constrained only by the ability to transmit the resulting UDP packets. > 4.3 introduced vxlan netdevs corresponding to vxlan vports. These > netdevs have an MTU, which limits the

Re: [ovs-dev] [PATCH net 0/2] vxlan: Set a large MTU on ovs-created vxlan devices

2016-01-07 Thread Thomas Graf
On 01/06/16 at 04:46pm, Jesse Gross wrote: > On Wed, Jan 6, 2016 at 4:14 PM, Hannes Frederic Sowa > > I don't see any other way as to make MTUs part of the flow if we want to > > have correct ip_local_error notifications. And those must also work across > > VMs, so openvswitch in quasi brouting

Re: [ovs-dev] [PATCH net 0/2] vxlan: Set a large MTU on ovs-created vxlan devices

2016-01-07 Thread Thomas Graf
On 01/07/16 at 08:35am, Jesse Gross wrote: > On Thu, Jan 7, 2016 at 3:49 AM, Thomas Graf <tg...@suug.ch> wrote: > > A simple start could be to add a new return code for > MTU drops in > > the dev_queue_xmit() path and check for NET_XMIT_DROP_MTU in > > ovs_vpor

Re: [ovs-dev] [PATCH net 0/2] vxlan: Set a large MTU on ovs-created vxlan devices

2016-01-07 Thread Thomas Graf
On 01/07/16 at 06:50pm, Hannes Frederic Sowa wrote: > On 07.01.2016 18:21, Thomas Graf wrote: > >On 01/07/16 at 08:35am, Jesse Gross wrote: > >>On Thu, Jan 7, 2016 at 3:49 AM, Thomas Graf <tg...@suug.ch> wrote: > >>>A simple start could be to a

Re: [ovs-dev] [RFC PATCH 5/5] openvswitch: Interface with NAT.

2015-10-21 Thread Thomas Graf
On 10/21/15 at 02:04pm, Jarno Rajahalme wrote: > > > On Oct 21, 2015, at 3:59 AM, Thomas Graf <tg...@suug.ch> wrote: > > Simplify this with an OVS_NAT_ATTR_FLAGS? > > The use of separate flag attributes was actually intentional, as it makes the > interface easie

Re: [ovs-dev] [RFC PATCH 1/5] netfilter: Remove IP_CT_NEW_REPLY definition.

2015-10-21 Thread Thomas Graf
On 10/21/15 at 01:15pm, Jarno Rajahalme wrote: > > > On Oct 21, 2015, at 1:33 AM, Thomas Graf <tg...@suug.ch> wrote: > > I understand what you are doing here but this is part of the published > > UAPI and removing this might break compilation of a user application

Re: [ovs-dev] [RFC PATCH 5/5] openvswitch: Interface with NAT.

2015-10-21 Thread Thomas Graf
luded within the nested > attributes, new (non-committed/non-confirmed) connections are mangled > according to the rest of the nested attributes. > > This work extends on a branch by Thomas Graf at > https://github.com/tgraf/ovs/tree/nat. > > Signed-off-by: Jarno Rajahalme <

Re: [ovs-dev] [RFC PATCH 4/5] openvswitch: conntrack netlink API updates.

2015-10-21 Thread Thomas Graf
On 10/21/15 at 12:41pm, Pablo Neira Ayuso wrote: > On Tue, Oct 20, 2015 at 03:20:28PM -0700, Jarno Rajahalme wrote: > > diff --git a/net/openvswitch/flow_netlink.c b/net/openvswitch/flow_netlink.c > > index 77850f1..1e6c2ac 100644 > > --- a/net/openvswitch/flow_netlink.c > > +++

Re: [ovs-dev] [RFC PATCH 5/5] openvswitch: Interface with NAT.

2015-10-21 Thread Thomas Graf
On 10/21/15 at 11:34am, Florian Westphal wrote: > Jarno Rajahalme wrote: > > #define OVS_CS_F_REPLY_DIR 0x08 /* Flow is in the reply direction. > > */ > > #define OVS_CS_F_INVALID 0x10 /* Could not track connection. */ > > #define OVS_CS_F_TRACKED

Re: [ovs-dev] [RFC PATCH 2/5] netfilter: Factor out nf_ct_get_info().

2015-10-21 Thread Thomas Graf
On 10/20/15 at 03:20pm, Jarno Rajahalme wrote: > Define a new inline function to map conntrack status to enum > ip_conntrack_info. This removes the need to otherwise duplicate this > code in a later patch. > > Signed-off-by: Jarno Rajahalme LGTM > --- >

Re: [ovs-dev] [PATCH net-next] openvswitch: report features supported by the kernel datapath

2015-10-09 Thread Thomas Graf
On 10/08/15 at 03:40pm, Jesse Gross wrote: > On Thu, Oct 8, 2015 at 6:53 AM, Jiri Benc wrote: > > Allow the user space to query what features are supported by the openvswitch > > module. This will be used to allow or disallow certain configurations and/or > > switch between

Re: [ovs-dev] [PATCH net-next v3 1/2] openvswitch: add tunnel protocol to sw_flow_key

2015-10-05 Thread Thomas Graf
on with IPv4 ones this won't work anymore). > > The new field was added to a hole in sw_flow_key. > > Signed-off-by: Jiri Benc <jb...@redhat.com> > Acked-by: Pravin B Shelar <pshe...@nicira.com> Acked-by: Thomas Graf <tg...@suug.ch> ___

Re: [ovs-dev] [PATCH v2 net-next 01/13] ip_tunnels: remove custom alignment and packing

2015-08-19 Thread Thomas Graf
...@redhat.com I came to the same conclusion but didn't want to change it in the original series. Acked-by: Thomas Graf tg...@suug.ch ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2 net-next 03/13] ip_tunnels: use offsetofend

2015-08-19 Thread Thomas Graf
On 08/19/15 at 12:09pm, Jiri Benc wrote: Signed-off-by: Jiri Benc jb...@redhat.com Acked-by: Thomas Graf tg...@suug.ch ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2 net-next 05/13] ip_tunnels: use tos and ttl fields also for IPv6

2015-08-19 Thread Thomas Graf
On 08/19/15 at 12:09pm, Jiri Benc wrote: Rename the ipv4_tos and ipv4_ttl fields to just 'tos' and 'ttl', as they'll be used with IPv6 tunnels, too. Signed-off-by: Jiri Benc jb...@redhat.com Acked-by: Thomas Graf tg...@suug.ch ___ dev mailing list

Re: [ovs-dev] [PATCH v2 net-next 04/13] ip_tunnels: add IPv6 addresses to ip_tunnel_key

2015-08-19 Thread Thomas Graf
calculation, thanks to Alexei. Acked-by: Thomas Graf tg...@suug.ch ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2 net-next 06/13] route: move lwtunnel state to dst_entry

2015-08-19 Thread Thomas Graf
it needs the lwtstate data. Moving the lwtstate data to dst_entry makes such inter-protocol tunneling possible. As a bonus, this brings a nice diffstat. Signed-off-by: Jiri Benc jb...@redhat.com Acked-by: Roopa Prabhu ro...@cumulusnetworks.com Acked-by: Thomas Graf tg...@suug.ch

[ovs-dev] [PATCH net-next] openvswitch: Re-add CONFIG_OPENVSWITCH_VXLAN

2015-07-29 Thread Thomas Graf
: fix compilation when vxlan is a module) Cc: Pravin B Shelar pshe...@nicira.com Cc: Nicolas Dichtel nicolas.dich...@6wind.com Signed-off-by: Thomas Graf tg...@suug.ch --- net/openvswitch/Kconfig| 13 ++- net/openvswitch/Makefile | 1 + net/openvswitch/vport-netdev.c | 211

Re: [ovs-dev] [PATCH net-next] openvswitch: fix compilation when vxlan is a module

2015-07-27 Thread Thomas Graf
`vxlan_tnl_create': .../net/openvswitch/vport-netdev.c:322: undefined reference to `vxlan_dev_create' make: *** [vmlinux] Error 1 CC: Thomas Graf tg...@suug.ch Fixes: 614732eaa12d (openvswitch: Use regular VXLAN net_device device) Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com

Re: [ovs-dev] [PATCH net-next] openvswitch: fix compilation when vxlan is a module

2015-07-23 Thread Thomas Graf
to `vxlan_dev_create' make: *** [vmlinux] Error 1 CC: Thomas Graf tg...@suug.ch Fixes: 614732eaa12d (openvswitch: Use regular VXLAN net_device device) Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com Thanks! Acked-by: Thomas Graf tg...@suug.ch ___ dev

[ovs-dev] [PATCH net-next] openvswitch: Retrieve tunnel metadata when receiving from vport-netdev

2015-07-23 Thread Thomas Graf
net_device device) Signed-off-by: Thomas Graf tg...@suug.ch --- net/openvswitch/vport-netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/openvswitch/vport-netdev.c b/net/openvswitch/vport-netdev.c index 68d0582..2254b74 100644 --- a/net/openvswitch/vport-netdev.c +++ b

Re: [ovs-dev] [PATCH net-next 14/22] vxlan: Flow based tunneling

2015-07-21 Thread Thomas Graf
On 07/21/15 at 10:30am, Alexei Starovoitov wrote: RX: +info-mode = IP_TUNNEL_INFO_RX; +info-key.tun_flags = TUNNEL_KEY; +info-key.tun_id = cpu_to_be64(vni 8); ... TX: +dst_port = info-key.tp_dst ? : vxlan-dst_port; +vni =

[ovs-dev] [PATCH net-next 06/22] ipv4: redirect dst output to lwtunnel output

2015-07-21 Thread Thomas Graf
From: Roopa Prabhu ro...@cumulusnetworks.com For input routes with tunnel encap state this patch redirects dst output functions to lwtunnel_output which later resolves to the corresponding lwtunnel output function. This has been tested to work with mpls ip tunnels. Signed-off-by: Roopa Prabhu

[ovs-dev] [PATCH net-next 12/22] dst: Metadata destinations

2015-07-21 Thread Thomas Graf
allowing to interpret metadata in a later commit. Signed-off-by: Thomas Graf tg...@suug.ch --- include/net/dst.h | 6 +++- include/net/dst_metadata.h | 32 ++ net/core/dev.c | 2 +- net/core/dst.c | 84

[ovs-dev] [PATCH net-next 08/22] mpls: export mpls functions for use by mpls iptunnels

2015-07-21 Thread Thomas Graf
From: Roopa Prabhu ro...@cumulusnetworks.com Signed-off-by: Roopa Prabhu ro...@cumulusnetworks.com --- net/mpls/af_mpls.c | 11 --- net/mpls/internal.h | 9 +++-- 2 files changed, 15 insertions(+), 5 deletions(-) diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c index

[ovs-dev] [PATCH net-next 09/22] mpls: ip tunnel support

2015-07-21 Thread Thomas Graf
From: Roopa Prabhu ro...@cumulusnetworks.com This implementation uses lwtunnel infrastructure to register hooks for mpls tunnel encaps. It picks cues from iptunnel_encaps infrastructure and previous mpls iptunnel RFC patches from Eric W. Biederman and Robert Shearman Signed-off-by: Roopa Prabhu

[ovs-dev] [PATCH net-next 22/22] openvswitch: Use regular VXLAN net_device device

2015-07-21 Thread Thomas Graf
(), vxlan_xmit_skb() since they are no longer needed. Signed-off-by: Thomas Graf tg...@suug.ch Signed-off-by: Pravin B Shelar pshe...@nicira.com --- drivers/net/vxlan.c| 242 +++ include/net/rtnetlink.h| 1 + include/net/vxlan.h| 24 +-- net/core

[ovs-dev] [PATCH net-next 18/22] vxlan: Factor out device configuration

2015-07-21 Thread Thomas Graf
This factors out the device configuration out of the RTNL newlink API which allows for in-kernel creation of VXLAN net_devices. Signed-off-by: Thomas Graf tg...@suug.ch --- drivers/net/vxlan.c | 332 include/net/vxlan.h | 59 ++ 2

[ovs-dev] [PATCH net-next 13/22] arp: Inherit metadata dst when creating ARP requests

2015-07-21 Thread Thomas Graf
If output device wants to see the dst, inherit the dst of the original skb and pass it on to generate the ARP request. Signed-off-by: Thomas Graf tg...@suug.ch --- net/ipv4/arp.c | 65 +- 1 file changed, 37 insertions(+), 28 deletions

[ovs-dev] [PATCH net-next 20/22] openvswitch: Move dev pointer into vport itself

2015-07-21 Thread Thomas Graf
This is the first step in representing all OVS vports as regular struct net_devices. Move the net_device pointer into the vport structure itself to get rid of struct vport_netdev. Signed-off-by: Thomas Graf tg...@suug.ch Signed-off-by: Pravin B Shelar pshe...@nicira.com --- net/openvswitch

[ovs-dev] [PATCH net-next 14/22] vxlan: Flow based tunneling

2015-07-21 Thread Thomas Graf
removed. Signed-off-by: Thomas Graf tg...@suug.ch Signed-off-by: Pravin B Shelar pshe...@nicira.com --- drivers/net/vxlan.c | 149 --- include/linux/skbuff.h | 1 + include/net/dst_metadata.h | 13 include/net/ip_tunnels.h | 14

[ovs-dev] [PATCH net-next 19/22] openvswitch: Make tunnel set action attach a metadata dst

2015-07-21 Thread Thomas Graf
Utilize the new metadata dst to attach encapsulation instructions to the skb. The existing egress_tun_info via the OVS_CB() is left in place until all tunnel vports have been converted to the new method. Signed-off-by: Thomas Graf tg...@suug.ch Signed-off-by: Pravin B Shelar pshe...@nicira.com

[ovs-dev] [PATCH net-next 16/22] route: Per route IP tunnel metadata via lightweight tunnel

2015-07-21 Thread Thomas Graf
This introduces a new IP tunnel lightweight tunnel type which allows to specify IP tunnel instructions per route. Only IPv4 is supported at this point. Signed-off-by: Thomas Graf tg...@suug.ch --- drivers/net/vxlan.c| 10 +++- include/net/dst_metadata.h | 12 - include/net

[ovs-dev] [PATCH net-next 11/22] icmp: Don't leak original dst into ip_route_input()

2015-07-21 Thread Thomas Graf
ip_route_input() unconditionally overwrites the dst. Hide the original dst attached to the skb by calling skb_dst_set(skb, NULL) prior to ip_route_input(). Reported-by: Julian Anastasov j...@ssi.bg Signed-off-by: Thomas Graf tg...@suug.ch --- net/ipv4/icmp.c | 1 + 1 file changed, 1 insertion

[ovs-dev] [PATCH net-next 17/22] fib: Add fib rule match on tunnel id

2015-07-21 Thread Thomas Graf
at tunnel level upon demand. Signed-off-by: Thomas Graf tg...@suug.ch --- drivers/net/vxlan.c| 3 ++- include/net/fib_rules.h| 1 + include/net/ip_tunnels.h | 11 +++ include/uapi/linux/fib_rules.h | 2 +- net/core/fib_rules.c | 24

[ovs-dev] [PATCH net-next 15/22] route: Extend flow representation with tunnel key

2015-07-21 Thread Thomas Graf
Add a new flowi_tunnel structure which is a subset of ip_tunnel_key to allow routes to match on tunnel metadata. For now, the tunnel id is added to flowi_tunnel which allows for routes to be bound to specific virtual tunnels. Signed-off-by: Thomas Graf tg...@suug.ch --- include/net/flow.h

[ovs-dev] [PATCH net-next 04/22] ipv6: support for fib route lwtunnel encap attributes

2015-07-21 Thread Thomas Graf
From: Roopa Prabhu ro...@cumulusnetworks.com This patch adds support in ipv6 fib functions to parse Netlink RTA encap attributes and attach encap state data to rt6_info. Signed-off-by: Roopa Prabhu ro...@cumulusnetworks.com --- include/net/ip6_fib.h | 3 +++ net/ipv6/ip6_fib.c| 2 ++

[ovs-dev] [PATCH net-next 00/22 v2] Lightweight flow based encapsulation

2015-07-21 Thread Thomas Graf
for use by mpls iptunnels mpls: ip tunnel support Thomas Graf (13): ip_tunnel: Make ovs_tunnel_info and ovs_key_ipv4_tunnel generic icmp: Don't leak original dst into ip_route_input() dst: Metadata destinations arp: Inherit metadata dst when creating ARP requests vxlan: Flow based

[ovs-dev] [PATCH net-next 02/22] lwtunnel: infrastructure for handling light weight tunnels like mpls

2015-07-21 Thread Thomas Graf
From: Roopa Prabhu ro...@cumulusnetworks.com Provides infrastructure to parse/dump/store encap information for light weight tunnels like mpls. Encap information for such tunnels is associated with fib routes. This infrastructure is based on previous suggestions from Eric Biederman to follow the

[ovs-dev] [PATCH net-next 01/22] rtnetlink: introduce new RTA_ENCAP_TYPE and RTA_ENCAP attributes

2015-07-21 Thread Thomas Graf
From: Roopa Prabhu ro...@cumulusnetworks.com This patch introduces two new RTA attributes to attach encap data to fib routes. Example iproute2 command to attach mpls encap data to ipv4 routes $ip route add 10.1.1.0/30 encap mpls 200 via inet 10.1.1.1 dev swp1 Signed-off-by: Roopa Prabhu

[ovs-dev] [PATCH net-next 05/22] lwtunnel: support dst output redirect function

2015-07-21 Thread Thomas Graf
From: Roopa Prabhu ro...@cumulusnetworks.com This patch introduces lwtunnel_output function to call corresponding lwtunnels output function to xmit the packet. It adds two variants lwtunnel_output and lwtunnel_output6 for ipv4 and ipv6 respectively today. But this is subject to change when

[ovs-dev] [PATCH net-next 03/22] ipv4: support for fib route lwtunnel encap attributes

2015-07-21 Thread Thomas Graf
From: Roopa Prabhu ro...@cumulusnetworks.com This patch adds support in ipv4 fib functions to parse user provided encap attributes and attach encap state data to fib_nh and rtable. Signed-off-by: Roopa Prabhu ro...@cumulusnetworks.com --- include/net/ip_fib.h | 5 ++- include/net/route.h

[ovs-dev] [PATCH net-next 07/22] ipv6: rt6_info output redirect to tunnel output

2015-07-21 Thread Thomas Graf
From: Roopa Prabhu ro...@cumulusnetworks.com This is similar to ipv4 redirect of dst output to lwtunnel output function for encapsulation and xmit. Signed-off-by: Roopa Prabhu ro...@cumulusnetworks.com --- net/ipv6/route.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ipv6/route.c

[ovs-dev] [PATCH net-next 21/22] openvswitch: Abstract vport name through ovs_vport_name()

2015-07-21 Thread Thomas Graf
This allows to get rid of the get_name() vport ops later on. Signed-off-by: Thomas Graf tg...@suug.ch --- net/openvswitch/datapath.c | 4 ++-- net/openvswitch/vport-internal_dev.c | 1 - net/openvswitch/vport-netdev.c | 6 -- net/openvswitch/vport-netdev.h | 1 - net

Re: [ovs-dev] [PATCH net-next 14/22] vxlan: Flow based tunneling

2015-07-20 Thread Thomas Graf
On 07/17/15 at 11:41am, Alexei Starovoitov wrote: On 7/17/15 5:55 AM, Thomas Graf wrote: @@ -2373,6 +2470,12 @@ static void vxlan_setup(struct net_device *dev) netif_keep_dst(dev); dev-priv_flags |= IFF_LIVE_ADDR_CHANGE; +/* If in flow based mode, keep the dst including

Re: [ovs-dev] [PATCH net-next 15/22] route: Extend flow representation with tunnel key

2015-07-20 Thread Thomas Graf
On 07/17/15 at 11:25pm, Julian Anastasov wrote: Hello, On Fri, 17 Jul 2015, Thomas Graf wrote: Add a new flowi_tunnel structure which is a subset of ip_tunnel_key to allow routes to match on tunnel metadata. For now, the tunnel id is added to flowi_tunnel which allows

[ovs-dev] [PATCH net-next 00/22] Lightweight flow based encapsulation

2015-07-17 Thread Thomas Graf
attributes lwtunnel: support dst output redirect function ipv4: redirect dst output to lwtunnel output ipv6: rt6_info output redirect to tunnel output mpls: export mpls functions for use by mpls iptunnels mpls: ip tunnel support Thomas Graf (13): ip_tunnel: Make ovs_tunnel_info

[ovs-dev] [PATCH net-next 05/22] lwtunnel: support dst output redirect function

2015-07-17 Thread Thomas Graf
From: Roopa Prabhu ro...@cumulusnetworks.com This patch introduces lwtunnel_output function to call corresponding lwtunnels output function to xmit the packet. It adds two variants lwtunnel_output and lwtunnel_output6 for ipv4 and ipv6 respectively today. But this is subject to change when

[ovs-dev] [PATCH net-next 01/22] rtnetlink: introduce new RTA_ENCAP_TYPE and RTA_ENCAP attributes

2015-07-17 Thread Thomas Graf
From: Roopa Prabhu ro...@cumulusnetworks.com This patch introduces two new RTA attributes to attach encap data to fib routes. Example iproute2 command to attach mpls encap data to ipv4 routes $ip route add 10.1.1.0/30 encap mpls 200 via inet 10.1.1.1 dev swp1 Signed-off-by: Roopa Prabhu

[ovs-dev] [PATCH net-next 03/22] ipv4: support for fib route lwtunnel encap attributes

2015-07-17 Thread Thomas Graf
From: Roopa Prabhu ro...@cumulusnetworks.com This patch adds support in ipv4 fib functions to parse user provided encap attributes and attach encap state data to fib_nh and rtable. Signed-off-by: Roopa Prabhu ro...@cumulusnetworks.com --- include/net/ip_fib.h | 5 ++- include/net/route.h

[ovs-dev] [PATCH net-next 04/22] ipv6: support for fib route lwtunnel encap attributes

2015-07-17 Thread Thomas Graf
From: Roopa Prabhu ro...@cumulusnetworks.com This patch adds support in ipv6 fib functions to parse Netlink RTA encap attributes and attach encap state data to rt6_info. Signed-off-by: Roopa Prabhu ro...@cumulusnetworks.com --- include/net/ip6_fib.h | 3 +++ net/ipv6/ip6_fib.c| 2 ++

[ovs-dev] [PATCH net-next 07/22] ipv6: rt6_info output redirect to tunnel output

2015-07-17 Thread Thomas Graf
From: Roopa Prabhu ro...@cumulusnetworks.com This is similar to ipv4 redirect of dst output to lwtunnel output function for encapsulation and xmit. Signed-off-by: Roopa Prabhu ro...@cumulusnetworks.com --- net/ipv6/route.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ipv6/route.c

[ovs-dev] [PATCH net-next 06/22] ipv4: redirect dst output to lwtunnel output

2015-07-17 Thread Thomas Graf
From: Roopa Prabhu ro...@cumulusnetworks.com For input routes with tunnel encap state this patch redirects dst output functions to lwtunnel_output which later resolves to the corresponding lwtunnel output function. This has been tested to work with mpls ip tunnels. Open items: Support for

[ovs-dev] [PATCH net-next 09/22] mpls: ip tunnel support

2015-07-17 Thread Thomas Graf
From: Roopa Prabhu ro...@cumulusnetworks.com This implementation uses lwtunnel infrastructure to register hooks for mpls tunnel encaps. It picks cues from iptunnel_encaps infrastructure and previous mpls iptunnel RFC patches from Eric W. Biederman and Robert Shearman Signed-off-by: Roopa Prabhu

[ovs-dev] [PATCH net-next 02/22] lwtunnel: infrastructure for handling light weight tunnels like mpls

2015-07-17 Thread Thomas Graf
From: Roopa Prabhu ro...@cumulusnetworks.com Provides infrastructure to parse/dump/store encap information for light weight tunnels like mpls. Encap information for such tunnels is associated with fib routes. This infrastructure is based on previous suggestions from Eric Biederman to follow the

[ovs-dev] [PATCH net-next 15/22] route: Extend flow representation with tunnel key

2015-07-17 Thread Thomas Graf
Add a new flowi_tunnel structure which is a subset of ip_tunnel_key to allow routes to match on tunnel metadata. For now, the tunnel id is added to flowi_tunnel which allows for routes to be bound to specific virtual tunnels. Signed-off-by: Thomas Graf tg...@suug.ch --- include/net/flow.h | 7

[ovs-dev] [PATCH net-next 11/22] icmp: Don't leak original dst into ip_route_input()

2015-07-17 Thread Thomas Graf
ip_route_input() unconditionally overwrites the dst. Hide the original dst attached to the skb by calling skb_dst_set(skb, NULL) prior to ip_route_input(). Reported-by: Julian Anastasov j...@ssi.bg Signed-off-by: Thomas Graf tg...@suug.ch --- net/ipv4/icmp.c | 1 + 1 file changed, 1 insertion

[ovs-dev] [PATCH net-next 12/22] dst: Metadata destinations

2015-07-17 Thread Thomas Graf
allowing to interpret metadata in a later commit. Signed-off-by: Thomas Graf tg...@suug.ch --- include/net/dst.h | 6 +++- include/net/dst_metadata.h | 32 ++ net/core/dev.c | 2 +- net/core/dst.c | 84

[ovs-dev] [PATCH net-next 20/22] openvswitch: Move dev pointer into vport itself

2015-07-17 Thread Thomas Graf
This is the first step in representing all OVS vports as regular struct net_devices. Move the net_device pointer into the vport structure itself to get rid of struct vport_netdev. Signed-off-by: Thomas Graf tg...@suug.ch Signed-off-by: Pravin B Shelar pshe...@nicira.com --- net/openvswitch

[ovs-dev] [PATCH net-next 22/22] openvswitch: Use regular VXLAN net_device device

2015-07-17 Thread Thomas Graf
(), vxlan_xmit_skb() since they are no longer needed. Signed-off-by: Thomas Graf tg...@suug.ch Signed-off-by: Pravin B Shelar pshe...@nicira.com --- drivers/net/vxlan.c| 242 +++ include/net/rtnetlink.h| 1 + include/net/vxlan.h| 24 +-- net/core

[ovs-dev] [PATCH net-next 17/22] fib: Add fib rule match on tunnel id

2015-07-17 Thread Thomas Graf
at tunnel level upon demand. Signed-off-by: Thomas Graf tg...@suug.ch --- drivers/net/vxlan.c| 3 ++- include/net/fib_rules.h| 1 + include/net/ip_tunnels.h | 11 +++ include/uapi/linux/fib_rules.h | 2 +- net/core/fib_rules.c | 24

[ovs-dev] [PATCH net-next 16/22] route: Per route IP tunnel metadata via lightweight tunnel

2015-07-17 Thread Thomas Graf
This introduces a new IP tunnel lightweight tunnel type which allows to specify IP tunnel instructions per route. Only IPv4 is supported at this point. Signed-off-by: Thomas Graf tg...@suug.ch --- drivers/net/vxlan.c| 10 +++- include/net/dst_metadata.h | 12 - include/net

[ovs-dev] [PATCH net-next 19/22] openvswitch: Make tunnel set action attach a metadata dst

2015-07-17 Thread Thomas Graf
Utilize the new metadata dst to attach encapsulation instructions to the skb. The existing egress_tun_info via the OVS_CB() is left in place until all tunnel vports have been converted to the new method. Signed-off-by: Thomas Graf tg...@suug.ch Signed-off-by: Pravin B Shelar pshe...@nicira.com

[ovs-dev] [PATCH net-next 21/22] openvswitch: Abstract vport name through ovs_vport_name()

2015-07-17 Thread Thomas Graf
This allows to get rid of the get_name() vport ops later on. Signed-off-by: Thomas Graf tg...@suug.ch --- net/openvswitch/datapath.c | 4 ++-- net/openvswitch/vport-internal_dev.c | 1 - net/openvswitch/vport-netdev.c | 6 -- net/openvswitch/vport-netdev.h | 1 - net

[ovs-dev] [PATCH net-next 13/22] arp: Inherit metadata dst when creating ARP requests

2015-07-17 Thread Thomas Graf
If output device wants to see the dst, inherit the dst of the original skb and pass it on to generate the ARP request. Signed-off-by: Thomas Graf tg...@suug.ch --- net/ipv4/arp.c | 65 +- 1 file changed, 37 insertions(+), 28 deletions

[ovs-dev] [PATCH net-next 18/22] vxlan: Factor out device configuration

2015-07-17 Thread Thomas Graf
This factors out the device configuration out of the RTNL newlink API which allows for in-kernel creation of VXLAN net_devices. Signed-off-by: Thomas Graf tg...@suug.ch --- drivers/net/vxlan.c | 332 include/net/vxlan.h | 59 ++ 2

[ovs-dev] [PATCH net-next 14/22] vxlan: Flow based tunneling

2015-07-17 Thread Thomas Graf
removed. Signed-off-by: Thomas Graf tg...@suug.ch Signed-off-by: Pravin B Shelar pshe...@nicira.com --- drivers/net/vxlan.c | 155 +-- include/linux/skbuff.h | 1 + include/net/dst_metadata.h | 13 include/net/ip_tunnels.h | 14

Re: [ovs-dev] [RFC net-next 22/22] openvswitch: Use regular GRE net_device instead of vport

2015-07-17 Thread Thomas Graf
On 07/16/15 at 02:36pm, Pravin Shelar wrote: On Thu, Jul 16, 2015 at 7:52 AM, Thomas Graf tg...@suug.ch wrote: I'm inclined to change this and use an in-kernel API as well to create the net_device just like VXLAN does in patch 21. Pravin, what do you think? About the vxlan APIs we also

Re: [ovs-dev] [RFC net-next 22/22] openvswitch: Use regular GRE net_device instead of vport

2015-07-16 Thread Thomas Graf
On 07/16/15 at 05:59pm, Simon Horman wrote: On Fri, Jul 10, 2015 at 04:19:24PM +0200, Thomas Graf wrote: static void ipgre_tap_setup(struct net_device *dev) { ether_setup(dev); - dev-netdev_ops = gre_tap_netdev_ops; dev-priv_flags |= IFF_LIVE_ADDR_CHANGE

Re: [ovs-dev] [RFC net-next 18/22] openvswitch: Make tunnel set action attach a metadata dst

2015-07-14 Thread Thomas Graf
On 07/13/15 at 03:55pm, Joe Stringer wrote: It doesn't look like flow_free() is using this new function to properly free the actions. Also, some of the error cases that hit this code have sf_acts=NULL. Good catch. Will fix in next iteration. ___ dev

[ovs-dev] [RFC net-next 09/22] mpls: ip tunnel support

2015-07-10 Thread Thomas Graf
From: Roopa Prabhu ro...@cumulusnetworks.com This implementation uses lwtunnel infrastructure to register hooks for mpls tunnel encaps. It picks cues from iptunnel_encaps infrastructure and previous mpls iptunnel RFC patches from Eric W. Biederman and Robert Shearman Signed-off-by: Roopa Prabhu

[ovs-dev] [RFC net-next 21/22] openvswitch: Use regular VXLAN net_device device

2015-07-10 Thread Thomas Graf
(), vxlan_xmit_skb() since they are no longer needed. Signed-off-by: Thomas Graf tg...@suug.ch Signed-off-by: Pravin B Shelar pshe...@nicira.com --- drivers/net/vxlan.c| 242 +++ include/net/vxlan.h| 24 +-- net/openvswitch/Kconfig| 12 -- net

[ovs-dev] [RFC net-next 01/22] rtnetlink: introduce new RTA_ENCAP_TYPE and RTA_ENCAP attributes

2015-07-10 Thread Thomas Graf
From: Roopa Prabhu ro...@cumulusnetworks.com This patch introduces two new RTA attributes to attach encap data to fib routes. Example iproute2 command to attach mpls encap data to ipv4 routes $ip route add 10.1.1.0/30 encap mpls 200 via inet 10.1.1.1 dev swp1 Signed-off-by: Roopa Prabhu

[ovs-dev] [RFC net-next 02/22] lwtunnel: infrastructure for handling light weight tunnels like mpls

2015-07-10 Thread Thomas Graf
From: Roopa Prabhu ro...@cumulusnetworks.com Provides infrastructure to parse/dump/store encap information for light weight tunnels like mpls. Encap information for such tunnels is associated with fib routes. This infrastructure is based on previous suggestions from Eric Biederman to follow the

[ovs-dev] [RFC net-next 05/22] lwtunnel: support dst output redirect function

2015-07-10 Thread Thomas Graf
From: Roopa Prabhu ro...@cumulusnetworks.com This patch introduces lwtunnel_output function to call corresponding lwtunnels output function to xmit the packet. It adds two variants lwtunnel_output and lwtunnel_output6 for ipv4 and ipv6 respectively today. But this is subject to change when

[ovs-dev] [RFC net-next 06/22] ipv4: redirect dst output to lwtunnel output

2015-07-10 Thread Thomas Graf
From: Roopa Prabhu ro...@cumulusnetworks.com For input routes with tunnel encap state this patch redirects dst output functions to lwtunnel_output which later resolves to the corresponding lwtunnel output function. This has been tested to work with mpls ip tunnels. Open items: Support for

[ovs-dev] [RFC net-next 13/22] vxlan: Flow based tunneling

2015-07-10 Thread Thomas Graf
. This member is removed again in a later commit after the indirect VXLAN receive API has been removed. Signed-off-by: Thomas Graf tg...@suug.ch Signed-off-by: Pravin B Shelar pshe...@nicira.com --- drivers/net/vxlan.c | 149 --- include/linux/skbuff.h

[ovs-dev] [RFC net-next 14/22] route: Extend flow representation with tunnel key

2015-07-10 Thread Thomas Graf
Add a new flowi_tunnel structure which is a subset of ip_tunnel_key to allow routes to match on tunnel metadata. For now, the tunnel id is added to flowi_tunnel which allows for routes to be bound to specific virtual tunnels. Signed-off-by: Thomas Graf tg...@suug.ch --- include/net/flow.h | 7

[ovs-dev] [RFC net-next 12/22] arp: Inherit metadata dst when creating ARP requests

2015-07-10 Thread Thomas Graf
If output device wants to see the dst, inherit the dst of the original skb and pass it on to generate the ARP request. Signed-off-by: Thomas Graf tg...@suug.ch --- net/ipv4/arp.c | 71 +++--- 1 file changed, 43 insertions(+), 28 deletions

[ovs-dev] [RFC net-next 07/22] ipv6: rt6_info output redirect to tunnel output

2015-07-10 Thread Thomas Graf
From: Roopa Prabhu ro...@cumulusnetworks.com This is similar to ipv4 redirect of dst output to lwtunnel output function for encapsulation and xmit. Signed-off-by: Roopa Prabhu ro...@cumulusnetworks.com --- net/ipv6/route.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ipv6/route.c

[ovs-dev] [RFC net-next 17/22] vxlan: Factor out device configuration

2015-07-10 Thread Thomas Graf
This factors out the device configuration out of the RTNL newlink API which allows for in-kernel creation of VXLAN net_devices. Signed-off-by: Thomas Graf tg...@suug.ch --- drivers/net/vxlan.c | 332 include/net/vxlan.h | 59 ++ 2

[ovs-dev] [RFC net-next 22/22] openvswitch: Use regular GRE net_device instead of vport

2015-07-10 Thread Thomas Graf
From: Pravin Shelar pshe...@nicira.com Removes all of the OVS specific GRE code and makes OVS use a GRE net_device. Signed-off-by: Pravin B Shelar pshe...@nicira.com --- net/core/dev.c | 5 +- net/ipv4/ip_gre.c | 165 +-

[ovs-dev] [RFC net-next 20/22] openvswitch: Abstract vport name through ovs_vport_name()

2015-07-10 Thread Thomas Graf
This allows to get rid of the get_name() vport ops later on. Signed-off-by: Thomas Graf tg...@suug.ch --- net/openvswitch/datapath.c | 4 ++-- net/openvswitch/vport-internal_dev.c | 1 - net/openvswitch/vport-netdev.c | 6 -- net/openvswitch/vport-netdev.h | 1 - net

[ovs-dev] [RFC net-next 18/22] openvswitch: Make tunnel set action attach a metadata dst

2015-07-10 Thread Thomas Graf
Utilize the new metadata dst to attach encapsulation instructions to the skb. The existing egress_tun_info via the OVS_CB() is left in place until all tunnel vports have been converted to the new method. Signed-off-by: Thomas Graf tg...@suug.ch Signed-off-by: Pravin B Shelar pshe...@nicira.com

[ovs-dev] [RFC net-next 15/22] route: Per route IP tunnel metadata via lightweight tunnel

2015-07-10 Thread Thomas Graf
This introduces a new IP tunnel lightweight tunnel type which allows to specify IP tunnel instructions per route. Only IPv4 is supported at this point. Signed-off-by: Thomas Graf tg...@suug.ch --- drivers/net/vxlan.c| 10 +++- include/net/dst_metadata.h | 12 - include/net

[ovs-dev] [RFC net-next 08/22] mpls: export mpls functions for use by mpls iptunnels

2015-07-10 Thread Thomas Graf
From: Roopa Prabhu ro...@cumulusnetworks.com Signed-off-by: Roopa Prabhu ro...@cumulusnetworks.com --- net/mpls/af_mpls.c | 11 --- net/mpls/internal.h | 3 +++ 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c index

[ovs-dev] [RFC net-next 11/22] dst: Metadata destinations

2015-07-10 Thread Thomas Graf
allowing to interpret metadata in a later commit. Signed-off-by: Thomas Graf tg...@suug.ch --- include/net/dst.h | 5 ++- include/net/dst_metadata.h | 32 +++ net/core/dev.c | 2 +- net/core/dst.c | 76

[ovs-dev] [RFC net-next 19/22] openvswitch: Move dev pointer into vport itself

2015-07-10 Thread Thomas Graf
This is the first step in representing all OVS vports as regular struct net_devices. Move the net_device pointer into the vport structure itself to get rid of struct vport_netdev. Signed-off-by: Thomas Graf tg...@suug.ch Signed-off-by: Pravin B Shelar pshe...@nicira.com --- net/openvswitch

[ovs-dev] [RFC net-next 16/22] fib: Add fib rule match on tunnel id

2015-07-10 Thread Thomas Graf
This add the ability to select a routing table based on the tunnel id which allows to maintain separate routing tables for each virtual tunnel network. ip rule add from all tunnel-id 100 lookup 100 ip rule add from all tunnel-id 200 lookup 200 Signed-off-by: Thomas Graf tg...@suug.ch

[ovs-dev] [RFC net-next 00/22] Lightweight flow based tunneling

2015-07-10 Thread Thomas Graf
ipv6: rt6_info output redirect to tunnel output mpls: export mpls functions for use by mpls iptunnels mpls: ip tunnel support Thomas Graf (12): ip_tunnel: Make ovs_tunnel_info and ovs_key_ipv4_tunnel generic dst: Metadata destinations arp: Inherit metadata dst when creating ARP requests

[ovs-dev] [RFC net-next 04/22] ipv6: support for fib route lwtunnel encap attributes

2015-07-10 Thread Thomas Graf
From: Roopa Prabhu ro...@cumulusnetworks.com This patch adds support in ipv6 fib functions to parse Netlink RTA encap attributes and attach encap state data to rt6_info. Signed-off-by: Roopa Prabhu ro...@cumulusnetworks.com --- include/net/ip6_fib.h | 3 +++ net/ipv6/ip6_fib.c| 2 ++

[ovs-dev] [RFC net-next 03/22] ipv4: support for fib route lwtunnel encap attributes

2015-07-10 Thread Thomas Graf
From: Roopa Prabhu ro...@cumulusnetworks.com This patch adds support in ipv4 fib functions to parse user provided encap attributes and attach encap state data to fib_nh and rtable. Signed-off-by: Roopa Prabhu ro...@cumulusnetworks.com --- include/net/ip_fib.h | 5 ++- include/net/route.h

Re: [ovs-dev] [RFC net-next 03/22] ipv4: support for fib route lwtunnel encap attributes

2015-07-10 Thread Thomas Graf
On 07/10/15 at 05:36pm, Eric Dumazet wrote: On Fri, 2015-07-10 at 16:19 +0200, Thomas Graf wrote: From: Roopa Prabhu ro...@cumulusnetworks.com + if (oif) + dev = __dev_get_by_index(net, oif); + ret = lwtunnel_build_state(dev, encap_type

Re: [ovs-dev] [RFC net-next 11/22] dst: Metadata destinations

2015-07-10 Thread Thomas Graf
On 07/10/15 at 09:57pm, Julian Anastasov wrote: Hello, On Fri, 10 Jul 2015, Thomas Graf wrote: --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -1691,6 +1691,8 @@ static int ip_route_input_slow(struct sk_buff *skb, __be32 daddr, __be32 saddr, by fib_lookup

Re: [ovs-dev] [net-next RFC 08/14] openvswitch: Allocate attach ip_tunnel_info for tunnel set action

2015-06-03 Thread Thomas Graf
On 06/03/15 at 05:29pm, Jiri Benc wrote: On Mon, 1 Jun 2015 16:27:32 +0200, Thomas Graf wrote: --- a/net/openvswitch/flow.h +++ b/net/openvswitch/flow.h @@ -45,6 +45,11 @@ struct sk_buff; #define TUN_METADATA_OPTS(flow_key, opt_len) \ ((void *)((flow_key)-tun_opts

[ovs-dev] [net-next RFC 11/14] openvswitch: Use regular VXLAN net_device device

2015-06-01 Thread Thomas Graf
(), vxlan_xmit_skb() since they are no longer needed. Signed-off-by: Thomas Graf tg...@suug.ch Signed-off-by: Pravin B Shelar pshe...@nicira.com --- drivers/net/vxlan.c| 23 +-- include/net/vxlan.h| 14 +- net/openvswitch/Kconfig| 12 -- net/openvswitch/Makefile | 1

[ovs-dev] [net-next RFC 10/14] openvswitch: Abstract vport name through ovs_vport_name()

2015-06-01 Thread Thomas Graf
This allows to get rid of the get_name() vport ops later on. Signed-off-by: Thomas Graf tg...@suug.ch --- net/openvswitch/datapath.c | 4 ++-- net/openvswitch/vport-internal_dev.c | 1 - net/openvswitch/vport-netdev.c | 6 -- net/openvswitch/vport-netdev.h | 1 - net

  1   2   3   4   5   6   7   8   9   10   >