+1 (non-binding)
I checked the following things:
- signatures are good.
```
gpg --verify orc-1.8.7.tar.gz.asc
```
- checksums are good.
```
sha256sum --check orc-1.8.7.tar.gz.sha256
```
- build and test success from source code.
```
make test-out
Test project /tmp/orc-1.8.7/orc-1.8.7/build
+1
I've seen this issue:
https://github.com/apache/orc/commit/9627a24439099046078c9f300028b79ab27fe33e
and have to manually port this patch to make the build pass. Not sure if
this is a blocker or just a special case
of toolchain setup. So I'll give a +1 for now.
Test project /Users/gangwu/RC/
+1
Here is the release manager verification link.
- https://github.com/apache/orc/issues/1887
In short,
- Checked checksum and GPG signature
- All tests (unit and docker) passed.
- Spark Integration tests passed with Apache Spark 3.4 branch
- Iceberg Integration tests passed with Apache Iceberg
Please vote on releasing the following candidate as Apache ORC version
1.8.7. This vote is open until April 14th 1AM (PST) and passes if a
majority +1 PMC votes are cast, with a minimum of 3 +1 votes.
[ ] +1 Release this package as Apache ORC 1.8.7
[ ] -1 Do not release this package because ...
Oh, thank you, William.
Let me volunteer and start it now.
I'm the release manager of Apache Spark 3.4.3 (for next Monday).
I guess I can include Apache ORC 1.8.7 there too.
Thanks,
Dongjoon.
On 2024/04/10 01:48:35 "William H." wrote:
> Hey All,
>
> I hope everyone had a great weekend and
Gang Wu created ORC-1686:
Summary: Avoid using std::filesystem
Key: ORC-1686
URL: https://issues.apache.org/jira/browse/ORC-1686
Project: ORC
Issue Type: Sub-task
Reporter: Gang Wu