[GitHub] xiaohui-sun commented on issue #3582: [TE] frontend - harleyjj/manage - align startDate at startOf() instea…

2018-12-03 Thread GitBox
xiaohui-sun commented on issue #3582: [TE] frontend - harleyjj/manage - align startDate at startOf() instea… URL: https://github.com/apache/incubator-pinot/pull/3582#issuecomment-443979976 Have you merged my change and tested?

[GitHub] xiaohui-sun closed pull request #3581: [TE] rootcause - Round end time after adjusting with the maxDateTime

2018-12-03 Thread GitBox
xiaohui-sun closed pull request #3581: [TE] rootcause - Round end time after adjusting with the maxDateTime URL: https://github.com/apache/incubator-pinot/pull/3581 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] snleee commented on issue #3583: Add segment selector for merged segments

2018-12-03 Thread GitBox
snleee commented on issue #3583: Add segment selector for merged segments URL: https://github.com/apache/incubator-pinot/pull/3583#issuecomment-443973650 #2715 This is an automated message from the Apache Git Service. To

[GitHub] snleee commented on issue #3543: Segment merge lineage data structure

2018-12-03 Thread GitBox
snleee commented on issue #3543: Segment merge lineage data structure URL: https://github.com/apache/incubator-pinot/pull/3543#issuecomment-443973735 #2715 This is an automated message from the Apache Git Service. To respond

[GitHub] snleee commented on a change in pull request #3543: Segment merge lineage data structure

2018-12-03 Thread GitBox
snleee commented on a change in pull request #3543: Segment merge lineage data structure URL: https://github.com/apache/incubator-pinot/pull/3543#discussion_r238497015 ## File path: pinot-common/src/main/java/com/linkedin/pinot/common/lineage/SegmentMergeLineageAccessHelper.java

[GitHub] mcvsubbu commented on a change in pull request #3543: Segment merge lineage data structure

2018-12-03 Thread GitBox
mcvsubbu commented on a change in pull request #3543: Segment merge lineage data structure URL: https://github.com/apache/incubator-pinot/pull/3543#discussion_r238489396 ## File path: pinot-common/src/main/java/com/linkedin/pinot/common/lineage/SegmentMergeLineage.java ##

[GitHub] mcvsubbu commented on a change in pull request #3578: Changing segmentCommitEnd to support deep storage

2018-12-03 Thread GitBox
mcvsubbu commented on a change in pull request #3578: Changing segmentCommitEnd to support deep storage URL: https://github.com/apache/incubator-pinot/pull/3578#discussion_r238456926 ## File path:

[GitHub] jenniferdai opened a new pull request #3578: Changing segmentCommitEnd to support deep storage

2018-12-03 Thread GitBox
jenniferdai opened a new pull request #3578: Changing segmentCommitEnd to support deep storage URL: https://github.com/apache/incubator-pinot/pull/3578 * Changing the way we move file to final location to use pinotFS so that we can support different storage backends * Testing covered

[GitHub] kishoreg commented on a change in pull request #3506: Add configuration merging tool

2018-12-03 Thread GitBox
kishoreg commented on a change in pull request #3506: Add configuration merging tool URL: https://github.com/apache/incubator-pinot/pull/3506#discussion_r238356413 ## File path: pinot-tools/src/main/java/com/linkedin/pinot/tools/admin/command/MergeConfigsCommand.java ##

[GitHub] kishoreg commented on a change in pull request #3506: Add configuration merging tool

2018-12-03 Thread GitBox
kishoreg commented on a change in pull request #3506: Add configuration merging tool URL: https://github.com/apache/incubator-pinot/pull/3506#discussion_r238354479 ## File path: pinot-tools/src/main/java/com/linkedin/pinot/tools/admin/command/MergeConfigsCommand.java ##

[GitHub] akshayrai opened a new pull request #3576: [TE] Minor fix in legacy alert filter

2018-12-03 Thread GitBox
akshayrai opened a new pull request #3576: [TE] Minor fix in legacy alert filter URL: https://github.com/apache/incubator-pinot/pull/3576 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] apucher closed pull request #3575: [TE] frontend - harleyjj/rootcause - use humanizeFloat to change form…

2018-12-03 Thread GitBox
apucher closed pull request #3575: [TE] frontend - harleyjj/rootcause - use humanizeFloat to change form… URL: https://github.com/apache/incubator-pinot/pull/3575 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] akshayrai commented on issue #3575: [TE] frontend - harleyjj/rootcause - use humanizeFloat to change form…

2018-12-03 Thread GitBox
akshayrai commented on issue #3575: [TE] frontend - harleyjj/rootcause - use humanizeFloat to change form… URL: https://github.com/apache/incubator-pinot/pull/3575#issuecomment-443811566 Can we also do this for the graph in the anomaly page? Only if it is simple change like this.

Re: Incubator Podling Report (Due 5th December)

2018-12-03 Thread Felix Cheung
Process info here https://incubator.apache.org/guides/ppmc.html#podling_status_reports It’s a wiki page https://wiki.apache.org/incubator/December2018 From: Subbu Subramaniam Sent: Monday, December 3, 2018 9:39 AM To: kishore g; dev@pinot.apache.org;

[GitHub] kishoreg commented on issue #3506: Add configuration merging tool

2018-12-03 Thread GitBox
kishoreg commented on issue #3506: Add configuration merging tool URL: https://github.com/apache/incubator-pinot/pull/3506#issuecomment-443805534 Thanks. Can you add some test cases? This is an automated message from the

Re: Incubator Podling Report (Due 5th December)

2018-12-03 Thread Subbu Subramaniam
What is involved here? Having never done one before, I have no idea. Is there a template for the report? thanks -Subbu From: kishore g Sent: Sunday, December 2, 2018 2:57 PM To: dev@pinot.apache.org Subject: Re: Incubator Podling Report (Due 5th December)

[GitHub] jfim commented on issue #3568: Add guava cache to cache table schema in pinot broker

2018-12-03 Thread GitBox
jfim commented on issue #3568: Add guava cache to cache table schema in pinot broker URL: https://github.com/apache/incubator-pinot/pull/3568#issuecomment-443707818 Can you explain why does the broker needs to cache the schema in the first place?

[GitHub] jfim commented on issue #3506: Add configuration merging tool

2018-12-03 Thread GitBox
jfim commented on issue #3506: Add configuration merging tool URL: https://github.com/apache/incubator-pinot/pull/3506#issuecomment-443708105 Any progress on this? This is an automated message from the Apache Git Service. To