[GitHub] kishoreg edited a comment on issue #3725: Replace partition ranges with partitions

2019-01-18 Thread GitBox
kishoreg edited a comment on issue #3725: Replace partition ranges with partitions URL: https://github.com/apache/incubator-pinot/pull/3725#issuecomment-455752096 Good example. With your change, how can we store partition 1,3,5? Sorry, my bad. From your example, it looked like we

Re: Requesting a review for updating license & notice information

2019-01-18 Thread Felix Cheung
Thanks for doing that and sending this note. I will help check today. From: Seunghyun Lee Sent: Friday, January 18, 2019 3:42 PM To: dev@pinot.apache.org Subject: Requesting a review for updating license & notice information Hi Mentors, I have recently

[GitHub] kishoreg commented on issue #3725: Replace partition ranges with partitions

2019-01-18 Thread GitBox
kishoreg commented on issue #3725: Replace partition ranges with partitions URL: https://github.com/apache/incubator-pinot/pull/3725#issuecomment-455752096 Good example. With your change, how can we store partition 1,3,5?

[GitHub] Jackie-Jiang commented on issue #3725: Replace partition ranges with partitions

2019-01-18 Thread GitBox
Jackie-Jiang commented on issue #3725: Replace partition ranges with partitions URL: https://github.com/apache/incubator-pinot/pull/3725#issuecomment-455750311 > What’s the benefit of changing this? What happens if minion merges two segments with different ranges? We treat range as

[GitHub] ly923976094 opened a new issue #3726: Multithreading concurrent request query, time increase problem

2019-01-18 Thread GitBox
ly923976094 opened a new issue #3726: Multithreading concurrent request query, time increase problem URL: https://github.com/apache/incubator-pinot/issues/3726 For the same PQL, the time difference between using one thread to query and 10 threads to query concurrently is quite large. May

[GitHub] ly923976094 commented on issue #3717: kafka consume problem

2019-01-18 Thread GitBox
ly923976094 commented on issue #3717: kafka consume problem URL: https://github.com/apache/incubator-pinot/issues/3717#issuecomment-455742219 > Not sure what the reason is that you want to stop consumption. If this is a new table and you set it up wrong, you can drop the table and

[GitHub] kishoreg commented on issue #3725: Replace partition ranges with partitions

2019-01-18 Thread GitBox
kishoreg commented on issue #3725: Replace partition ranges with partitions URL: https://github.com/apache/incubator-pinot/pull/3725#issuecomment-455738520 What’s the benefit of changing this? What happens if minion merges two segments with different ranges?

[GitHub] Jackie-Jiang commented on issue #3722: Update LICENSE and NOTICE files

2019-01-18 Thread GitBox
Jackie-Jiang commented on issue #3722: Update LICENSE and NOTICE files URL: https://github.com/apache/incubator-pinot/pull/3722#issuecomment-455735093 Awesome! You make my OCD so satisfied! This is an automated message from

[GitHub] kishoreg opened a new pull request #3723: Remove auto-gen class files that were checked-in

2019-01-18 Thread GitBox
kishoreg opened a new pull request #3723: Remove auto-gen class files that were checked-in URL: https://github.com/apache/incubator-pinot/pull/3723 Removed the auto-generated classes from request.thrift and response.thrift. The generated files show up under target/generated-sources/thrift

[GitHub] codecov-io commented on issue #3722: Update LICENSE and NOTICE files

2019-01-18 Thread GitBox
codecov-io commented on issue #3722: Update LICENSE and NOTICE files URL: https://github.com/apache/incubator-pinot/pull/3722#issuecomment-455726148 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3722?src=pr=h1) Report > Merging

[GitHub] snleee edited a comment on issue #3722: Update LICENSE and NOTICE files

2019-01-18 Thread GitBox
snleee edited a comment on issue #3722: Update LICENSE and NOTICE files URL: https://github.com/apache/incubator-pinot/pull/3722#issuecomment-455721410 @felixcheung @olamy Can you check this when you find the time? This is

[GitHub] snleee edited a comment on issue #3722: Update LICENSE and NOTICE files

2019-01-18 Thread GitBox
snleee edited a comment on issue #3722: Update LICENSE and NOTICE files URL: https://github.com/apache/incubator-pinot/pull/3722#issuecomment-455720913 After removing category X dependency and removing "pinot-perf" from distribution package, we are bundling `109` external jar files and `9`

[GitHub] snleee commented on issue #3722: Update LICENSE and NOTICE files

2019-01-18 Thread GitBox
snleee commented on issue #3722: Update LICENSE and NOTICE files URL: https://github.com/apache/incubator-pinot/pull/3722#issuecomment-455720913 After removing category X dependency and removing "pinot-perf" from distribution package, we are bundling `109` external jar files and `9` js/css

[GitHub] codecov-io edited a comment on issue #3711: Fix SegmentConverter to handle virtual column

2019-01-18 Thread GitBox
codecov-io edited a comment on issue #3711: Fix SegmentConverter to handle virtual column URL: https://github.com/apache/incubator-pinot/pull/3711#issuecomment-455365326 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3711?src=pr=h1) Report > Merging

[GitHub] snleee opened a new pull request #3722: Update LICENSE and NOTICE files

2019-01-18 Thread GitBox
snleee opened a new pull request #3722: Update LICENSE and NOTICE files URL: https://github.com/apache/incubator-pinot/pull/3722 Followed Apache Spark's approach for handling LICENSE, NOTICE. https://github.com/apache/spark/commit/f825847c82042a9eee7bd5cfab106310d279fc32 -

[GitHub] npawar opened a new pull request #3721: Add metric to capture max queries per 10s seen in the last minute

2019-01-18 Thread GitBox
npawar opened a new pull request #3721: Add metric to capture max queries per 10s seen in the last minute URL: https://github.com/apache/incubator-pinot/pull/3721 We don't have a very good way of knowing what was the QPS for a table at a given time. Currently, whenever we receive a query,

[GitHub] codecov-io edited a comment on issue #3711: Fix SegmentConverter to handle virtual column

2019-01-18 Thread GitBox
codecov-io edited a comment on issue #3711: Fix SegmentConverter to handle virtual column URL: https://github.com/apache/incubator-pinot/pull/3711#issuecomment-455365326 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3711?src=pr=h1) Report > Merging

[GitHub] Jackie-Jiang commented on a change in pull request #3711: Fix SegmentConverter to handle virtual column

2019-01-18 Thread GitBox
Jackie-Jiang commented on a change in pull request #3711: Fix SegmentConverter to handle virtual column URL: https://github.com/apache/incubator-pinot/pull/3711#discussion_r249208864 ## File path:

[GitHub] jihaozh merged pull request #3714: [TE] yaml - subscribed detection names in notification yaml

2019-01-18 Thread GitBox
jihaozh merged pull request #3714: [TE] yaml - subscribed detection names in notification yaml URL: https://github.com/apache/incubator-pinot/pull/3714 This is an automated message from the Apache Git Service. To respond to

[GitHub] jihaozh opened a new pull request #3720: [TE] alerter - do not send replay anomalies

2019-01-18 Thread GitBox
jihaozh opened a new pull request #3720: [TE] alerter - do not send replay anomalies URL: https://github.com/apache/incubator-pinot/pull/3720 Don't send an alert if the anomaly is from replay or user report. This is an

[GitHub] xiaohui-sun commented on a change in pull request #3709: [TE] - Fix true anomaly definition to include expected anomaly

2019-01-18 Thread GitBox
xiaohui-sun commented on a change in pull request #3709: [TE] - Fix true anomaly definition to include expected anomaly URL: https://github.com/apache/incubator-pinot/pull/3709#discussion_r249158040 ## File path:

[GitHub] aaronucsd merged pull request #3719: [TE] aaronucsd/remove true in alert list

2019-01-18 Thread GitBox
aaronucsd merged pull request #3719: [TE] aaronucsd/remove true in alert list URL: https://github.com/apache/incubator-pinot/pull/3719 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] aaronucsd opened a new pull request #3719: [TE] aaronucsd/remove true in alert list

2019-01-18 Thread GitBox
aaronucsd opened a new pull request #3719: [TE] aaronucsd/remove true in alert list URL: https://github.com/apache/incubator-pinot/pull/3719 This is an automated message from the Apache Git Service. To respond to the

[GitHub] akshayrai commented on a change in pull request #3714: [TE] yaml - subscribed detection names in notification yaml

2019-01-18 Thread GitBox
akshayrai commented on a change in pull request #3714: [TE] yaml - subscribed detection names in notification yaml URL: https://github.com/apache/incubator-pinot/pull/3714#discussion_r249148882 ## File path:

[GitHub] xiaohui-sun commented on a change in pull request #3709: [TE] - Fix true anomaly definition to include expected anomaly

2019-01-18 Thread GitBox
xiaohui-sun commented on a change in pull request #3709: [TE] - Fix true anomaly definition to include expected anomaly URL: https://github.com/apache/incubator-pinot/pull/3709#discussion_r249145991 ## File path:

[GitHub] codecov-io edited a comment on issue #3671: Make different PinotFS concrete classes have the same behaviors

2019-01-18 Thread GitBox
codecov-io edited a comment on issue #3671: Make different PinotFS concrete classes have the same behaviors URL: https://github.com/apache/incubator-pinot/pull/3671#issuecomment-452940403 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3671?src=pr=h1) Report > Merging

[GitHub] ly923976094 commented on issue #3717: kafka consume problem

2019-01-18 Thread GitBox
ly923976094 commented on issue #3717: kafka consume problem URL: https://github.com/apache/incubator-pinot/issues/3717#issuecomment-455475008 > Stop temporarily or permanently? > […](#) > On Thu, Jan 17, 2019 at 10:23 PM Sun-Li ***@***.***> wrote: The table has kafka real-time