[GitHub] xueyumusic commented on issue #3786: [PINOT-5] make BitmapInvertedIndexTest Windows compatible

2019-02-06 Thread GitBox
xueyumusic commented on issue #3786: [PINOT-5] make BitmapInvertedIndexTest Windows compatible URL: https://github.com/apache/incubator-pinot/pull/3786#issuecomment-461275686 Hi, @kishoreg , thanks for review. In pinot-core there are a batch of non-Windows-compatible tests. I tried to fix

[GitHub] akshayrai merged pull request #3801: [TE] API fix for partially migrated alerts in dashboard

2019-02-06 Thread GitBox
akshayrai merged pull request #3801: [TE] API fix for partially migrated alerts in dashboard URL: https://github.com/apache/incubator-pinot/pull/3801 This is an automated message from the Apache Git Service. To respond to

[GitHub] jihaozh merged pull request #3800: [TE] frontend - harleyjj/yaml-editor - link Documentation buttons to …

2019-02-06 Thread GitBox
jihaozh merged pull request #3800: [TE] frontend - harleyjj/yaml-editor - link Documentation buttons to … URL: https://github.com/apache/incubator-pinot/pull/3800 This is an automated message from the Apache Git Service. To

[GitHub] harleyjj opened a new pull request #3800: [TE] frontend - harleyjj/yaml-editor - link Documentation buttons to …

2019-02-06 Thread GitBox
harleyjj opened a new pull request #3800: [TE] frontend - harleyjj/yaml-editor - link Documentation buttons to … URL: https://github.com/apache/incubator-pinot/pull/3800 …YAML Documentation This is an automated message from

[GitHub] mcvsubbu commented on issue #3748: Use the PinotFS instead of local file system to open a segment file t…

2019-02-06 Thread GitBox
mcvsubbu commented on issue #3748: Use the PinotFS instead of local file system to open a segment file t… URL: https://github.com/apache/incubator-pinot/pull/3748#issuecomment-461229243 Thanks, @npawar for evaluating this. Here are things I will add: step 2 should be made

Fwd: Mentor sign-off due next Tuesday (February 12th)

2019-02-06 Thread Seunghyun Lee
Dear Mentors, Can we get the sign-offs for our podling reports? It seems that it's due next Tuesday. Best, Seunghyun -- Forwarded message - From: Justin Mclean Date: Wed, Feb 6, 2019 at 2:44 PM Subject: Mentor sign-off due next Tuesday (February 12th) To: Hi, Mentor

Re: ASF Release process

2019-02-06 Thread Seunghyun Lee
Thank you for the reference! After I go over the release process, I will come up with the similar documentation for our project so that anyone who becomes the release manager in the future can proceed. Best, Seunghyun On Wed, Feb 6, 2019 at 11:14 AM Felix Cheung wrote: > Sharing doc Chris has

Re: Request for checking commits before creating a release candidate

2019-02-06 Thread Seunghyun Lee
Hi Felix, I retried to build NOTICE file and get the same result for concatenated NOTICE. I think that those are the part of old glassfish.jersey libraries. If you confirm, I will go ahead of merging the pr. Best, Seunghyun On Wed, Feb 6, 2019 at 10:08 AM Seunghyun Lee wrote: > I rebuilt

[GitHub] npawar commented on issue #3748: Use the PinotFS instead of local file system to open a segment file t…

2019-02-06 Thread GitBox
npawar commented on issue #3748: Use the PinotFS instead of local file system to open a segment file t… URL: https://github.com/apache/incubator-pinot/pull/3748#issuecomment-461218017 I did some evaluation. You can introduce the new metadata upload **Step 1** Add a new endpoint in

[GitHub] jihaozh merged pull request #3787: [TE] frontend - harleyjj/yaml-editor - implements simple graph for pr…

2019-02-06 Thread GitBox
jihaozh merged pull request #3787: [TE] frontend - harleyjj/yaml-editor - implements simple graph for pr… URL: https://github.com/apache/incubator-pinot/pull/3787 This is an automated message from the Apache Git Service. To

[GitHub] harleyjj closed pull request #3620: [TE] frontend - harleyjj/rootcause-visual - componentize rootcause gr…

2019-02-06 Thread GitBox
harleyjj closed pull request #3620: [TE] frontend - harleyjj/rootcause-visual - componentize rootcause gr… URL: https://github.com/apache/incubator-pinot/pull/3620 This is an automated message from the Apache Git Service.

[GitHub] jihaozh merged pull request #3732: [TE] frontend - harleyjj/yaml-editor - improves yaml autocomplete

2019-02-06 Thread GitBox
jihaozh merged pull request #3732: [TE] frontend - harleyjj/yaml-editor - improves yaml autocomplete URL: https://github.com/apache/incubator-pinot/pull/3732 This is an automated message from the Apache Git Service. To

[GitHub] harleyjj commented on a change in pull request #3787: [TE] frontend - harleyjj/yaml-editor - implements simple graph for pr…

2019-02-06 Thread GitBox
harleyjj commented on a change in pull request #3787: [TE] frontend - harleyjj/yaml-editor - implements simple graph for pr… URL: https://github.com/apache/incubator-pinot/pull/3787#discussion_r254467036 ## File path:

[GitHub] aaronucsd commented on a change in pull request #3787: [TE] frontend - harleyjj/yaml-editor - implements simple graph for pr…

2019-02-06 Thread GitBox
aaronucsd commented on a change in pull request #3787: [TE] frontend - harleyjj/yaml-editor - implements simple graph for pr… URL: https://github.com/apache/incubator-pinot/pull/3787#discussion_r254465281 ## File path:

[GitHub] aaronucsd commented on a change in pull request #3787: [TE] frontend - harleyjj/yaml-editor - implements simple graph for pr…

2019-02-06 Thread GitBox
aaronucsd commented on a change in pull request #3787: [TE] frontend - harleyjj/yaml-editor - implements simple graph for pr… URL: https://github.com/apache/incubator-pinot/pull/3787#discussion_r254464956 ## File path:

[GitHub] jihaozh commented on a change in pull request #3787: [TE] frontend - harleyjj/yaml-editor - implements simple graph for pr…

2019-02-06 Thread GitBox
jihaozh commented on a change in pull request #3787: [TE] frontend - harleyjj/yaml-editor - implements simple graph for pr… URL: https://github.com/apache/incubator-pinot/pull/3787#discussion_r254464261 ## File path:

ASF Release process

2019-02-06 Thread Felix Cheung
Sharing doc Chris has on the ASF release process http://plc4x.apache.org/developers/release.html Thanks Chris!

[GitHub] Jackie-Jiang merged pull request #3797: Fix some indentation for the pom files

2019-02-06 Thread GitBox
Jackie-Jiang merged pull request #3797: Fix some indentation for the pom files URL: https://github.com/apache/incubator-pinot/pull/3797 This is an automated message from the Apache Git Service. To respond to the message,

Re: Request for checking commits before creating a release candidate

2019-02-06 Thread Seunghyun Lee
I rebuilt NOTICE-binary file using the same approach and those were cut out. I will check that one more time and get back to you. Best, Seunghyun On Wed, Feb 6, 2019 at 12:46 AM Felix Cheung wrote: > For #1 LG generally. What happened to the whole chunk of Apache ones > like Apache > Commons

[GitHub] akshayrai commented on a change in pull request #3790: [TE] yaml - onboarding tasks

2019-02-06 Thread GitBox
akshayrai commented on a change in pull request #3790: [TE] yaml - onboarding tasks URL: https://github.com/apache/incubator-pinot/pull/3790#discussion_r254366707 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/yaml/YamlResource.java

[GitHub] akshayrai commented on a change in pull request #3790: [TE] yaml - onboarding tasks

2019-02-06 Thread GitBox
akshayrai commented on a change in pull request #3790: [TE] yaml - onboarding tasks URL: https://github.com/apache/incubator-pinot/pull/3790#discussion_r254363559 ## File path:

[GitHub] akshayrai commented on a change in pull request #3790: [TE] yaml - onboarding tasks

2019-02-06 Thread GitBox
akshayrai commented on a change in pull request #3790: [TE] yaml - onboarding tasks URL: https://github.com/apache/incubator-pinot/pull/3790#discussion_r254363807 ## File path:

[GitHub] codecov-io commented on issue #3796: [PINOT-6] Fix Windows compatibility of a batch of pinot-core tests

2019-02-06 Thread GitBox
codecov-io commented on issue #3796: [PINOT-6] Fix Windows compatibility of a batch of pinot-core tests URL: https://github.com/apache/incubator-pinot/pull/3796#issuecomment-461085571 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3796?src=pr=h1) Report > Merging

Re: Request for checking commits before creating a release candidate

2019-02-06 Thread Felix Cheung
For #1 LG generally. What happened to the whole chunk of Apache ones like Apache Commons Net? #2 LGTM On Tue, Feb 5, 2019 at 9:59 PM Seunghyun Lee wrote: > Hi Felix, > > Before we cut the release candidate, I have some remaining checks from you. > > 1. Can you double check on the update for