[GitHub] ly923976094 commented on issue #3820: DefaultTenant and CustomTenant machines have different roles

ly923976094 commented on issue #3820: DefaultTenant and CustomTenant machines have different roles URL: https://github.com/apache/incubator-pinot/issues/3820#issuecomment-463082307 > you can use helix-admin commands to add the additional tags as needed. Download helix from

Re: Failing on deploying artifacts

Hi Felix, I actually was following the same documentation; however, I somehow missed the very first step (filing the ticket for setting up the repository before publishing) Thank you! Seunghyun On Tue, Feb 12, 2019 at 8:54 PM Felix Cheung wrote: > Also are you able to login to nexus

Re: Failing on deploying artifacts

Ah good. Is this documented as a step somewhere? (Just want to see if this needs to be clarified) From: Seunghyun Lee Sent: Tuesday, February 12, 2019 7:14 PM To: dev@pinot.apache.org Subject: Re: Failing on deploying artifacts This was because I haven't set

Re: Failing on deploying artifacts

This was because I haven't set up the access to nexus yet. I have filed the ticket to INFRA https://issues.apache.org/jira/browse/INFRA-17840 Best, Seunghyun On Tue, Feb 12, 2019 at 6:10 PM Seunghyun Lee wrote: > Hi mentors, > > I am trying to upload our artifacts to Nexus staging repository.

Failing on deploying artifacts

Hi mentors, I am trying to upload our artifacts to Nexus staging repository. I was following the apache document. Have set up "~/.m2/settings.xml" file correctly. Since the job fails after uploading the "pinot-0.1.0.pom" file, I think that it's not the authentication issue. When I run "mvn

[GitHub] Jackie-Jiang merged pull request #3819: Refactor periodic task

Jackie-Jiang merged pull request #3819: Refactor periodic task URL: https://github.com/apache/incubator-pinot/pull/3819 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] npawar commented on a change in pull request #3819: Refactor periodic task

npawar commented on a change in pull request #3819: Refactor periodic task URL: https://github.com/apache/incubator-pinot/pull/3819#discussion_r256208642 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/periodictask/ControllerPeriodicTask.java

[GitHub] npawar commented on a change in pull request #3819: Refactor periodic task

npawar commented on a change in pull request #3819: Refactor periodic task URL: https://github.com/apache/incubator-pinot/pull/3819#discussion_r256209491 ## File path: pinot-core/src/main/java/org/apache/pinot/core/periodictask/BasePeriodicTask.java ## @@ -42,9 +61,126 @@

[GitHub] npawar commented on a change in pull request #3819: Refactor periodic task

npawar commented on a change in pull request #3819: Refactor periodic task URL: https://github.com/apache/incubator-pinot/pull/3819#discussion_r256209491 ## File path: pinot-core/src/main/java/org/apache/pinot/core/periodictask/BasePeriodicTask.java ## @@ -42,9 +61,126 @@

[GitHub] npawar commented on a change in pull request #3819: Refactor periodic task

npawar commented on a change in pull request #3819: Refactor periodic task URL: https://github.com/apache/incubator-pinot/pull/3819#discussion_r256208642 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/periodictask/ControllerPeriodicTask.java

[GitHub] codecov-io edited a comment on issue #3819: Refactor periodic task

codecov-io edited a comment on issue #3819: Refactor periodic task URL: https://github.com/apache/incubator-pinot/pull/3819#issuecomment-462610714 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3819?src=pr=h1) Report > Merging

[GitHub] akshayrai commented on a change in pull request #3822: [TE] Return yaml errors after grouping and use consistent convention …

akshayrai commented on a change in pull request #3822: [TE] Return yaml errors after grouping and use consistent convention … URL: https://github.com/apache/incubator-pinot/pull/3822#discussion_r256200058 ## File path:

[GitHub] akshayrai commented on a change in pull request #3822: [TE] Return yaml errors after grouping and use consistent convention …

akshayrai commented on a change in pull request #3822: [TE] Return yaml errors after grouping and use consistent convention … URL: https://github.com/apache/incubator-pinot/pull/3822#discussion_r256200033 ## File path:

[GitHub] jihaozh commented on a change in pull request #3822: [TE] Return yaml errors after grouping and use consistent convention …

jihaozh commented on a change in pull request #3822: [TE] Return yaml errors after grouping and use consistent convention … URL: https://github.com/apache/incubator-pinot/pull/3822#discussion_r256199222 ## File path:

[GitHub] jihaozh commented on a change in pull request #3822: [TE] Return yaml errors after grouping and use consistent convention …

jihaozh commented on a change in pull request #3822: [TE] Return yaml errors after grouping and use consistent convention … URL: https://github.com/apache/incubator-pinot/pull/3822#discussion_r256199198 ## File path:

[GitHub] Jackie-Jiang commented on issue #3819: Refactor periodic task

Jackie-Jiang commented on issue #3819: Refactor periodic task URL: https://github.com/apache/incubator-pinot/pull/3819#issuecomment-462991869 @npawar Addressed the comments. Periodic task logic is covered by unit test: ControllerPeriodicTask and PeriodicTaskSchedulerTest. For each

[GitHub] Jackie-Jiang commented on a change in pull request #3819: Refactor periodic task

Jackie-Jiang commented on a change in pull request #3819: Refactor periodic task URL: https://github.com/apache/incubator-pinot/pull/3819#discussion_r256195484 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/SegmentStatusChecker.java ## @@

[GitHub] Jackie-Jiang commented on a change in pull request #3819: Refactor periodic task

Jackie-Jiang commented on a change in pull request #3819: Refactor periodic task URL: https://github.com/apache/incubator-pinot/pull/3819#discussion_r256188719 ## File path:

[GitHub] harleyjj opened a new pull request #3823: [TE] frontend - harleyjj/alert-details - add duration to anomaly tabl…

harleyjj opened a new pull request #3823: [TE] frontend - harleyjj/alert-details - add duration to anomaly tabl… URL: https://github.com/apache/incubator-pinot/pull/3823 …e and hide preview when yaml field updated 1) If the user changes the YAML input, the graph and other visuals

[GitHub] Jackie-Jiang commented on a change in pull request #3819: Refactor periodic task

Jackie-Jiang commented on a change in pull request #3819: Refactor periodic task URL: https://github.com/apache/incubator-pinot/pull/3819#discussion_r256193623 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java

[GitHub] akshayrai opened a new pull request #3822: [TE] Return yaml errors after grouping and use consistent convention …

akshayrai opened a new pull request #3822: [TE] Return yaml errors after grouping and use consistent convention … URL: https://github.com/apache/incubator-pinot/pull/3822 …(subscription over notification) This is an

[GitHub] Jackie-Jiang commented on a change in pull request #3819: Refactor periodic task

Jackie-Jiang commented on a change in pull request #3819: Refactor periodic task URL: https://github.com/apache/incubator-pinot/pull/3819#discussion_r256188719 ## File path:

[GitHub] codecov-io commented on issue #3821: Refactor SegmentNameGenerators and integrate them into Hadoop

codecov-io commented on issue #3821: Refactor SegmentNameGenerators and integrate them into Hadoop URL: https://github.com/apache/incubator-pinot/pull/3821#issuecomment-462978060 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3821?src=pr=h1) Report > Merging

[GitHub] Jackie-Jiang commented on a change in pull request #3819: Refactor periodic task

Jackie-Jiang commented on a change in pull request #3819: Refactor periodic task URL: https://github.com/apache/incubator-pinot/pull/3819#discussion_r256183740 ## File path:

[GitHub] Jackie-Jiang commented on a change in pull request #3819: Refactor periodic task

Jackie-Jiang commented on a change in pull request #3819: Refactor periodic task URL: https://github.com/apache/incubator-pinot/pull/3819#discussion_r256183052 ## File path: pinot-core/src/main/java/org/apache/pinot/core/periodictask/BasePeriodicTask.java ## @@ -42,9

[GitHub] Jackie-Jiang commented on a change in pull request #3819: Refactor periodic task

Jackie-Jiang commented on a change in pull request #3819: Refactor periodic task URL: https://github.com/apache/incubator-pinot/pull/3819#discussion_r256181834 ## File path: pinot-core/src/main/java/org/apache/pinot/core/periodictask/BasePeriodicTask.java ## @@ -18,20

[GitHub] Jackie-Jiang commented on issue #3819: Refactor periodic task

Jackie-Jiang commented on issue #3819: Refactor periodic task URL: https://github.com/apache/incubator-pinot/pull/3819#issuecomment-462970857 @sunithabeeram The race condition between start() and stop(), and is addressed by adding synchronization. As for the leader and non-leader

[GitHub] npawar commented on a change in pull request #3819: Refactor periodic task

npawar commented on a change in pull request #3819: Refactor periodic task URL: https://github.com/apache/incubator-pinot/pull/3819#discussion_r256174360 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/periodictask/ControllerPeriodicTask.java

[GitHub] npawar commented on a change in pull request #3819: Refactor periodic task

npawar commented on a change in pull request #3819: Refactor periodic task URL: https://github.com/apache/incubator-pinot/pull/3819#discussion_r256176671 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/SegmentStatusChecker.java ## @@ -69,58

[GitHub] npawar commented on a change in pull request #3819: Refactor periodic task

npawar commented on a change in pull request #3819: Refactor periodic task URL: https://github.com/apache/incubator-pinot/pull/3819#discussion_r256167332 ## File path: pinot-core/src/main/java/org/apache/pinot/core/periodictask/BasePeriodicTask.java ## @@ -18,20 +18,39 @@

[GitHub] npawar commented on a change in pull request #3819: Refactor periodic task

npawar commented on a change in pull request #3819: Refactor periodic task URL: https://github.com/apache/incubator-pinot/pull/3819#discussion_r256178149 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java ## @@

[GitHub] npawar commented on a change in pull request #3819: Refactor periodic task

npawar commented on a change in pull request #3819: Refactor periodic task URL: https://github.com/apache/incubator-pinot/pull/3819#discussion_r256172676 ## File path: pinot-core/src/main/java/org/apache/pinot/core/periodictask/BasePeriodicTask.java ## @@ -42,9 +61,126 @@

[GitHub] npawar commented on a change in pull request #3819: Refactor periodic task

npawar commented on a change in pull request #3819: Refactor periodic task URL: https://github.com/apache/incubator-pinot/pull/3819#discussion_r256170073 ## File path: pinot-core/src/main/java/org/apache/pinot/core/periodictask/BasePeriodicTask.java ## @@ -42,9 +61,126 @@

[GitHub] npawar commented on a change in pull request #3819: Refactor periodic task

npawar commented on a change in pull request #3819: Refactor periodic task URL: https://github.com/apache/incubator-pinot/pull/3819#discussion_r256178624 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/periodictask/ControllerPeriodicTask.java

[GitHub] Jackie-Jiang opened a new pull request #3821: Refactor SegmentNameGenerators and integrate them into Hadoop

Jackie-Jiang opened a new pull request #3821: Refactor SegmentNameGenerators and integrate them into Hadoop URL: https://github.com/apache/incubator-pinot/pull/3821 - generateSegmentName() now take 3 arguments: sequenceId, minTimeValue, maxTimeValue - 3 segment name generator

[GitHub] mcvsubbu commented on issue #3819: Refactor periodic task

mcvsubbu commented on issue #3819: Refactor periodic task URL: https://github.com/apache/incubator-pinot/pull/3819#issuecomment-462949656 @Jackie-Jiang could you also please check with @npawar ? I think we had similar questions (should there be a stop/start, etc.) in her PR and had made

[GitHub] sunithabeeram commented on issue #3819: Refactor periodic task

sunithabeeram commented on issue #3819: Refactor periodic task URL: https://github.com/apache/incubator-pinot/pull/3819#issuecomment-462937418 @Jackie-Jiang what race condition was addressed in this PR and how? Was any manual testing done to make sure leader and non-leader controllers

[GitHub] jihaozh commented on a change in pull request #3816: [TE] yaml - error messages

jihaozh commented on a change in pull request #3816: [TE] yaml - error messages URL: https://github.com/apache/incubator-pinot/pull/3816#discussion_r256081877 ## File path:

[GitHub] jihaozh commented on a change in pull request #3816: [TE] yaml - error messages

jihaozh commented on a change in pull request #3816: [TE] yaml - error messages URL: https://github.com/apache/incubator-pinot/pull/3816#discussion_r256081094 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/DetectionResource.java ##

[GitHub] jihaozh commented on a change in pull request #3816: [TE] yaml - error messages

jihaozh commented on a change in pull request #3816: [TE] yaml - error messages URL: https://github.com/apache/incubator-pinot/pull/3816#discussion_r256081094 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/DetectionResource.java ##

[GitHub] aaronucsd merged pull request #3818: [TE] frontend - aarouncsd/add debug global flag

aaronucsd merged pull request #3818: [TE] frontend - aarouncsd/add debug global flag URL: https://github.com/apache/incubator-pinot/pull/3818 This is an automated message from the Apache Git Service. To respond to the

[GitHub] mcvsubbu commented on issue #3820: DefaultTenant and CustomTenant machines have different roles

mcvsubbu commented on issue #3820: DefaultTenant and CustomTenant machines have different roles URL: https://github.com/apache/incubator-pinot/issues/3820#issuecomment-462852597 you can use helix-admin commands to add the additional tags as needed. Download helix from

[GitHub] akshayrai commented on a change in pull request #3816: [TE] yaml - error messages

akshayrai commented on a change in pull request #3816: [TE] yaml - error messages URL: https://github.com/apache/incubator-pinot/pull/3816#discussion_r255760641 ## File path:

[GitHub] mcvsubbu commented on a change in pull request #3796: [PINOT-6] Fix Windows compatibility of a batch of pinot-core tests

mcvsubbu commented on a change in pull request #3796: [PINOT-6] Fix Windows compatibility of a batch of pinot-core tests URL: https://github.com/apache/incubator-pinot/pull/3796#discussion_r256056313 ## File path:

[GitHub] mcvsubbu commented on a change in pull request #3796: [PINOT-6] Fix Windows compatibility of a batch of pinot-core tests

mcvsubbu commented on a change in pull request #3796: [PINOT-6] Fix Windows compatibility of a batch of pinot-core tests URL: https://github.com/apache/incubator-pinot/pull/3796#discussion_r256056443 ## File path:

[GitHub] shaunschembri commented on issue #1924: java.lang.IllegalArgumentException: bound must be positive

shaunschembri commented on issue #1924: java.lang.IllegalArgumentException: bound must be positive URL: https://github.com/apache/incubator-pinot/issues/1924#issuecomment-462655765 @snleee Here is the exception in pinotBroker.log 2019/02/12 07:59:23.384 ERROR