Re: Request for checking commits before creating a release candidate

2019-02-06 Thread Seunghyun Lee
Hi Felix, I retried to build NOTICE file and get the same result for concatenated NOTICE. I think that those are the part of old glassfish.jersey libraries. If you confirm, I will go ahead of merging the pr. Best, Seunghyun On Wed, Feb 6, 2019 at 10:08 AM Seunghyun Lee wrote: > I rebuilt

Re: Request for checking commits before creating a release candidate

2019-02-06 Thread Seunghyun Lee
I rebuilt NOTICE-binary file using the same approach and those were cut out. I will check that one more time and get back to you. Best, Seunghyun On Wed, Feb 6, 2019 at 12:46 AM Felix Cheung wrote: > For #1 LG generally. What happened to the whole chunk of Apache ones > like Apache > Commons

Re: Request for checking commits before creating a release candidate

2019-02-06 Thread Felix Cheung
For #1 LG generally. What happened to the whole chunk of Apache ones like Apache Commons Net? #2 LGTM On Tue, Feb 5, 2019 at 9:59 PM Seunghyun Lee wrote: > Hi Felix, > > Before we cut the release candidate, I have some remaining checks from you. > > 1. Can you double check on the update for

Request for checking commits before creating a release candidate

2019-02-05 Thread Seunghyun Lee
Hi Felix, Before we cut the release candidate, I have some remaining checks from you. 1. Can you double check on the update for LICENSE-binary/NOTICE-binary due to jersery version upgrade? (A lot of glassfish projects have been moved from CDDL to EPL 2.0.)