Re: AW: Modbus RTU

2021-08-18 Thread Łukasz Dywicki
Hey Stephen, It really depends how you copied the repository. Have a look on output of "git remote -v" command. For me its: connectorio g...@github.com:ConnectorIO/plc4x.git (fetch) connectorio g...@github.com:ConnectorIO/plc4x.git (push) origin g...@github.com:apache/plc4x.git (fetch)

Re: AW: Modbus RTU

2021-08-18 Thread Stephen Snow
Hi Ben, I forked the repo, actually had it forked for snapshot 0.7.0 so just had to merge the commits from the repo. On Wed, 2021-08-18 at 07:12 +1000, Ben Hutcheson wrote: > Hi Stephen, > > I have pushed support for RTU to the branch feature/modbusrtu, it > seems to > work. I've only used RTU

AW: AW: Nifi integration record oriented processor for reading

2021-08-18 Thread Christofer Dutz
Hi Gustavo, great ... I had something in the back of my mind, but I wasn't sure anymore ... then we're safe on that side ;-) Chris -Ursprüngliche Nachricht- Von: Gustavo Fernandez Gesendet: Mittwoch, 18. August 2021 12:32 An: dev@plc4x.apache.org Betreff: Re: AW: Nifi integration

Re: AW: Nifi integration record oriented processor for reading

2021-08-18 Thread Gustavo Fernandez
Hi Chris I sent my ICLA a month ago. The response from ASF was: [...] This message acknowledges receipt of your ICLA, which has been filed in the Apache Software Foundation records. With this message, the PLC4X PMC has been notified that your ICLA has been filed. [...] My apache user id is

AW: Nifi integration record oriented processor for reading

2021-08-18 Thread Christofer Dutz
HI Inigo, great news ... I hope Otto can spare some cycles to review the PR from the NiFi side ... Happy to assist with merging things back. As it's been quite some time ... I am pretty sure we have an ICLA on file from your side, correct? Chris -Ursprüngliche Nachricht- Von: Iñigo

Re: Nifi integration record oriented processor for reading

2021-08-18 Thread Iñigo Angulo
Hi Otto, Chris, We have gone over the comments on the Nifi PR and made a commit including revisions for all (or most) topics. the last changes we did were related to reforcing the methods for datatype conversion (for the record schema construction), and extending the tests. About this last