[GitHub] incubator-rocketmq pull request #134: Rito - #44 - Extracting out duplicated...

2017-07-25 Thread vsair
Github user vsair commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/134#discussion_r129468820 --- Diff: store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java --- @@ -745,17 +751,7 @@ public long

[GitHub] incubator-rocketmq pull request #134: Rito - #44 - Extracting out duplicated...

2017-07-25 Thread vsair
Github user vsair commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/134#discussion_r129469074 --- Diff: client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java --- @@ -1215,9 +1199,14 @@ public TopicRouteData

[GitHub] incubator-rocketmq issue #134: Rito - #44 - Extracting out duplicated code f...

2017-07-25 Thread Ritabrata-TW
Github user Ritabrata-TW commented on the issue: https://github.com/apache/incubator-rocketmq/pull/134 @vongosling Please have a look and let me know if you need any further improvements about the same. Thanks. --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-rocketmq pull request #134: Rito - #44 - Extracting out duplicated...

2017-07-25 Thread Ritabrata-TW
GitHub user Ritabrata-TW opened a pull request: https://github.com/apache/incubator-rocketmq/pull/134 Rito - #44 - Extracting out duplicated code from DefaultMessageStore.… This commit is in reference to Story number 44 from the Kanban Board, which refers to removing duplicated

[GitHub] incubator-rocketmq issue #133: [ROCKETMQ-249] Do not attempt to clear disk e...

2017-07-25 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/133 [![Coverage Status](https://coveralls.io/builds/12539692/badge)](https://coveralls.io/builds/12539692) Coverage increased (+0.1%) to 38.817% when pulling

[GitHub] incubator-rocketmq issue #133: [ROCKETMQ-249] Do not attempt to clear disk e...

2017-07-25 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/133 [![Coverage Status](https://coveralls.io/builds/12539692/badge)](https://coveralls.io/builds/12539692) Coverage increased (+0.1%) to 38.817% when pulling

[GitHub] incubator-rocketmq issue #133: [ROCKETMQ-249] Do not attempt to clear disk e...

2017-07-25 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/133 [![Coverage Status](https://coveralls.io/builds/12539692/badge)](https://coveralls.io/builds/12539692) Coverage increased (+0.1%) to 38.817% when pulling

[BUG] warnings and errors

2017-07-25 Thread Roman Shtykh
Guys, I noticed the source code contains many lines like this log.error("[BUG] ...) or log.warn("[BUG] ...). Are they really bugs (if yes, they have to go to JIRA), or errors and warnings that does not have to be fixed? -- Roman

.Net SDK exception in Microsoft Service Fabric

2017-07-25 Thread santanu adhikari
Hi, I have installed .Net SDK ManagedONS (v 1.3.0) in a Microsoft Service Fabric stateless service application. Whenever calling any class of the SDK, getting exception : External component has thrown an exception. But same things are working in Console Apllication. Is there any

[GitHub] incubator-rocketmq-site pull request #20: Add committer Jaskey to team site

2017-07-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-rocketmq-site/pull/20 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if