[
https://issues.apache.org/jira/browse/SLING-8869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989081#comment-16989081
]
Timothee Maret commented on SLING-8869:
---
Merged PR
[
https://issues.apache.org/jira/browse/SLING-8869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16988966#comment-16988966
]
Mohit Arora commented on SLING-8869:
[~marett] I have addressed the NPE. Can you please review the PR
[
https://issues.apache.org/jira/browse/SLING-8869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16988892#comment-16988892
]
Timothee Maret commented on SLING-8869:
---
Based on [~ashishc] PR
[
https://issues.apache.org/jira/browse/SLING-8869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16988792#comment-16988792
]
Timothee Maret commented on SLING-8869:
---
{quote}I'll try to update that with a commit applying the
[
https://issues.apache.org/jira/browse/SLING-8869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16988770#comment-16988770
]
Ashish Chopra commented on SLING-8869:
--
{quote}
bq. I still don't see in which case a
[
https://issues.apache.org/jira/browse/SLING-8869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16988758#comment-16988758
]
Mohit Arora commented on SLING-8869:
[~marett] {quote}With the approach taken by SLING-8869-new.patch
[
https://issues.apache.org/jira/browse/SLING-8869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16988664#comment-16988664
]
Timothee Maret commented on SLING-8869:
---
{quote}I still don't see in which case a
[
https://issues.apache.org/jira/browse/SLING-8869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16988653#comment-16988653
]
Ashish Chopra commented on SLING-8869:
--
bq. DistributionTransportSecretProvider is an API and anyone
[
https://issues.apache.org/jira/browse/SLING-8869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16988627#comment-16988627
]
Timothee Maret commented on SLING-8869:
---
{quote}If such a mechanism exists, can you please explain
[
https://issues.apache.org/jira/browse/SLING-8869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16988538#comment-16988538
]
Ashish Chopra commented on SLING-8869:
--
bq. If an Executor with a wrong pwd is cached then the only
[
https://issues.apache.org/jira/browse/SLING-8869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16988514#comment-16988514
]
Mohit Arora commented on SLING-8869:
[~marett] I have raised PRs for both the approaches -
[
https://issues.apache.org/jira/browse/SLING-8869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987967#comment-16987967
]
Timothee Maret commented on SLING-8869:
---
{quote}It works fine for credentials based secret provider
[
https://issues.apache.org/jira/browse/SLING-8869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987757#comment-16987757
]
Ashish Chopra commented on SLING-8869:
--
[~mohiaror], may I suggest raising a PR for SCD maintainers
[
https://issues.apache.org/jira/browse/SLING-8869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987641#comment-16987641
]
Mohit Arora commented on SLING-8869:
[~bdelacretaz], [~ashishc] I have attached another patch,
[
https://issues.apache.org/jira/browse/SLING-8869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987619#comment-16987619
]
Ashish Chopra commented on SLING-8869:
--
hi [~bdelacretaz], thanks for your comments!
bq. If it's a
[
https://issues.apache.org/jira/browse/SLING-8869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986813#comment-16986813
]
Bertrand Delacretaz commented on SLING-8869:
I don't have much context about this so feel
[
https://issues.apache.org/jira/browse/SLING-8869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986688#comment-16986688
]
Mohit Arora commented on SLING-8869:
[~ashishc] Thanks for pointing it out. I have updated the patch.
[
https://issues.apache.org/jira/browse/SLING-8869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986649#comment-16986649
]
Ashish Chopra commented on SLING-8869:
--
[~mohiaror], IIUC the patch, once the secret is associated
[
https://issues.apache.org/jira/browse/SLING-8869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985903#comment-16985903
]
Mohit Arora commented on SLING-8869:
Attached a sample patch to resolve the issue.
cc -
19 matches
Mail list logo
