[jira] [Commented] (SLING-8946) Non-deterministic shadowing of resource observation

[ https://issues.apache.org/jira/browse/SLING-8946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027322#comment-17027322 ] Sonal Gupta commented on SLING-8946: [~diru] Can you please suggest the steps by which i can test

[jira] [Updated] (SLING-9044) Use traversal to list resource distribution queue items.

[ https://issues.apache.org/jira/browse/SLING-9044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohit Arora updated SLING-9044: --- Description: [ResourceQueueUtils#

adaptTo() 2020: Tickets now available / Call for Papers open

Dear adaptTo() Community, The new year has just begun and we are already coming up with some exciting news about the upcoming adaptTo() 2020 (28th - 30th September 2020). There is for example our new slogan. In the future, we will advertise our event with confidence and not without a certain

[jira] [Commented] (SLING-8946) Non-deterministic shadowing of resource observation

[ https://issues.apache.org/jira/browse/SLING-8946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027345#comment-17027345 ] Dirk Rudolph commented on SLING-8946: - I verified the changes against the IT you shared earlier and

Re: Redirect Provider

Hi, On Fri, Jan 31, 2020 at 11:00 AM Ian Boston wrote: > ...If an implementation of a RedirectResolver requires SlingHttpServletRequest > it can check for that and cast to it, returning NO_REDIRECT if the context > isn't what it required... Makes sense and that's probably going to be an

Re: Redirect Provider

Hi, NO_REDIRECT, good point, added. I think HttpServletRequest is better as it is wider. If an implementation of a RedirectResolver requires SlingHttpServletRequest it can check for that and cast to it, returning NO_REDIRECT if the context isn't what it required. Best Regards Ian On Fri, 31

[jira] [Commented] (SLING-8946) Non-deterministic shadowing of resource observation

[ https://issues.apache.org/jira/browse/SLING-8946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027339#comment-17027339 ] Dirk Rudolph commented on SLING-8946: - Please apply the changes made in SLING-9040 on top of the ones

[GitHub] [sling-org-apache-sling-dynamic-include] jfmitchell commented on issue #1: Option to disable the URL params check when there is need to process all GET requests

jfmitchell commented on issue #1: Option to disable the URL params check when there is need to process all GET requests URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/1#issuecomment-580680099 I'll sort it out. I reached out to @srgovindaraj before - because I

[GitHub] [sling-org-apache-sling-dynamic-include] rombert commented on issue #1: Option to disable the URL params check when there is need to process all GET requests

rombert commented on issue #1: Option to disable the URL params check when there is need to process all GET requests URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/1#issuecomment-580679522 I see that the PR no longer merges cleanly, and also the build check

[jira] [Created] (SLING-9044) Use traversal to list resource distribution queue items.

Mohit Arora created SLING-9044: -- Summary: Use traversal to list resource distribution queue items. Key: SLING-9044 URL: https://issues.apache.org/jira/browse/SLING-9044 Project: Sling Issue

[jira] [Assigned] (SLING-9044) Use traversal to list resource distribution queue items.

[ https://issues.apache.org/jira/browse/SLING-9044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothee Maret reassigned SLING-9044: - Assignee: Timothee Maret > Use traversal to list resource distribution queue items. >

[jira] [Commented] (SLING-9044) Use traversal to list resource distribution queue items.

[ https://issues.apache.org/jira/browse/SLING-9044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027354#comment-17027354 ] Timothee Maret commented on SLING-9044: --- Thanks [~mohiaror]! This makes sense, would you provide a

[jira] [Updated] (SLING-9044) Use traversal to count items in resource based distribution queue

[ https://issues.apache.org/jira/browse/SLING-9044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothee Maret updated SLING-9044: -- Summary: Use traversal to count items in resource based distribution queue (was: Use

[GitHub] [sling-org-apache-sling-dynamic-include] jasper-s commented on issue #1: Option to disable the URL params check when there is need to process all GET requests

jasper-s commented on issue #1: Option to disable the URL params check when there is need to process all GET requests URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/1#issuecomment-580678129 This feature would come in real handy in some of our projects as well!

Re: Redirect Provider

Hi, Why not return RedirectResponse from RedirectResolver#resolve(SlingHttpServletRequest)? This would obviate the need for the magic NO_REDIRECT status code. Instead null could be returned if no redirect should be performed. I am also wondering if it is sensible to encode the word "redirect"

Re: Redirect Provider

Hi, Good observations. > Why not return RedirectResponse from RedirectResolver#resolve(SlingHttpServletRequest)? This would obviate the need for the magic NO_REDIRECT status code. Instead null could be returned if no redirect should be performed. Initially an interface was used, and hence

Re: Redirect Provider

Hi, I started with that service pattern, as you have suggested, but Carsten asked we used a provider with the adaptTo pattern. He can explain. He does that better. It made sense to me when he did. Best Regards Ian On Fri, 31 Jan 2020 at 12:02, Radu Cotescu wrote: > Hi Ian, > > I posted a

Re: [VOTE] Release Apache Sling XSS Protection API 2.2.2

+1 > On 28 Jan 2020, at 16:24, Radu Cotescu wrote: > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ...

[jira] [Commented] (SLING-8946) Non-deterministic shadowing of resource observation

[ https://issues.apache.org/jira/browse/SLING-8946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027341#comment-17027341 ] Sonal Gupta commented on SLING-8946: [~diru] Yes i have done that but can you please suggest me the

Re: Redirect Provider

Hi Ian, I posted a comment to your gist [2] where I just changed the pattern to not use adaptTo. WDYT? Thanks, Radu [2] - https://gist.github.com/ieb/5f217e2c160afb7bb4098bca99896621#gistcomment-3162233

[Jenkins] Sling » sling-org-apache-sling-launchpad-testing » master #556 is BROKEN

-20200131-133242-2796026946780168256182.log [Pipeline] } [withMaven] Publishers: Pipeline Graph Publisher: 27 ms, JGiven Publisher: 1 ms [Pipeline] // withMaven [Pipeline] } [Pipeline] // stage [Pipeline] stage [Pipeline] { (SonarCloud) [Pipeline] withCredentials Masking supported pattern matches

[jira] [Commented] (SLING-9043) COPY should be in the referer filter's default list of protected HTTP methods

[ https://issues.apache.org/jira/browse/SLING-9043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027305#comment-17027305 ] Julian Reschke commented on SLING-9043: --- Well, if COPY is problematic, so is MOVE. That said, I'd

[jira] [Commented] (SLING-9043) COPY should be in the referer filter's default list of protected HTTP methods

[ https://issues.apache.org/jira/browse/SLING-9043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027313#comment-17027313 ] Julian Reschke commented on SLING-9043: --- So the assumption is that the XHR request will not include

Re: Redirect Provider

Hi, On Fri, Jan 31, 2020 at 9:11 AM Ian Boston wrote: .. > 1 https://gist.github.com/ieb/5f217e2c160afb7bb4098bca99896621 ... The RedirectResolver gets an HttpServletRequest, shouldn't that be a SlingHttpServletRequest to be able to get at the Resource, selectors etc? I understand the Resource

[jira] [Commented] (SLING-9043) COPY should be in the referer filter's default list of protected HTTP methods

[ https://issues.apache.org/jira/browse/SLING-9043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027311#comment-17027311 ] Sonal Gupta commented on SLING-9043: [~reschke] COPY command works perfectly fine with both

Re: Redirect Provider

Hi, Agreed. We should have the deprecation conversation in a separate thread. No rush. Here is a gist[1] of what is being proposed. It has had some input already from Carsten and Robert. On reflection we changed the signature of the provider to pass in an implementation of a class

[jira] [Commented] (SLING-9043) COPY should be in the referer filter's default list of protected HTTP methods

[ https://issues.apache.org/jira/browse/SLING-9043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027304#comment-17027304 ] Sonal Gupta commented on SLING-9043: [~reschke] There was an issue opened for COPY function

[jira] [Commented] (SLING-7760) Sling Main Servlet - Change header configuration to a service

[ https://issues.apache.org/jira/browse/SLING-7760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027587#comment-17027587 ] Jason E Bailey commented on SLING-7760: --- I've been considering this a lot. It's true that I could

[jira] [Updated] (SLING-9045) Add option to process requests with querystring parameters

[ https://issues.apache.org/jira/browse/SLING-9045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Mitchell updated SLING-9045: - Affects Version/s: Dynamic Include 3.1.6 > Add option to process requests with querystring

[jira] [Updated] (SLING-9045) Add option to process requests with querystring parameters

[ https://issues.apache.org/jira/browse/SLING-9045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Mitchell updated SLING-9045: - Fix Version/s: (was: Dynamic Include 3.1.8) > Add option to process requests with

Re: [VOTE] Release Apache Sling XSS Protection API 2.2.2

+1 Le ven. 31 janv. 2020 à 14:10, Radu Cotescu a écrit : > +1 > > > On 28 Jan 2020, at 16:24, Radu Cotescu wrote: > > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] 0 Don't care > > [ ] -1 Don't release, because ... > >

Re: Redirect Provider

Casting is bad, but as RedirectResolver is the result of adapting a resource, the implementation has access to the resource already. So no need for SlingHttpServletRequest or casting etc. Regards Carsten On 31.01.2020 01:59, Ian Boston wrote: Hi, NO_REDIRECT, good point, added. I think

[jira] [Updated] (SLING-9045) Add option to process requests with querystring parameters

[ https://issues.apache.org/jira/browse/SLING-9045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Mitchell updated SLING-9045: - Fix Version/s: Dynamic Include 3.1.8 > Add option to process requests with querystring

[jira] [Updated] (SLING-9045) Add option to process requests with querystring parameters

[ https://issues.apache.org/jira/browse/SLING-9045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Mitchell updated SLING-9045: - Component/s: Extensions > Add option to process requests with querystring parameters >

[jira] [Commented] (SLING-7760) Sling Main Servlet - Change header configuration to a service

[ https://issues.apache.org/jira/browse/SLING-7760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027659#comment-17027659 ] Bertrand Delacretaz commented on SLING-7760: bq. create a service interface that takes the

[jira] [Commented] (SLING-9045) Add option to process requests with querystring parameters

[ https://issues.apache.org/jira/browse/SLING-9045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027660#comment-17027660 ] John Mitchell commented on SLING-9045: -- PR at

Re: Build marked unstable due to Sonar, but it's there and green

On Fri, Jan 31, 2020 at 3:32 PM Bertrand Delacretaz wrote: > ...The Jenkins code at [3] outputs this "unstable" message regardless of > what fails in the Maven build, we might need to provide more details > there on what failed?.. ...in the meantime I read [4] and apparently getting the Maven

[jira] [Created] (SLING-9045) Add option to process requests with querystring parameters

John Mitchell created SLING-9045: Summary: Add option to process requests with querystring parameters Key: SLING-9045 URL: https://issues.apache.org/jira/browse/SLING-9045 Project: Sling

[jira] [Comment Edited] (SLING-7760) Sling Main Servlet - Change header configuration to a service

[ https://issues.apache.org/jira/browse/SLING-7760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027587#comment-17027587 ] Jason E Bailey edited comment on SLING-7760 at 1/31/20 3:38 PM:

[GitHub] [sling-org-apache-sling-dynamic-include] jfmitchell commented on issue #1: Option to disable the URL params check when there is need to process all GET requests

jfmitchell commented on issue #1: Option to disable the URL params check when there is need to process all GET requests URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/1#issuecomment-580809790 I don't have the permission to modify this existing PR - so I've

Re: Redirect Provider

A general service does imho not sense. That service has no knowledge about where resources are coming from and how binaries a stored. A resource provider does know these things. This leaves us with two options: we allow multiple services to be registered. Each service than has to check if it

[jira] [Commented] (SLING-9044) Use traversal to count items in resource based distribution queue

[ https://issues.apache.org/jira/browse/SLING-9044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027504#comment-17027504 ] Jason E Bailey commented on SLING-9044: --- As a note, we have a traversal library that's part of the

Build marked unstable due to Sonar, but it's there and green

Hi, The build at [1] is marked unstable "due to missing SonarCloud onboarding", but if I look in Sonar at [2] that module is there and says "passed". The Jenkins code at [3] outputs this "unstable" message regardless of what fails in the Maven build, we might need to provide more details there

[GitHub] [sling-org-apache-sling-dynamic-include] jfmitchell opened a new pull request #13: Rebase of PR #1 - Adding option to disable URL params check

jfmitchell opened a new pull request #13: Rebase of PR #1 - Adding option to disable URL params check URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/13 All credit to @srgovindaraj for the changes. I'm championing this PR - since it complements the

[GitHub] [sling-org-apache-sling-dynamic-include] jfmitchell commented on issue #13: Rebase of PR #1 - Adding option to disable URL params check

jfmitchell commented on issue #13: Rebase of PR #1 - Adding option to disable URL params check URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/13#issuecomment-580811242 #13 is the original PR This

[GitHub] [sling-org-apache-sling-dynamic-include] jfmitchell edited a comment on issue #13: Rebase of PR #13 - Adding option to disable URL params check

jfmitchell edited a comment on issue #13: Rebase of PR #13 - Adding option to disable URL params check URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/13#issuecomment-580811242 #1 is the original PR

[jira] [Commented] (SLING-7760) Sling Main Servlet - Change header configuration to a service

[ https://issues.apache.org/jira/browse/SLING-7760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027709#comment-17027709 ] Jason E Bailey commented on SLING-7760: --- [~bdelacretaz] My thought process for this is that I

[jira] [Comment Edited] (SLING-8879) Make JSONObject#toString and XSSAPI#encodeForJSString both safe and correct for pasting into a javascript string literal

[ https://issues.apache.org/jira/browse/SLING-8879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989033#comment-16989033 ] Ilguiz Latypov edited comment on SLING-8879 at 1/31/20 9:24 PM: I also

[jira] [Commented] (SLING-7760) Sling Main Servlet - Change header configuration to a service

[ https://issues.apache.org/jira/browse/SLING-7760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027904#comment-17027904 ] Carsten Ziegeler commented on SLING-7760: - Totally agree that we must not pass the whole response