Re: Automated close of PR's ?

2015-12-31 Thread Mridul Muralidharan
On the contrary, PR's are actually meant to be long lived - and a reference of discussion about review and changes. Particularly so for spark since JIRA's and review board are not used for code review. Note - they are not used only in spark, but by other organization's to track contributions (like

Re: Automated close of PR's ?

2015-12-31 Thread Sean Owen
Yes, I mean "open" for a long time, but I do mean PRs aren't intended to be open for long periods. Of course, they actually stick around forever on github. I think Reynold did manually close yours, but I was noting for the record that there's also an automated process that does this in response

Re: Automated close of PR's ?

2015-12-31 Thread Reynold Xin
Hi Mridul, Thanks for the message. All you said made sense to me. It can definitely be frustrating when one of your pull requests got accidentally closed, and that's why we often ping the original authors to close them. However, this doesn't always work because the original authors might be

Re: problem with reading source code-pull out nondeterministic expresssions

2015-12-31 Thread 汪洋
I get it, thanks! > 在 2015年12月31日,上午3:00,Michael Armbrust 写道: > > The goal here is to ensure that the non-deterministic value is evaluated only > once, so the result won't change for a given row (i.e. when sorting). > > On Tue, Dec 29, 2015 at 10:57 PM, 汪洋

Re: Spark streaming 1.6.0-RC4 NullPointerException using mapWithState

2015-12-31 Thread Jan Uyttenhove
Thanks for your answers, and I'm sorry for the sight delay. I was trying to narrow it down first since I noticed very unpredictable behaviour in reproducing it. Finally the unpredictability seemed related to the message format of the messages on Kafka, so I also came to suspect it had something