Re: Live Streamed Code Review today at 11am Pacific

2018-06-07 Thread Holden Karau
I'll be doing another one tomorrow morning at 9am pacific focused on Python + K8s support & improved JSON support - https://www.youtube.com/watch?v=Z7ZEkvNwneU & https://www.twitch.tv/events/xU90q9RGRGSOgp2LoNsf6A :) On Fri, Mar 9, 2018 at 3:54 PM, Holden Karau wrote: > If anyone wants to watch

Re: Scala 2.12 support

2018-06-07 Thread Sean Owen
When I updated for Scala 2.12, I was able to remove almost all the 2.11-2.12 differences. There are still already two source trees for 2.11 vs 2.12. I mean that if it's necessary to accommodate differences between the two, it's already set up for that, and there aren't a mess of differences to

Re: Scala 2.12 support

2018-06-07 Thread DB Tsai
It is from the most recent 2.11 I don’t try it yet on 2.12, but I expect to get the same result. On Thu, Jun 7, 2018 at 6:28 PM Wenchen Fan wrote: > One more point: There was a time that we maintain 2 Spark REPL codebase > for Scala 2.10 and 2.11, maybe we can do the same for Scala 2.11 and

Re: Scala 2.12 support

2018-06-07 Thread Holden Karau
I agree that's a little odd, could we not add the bacspace terminal character? Regardless even if not, I don't think that should be a blocker for 2.12 support especially since it doesn't degrade the 2.11 experience. On Thu, Jun 7, 2018, 5:53 PM DB Tsai wrote: > If we decide to initialize Spark

Re: Scala 2.12 support

2018-06-07 Thread DB Tsai
If we decide to initialize Spark in `initializeSynchronous()` in Scala 2.11.12, it will look like the following which is odd. Using Scala version 2.11.12 (Java HotSpot(TM) 64-Bit Server VM, Java 1.8.0_161) Type in expressions to have them evaluated. Type :help for more information. scala> Spark

Re: Scala 2.12 support

2018-06-07 Thread Holden Karau
Tests can just be changed to accept either output too :p On Thu, Jun 7, 2018, 5:19 PM Dean Wampler wrote: > Do the tests expect a particular console output order? That would annoy > them. ;) You could sort the expected and output lines, then diff... > > > *Dean Wampler, Ph.D.* > > *VP, Fast

Re: Scala 2.12 support

2018-06-07 Thread Dean Wampler
Do the tests expect a particular console output order? That would annoy them. ;) You could sort the expected and output lines, then diff... *Dean Wampler, Ph.D.* *VP, Fast Data Engineering at Lightbend* Author: Programming Scala, 2nd Edition ,

Re: Scala 2.12 support

2018-06-07 Thread Dean Wampler
I'll point the Scala team to this issue, but it's unlikely to get fixed any time soon. dean *Dean Wampler, Ph.D.* *VP, Fast Data Engineering at Lightbend* Author: Programming Scala, 2nd Edition , Fast Data Architectures for Streaming

Re: Scala 2.12 support

2018-06-07 Thread DB Tsai
Thanks Felix for bringing this up. Currently, in Scala 2.11.8, we initialize the Spark by overriding loadFIles() before REPL sees any file since there is no good hook in Scala to load our initialization code. In Scala 2.11.12 and newer version of the Scala 2.12.x, loadFIles() method was

Re: Time for 2.2.2 release

2018-06-07 Thread Marcelo Vanzin
Took a look at our branch and most of the stuff that is not already in 2.2 are flaky test fixes, so +1. On Wed, Jun 6, 2018 at 7:54 AM, Tom Graves wrote: > Hello all, > > I think its time for another 2.2 release. > I took a look at Jira and I don't see anything explicitly targeted for 2.2.2 >

Re: Scala 2.12 support

2018-06-07 Thread Felix Cheung
+1 Spoke to Dean as well and mentioned the problem with 2.11.12 https://github.com/scala/bug/issues/10913 _ From: Sean Owen Sent: Wednesday, June 6, 2018 12:23 PM Subject: Re: Scala 2.12 support To: Holden Karau Cc: Dean Wampler , Reynold Xin , dev If it means

Re: Time for 2.2.2 release

2018-06-07 Thread Felix Cheung
+1 and thanks! From: Tom Graves Sent: Wednesday, June 6, 2018 7:54:43 AM To: Dev Subject: Time for 2.2.2 release Hello all, I think its time for another 2.2 release. I took a look at Jira and I don't see anything explicitly targeted for 2.2.2 that is not yet

Re: [build system] meet your build engineer @ spark ai summit SF 2018

2018-06-07 Thread Hyukjin Kwon
I regret that I couldn't make it to Spark Summit :(. 2018년 6월 6일 (수) 오전 3:25, Holden Karau 님이 작성: > That's awesome! > > On Tue, Jun 5, 2018 at 12:23 PM, shane knapp wrote: > >> just a reminder to come meet your build engineer! >> >> we'll also be having a couple of demos of current projects in