Re: [VOTE] Release Spark 2.4.8 (RC2)

2021-04-13 Thread Kent Yao
+1 (non-binding) Kent Yao @ Data Science Center, Hangzhou Research Institute, NetEase Corp.a spark 

Re: [VOTE] Release Spark 2.4.8 (RC2)

2021-04-13 Thread Gengliang Wang
+1 (non-binding) On Wed, Apr 14, 2021 at 1:34 PM Jungtaek Lim wrote: > +1 (non-binding) > > signature OK, extracting tgz files OK, build source without running tests > OK. > > On Tue, Apr 13, 2021 at 5:02 PM Herman van Hovell > wrote: > >> +1 >> >> On Tue, Apr 13, 2021 at 2:40 AM sarutak

Re: [VOTE] Release Spark 2.4.8 (RC2)

2021-04-13 Thread Jungtaek Lim
+1 (non-binding) signature OK, extracting tgz files OK, build source without running tests OK. On Tue, Apr 13, 2021 at 5:02 PM Herman van Hovell wrote: > +1 > > On Tue, Apr 13, 2021 at 2:40 AM sarutak wrote: > >> +1 (non-binding) >> >> > +1 >> > >> > On Tue, 13 Apr 2021, 02:58 Sean Owen,

Re: [PSA] Please read: PR builder now runs test and build in your forked repository

2021-04-13 Thread Gengliang Wang
Thanks for the amazing work, Hyukjin! I created a PR for trial and it looks well so far: https://github.com/apache/spark/pull/32158 On Wed, Apr 14, 2021 at 12:47 PM Hyukjin Kwon wrote: > Hi all, > > After https://github.com/apache/spark/pull/32092 merged, now we run the > GitHub Actions >

Re: [PSA] Please read: PR builder now runs test and build in your forked repository

2021-04-13 Thread Hyukjin Kwon
Hi all, After https://github.com/apache/spark/pull/32092 merged, now we run the GitHub Actions workflows in your forked repository. In short, please see this example HyukjinKwon#34 1. You create a PR and your repository triggers the workflow.

[PSA] Please read: PR builder now runs test and build in your forked repository

2021-04-13 Thread Hyukjin Kwon
Hi all, After https://github.com/apache/spark/pull/32092 merged, now we run the GitHub Actions workflows in your forked repository. In short, please see this example HyukjinKwon#34 1. You create a PR and your repository triggers the workflow.

Re: [DISCUSS] Build error message guideline

2021-04-13 Thread Yuming Wang
Do we have plans to apply these guidelines to assert? For example: https://github.com/apache/spark/blob/5b478416f8e3fe2f015af1b6c8faa7fe9f15c05d/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcUtils.scala#L136-L138

Re: [DISCUSS] Build error message guideline

2021-04-13 Thread Hyukjin Kwon
I would just go ahead and create a PR for that. Nothing written there looks unreasonable. But probably it should be best to wait a couple of days to make sure people are happy with it. 2021년 4월 14일 (수) 오전 6:38, Karen 님이 작성: > If the proposed guidelines look good, it would be useful to share

Re: [DISCUSS] Build error message guideline

2021-04-13 Thread Karen
If the proposed guidelines look good, it would be useful to share these guidelines with the wider community. A good landing page for contributors could be https://spark.apache.org/contributing.html. What do you think? Thank you, Karen Feng On Wed, Apr 7, 2021 at 8:19 PM Hyukjin Kwon wrote: >

Re: [VOTE] Release Spark 2.4.8 (RC2)

2021-04-13 Thread Herman van Hovell
+1 On Tue, Apr 13, 2021 at 2:40 AM sarutak wrote: > +1 (non-binding) > > > +1 > > > > On Tue, 13 Apr 2021, 02:58 Sean Owen, wrote: > > > >> +1 same result as last RC for me. > >> > >> On Mon, Apr 12, 2021, 12:53 AM Liang-Chi Hsieh > >> wrote: > >> > >>> Please vote on releasing the following