Re: [PSA] Please read: PR builder now runs test and build in your forked repository

I remember it's turned on by default (?). If not, yeah we should document. 2021년 4월 15일 (목) 오후 1:14, Kent Yao 님이 작성: > Thanks Hyukjin and Yikun, > > > 2. New Forks have to turn on GitHub action by the fork owner manually > > And we may still need a suitable place to make this note clearer to new

Re: [PSA] Please read: PR builder now runs test and build in your forked repository

Thanks Hyukjin and Yikun,> 2. New Forks have to turn on GitHub action by the fork owner manuallyAnd we may still need a suitable place to make this note clearer to new contributors or someone delete and re-fork their forked repo.Thanks

Re: [PSA] Please read: PR builder now runs test and build in your forked repository

The issue is fixed now. Please keep monitoring this. Thank you all! The spark community is super active and cooperative! 2021년 4월 15일 (목) 오전 11:01, Hyukjin Kwon 님이 작성: > The fix will be straightforward. We can either, in Github Actions > workflow,: > - remove fast forward option and see if ti

Re: [PSA] Please read: PR builder now runs test and build in your forked repository

The fix will be straightforward. We can either, in Github Actions workflow,: - remove fast forward option and see if ti works - or git rebase before merge the branch 2021년 4월 15일 (목) 오전 11:00, Hyukjin Kwon 님이 작성: > I think it works mostly correctly as Dongjoon investigated and shared > (Thanks a

Re: [PSA] Please read: PR builder now runs test and build in your forked repository

I think it works mostly correctly as Dongjoon investigated and shared (Thanks a lot!). One problem seems to be syncing to the master seems too strict ( https://github.com/apache/spark/pull/32168#issuecomment-819736508). Thanks Yikun. I think we should make it less strict. I can create a PR right

Re: [DISCUSS] Build error message guideline

+1 LGTM. On Thu, Apr 15, 2021 at 1:50 AM Karen wrote: > That makes sense to me - given that an assert failure throws an > AssertException, I would say that the same guidelines should apply for > asserts. > > On Tue, Apr 13, 2021 at 7:41 PM Yuming Wang wrote: > >> Do we have plans to apply

Re: please read: current state and the future of the apache spark build system

Thanks Shane for keeping the build infra structure running for all of these years :) I've got some Kubernetes infra on AS399306 down in HE in Fremont but it's also perhaps not of the newest variety, but so far no disk failures or anything like that (knock on wood of course). The catch is it's on

Re: please read: current state and the future of the apache spark build system

> > medium term (in 6 months): > * prepare jenkins worker ansible configs and stick in the spark repo > - nothing fancy, but enough to config ubuntu workers > - could be used to create docker containers for testing in > THE CLOUD > > fwiw, i just decided to bang this out today:

Re: [PSA] Please read: PR builder now runs test and build in your forked repository

Hi, Kent. I checked (1) in your PR, but those test result comments look correct to me. Please note that both Jenkins and GitHub Action leave the same number of comments on the same GitHash. Given that, there are not fake comments. It looks like a real result of your commits on that PR. GitHash:

Re: [VOTE] Release Spark 2.4.8 (RC2)

+1 (binding) DB Tsai | ACS Spark Core |  Apple, Inc. > On Apr 14, 2021, at 10:42 AM, Wenchen Fan wrote: > > +1 (binding) > > On Thu, Apr 15, 2021 at 12:22 AM Maxim Gekk > wrote: > +1 (non-binding) > > On Wed, Apr 14, 2021 at 6:39 PM Dongjoon Hyun

Re: [VOTE] Release Spark 2.4.8 (RC2)

+1 (binding) On Thu, Apr 15, 2021 at 12:22 AM Maxim Gekk wrote: > +1 (non-binding) > > On Wed, Apr 14, 2021 at 6:39 PM Dongjoon Hyun > wrote: > >> +1 >> >> Bests, >> Dongjoon. >> >> On Tue, Apr 13, 2021 at 10:38 PM Kent Yao wrote: >> >>> +1 (non-binding) >>> >>> *Kent Yao * >>> @ Data Science

Re: [PSA] Please read: PR builder now runs test and build in your forked repository

Hi ALL, here is something I notice after this change: 1. Github-actions notification could be wrong when another PR opened with some same commits, and you will get a lot of fake comments then. Meanwhile, the new PR get no comments, even if it is actually the chosen one. 1.1

Re: [SPARK-34738] issues w/k8s+minikube and PV tests

On Wed, Apr 14, 2021 at 10:32 AM Frank Luo wrote: > Is there any hard dependency on minkube? (i.e, GPU setting), kind ( > https://kind.sigs.k8s.io/) is a stabler and simpler k8s cluster env on a > single machine (only requires docker) , it been widely used by k8s projects > testing. > > there

Re: [SPARK-34738] issues w/k8s+minikube and PV tests

Is there any hard dependency on minkube? (i.e, GPU setting), kind ( https://kind.sigs.k8s.io/) is a stabler and simpler k8s cluster env on a single machine (only requires docker) , it been widely used by k8s projects testing. I am interested at looking into test code to understand this aspect,

[SPARK-34738] issues w/k8s+minikube and PV tests

please see: https://issues.apache.org/jira/browse/SPARK-34738 i could really use a hand. all k8s integration tests are currently broken, and i'd rather spend the time fixing the latest version of minikube, k8s and the docker virtualization layer than debug the 'old' way which uses the kvm2/qemu

Re: [VOTE] Release Spark 2.4.8 (RC2)

+1 (non-binding) On Wed, Apr 14, 2021 at 6:39 PM Dongjoon Hyun wrote: > +1 > > Bests, > Dongjoon. > > On Tue, Apr 13, 2021 at 10:38 PM Kent Yao wrote: > >> +1 (non-binding) >> >> *Kent Yao * >> @ Data Science Center, Hangzhou Research Institute, NetEase Corp. >> *a spark enthusiast* >> *kyuubi

Re: [VOTE] Release Spark 2.4.8 (RC2)

+1 Bests, Dongjoon. On Tue, Apr 13, 2021 at 10:38 PM Kent Yao wrote: > +1 (non-binding) > > *Kent Yao * > @ Data Science Center, Hangzhou Research Institute, NetEase Corp. > *a spark enthusiast* > *kyuubi is a unified multi-tenant JDBC > interface for

Re: [PSA] Please read: PR builder now runs test and build in your forked repository

Thank you again, Hyukjin. Bests, Dongjoon. On Wed, Apr 14, 2021 at 5:25 AM Kent Yao wrote: > Cool, thanks! > > Hyukjin Kwon 于2021年4月14日周三 下午8:19写道： > >> Good point! I had to clarify. >> Once is enough. The sync is needed for your branch to include the changes >> of

Re: [PSA] Please read: PR builder now runs test and build in your forked repository

Cool, thanks! Hyukjin Kwon 于2021年4月14日周三 下午8:19写道： > Good point! I had to clarify. > Once is enough. The sync is needed for your branch to include the changes > of https://github.com/apache/spark/pull/32092. > > > 2021년 4월 14일 (수) 오후 9:11, Kent Yao 님이 작성: > >> Hi Hyukjin, >> >> > Please sync

Re: [PSA] Please read: PR builder now runs test and build in your forked repository

Good point! I had to clarify. Once is enough. The sync is needed for your branch to include the changes of https://github.com/apache/spark/pull/32092. 2021년 4월 14일 (수) 오후 9:11, Kent Yao 님이 작성: > Hi Hyukjin, > > > Please sync your branch to the latest master branch in Apache Spark in > order for

Re: [PSA] Please read: PR builder now runs test and build in your forked repository

Hi Hyukjin,> Please sync your branch to the latest master branch in Apache Spark in order for the main repository to run the workflow and detect it. Do we need to sync master for every PR or just one-time cost to 

Re: [PSA] Please read: PR builder now runs test and build in your forked repository

Cool~Thanks, Hyukjin Yuanjian Li 于2021年4月14日周三 下午3:39写道： > Awesome! Thanks for making this happen, Hyukjin! > > Yi Wu 于2021年4月14日周三 下午2:51写道： > >> Thanks for the great work, Hyukjin! >> >> On Wed, Apr 14, 2021 at 1:00 PM Gengliang Wang wrote: >> >>> Thanks for the amazing work, Hyukjin! >>> I

Re: [PSA] Please read: PR builder now runs test and build in your forked repository

Awesome! Thanks for making this happen, Hyukjin! Yi Wu 于2021年4月14日周三 下午2:51写道： > Thanks for the great work, Hyukjin! > > On Wed, Apr 14, 2021 at 1:00 PM Gengliang Wang wrote: > >> Thanks for the amazing work, Hyukjin! >> I created a PR for trial and it looks well so far: >>

Re: [PSA] Please read: PR builder now runs test and build in your forked repository

Thanks for the great work, Hyukjin! On Wed, Apr 14, 2021 at 1:00 PM Gengliang Wang wrote: > Thanks for the amazing work, Hyukjin! > I created a PR for trial and it looks well so far: > https://github.com/apache/spark/pull/32158 > > On Wed, Apr 14, 2021 at 12:47 PM Hyukjin Kwon wrote: > >> Hi