Re: [DISCUSS] SPIP: Storage Partitioned Join for Data Source V2

2021-10-26 Thread Chao Sun
Thanks Cheng for the comments. > Is migrating Hive table read path to data source v2, being a prerequisite of this SPIP Yes, this SPIP only aims at DataSourceV2, so obviously it will help if Hive eventually moves to use V2 API. With that said, I think some of the ideas could be useful for V1

Re: [DISCUSS] SPIP: Storage Partitioned Join for Data Source V2

2021-10-26 Thread Erik Krogen
It's great to see this SPIP going live. Once this is complete, it will really help Spark to play nicely with a broader data ecosystem (Hive, Iceberg, Trino, etc.), and it's great to see that besides just bringing the existing bucketed-join support to V2, we are also making the types of

Re: [DISCUSS] SPIP: Storage Partitioned Join for Data Source V2

2021-10-26 Thread Cheng Su
+1 for this. This is exciting movement to efficiently read bucketed table from other systems (Hive, Trino & Presto)! Still looking at the details but having some early questions: 1. Is migrating Hive table read path to data source v2, being a prerequisite of this SPIP? Hive table read

Re: [DISCUSS] SPIP: Storage Partitioned Join for Data Source V2

2021-10-26 Thread Ryan Blue
Instead of commenting on the doc, could we keep discussion here on the dev list please? That way more people can follow it and there is more room for discussion. Comment threads have a very small area and easily become hard to follow. Ryan On Tue, Oct 26, 2021 at 9:32 AM John Zhuge wrote: > +1

Re: [DISCUSS] SPIP: Storage Partitioned Join for Data Source V2

2021-10-26 Thread John Zhuge
+1 Nicely done! On Tue, Oct 26, 2021 at 8:08 AM Chao Sun wrote: > Oops, sorry. I just fixed the permission setting. > > Thanks everyone for the positive support! > > On Tue, Oct 26, 2021 at 7:30 AM Wenchen Fan wrote: > >> +1 to this SPIP and nice writeup of the design doc! >> >> Can we open

Re: [DISCUSS] SPIP: Storage Partitioned Join for Data Source V2

2021-10-26 Thread Chao Sun
Oops, sorry. I just fixed the permission setting. Thanks everyone for the positive support! On Tue, Oct 26, 2021 at 7:30 AM Wenchen Fan wrote: > +1 to this SPIP and nice writeup of the design doc! > > Can we open comment permission in the doc so that we can discuss details > there? > > On Tue,

Re: [DISCUSS] SPIP: Storage Partitioned Join for Data Source V2

2021-10-26 Thread angers zhu
+1 on this, Wenchen Fan 于2021年10月26日周二 下午10:29写道: > +1 to this SPIP and nice writeup of the design doc! > > Can we open comment permission in the doc so that we can discuss details > there? > > On Tue, Oct 26, 2021 at 8:29 PM Hyukjin Kwon wrote: > >> Seems making sense to me. >> >> Would be

Re: [DISCUSS] SPIP: Storage Partitioned Join for Data Source V2

2021-10-26 Thread Wenchen Fan
+1 to this SPIP and nice writeup of the design doc! Can we open comment permission in the doc so that we can discuss details there? On Tue, Oct 26, 2021 at 8:29 PM Hyukjin Kwon wrote: > Seems making sense to me. > > Would be great to have some feedback from people such as @Wenchen Fan >

Re: [DISCUSS] SPIP: Storage Partitioned Join for Data Source V2

2021-10-26 Thread Hyukjin Kwon
Seems making sense to me. Would be great to have some feedback from people such as @Wenchen Fan @Cheng Su @angers zhu . On Tue, 26 Oct 2021 at 17:25, Dongjoon Hyun wrote: > +1 for this SPIP. > > On Sun, Oct 24, 2021 at 9:59 AM huaxin gao wrote: > >> +1. Thanks for lifting the current

Re: [DISCUSS] SPIP: Storage Partitioned Join for Data Source V2

2021-10-26 Thread Dongjoon Hyun
+1 for this SPIP. On Sun, Oct 24, 2021 at 9:59 AM huaxin gao wrote: > +1. Thanks for lifting the current restrictions on bucket join and making > this more generalized. > > On Sun, Oct 24, 2021 at 9:33 AM Ryan Blue wrote: > >> +1 from me as well. Thanks Chao for doing so much to get it to this