Re: [VOTE] Spark 2.3.1 (RC3)

2018-06-01 Thread Xiao Li
Sure, will send RM an email next time when I made a release-blocker change. Xiao 2018-06-01 13:32 GMT-07:00 Reynold Xin : > Yes everybody please cc the release manager on changes that merit -1. It's > high overhead and let's make this smoother. > > > On Fri, Jun 1, 2018 at 1:28 PM Marcelo

Re: [VOTE] Spark 2.3.1 (RC3)

2018-06-01 Thread Reynold Xin
Yes everybody please cc the release manager on changes that merit -1. It's high overhead and let's make this smoother. On Fri, Jun 1, 2018 at 1:28 PM Marcelo Vanzin wrote: > Xiao, > > This is the third time in this release cycle that this is happening. > Sorry to single out you guys, but can

Re: [VOTE] Spark 2.3.1 (RC3)

2018-06-01 Thread Marcelo Vanzin
Xiao, This is the third time in this release cycle that this is happening. Sorry to single out you guys, but can you please do two things: - do not merge things in 2.3 you're not absolutely sure about - make sure that things you backport to 2.3 are not causing problems - let the RM know about

Re: [VOTE] Spark 2.3.1 (RC3)

2018-06-01 Thread Xiao Li
Based on the plan, the changes in that PR added the extra Aggregate and Expand for common queries: SELECT sum(DISTINCT x), avg(DISTINCT x) FROM tab Both Aggregate and Expand are expensive operators. 2018-06-01 13:24 GMT-07:00 Sean Owen : > Hm, that was merged two days ago, and you decided to

Re: [VOTE] Spark 2.3.1 (RC3)

2018-06-01 Thread Sean Owen
Hm, that was merged two days ago, and you decided to revert it 2 hours ago. It sounds like this was maybe risky to put into 2.3.x during the RC phase, at least. You also don't seem certain whether there's a performance problem; how sure are you? These may all have been the right thing to do

Re: [VOTE] Spark 2.3.1 (RC3)

2018-06-01 Thread Xiao Li
Sorry, I need to say -1 This morning, just found a regression in 2.3.1 and reverted https://github.com/apache/spark/pull/21443 Xiao 2018-06-01 13:09 GMT-07:00 Marcelo Vanzin : > Please vote on releasing the following candidate as Apache Spark version > 2.3.1. > > Given that I expect at least a

[VOTE] Spark 2.3.1 (RC3)

2018-06-01 Thread Marcelo Vanzin
Please vote on releasing the following candidate as Apache Spark version 2.3.1. Given that I expect at least a few people to be busy with Spark Summit next week, I'm taking the liberty of setting an extended voting period. The vote will be open until Friday, June 8th, at 19:00 UTC (that's 12:00