Re: Disabling `Merge Commits` from GitHub Merge Button

2019-07-02 Thread Wenchen Fan
+1 as well On Tue, Jul 2, 2019 at 12:13 PM Dongjoon Hyun wrote: > Thank you so much for the replies, Reynold, Sean, Takeshi, Hyukjin! > > Bests, > Dongjoon. > > On Mon, Jul 1, 2019 at 6:00 PM Hyukjin Kwon wrote: > >> +1 >> >> 2019년 7월 2일 (화) 오전 9:39, Takeshi Yamamuro 님이 작성: >> >>> I'm also

Re: Disabling `Merge Commits` from GitHub Merge Button

2019-07-01 Thread Dongjoon Hyun
Thank you so much for the replies, Reynold, Sean, Takeshi, Hyukjin! Bests, Dongjoon. On Mon, Jul 1, 2019 at 6:00 PM Hyukjin Kwon wrote: > +1 > > 2019년 7월 2일 (화) 오전 9:39, Takeshi Yamamuro 님이 작성: > >> I'm also using the script in both cases, anyway +1. >> >> On Tue, Jul 2, 2019 at 5:58 AM Sean

Re: Disabling `Merge Commits` from GitHub Merge Button

2019-07-01 Thread Hyukjin Kwon
+1 2019년 7월 2일 (화) 오전 9:39, Takeshi Yamamuro 님이 작성: > I'm also using the script in both cases, anyway +1. > > On Tue, Jul 2, 2019 at 5:58 AM Sean Owen wrote: > >> I'm using the merge script in both repos. I think that was the best >> practice? >> So, sure, I'm fine with disabling it. >> >> On

Re: Disabling `Merge Commits` from GitHub Merge Button

2019-07-01 Thread Takeshi Yamamuro
I'm also using the script in both cases, anyway +1. On Tue, Jul 2, 2019 at 5:58 AM Sean Owen wrote: > I'm using the merge script in both repos. I think that was the best > practice? > So, sure, I'm fine with disabling it. > > On Mon, Jul 1, 2019 at 3:53 PM Dongjoon Hyun > wrote: > > > > Hi,

Re: Disabling `Merge Commits` from GitHub Merge Button

2019-07-01 Thread Sean Owen
I'm using the merge script in both repos. I think that was the best practice? So, sure, I'm fine with disabling it. On Mon, Jul 1, 2019 at 3:53 PM Dongjoon Hyun wrote: > > Hi, Apache Spark PMC members and committers. > > We are using GitHub `Merge Button` in `spark-website` repository > because

Re: Disabling `Merge Commits` from GitHub Merge Button

2019-07-01 Thread Reynold Xin
That's a good idea. We should only be using squash. On Mon, Jul 01, 2019 at 1:52 PM, Dongjoon Hyun < dongjoon.h...@gmail.com > wrote: > > Hi, Apache Spark PMC members and committers. > > > We are using GitHub `Merge Button` in `spark-website` repository > because it's very convenient. > >

Disabling `Merge Commits` from GitHub Merge Button

2019-07-01 Thread Dongjoon Hyun
Hi, Apache Spark PMC members and committers. We are using GitHub `Merge Button` in `spark-website` repository because it's very convenient. 1. https://github.com/apache/spark-website/commits/asf-site 2. https://github.com/apache/spark/commits/master In order to be consistent with our