Re: Running lint-java during PR builds?

gt; backed up since - if I recall - all of ASF shares one queue. > >> > >> At the number of PRs Spark has this could be a big issue. > >> > >> > >> ____________ > >> From: Marcelo Vanzin <van...@cloudera.com> > >> Sent: Monday, May 21, 2018 9:08:28 AM > &g

Re: Running lint-java during PR builds?

ince - if I recall - all of ASF shares one queue. >> >> At the number of PRs Spark has this could be a big issue. >> >> >> >> From: Marcelo Vanzin <van...@cloudera.com> >> Sent: Monday, May 21, 2018 9:08:28 AM >&

Re: Running lint-java during PR builds?

lume of test runs on Travis. >>> > >>> > In ASF projects Travis could get significantly >>> > backed up since - if I recall - all of ASF shares one queue. >>> > >>> > At the number of PRs Spark has this could be a big issue. >>> > >>

Re: Running lint-java during PR builds?

s could be a big issue. >> > >> > >> > >> > From: Marcelo Vanzin <van...@cloudera.com> >> > Sent: Monday, May 21, 2018 9:08:28 AM >> > To: Hyukjin Kwon >> > Cc: Dongjoon Hyun; dev >> > Subject:

Re: Running lint-java during PR builds?

; > At the number of PRs Spark has this could be a big issue. > > > > > > > > From: Marcelo Vanzin <van...@cloudera.com> > > Sent: Monday, May 21, 2018 9:08:28 AM > > To: Hyukjin Kwon > > Cc: Dongjoon Hyun; dev > > Subject: Re: Running lint-

Re: Running lint-java during PR builds?

Cc: Dongjoon Hyun; dev > Subject: Re: Running lint-java during PR builds? > > I'm fine with it. I tried to use the existing checkstyle sbt plugin > (trying to fix SPARK-22269), but it depends on an ancient version of > checkstyle, and I don't know sbt enough to figure out how to h

Re: Running lint-java during PR builds?

van...@cloudera.com> Sent: Monday, May 21, 2018 9:08:28 AM To: Hyukjin Kwon Cc: Dongjoon Hyun; dev Subject: Re: Running lint-java during PR builds? I'm fine with it. I tried to use the existing checkstyle sbt plugin (trying to fix SPARK-22269), but it depends on an ancient version of checkstyle, and I don't kn

Re: Running lint-java during PR builds?

I'm fine with it. I tried to use the existing checkstyle sbt plugin (trying to fix SPARK-22269), but it depends on an ancient version of checkstyle, and I don't know sbt enough to figure out how to hack classpaths and class loaders when applying rules, so gave up. On Mon, May 21, 2018 at 1:47 AM,

Re: Running lint-java during PR builds?

I am going to open an INFRA JIRA if there's no explicit objection in few days. 2018-05-21 13:09 GMT+08:00 Hyukjin Kwon : > I would like to revive this proposal. Travis CI. Shall we give this try? I > think it's worth trying it. > > 2016-11-17 3:50 GMT+08:00 Dongjoon Hyun

Re: Running lint-java during PR builds?

I would like to revive this proposal. Travis CI. Shall we give this try? I think it's worth trying it. 2016-11-17 3:50 GMT+08:00 Dongjoon Hyun : > Hi, Marcelo and Ryan. > > That was the main purpose of my proposal about Travis.CI. > IMO, that is the only way to achieve that

Re: Running lint-java during PR builds?

Hi, Marcelo and Ryan. That was the main purpose of my proposal about Travis.CI. IMO, that is the only way to achieve that without any harmful side-effect on Jenkins infra. Spark is already ready for that. Like AppVoyer, if one of you files an INFRA jira issue to enable that, they will turn on

Re: Running lint-java during PR builds?

I remember it's because you need to run `mvn install` before running lint-java if the maven cache is empty, and `mvn install` is pretty heavy. On Tue, Nov 15, 2016 at 1:21 PM, Marcelo Vanzin wrote: > Hey all, > > Is there a reason why lint-java is not run during PR builds?