Re: Scala 2.12 support

2018-06-21 Thread Stavros Kontopoulos
Hi all, Scala team @Lightbend (Lukas, Adriaan, Jason) and I, have worked for a couple of days now on this. We have captured current status and possible solutions for the remaining two issues here: https://docs.google.com/document/d/ 1fbkjEL878witxVQpOCbjlvOvadHtVjYXeB-2mgzDTvk Please review the

Re: Scala 2.12 support

2018-06-07 Thread Sean Owen
When I updated for Scala 2.12, I was able to remove almost all the 2.11-2.12 differences. There are still already two source trees for 2.11 vs 2.12. I mean that if it's necessary to accommodate differences between the two, it's already set up for that, and there aren't a mess of differences to

Re: Scala 2.12 support

2018-06-07 Thread DB Tsai
>>> work for older version of Scala too. >> >>>>>> >> >>>>>> However, in the newer version of Scala, the first thing that the >> REPL >> >>>>>> calls is printWelcome, so in the newer version of Scala, welcome >> mes

Re: Scala 2.12 support

2018-06-07 Thread Holden Karau
work for newer version of Scala since in order version >>>>> of Scala, printWelcome is called in the end of the initialization process. >>>>> If we decide to go this route, basically users can not use Scala older >>>>> than >>>>> 2.11.9. >>>>>

Re: Scala 2.12 support

2018-06-07 Thread DB Tsai
oot cause and provide a stable hook for > 3rd party developers to initialize their custom code. > > DB Tsai | Siri Open Source Technologies [not a contribution] |  Apple, > Inc > > > On Jun 7, 2018, at 6:43 AM, Felix Cheung > <mailto:felixcheun...@hotmail.com>

Re: Scala 2.12 support

2018-06-07 Thread Holden Karau
newer version of Scala 2.12.x has the same issue. >>>> >>>> In my opinion, Scala should fix the root cause and provide a stable >>>> hook for 3rd party developers to initialize their custom code. >>>> >>>> DB Tsai | Siri Open Source T

Re: Scala 2.12 support

2018-06-07 Thread Dean Wampler
> >>> In my opinion, Scala should fix the root cause and provide a stable hook >>> for 3rd party developers to initialize their custom code. >>> >>> DB Tsai | Siri Open Source Technologies [not a contribution] |  >>> Apple, Inc >>> >>> > On Jun 7, 2018, at 6:43 AM, Feli

Re: Scala 2.12 support

2018-06-07 Thread Dean Wampler
to Dean as well and mentioned the problem with 2.11.12 > https://github.com/scala/bug/issues/10913 > > > > _ > > From: Sean Owen > > Sent: Wednesday, June 6, 2018 12:23 PM > > Subject: Re: Scala 2.12 support > > To: Holden Karau >

Re: Scala 2.12 support

2018-06-07 Thread DB Tsai
dnesday, June 6, 2018 12:23 PM > Subject: Re: Scala 2.12 support > To: Holden Karau > Cc: Dean Wampler , Reynold Xin , > dev > > > If it means no change to 2.11 support, seems OK to me for Spark 2.4.0. The > 2.12 support is separate and has never been mutually compat

Re: Scala 2.12 support

2018-06-07 Thread Felix Cheung
+1 Spoke to Dean as well and mentioned the problem with 2.11.12 https://github.com/scala/bug/issues/10913 _ From: Sean Owen Sent: Wednesday, June 6, 2018 12:23 PM Subject: Re: Scala 2.12 support To: Holden Karau Cc: Dean Wampler , Reynold Xin , dev If it means

Re: Scala 2.12 support

2018-06-06 Thread Sean Owen
If it means no change to 2.11 support, seems OK to me for Spark 2.4.0. The 2.12 support is separate and has never been mutually compatible with 2.11 builds anyway. (I also hope, suspect that the changes are minimal; tests are already almost entirely passing with no change to the closure cleaner

Re: Scala 2.12 support

2018-06-06 Thread DW @ Gmail
I feel good ;) I know there is a lot of interest among Spark users. Since the compiler change won’t force a Spark API change, can we target Spark 2.4? Sent from my rotary phone. > On Jun 6, 2018, at 11:33 AM, Holden Karau wrote: > > Just chatted with Dean @ the summit and it sounds like

Re: Scala 2.12 support

2018-06-06 Thread Holden Karau
Just chatted with Dean @ the summit and it sounds like from Adriaan there is a fix in 2.13 for the API change issue that could be back ported to 2.12 so how about we try and get this ball rolling? It sounds like it would also need a closure cleaner change, which could be backwards compatible but

Re: Scala 2.12 support

2018-04-21 Thread Dean Wampler
Hi, Reynold, Sorry for the delay in replying; I was traveling. The Scala changes would avoid the need to change the API now. Basically, the compiler would be modified to detect the particular case of the two ambiguous, overloaded methods, then pick the best fit in a more "intelligent" way. (They

Scala 2.12 support

2018-04-19 Thread Reynold Xin
Forking the thread to focus on Scala 2.12. Dean, There are couple different issues with Scala 2.12 (closure cleaner, API breaking changes). Which one do you think we can address with a Scala upgrade? (The closure cleaner one I haven't spent a lot of time looking at it but it might involve more