Re: bazel and external/

2022-03-22 Thread Jungtaek Lim
vely a rename. I don't have a strong opinion, just wanted to avoid >>>>> the external directory to become/remain miscellaneous one. >>>>> >>>>> On Fri, Mar 18, 2022 at 10:04 AM Sean Owen wrote: >>>>> >>>>>> I sympathize, but mi

Re: bazel and external/

2022-03-22 Thread Alkis Evlogimenos
I don't have a strong opinion, just wanted to avoid >>>> the external directory to become/remain miscellaneous one. >>>> >>>> On Fri, Mar 18, 2022 at 10:04 AM Sean Owen wrote: >>>> >>>>> I sympathize, but might be less change to

Re: bazel and external/

2022-03-21 Thread Alkis Evlogimenos
>> the external directory to become/remain miscellaneous one. >>> >>> On Fri, Mar 18, 2022 at 10:04 AM Sean Owen wrote: >>> >>>> I sympathize, but might be less change to just rename the dir. There is >>>> more in there like the avro reader;

Re: bazel and external/

2022-03-21 Thread Wenchen Fan
nd of miscellaneous. I think we >>> might want fewer rather than more top level dirs. >>> >>> On Thu, Mar 17, 2022 at 7:33 PM Jungtaek Lim < >>> kabhwan.opensou...@gmail.com> wrote: >>> >>>> We seem to just focus on how to avoid the conf

Re: bazel and external/

2022-03-19 Thread Alkis Evlogimenos
e avro reader; it's kind of miscellaneous. I think we >> might want fewer rather than more top level dirs. >> >> On Thu, Mar 17, 2022 at 7:33 PM Jungtaek Lim < >> kabhwan.opensou...@gmail.com> wrote: >> >>> We seem to just focus on how to avoid the c

Re: bazel and external/

2022-03-17 Thread Jungtaek Lim
rs. > > On Thu, Mar 17, 2022 at 7:33 PM Jungtaek Lim > wrote: > >> We seem to just focus on how to avoid the conflict with the name >> "external" used in bazel. Since we consider the possibility of renaming, >> why not revisit the modules "external" conta

Re: bazel and external/

2022-03-17 Thread Sean Owen
oid the conflict with the name > "external" used in bazel. Since we consider the possibility of renaming, > why not revisit the modules "external" contains? > > Looks like kinds of the modules external directory contains are 1) Docker > 2) Connectors 3) Sink on

Re: bazel and external/

2022-03-17 Thread Jungtaek Lim
We seem to just focus on how to avoid the conflict with the name "external" used in bazel. Since we consider the possibility of renaming, why not revisit the modules "external" contains? Looks like kinds of the modules external directory contains are 1) Docker 2) Connectors 3

Re: bazel and external/

2022-03-17 Thread Dongjoon Hyun
Thank you for posting this, Alkis. Before the question (1) and (2), I'm curious if the Apache Spark community has other downstreams using Bazel. To All. If there are some Bazel users with Apache Spark code, could you share your practice? If you are using renaming, what is your renamed directory

Re: bazel and external/

2022-03-17 Thread Alkis Evlogimenos
AFAIK there is not. `external` has been baked in bazel since the beginning and there is no plan from bazel devs to attempt to fix this . On Thu, Mar 17, 2022 at 7:52 PM Sean Owen wrote: > Just checking - there is no way to

Re: bazel and external/

2022-03-17 Thread Sean Owen
Just checking - there is no way to tell bazel to look somewhere else for whatever 'external' means to it? It's a kinda big ugly change but it's not a functional change. If anything it might break some downstream builds that rely on the current structure too. But such is life for developers? I

bazel and external/

2022-03-17 Thread Alkis Evlogimenos
Hi Spark devs. The Apache Spark repo has a top level external/ directory. This is a reserved name for the bazel build system and it causes all sorts of problems: some can be worked around and some cannot (for some details on one that cannot see