I like the `/* .. */` style more. Because it is easier for IDEs to
recognize it as a block comment. If you press enter in the comment
block with the `//` style, IDEs won't add `//` for you. -Xiangrui
On Wed, Feb 4, 2015 at 2:15 PM, Reynold Xin r...@databricks.com wrote:
We should update the
Btw, I think allowing `/* ... */` without the leading `*` in lines is
also useful. Check this line:
https://github.com/apache/spark/pull/4259/files#diff-e9dcb3b5f3de77fc31b3aff7831110eaR55,
where we put the R commands that can reproduce the test result. It is
easier if we write in the following
Clearly there isn't a strictly optimal commenting format (pro's and
cons for both '//' and '/*'). My thought is for consistency we should
just chose one and put in the style guide.
On Mon, Feb 9, 2015 at 12:25 PM, Xiangrui Meng men...@gmail.com wrote:
Btw, I think allowing `/* ... */` without
Why don't we just pick // as the default (by encouraging it in the style
guide), since it is mostly used, and then do not disallow /* */? I don't
think it is that big of a deal to have slightly deviations here since it is
dead simple to understand what's going on.
On Mon, Feb 9, 2015 at 1:33 PM,
+1 to what Andrew said, I think both make sense in different situations and
trusting developer discretion here is reasonable.
On Mon, Feb 9, 2015 at 1:48 PM, Andrew Or and...@databricks.com wrote:
In my experience I find it much more natural to use // for short multi-line
comments (2 or 3
In my experience I find it much more natural to use // for short multi-line
comments (2 or 3 lines), and /* */ for long multi-line comments involving
one or more paragraphs. For short multi-line comments, there is no reason
not to use // if it just so happens that your first line exceeded 100
We should update the style doc to reflect what we have in most places
(which I think is //).
On Wed, Feb 4, 2015 at 2:09 PM, Shivaram Venkataraman
shiva...@eecs.berkeley.edu wrote:
FWIW I like the multi-line // over /* */ from a purely style standpoint.
The Google Java style guide[1] has
Personally I have no opinion, but agree it would be nice to standardize.
- Patrick
On Wed, Feb 4, 2015 at 1:58 PM, Sean Owen so...@cloudera.com wrote:
One thing Marcelo pointed out to me is that the // style does not
interfere with commenting out blocks of code with /* */, which is a
small
FWIW I like the multi-line // over /* */ from a purely style standpoint.
The Google Java style guide[1] has some comment about code formatting tools
working better with /* */ but there doesn't seem to be any strong arguments
for one over the other I can find
Thanks
Shivaram
[1]
