Re: scalastyle annoys me a little bit

2014-10-24 Thread Koert Kuipers
thanks ted. apologies for complaining about maven here again, but this is the first time i seriously use it for development, and i am completely unfamiliar with it. a few more issues: mvn clean package -DskipTests takes about 30 mins for me. thats painful since its needed for the tests. does

Re: scalastyle annoys me a little bit

2014-10-24 Thread Koert Kuipers
oh i found some stuff about tests and how to continue them, gonna try that now (-fae switch). should have googled before asking... On Fri, Oct 24, 2014 at 3:59 PM, Koert Kuipers ko...@tresata.com wrote: thanks ted. apologies for complaining about maven here again, but this is the first time

Re: scalastyle annoys me a little bit

2014-10-24 Thread Marcelo Vanzin
On Fri, Oct 24, 2014 at 12:59 PM, Koert Kuipers ko...@tresata.com wrote: mvn clean package -DskipTests takes about 30 mins for me. thats painful since its needed for the tests. does anyone know any tricks to speed it up? (besides getting a better laptop). does zinc help? I noticed this too,

Re: scalastyle annoys me a little bit

2014-10-24 Thread Sean Owen
On Fri, Oct 24, 2014 at 8:59 PM, Koert Kuipers ko...@tresata.com wrote: mvn clean package -DskipTests takes about 30 mins for me. thats painful since its needed for the tests. does anyone know any tricks to speed it up? (besides getting a better laptop). does zinc help? Zinc helps by about

Re: scalastyle annoys me a little bit

2014-10-24 Thread Stephen Boesch
Sean Owen beat me to (strongly) recommending running zinc server. Using the -pl option is great too - but be careful to only use it when your work is restricted to the modules in the (comma separated) list you provide to -pl. Also before using -pl you should do a mvn compile package install on

Re: scalastyle annoys me a little bit

2014-10-24 Thread Koert Kuipers
thanks everyone, very helpful On Fri, Oct 24, 2014 at 4:22 PM, Stephen Boesch java...@gmail.com wrote: Sean Owen beat me to (strongly) recommending running zinc server. Using the -pl option is great too - but be careful to only use it when your work is restricted to the modules in the (comma

scalastyle annoys me a little bit

2014-10-23 Thread Koert Kuipers
100 max width seems very restrictive to me. even the most restrictive environment i have for development (ssh with emacs) i get a lot more characters to work with than that. personally i find the code harder to read, not easier. like i kept wondering why there are weird newlines in the middle of

Re: scalastyle annoys me a little bit

2014-10-23 Thread Patrick Wendell
Hey Koert, I think disabling the style checks in maven package could be a good idea for the reason you point out. I was sort of mixed on that when it was proposed for this exact reason. It's just annoying to developers. In terms of changing the global limit, this is more religion than anything

Re: scalastyle annoys me a little bit

2014-10-23 Thread Marcelo Vanzin
I know this is all very subjective, but I find long lines difficult to read. I also like how 100 characters fit in my editor setup fine (split wide screen), while a longer line length would mean I can't have two buffers side-by-side without horizontal scrollbars. I think it's fine to add a

Re: scalastyle annoys me a little bit

2014-10-23 Thread Ted Yu
Koert: Have you tried adding the following on your commandline ? -Dscalastyle.failOnViolation=false Cheers On Thu, Oct 23, 2014 at 11:07 AM, Patrick Wendell pwend...@gmail.com wrote: Hey Koert, I think disabling the style checks in maven package could be a good idea for the reason you

Re: scalastyle annoys me a little bit

2014-10-23 Thread Koert Kuipers
Hey Ted, i tried: mvn clean package -DskipTests -Dscalastyle.failOnViolation=false no luck, still get [ERROR] Failed to execute goal org.scalastyle:scalastyle-maven-plugin:0.4.0:check (default) on project spark-core_2.10: Failed during scalastyle execution: You have 3 Scalastyle violation(s). -

Re: scalastyle annoys me a little bit

2014-10-23 Thread Ted Yu
Koert: If you have time, you can try this diff - with which you would be able to specify the following on the command line: -Dscalastyle.failonviolation=false diff --git a/pom.xml b/pom.xml index 687cc63..108585e 100644 --- a/pom.xml +++ b/pom.xml @@ -123,6 +123,7 @@

Re: scalastyle annoys me a little bit

2014-10-23 Thread Koert Kuipers
great thanks i will do that On Thu, Oct 23, 2014 at 3:55 PM, Ted Yu yuzhih...@gmail.com wrote: Koert: If you have time, you can try this diff - with which you would be able to specify the following on the command line: -Dscalastyle.failonviolation=false diff --git a/pom.xml b/pom.xml

Re: scalastyle annoys me a little bit

2014-10-23 Thread Ted Yu
Created SPARK-4066 and attached patch there. On Thu, Oct 23, 2014 at 1:07 PM, Koert Kuipers ko...@tresata.com wrote: great thanks i will do that On Thu, Oct 23, 2014 at 3:55 PM, Ted Yu yuzhih...@gmail.com wrote: Koert: If you have time, you can try this diff - with which you would be able