Re: [VOTE] SPARK 2.4.0 (RC5)

2018-10-31 Thread Dongjoon Hyun
+1 Cheers, Dongjoon.

Re: [VOTE] SPARK 2.4.0 (RC5)

2018-10-31 Thread Felix Cheung
+1 Checked R doc and all R API changes From: Denny Lee Sent: Wednesday, October 31, 2018 9:13 PM To: Chitral Verma Cc: Wenchen Fan; dev@spark.apache.org Subject: Re: [VOTE] SPARK 2.4.0 (RC5) +1 On Wed, Oct 31, 2018 at 12:54 PM Chitral Verma

Re: [VOTE] SPARK 2.4.0 (RC5)

2018-10-31 Thread Denny Lee
+1 On Wed, Oct 31, 2018 at 12:54 PM Chitral Verma wrote: > +1 > > On Wed, 31 Oct 2018 at 11:56, Reynold Xin wrote: > >> +1 >> >> Look forward to the release! >> >> >> >> On Mon, Oct 29, 2018 at 3:22 AM Wenchen Fan wrote: >> >>> Please vote on releasing the following candidate as Apache Spark

Re: [VOTE] SPARK 2.4.0 (RC5)

2018-10-31 Thread Reynold Xin
+1 Look forward to the release! On Mon, Oct 29, 2018 at 3:22 AM Wenchen Fan wrote: > Please vote on releasing the following candidate as Apache Spark version > 2.4.0. > > The vote is open until November 1 PST and passes if a majority +1 PMC > votes are cast, with > a minimum of 3 +1 votes. >

Re: [VOTE] SPARK 2.4.0 (RC5)

2018-10-31 Thread Marcelo Vanzin
+1 On Mon, Oct 29, 2018 at 3:22 AM Wenchen Fan wrote: > > Please vote on releasing the following candidate as Apache Spark version > 2.4.0. > > The vote is open until November 1 PST and passes if a majority +1 PMC votes > are cast, with > a minimum of 3 +1 votes. > > [ ] +1 Release this package

Re: DataSourceV2 hangouts sync

2018-10-31 Thread Arun Mahadevan
Thanks for bringing up the custom metrics API in the list, its something that needs to be addressed. A couple more items worth considering, 1. Possibility to unify the batch, micro-batch and continuous sources. (similar to SPARK-25000) Right now now there is significant code duplication even

Re: python lint is broken on master branch

2018-10-31 Thread Wenchen Fan
Cool! Thanks Shane! On Wed, Oct 31, 2018 at 11:24 PM shane knapp wrote: > flake8 was at 3.6.0 on amp-jenkins-staging-worker-01, so i downgraded to > 3.5.0 and we're green: > > https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Compile/job/spark-master-lint/9082/console > > checked the

Re: python lint is broken on master branch

2018-10-31 Thread shane knapp
flake8 was at 3.6.0 on amp-jenkins-staging-worker-01, so i downgraded to 3.5.0 and we're green: https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Compile/job/spark-master-lint/9082/console checked the rest of the ubuntu workers and they were fine. On Wed, Oct 31, 2018 at 7:59 AM shane

Re: python lint is broken on master branch

2018-10-31 Thread shane knapp
yeah, that's what it is. thought i'd fixed that. looking now. On Wed, Oct 31, 2018 at 6:09 AM Sean Owen wrote: > Maybe a pycodestyle or flake8 version issue? > On Wed, Oct 31, 2018 at 7:43 AM Wenchen Fan wrote: > > > > The Jenkins job spark-master-lint keeps failing. The error message is > >

Re: python lint is broken on master branch

2018-10-31 Thread Sean Owen
Maybe a pycodestyle or flake8 version issue? On Wed, Oct 31, 2018 at 7:43 AM Wenchen Fan wrote: > > The Jenkins job spark-master-lint keeps failing. The error message is > flake8.exceptions.FailedToLoadPlugin: Flake8 failed to load plugin > "pycodestyle.break_after_binary_operator" due to

python lint is broken on master branch

2018-10-31 Thread Wenchen Fan
The Jenkins job spark-master-lint keeps failing. The error message is flake8.exceptions.FailedToLoadPlugin: Flake8 failed to load plugin "pycodestyle.break_after_binary_operator" due to 'module' object has no attribute 'break_after_binary_operator'. flake8 checks failed. As an example please see