Re: Automated formatting

2018-11-22 Thread Matei Zaharia
Can we start by just recommending to contributors that they do this manually? Then if it seems to work fine, we can try to automate it. > On Nov 22, 2018, at 4:40 PM, Cody Koeninger wrote: > > I believe scalafmt only works on scala sources. There are a few > plugins for formatting java

Re: Automated formatting

2018-11-22 Thread Cody Koeninger
I believe scalafmt only works on scala sources. There are a few plugins for formatting java sources, but I'm less familiar with them. On Thu, Nov 22, 2018 at 11:39 AM Mridul Muralidharan wrote: > > Is this handling only scala or java as well ? > > Regards, > Mridul > > On Thu, Nov 22, 2018 at

Re: Automated formatting

2018-11-22 Thread Mridul Muralidharan
Is this handling only scala or java as well ? Regards, Mridul On Thu, Nov 22, 2018 at 9:11 AM Cody Koeninger wrote: > Plugin invocation is ./build/mvn mvn-scalafmt_2.12:format > > It takes about 5 seconds, and errors out on the first different file > that doesn't match formatting. > > I made a

Re: Automated formatting

2018-11-22 Thread Cody Koeninger
Plugin invocation is ./build/mvn mvn-scalafmt_2.12:format It takes about 5 seconds, and errors out on the first different file that doesn't match formatting. I made a shell wrapper so that contributors can just run ./dev/scalafmt to actually format in place the files that have changed (or pass