Re: TagHandler design for tag implementations (was Re: JXP Template support?)

2006-10-19 Thread Ted Husted
On 10/18/06, Don Brown [EMAIL PROTECTED] wrote: I'm wondering if we shouldn't go in new direction to improve the tags Looking at the freemarker templates, the ratio of Freemarker code to HTML is probably 1.5, which leads me to wonder why we are using a template language at all. There is

Subversion keyword expansion warning

2006-10-19 Thread Antonio Petrelli
Dear all David H. DeWolf and I stumbled in a pretty-serious problem with Subversion, already filed as a bug: http://subversion.tigris.org/issues/show_bug.cgi?id=1663 It seems that, under certain circumstances, SVN's keywords are not expanded. In particular we had problem preparing patches,

Re: Subversion keyword expansion warning

2006-10-19 Thread Antonio Petrelli
Antonio Petrelli ha scritto: Dear all David H. DeWolf and I stumbled in a pretty-serious problem with Subversion, already filed as a bug: http://subversion.tigris.org/issues/show_bug.cgi?id=1663 It seems that, under certain circumstances, SVN's keywords are not expanded. In particular we had

Re: [tiles2] TilesContextFactory refactor

2006-10-19 Thread David H. DeWolf
Antonio Petrelli wrote: David H. DeWolf ha scritto: 1) TilesContext is refactored into two different contexts - TilesContext and TilesRequestContext. Only one instance of the TilesContext should exist within the application and it will be used to provide application scoped functions (e.g.

Re: [tiles2] TilesContextFactory refactor

2006-10-19 Thread Greg Reddin
On Oct 19, 2006, at 10:24 AM, David H. DeWolf wrote: Antonio Petrelli wrote: David H. DeWolf ha scritto: 1) TilesContext is refactored into two different contexts - TilesContext and TilesRequestContext. Only one instance of the TilesContext should exist within the application and it

Re: TagHandler design for tag implementations (was Re: JXP Template support?)

2006-10-19 Thread Don Brown
Martin Cooper wrote: Hmm, this is starting to look like it would if you used ECS: http://jakarta.apache.org/ecs/index.html Well, DOM is to SAX as ECS is to a TagHandler. While both are trying to create HTML, ECS creates an object for every element, which is a lot to maintain and takes more

Re: ajax tags

2006-10-19 Thread Musachy Barroso
I picked WW-205, (https://issues.apache.org/struts/browse/WW-205) to start playing with and I have replaced the tabbedpanel implementation with dojo's implementation, so far I have the static and dynamic tabs working. I was having so much fun that I didn't stop to ask if this is what you guys

Re: ajax tags

2006-10-19 Thread Don Brown
Cool! Any chance it fixes other tickets like WW-1371? Do you think this should be a new tag or replace the existing? What are the advantages of the new implementation? Don Musachy Barroso wrote: I picked WW-205, (https://issues.apache.org/struts/browse/WW-205) to start playing with and I

Re: ajax tags

2006-10-19 Thread Musachy Barroso
Well, dojo's has some of nice things out of the box(they are just hard to figure out given the amount of documentation), tabs can placed on any of the sides, you can have close buttons on the tabs, (either on the tab or on a corner, firefox-style), and they look a lot better by default ;)

s:datepicker in Struts 2

2006-10-19 Thread Matt Raible
I'm trying to upgrade Equinox (http://equinox.dev.java.net) to Struts 2. So far, the only major issue I've found is the datepicker component doesn't seem to work. It looks like it's using dojo, but dojo is never included in the head. Is there a tag I need to do add to get dojo included? Below

Re: ajax tags

2006-10-19 Thread Don Brown
Ok, I guess my next question is does the tag provide anything significant on top of Dojo? If we are a simple wrapper for Dojo, it might not be worth continuing to support the tabbed pane tag. What do you think? Don Musachy Barroso wrote: Well, dojo's has some of nice things out of the

Re: s:datepicker in Struts 2

2006-10-19 Thread Don Brown
Hmm...didn't you have a ticket in about problems with the html extension? As for the date picker, the real solution is to take the WW tag and spin it off into its own Struts plugin, but hosted at OpenSymphony. For an application that uses the WW date picker, the Dojo one won't be an adequate

Re: s:datepicker in Struts 2

2006-10-19 Thread Matt Raible
I don't mind using the datepicker from Struts2, I just want a popup calendar to show folks how to use it. After some more playing around with things, it seems the problem is caused by SiteMesh. If I disable it, the calendars icon renders, and I can popup a calendar. It's all squished though, so

Re: ajax tags

2006-10-19 Thread Musachy Barroso
It doesn't provide anything on top of Dojo right now, it is just a wrapper. Even when it is available using dojo, it is really nice when you get isolated from the js and just have to use a couple of tags on your page. That's what ajaxtags does, wrappers around other widgets(scriptaculous and

Re: s:datepicker in Struts 2

2006-10-19 Thread Don Brown
Ah, ok, yeah, we saw that problem while working on the starter archetype. The problem is you have to be sure you tell Sitemesh not to decorate any of the static files that Struts 2 delivers. Here is the settings we used: excludes pattern/nodecorate/*/pattern

Re: ajax tags

2006-10-19 Thread Don Brown
Ok, sounds reasonable. I'm all for offloading the maintaining of code to other projects when possible :) Hmm...I wonder...could your work be improved to allow your tags to be called from velocity and freemarker as well? Currently, IMO, Struts has only half-hearted support for Ajax widgets

Re: ajax tags

2006-10-19 Thread Musachy Barroso
I'm not sure if that would be a good idea, the thing is that it would add a set of dependencies that I don't think are desirable (scriptaculous, prototype, overlib, etc), I don't see ajaxtags going too far in the future if struts supports these simple ajax tags, because most of its users are

Re: s:datepicker in Struts 2

2006-10-19 Thread Matt Raible
That doesn't seem to help either. Oh well, I guess I just won't use a datepicker for now. It's quite strange because the calendar icon doesn't show up either. Matt On 10/19/06, Don Brown [EMAIL PROTECTED] wrote: Ah, ok, yeah, we saw that problem while working on the starter archetype. The

Re: s:datepicker in Struts 2

2006-10-19 Thread Don Brown
Post a screenshot, because it really sounds like Sitemesh is trying to decorate the static content from the jar, including the icon for the calendar. Don Matt Raible wrote: That doesn't seem to help either. Oh well, I guess I just won't use a datepicker for now. It's quite strange because

Re: ajax tags

2006-10-19 Thread Don Brown
Well, your help is very appreciated. I would still like to rethink our concept of tags, themes, and ajax support, but it isn't urgent, and anything you can do to help us clean up our ajax tags in the meantime would be great. Thanks for joining the fun :) Don Musachy Barroso wrote: I'm not

Re: ajax tags

2006-10-19 Thread Ian Roughley
I'd like to start a thread on that myself early Nov (after I get back from vacation). /Ian -- From Down Around, Inc. Innovative IT Solutions Software Architecture * Design * Development ~ web: www.fdar.com email [EMAIL PROTECTED]

Re: ajax tags

2006-10-19 Thread Musachy Barroso
The one feature that we had that you should check that has been implemented in dojo is the pub/sub events - so there should be events that each tabs listens to to refresh itself. I haven't seen this in dojo (I haven't seen much anyway), I will check it out and implement it if isn't

Re: s:datepicker in Struts 2

2006-10-19 Thread Matt Raible
http://static.appfuse.org/downloads/datepicker.png Another weird thing that's happening is my label tags are getting italicized (I'm guessing by Dojo). Matt On 10/19/06, Don Brown [EMAIL PROTECTED] wrote: Post a screenshot, because it really sounds like Sitemesh is trying to decorate the

Re: s:datepicker in Struts 2

2006-10-19 Thread Don Brown
Hmm...try to access the calendar icon directly. See if Sitemesh is still interfering somehow. Also, I'm on the webwork-users group on the OpenSymphony forum if you want to run this issue down via chat. Don Matt Raible wrote: http://static.appfuse.org/downloads/datepicker.png Another weird

Re: s:datepicker in Struts 2

2006-10-19 Thread Matt Raible
Yeah, I can still access the calendar just fine - I'll logon to the chat. Matt On 10/19/06, Don Brown [EMAIL PROTECTED] wrote: Hmm...try to access the calendar icon directly. See if Sitemesh is still interfering somehow. Also, I'm on the webwork-users group on the OpenSymphony forum if you

Re: s:datepicker in Struts 2

2006-10-19 Thread Matt Raible
You can also download the application from http://static.appfuse.org/downloads/equinox-struts2-1.7.zip. It expects a postgresql database named equinox to be installed and a postgres/postgres user. Instructions for changing this are in the README.txt. Of course, you can use mvn jetty:run to

[ANNOUNCE] New Struts Committer: David DeWolf

2006-10-19 Thread Niall Pemberton
Please join us in welcoming David DeWolf as a new Struts committer. David is a FTP Server and Portals committer, and has been submitting high quality Struts and Tiles patches since April. As a member of the JSR-286 Expert Group and Apache Pluto project David brings invaluable Portals experience

[ANNOUNCEMENT] New Struts Committer: David DeWolf

2006-10-19 Thread Don Brown
Please join us in welcoming David DeWolf as a new Struts committer. David has been very active in the Struts and Tiles communities, providing good discussion and patches to the list and JIRA tickets. He is also a FTP Server and Portals committer, and has been submitting Struts patches since