Re: [VOTE] Release Struts Annotations 1.0.0

2007-01-26 Thread Ted Husted
1.3.5 does, but 2.0.3 does not. On 1/25/07, Wendy Smoak [EMAIL PROTECTED] wrote: On 1/25/07, Don Brown [EMAIL PROTECTED] wrote: I don't understand - all of the Struts jars are missing those files. The only place I see it added is in the assembly tarballs. LICENSE and NOTICE must be present

Fast ValueStack

2007-01-26 Thread David H. DeWolf
I'm going to be looking into optimizing the performance of the ValueStack and because of the recent conversations regarding OGNL and other options, I anticipate that others may have some ideas. I've ripped off the custom stack that Bob posted to the list a couple of a weeks ago, and have

Re: Fast ValueStack

2007-01-26 Thread David H. DeWolf
Well, I hope I'm wrong, and have only done some initial tests so far, but it seems to me that there are two major issues causing our slugishness. The first seems to be OGNL and the second seems to be freemarker templates. By simply replacing the default value stack with the version Bob

Re: Fast ValueStack

2007-01-26 Thread Don Brown
This might be applicable: http://crazybob.org/2007/01/fast-reflection.html Don On 1/26/07, David H. DeWolf [EMAIL PROTECTED] wrote: Well, I hope I'm wrong, and have only done some initial tests so far, but it seems to me that there are two major issues causing our slugishness. The first

Re: [VOTE] Release Struts Annotations 1.0.0

2007-01-26 Thread Don Brown
Arg!! So now we have to start this whole process again, pushing the 2.0.4 release off at least three more days? There has really got to be a better way to handle these types of minor modifications. Since the lack of these two files is the only reason for a -1 vote in many days of voting,

Re: correct way to build struts

2007-01-26 Thread Don Brown
mvn -Pall works for me, although I ran out of memory part way through the tests. They currently take a lot of memory, something we should look into after 2.0.4. Don David Durham wrote: David Durham wrote: If the information here is correct:

Re: Fast ValueStack

2007-01-26 Thread Tom Schneider
David, See https://issues.apache.org/struts/browse/WW-1661 and http://wiki.opensymphony.com/display/WW/Performance+Tuning (particularly the freemarker entries) By just adding the freemarker.properties and copying all the templates to the webapp directory we were able to resolve all of our

Re: Fast ValueStack

2007-01-26 Thread David H. DeWolf
Tom Schneider wrote: David, See https://issues.apache.org/struts/browse/WW-1661 and http://wiki.opensymphony.com/display/WW/Performance+Tuning (particularly the freemarker entries) By just adding the freemarker.properties and copying all the templates to the webapp directory we were able to

Re: Fast ValueStack

2007-01-26 Thread Tom Schneider
David H. DeWolf wrote: Tom Schneider wrote: David, See https://issues.apache.org/struts/browse/WW-1661 and http://wiki.opensymphony.com/display/WW/Performance+Tuning (particularly the freemarker entries) By just adding the freemarker.properties and copying all the templates to the webapp

Re: [VOTE] Release Struts Annotations 1.0.0

2007-01-26 Thread Wendy Smoak
On 1/26/07, Don Brown [EMAIL PROTECTED] wrote: Arg!! So now we have to start this whole process again, pushing the 2.0.4 release off at least three more days? There has really got to be a better way to handle these types of minor modifications. Since the lack of these two files is the only

Re: Fast ValueStack

2007-01-26 Thread Ted Husted
On 1/26/07, David H. DeWolf [EMAIL PROTECTED] wrote: pages. The real kicker is when I remove the method invocations (%{getText('')}) - this results in a 1100-1200ms/request gain (an average of about 100ms per method invocation) and drops my total request time to well under a second. The

Re: [VOTE] Release Struts Annotations 1.0.0

2007-01-26 Thread Ted Husted
On 1/26/07, Don Brown [EMAIL PROTECTED] wrote: Arg!! So now we have to start this whole process again, pushing the 2.0.4 release off at least three more days? There has really got to be a better way to handle these types of minor modifications. Since the lack of these two files is the only

Re: Fast ValueStack

2007-01-26 Thread Tom Schneider
From UIBean.java: if (this.key != null) { if(this.name == null) { this.name = key; } if(this.label == null) { this.label = %{getText('+ key +')}; } } Looks like it's doing exactly the same thing. :( Even

Re: Fast ValueStack

2007-01-26 Thread Tom Schneider
Well, I guess I was feeling more ambitious than I thought. I wrote a simple junit test (below) that tests the 2 techniques for retrieving I18N text. My numbers for 100 iterations were: Using OGNL expression: 476 ms Explicitly calling getText: 0 ms Yikes!!! There is quite a difference between

Re: Fast ValueStack

2007-01-26 Thread David H. DeWolf
Tom Schneider wrote: The other thing to check is to make sure devmode is off. With devmode on, the resource bundles will be reloaded quite offend vs. not being reload at all with devmode off. That could definitely be a culprit if the getText calls are taking so long. Apparently

Re: Fast ValueStack

2007-01-26 Thread David H. DeWolf
Nice, that seems in line with what I'm seeing as well now. I still think this is worth improving, as those 5ms can add up on larger forms. Tom Schneider wrote: Well, I guess I was feeling more ambitious than I thought. I wrote a simple junit test (below) that tests the 2 techniques for