Hi list, and especially David (H. DeWolf)
I noticed that you renamed AttributeTag.preprocessAttribute into
calculateType, and you removed all the logic that fixed the
attribute object itself.
Is this fixing code moved anywhere, or is it been removed completely?
TIA
Antonio
ummm. . .yes, I specifically remember removing that for a reason, but
for the life of me can't remember why. Perhaps I just wasn't thinking
straight.
Good catch, I'd say let's add it back in as it will make the rest of the
attribute tag processing a little simpler.
The only reason why we
David H. DeWolf ha scritto:
ummm. . .yes, I specifically remember removing that for a reason, but
for the life of me can't remember why. Perhaps I just wasn't thinking
straight.
Good catch, I'd say let's add it back in as it will make the rest of
the attribute tag processing a little
Antonio Petrelli wrote:
David H. DeWolf ha scritto:
ummm. . .yes, I specifically remember removing that for a reason, but
for the life of me can't remember why. Perhaps I just wasn't thinking
straight.
Good catch, I'd say let's add it back in as it will make the rest of
the attribute tag
By the way, what's the use case for putting definitions in a jsp? Why
would someone prefer that method over another. . .
David
Antonio Petrelli wrote:
David H. DeWolf ha scritto:
ummm. . .yes, I specifically remember removing that for a reason, but
for the life of me can't remember why.
David H. DeWolf ha scritto:
Can you help me understand why those created from the factory are
consistent?
Err... I am not that sure... I think that preprocessing should happen
also to configured attributes, I thought that
ComponentDefinitionsImpl.resolveAttributes fixed the attributes, but
David H. DeWolf ha scritto:
By the way, what's the use case for putting definitions in a jsp? Why
would someone prefer that method over another. . .
That's a good question. In real applications I never used JSP-configured
defininitions, but removing them could break all the applications. It
Works for me. . .go for it!
Antonio Petrelli wrote:
David H. DeWolf ha scritto:
Can you help me understand why those created from the factory are
consistent?
Err... I am not that sure... I think that preprocessing should happen
also to configured attributes, I thought that
David H. DeWolf ha scritto:
Works for me. . .go for it!
Committed but there's still a problem. In previous versions, if the
attribute value was a string and the type was definition, it tries to
get that definition and put it as the value of the attribute. This logic
seems to have
I don't think that we want to get a definition outside of the
container. That should be an implementation detail of the container. I
think it's this philosophy that allowed the tags to be cleaned up
significantly.
Instead, attributes are now recognized as being a definition and thus
the
David H. DeWolf ha scritto:
Perhaps we're talking past each other, do you have a test case that
shows the failure?
Yes, it is Test definition tag in test webapp, but it is hidden by a
TODO that you put in DefinitionTag...
In fact the problem happens only with JSP-configured definitions, so no
On Nov 6, 2006, at 8:42 AM, Antonio Petrelli wrote:
David H. DeWolf ha scritto:
By the way, what's the use case for putting definitions in a jsp?
Why would someone prefer that method over another. . .
That's a good question. In real applications I never used JSP-
configured
Cool! As long as there's a reason! :)
Greg Reddin wrote:
On Nov 6, 2006, at 8:42 AM, Antonio Petrelli wrote:
David H. DeWolf ha scritto:
By the way, what's the use case for putting definitions in a jsp?
Why would someone prefer that method over another. . .
That's a good question. In
Hmm, now I'm really lost. . what is the feature that you're talking
about? I thought you were talking about rendering attributes of type
definition. How is that tested by the Test definition tag (testdef.jsp)?
tiles:definition name=templateDefinition template=/layout.jsp
tiles:put
David H. DeWolf ha scritto:
Hmm, now I'm really lost. . what is the feature that you're talking
about? I thought you were talking about rendering attributes of type
definition. How is that tested by the Test definition tag
(testdef.jsp)?
Err... sorry I meant Test insert definition that
Gotcha,
Yes, I fully expect that this test will pass as soon as we are able to
register the jsp defined definitions (of course, I could be wrong!).
The behavior should be the same as the configured definitions. . and the
test should result in the same behavior as the configured composite
16 matches
Mail list logo
