Re: improve documentation for UploadedFilesAware

2024-03-25 Thread Łukasz Lenart
pon., 25 mar 2024 o 10:00 Greg Huber napisał(a): > > OK great. More of a chance of it being read . Thanks, merged > I guess this new version includes all the "old versions" security stuff > from past issues, and is not a new code base. Yes, it only uses a different mechanism to pass uploaded

Re: improve documentation for UploadedFilesAware

2024-03-25 Thread Greg Huber
OK great.  More of a chance of it being read . I guess this new version includes all the "old versions" security stuff from past issues, and is not a new code base. As the old one is deprecated, and we all rush and upgrade, their may be more resources put in trying to break it.  Maybe

Re: improve documentation for UploadedFilesAware

2024-03-24 Thread Lukasz Lenart
pon., 18 mar 2024 o 14:42 Greg Huber napisał(a): > > OK...I did not spot the link in the text. I repeated the links in the Examples sections of both Cheers Lukasz - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org

Re: improve documentation for UploadedFilesAware

2024-03-18 Thread Greg Huber
OK...I did not spot the link in the text. On Mon, 18 Mar 2024 at 12:59, Łukasz Lenart wrote: > pon., 18 mar 2024 o 13:05 Greg Huber napisał(a): > > > > > See [this page] for more examples and advanced configuration. > > > > Which page? > > On these pages, a very first sentence > >

Re: improve documentation for UploadedFilesAware

2024-03-18 Thread Łukasz Lenart
pon., 18 mar 2024 o 13:05 Greg Huber napisał(a): > > > See [this page] for more examples and advanced configuration. > > Which page? On these pages, a very first sentence https://struts.staged.apache.org/core-developers/action-file-upload-interceptor

Re: improve documentation for UploadedFilesAware

2024-03-18 Thread Greg Huber
See [this page] for more examples and advanced configuration. Which page? I reverted this idea and UploadedFile isn't generic. that would be in 7.0.0_M4? I used _M3 to test it. On 18/03/2024 11:56, Lukasz Lenart wrote: pon., 18 mar 2024 o 08:21 Greg Huber napisał(a): Rechecking these :

Re: improve documentation for UploadedFilesAware

2024-03-18 Thread Lukasz Lenart
pon., 18 mar 2024 o 08:21 Greg Huber napisał(a): > > Rechecking these : > > Could not see the link from from the interceptor pages to these detailed > help pages. Add a link after Examples? > > File Upload Interceptor > > Parameters > Extending the Interceptor > Examples > > > Or

Re: improve documentation for UploadedFilesAware

2024-03-18 Thread Greg Huber
Rechecking these : Could not see the link from from the interceptor pages to these detailed help pages.  Add a link after Examples? File Upload Interceptor     Parameters     Extending the Interceptor     Examples Or at the bottom of the page? # There is a UploadedFile is a raw type.

Re: improve documentation for UploadedFilesAware

2024-03-17 Thread Lukasz Lenart
Added :) Also adjusted the Showcase https://github.com/apache/struts/pull/895 niedz., 17 mar 2024 o 12:29 Greg Huber napisał(a): > > Looks good, but what happened to the examples with the stream stuff? > > Something like this for MultipleFileUploadUsingArrayActionusing arrays > example? > > >

Re: improve documentation for UploadedFilesAware

2024-03-17 Thread Greg Huber
Looks good, but what happened to the examples with the stream stuff? Something like this for MultipleFileUploadUsingArrayActionusing arrays example? public class MultipleFileUploadUsingArrayAction extends ActionSupport    implements UploadedFilesAware {     private List> uploads =

Re: improve documentation for UploadedFilesAware

2024-03-17 Thread Lukasz Lenart
Better? https://struts.staged.apache.org/core-developers/action-file-upload https://struts.staged.apache.org/core-developers/file-upload czw., 14 mar 2024 o 15:29 Greg Huber napisał(a): > > Sorry, I meant we need to copy/duplicate this page : > >

Re: improve documentation for UploadedFilesAware

2024-03-14 Thread Greg Huber
Sorry, I meant we need to copy/duplicate this page : https://struts.apache.org/core-developers/file-upload.html to an *action* version: https://struts.apache.org/core-developers/action-file-upload.html and modify it for the new interceptor methods/logic On Thu, 14 Mar 2024 at 12:42, Łukasz

Re: improve documentation for UploadedFilesAware

2024-03-14 Thread Łukasz Lenart
Done https://github.com/apache/struts-site/pull/231 czw., 14 mar 2024 o 11:35 Greg Huber napisał(a): > > There is a really good page for the old upload > > https://struts.apache.org/core-developers/file-upload.html > > But the << back to Core Developers Guide does not make it easy to find > it

Re: improve documentation for UploadedFilesAware

2024-03-14 Thread Greg Huber
There is a really good page for the old upload https://struts.apache.org/core-developers/file-upload.html But the << back to Core Developers Guide does not make it easy to find it again. ## https://struts.apache.org/core-developers/action-file-upload-interceptor would benefit a similar

Re: improve documentation for UploadedFilesAware

2024-03-12 Thread Lukasz Lenart
pon., 26 lut 2024 o 12:08 Greg Huber napisał(a): > > The documentation only lists one file > > |public void withUploadedFiles(List uploadedFiles) { if > (!uploadedFiles.isEmpty()) { this.uploadedFile = uploadedFiles.get(0); > this.fileName = uploadedFile.getName(); this.contentType = >