Very interesting article, indeed. Both WW and S2 use static loggers, as
it was always considered best practice...
On the other hand, the problem only applies if a shared classloader is
used, and I can hardly imagine a setup where struts jars are deployed
eg. in $CATALINA/commons/lib rather
How about Struts JARs at the EAR level? Wouldn't that be loaded (by
default anyway) by a higher-level classloader than individual apps and
shared across all WARs in the EAR? Not sure that's quite the same thing
though (and I'm basing this on Websphere, which as we all know has some
of the
I tend to deploy S2 in commons/lib only because I use S2 in all of my
web-apps. It saves space and keeps WEB-INF/lib a little more organized. Not
that I wouldn't change, it's just the way I've done it.
-Wes
On 7/8/07, Rene Gielen [EMAIL PROTECTED] wrote:
Very interesting article, indeed. Both
On 7/8/07, Rene Gielen [EMAIL PROTECTED] wrote:
Very interesting article, indeed. Both WW and S2 use static loggers, as
it was always considered best practice...
On the other hand, the problem only applies if a shared classloader is
used, and I can hardly imagine a setup where struts jars are
On 7/8/07, Frank W. Zammetti [EMAIL PROTECTED] wrote:
How about Struts JARs at the EAR level? Wouldn't that be loaded (by
default anyway) by a higher-level classloader than individual apps and
shared across all WARs in the EAR? Not sure that's quite the same thing
though (and I'm basing this
Martin Cooper wrote:
It would be the same thing in the sense of the direction of the class
loader, and I would expect the same screwy things to happen. And if you're
using WebFear, then I'd fully expect other screwy things to happen as well,
as a free bonus. ;-)
Hehe, I know *exactly* what you
I use WAS 6.0 at work and it took me 3 full days to figure out how to
get log4j working with it. Ugh. Yes, the software is an elephant.
Anyway, despite the fact that Struts 1 supports only static logging, I
believe this position could be evaluated. Correct me when wrong, but the
article
FWIW, my opinion would be go ahead and change it... unless someone can
show where it would cause trouble, I'm in the better safe than sorry
camp. I know of a number of instances where I've seen Struts installed
in a shared way, either at EAR-level or something like Tomcat's shared
libs
It doesn't have to be an all or nothing game either. Obviously, even in
a shared library, instance loggers are not always appropriate. So it's
definitely on a class by class basis.
Frank W. Zammetti wrote:
FWIW, my opinion would be go ahead and change it... unless someone can
show where it
So what determines what should be an instance logger and what should be
a static logger? From the original article, they recommend creating the
loggers as needed when logging in a static context. To me, that implies
only instance level loggers are allowed globally to a class. In static
Has anyone ever read this?
http://wiki.apache.org/jakarta-commons/Logging/StaticLog
Please correct me when I am wrong, but the recommendations say that
shared libraries should not be using a static logger because it causes
problems with application classloaders. Most of the S1 code uses static
On 7/6/07, Paul Benedict [EMAIL PROTECTED] wrote:
Has anyone ever read this?
http://wiki.apache.org/jakarta-commons/Logging/StaticLog
Did you check the archives? Simon mentioned it well over a year ago,
with no replies:
12 matches
Mail list logo
