AW: JSON & XML serialisation

2017-11-10 Thread Christoph.Nenning
Hi, I would prefer standardized "Java API for JSON Processing" just to avoid another dependency forced on applications. It seems to me selection of json library is like selection of logging lib. There are some options and everyone wants to use something different. It is hard for a framework

re: [VOTE][FASTTRACK] Struts 2.5.14.1

2017-11-30 Thread Christoph.Nenning
Hi, here is another vote: > [ ] Leave at test build > [ ] Alpha > [ ] Beta > [X] General Availability (GA) +1, binding Regards, Christoph > -Ursprüngliche Nachricht- > Von: Lukasz Lenart [mailto:lukaszlen...@apache.org] > Gesendet: Donnerstag, 30. November 2017 08:57 > An: Struts

AW: [VOTE] Struts 2.5.14

2017-11-20 Thread Christoph.Nenning
> [ ] Leave at test build > [ ] Alpha > [ ] Beta > [X] General Availability (GA) +1, binding Regards, Christoph > > The Apache Struts 2.5.14 test build is now available. With this > release the following issues were addressed: > > Bug > > [WW-4843] - DefaultUrlHelper().buildUrl() not

AW: Struts 2.5.14 test build is ready

2017-11-16 Thread Christoph.Nenning
Hi, > I have noticed one problem and added a note about it to the Version > Notes - not a big problem IMHO. Agree. 2.5.14 looks good in my test. Regards, Christoph > > I have noticed one problem and added a note about it to the Version > Notes - not a big problem IMHO. > > > Regards >

AW: Would we need to achieve better place in trends ranking?

2017-11-08 Thread Christoph.Nenning
Hi, other tools in this regard would be pmd and spotbugs (successor of findbugs) https://pmd.github.io/ http://findbugs.sourceforge.net/ In my experience it is easy to integrate them in builds and generate nice reports but it is quite hard and a lot of work to fix all those findings. Another

Re: Squash PR-s

2017-11-07 Thread Christoph.Nenning
let's see how much we agree what common sense is :) regards, Christoph On 11/7/2017 12:16 AM, Aleksandr Mashchenko wrote: > I suggest we should start to use this option along with the common sense. I agree. Good for cases such [1], however, not good for [2] for example where commit 1 and 2

AW: Struts 2.5.15 test build is ready

2018-02-13 Thread Christoph.Nenning
LGTM Regards, Christoph > -Ursprüngliche Nachricht- > Von: Lukasz Lenart [mailto:lukaszlen...@apache.org] > Gesendet: Freitag, 9. Februar 2018 10:24 > An: Struts Developers List > Betreff: Struts 2.5.15 test build is ready > > Hi, > > Please take a time and

AW: Struts 2.4

2018-04-06 Thread Christoph.Nenning
Hi, my impression is that there are lots of people using old versions of struts, java, app servers, ... and who are not active on mailing-lists or github or whatever. Just when they have issues due to old versions being no longer supported they start sending mails to users list or asking on

AW: Struts 2.4

2018-04-16 Thread Christoph.Nenning
Maybe different minor versions of jdk, maven or maven-compiler-plugin ? Regards, Christoph > -Ursprüngliche Nachricht- > Von: Lukasz Lenart [mailto:lukaszlen...@apache.org] > Gesendet: Montag, 16. April 2018 09:15 > An: Struts Developers List > Betreff: Re:

AW: Dependency mapping for [type=java.lang.String, name='struts.devMode'] already exists error in Eclipse

2018-10-12 Thread Christoph.Nenning
Hi, in Eclipse web-projects there are these two places to configure jars, if you don't use dependency management with maven or gradle: - java build path - deployment assembly Hope that helps! Christoph -Ursprüngliche Nachricht- Von: Lukasz Lenart [mailto:lukaszlen...@apache.org]

AW: [VOTE] Struts 2.3.36

2018-10-10 Thread Christoph.Nenning
[ ] Leave at test build [ ] Alpha [ ] Beta [X] General Availability (GA) +1, binding Regards, Christoph -Ursprüngliche Nachricht- Von: Yasser Zamani [mailto:yasser.zam...@live.com] Im Auftrag von Yasser Zamani Gesendet: Montag, 8. Oktober 2018 10:06 An: Struts Developers List

AW: [VOTE] Struts Master 13

2018-09-28 Thread Christoph.Nenning
[ ] Leave at test build [ ] Alpha [ ] Beta [X] General Availability (GA) +1, binding Regards, Christoph -Ursprüngliche Nachricht- Von: Lukasz Lenart [mailto:lukaszlen...@apache.org] Gesendet: Donnerstag, 27. September 2018 08:49 An: Struts Developers List Betreff: [VOTE] Struts

AW: AW: Avoid using setters

2018-09-25 Thread Christoph.Nenning
> > > Same refactor would be nice for Struts internal CDI by > > > finding all references of @Inject and refactoring them [1]. This changes > > > isn't backward compatible so no need for deprecation I think. > > > > FIX: This change (finding all references of @Inject and refactoring them > > e.g.

AW: Struts 2.5.20 test build is ready

2019-01-11 Thread Christoph.Nenning
Hi, for me it looks alright. I would be ready to vote :) regards, Christoph -Ursprüngliche Nachricht- Von: Lukasz Lenart [mailto:lukaszlen...@apache.org] Gesendet: Mittwoch, 9. Januar 2019 09:38 An: Struts Developers List Betreff: Struts 2.5.20 test build is ready Hi, Please take

AW: [VOTE] Struts 2.3.37

2019-01-11 Thread Christoph.Nenning
> [ ] Leave at test build > [ ] Alpha > [ ] Beta > [X] General Availability (GA) +1, binding regards, Christoph

Re: [VOTE] Struts 2.5.20

2019-01-13 Thread Christoph.Nenning
[ ] Leave at test build [ ] Alpha [ ] Beta [x] General Availability (GA) +1 binding regards, Christoph

***UNCHECKED*** AW: Avoid using setters

2018-09-19 Thread Christoph.Nenning
Oh yes, that sounds like a great idea! I wonder why we didn't come up with this earlier, the simplest ideas are the hardest to find ;) My preference would be the name withSession. Regards, Christoph -Ursprüngliche Nachricht- Von: Lukasz Lenart [mailto:lukaszlen...@apache.org]

AW: which jdk 2019

2018-09-17 Thread Christoph.Nenning
> Is IBM JDK free? AFAIK IBM products usually aren't. Some time ago IBM released an OpenSource version of their JDK at eclipse foundation: https://github.com/eclipse/openj9 Regards, Christoph -Ursprüngliche Nachricht- Von: Yasser Zamani [mailto:yasser.zam...@live.com] Im Auftrag von

AW: Struts 2.3.x EOL

2019-09-03 Thread Christoph.Nenning
> Should we post this announcement once more to users@ and announcement@ lists? > https://struts.apache.org/struts23-eol-announcement Yes, there are surly people not aware of it. -Ursprüngliche Nachricht- Von: Lukasz Lenart [mailto:lukaszlen...@apache.org] Gesendet: Dienstag, 3.

AW: Struts 2.3.x EOL

2019-08-29 Thread Christoph.Nenning
Hi, from my point of view it would not be necessary to do another release of 2.3.x. What would be in that release anyway? Regards, Christoph -Ursprüngliche Nachricht- Von: Lukasz Lenart [mailto:lukaszlen...@apache.org] Gesendet: Montag, 26. August 2019 12:49 An: Struts Developers

AW: Max length for OGNL expression

2019-09-16 Thread Christoph.Nenning
I agree with this. Basically I like the idea to limit length of ognl and I think it would increase security. But IMHO it is likely to cause issues in applications and thus applications must be able to control it. Regards, Christoph > Seems to me not to be the right place to correct any

AW: [VOTE] Struts Master 14

2020-02-02 Thread Christoph.Nenning
Changes seem to be quite easy :) > [ ] Leave at test build > [ ] Alpha > [ ] Beta > [X] General Availability (GA) +1 (binding) Regards, Christoph -Ursprüngliche Nachricht- Von: Lukasz Lenart [mailto:lukaszlen...@apache.org] Gesendet: Sonntag, 2. Februar 2020 08:20 An: Struts

AW: [VOTE] Struts Annotations 1.0.7

2020-02-18 Thread Christoph.Nenning
[ ] Leave at test build [ ] Alpha [ ] Beta [X] General Availability (GA) +1, binding Regards, Christoph -Ursprüngliche Nachricht- Von: Lukasz Lenart [mailto:lukaszlen...@apache.org] Gesendet: Montag, 17. Februar 2020 21:20 An: Struts Developers List Betreff: [VOTE] Struts

AW: Security impact levels

2021-01-13 Thread Christoph.Nenning
Hi, description of impact levels looks good to me. Best Regards Christoph -Ursprüngliche Nachricht- Von: Lukasz Lenart Gesendet: Donnerstag, 14. Januar 2021 07:25 An: Struts Developers List Betreff: Security impact levels Hi, I have prepared a list of Security Impact Levels which