Re: [dev] [ii] [PATCH] keep nick synchronized with server

2015-11-05 Thread Nico Golde
Hi, * Troy Sankey [2015-01-29 04:12]: > On 2015-01-28 14:44:52 -0500, Nico Golde wrote: > > What I think may be better would be to only set nick after a successful > > NICK > > message was received from the network as Truls suggests. > > Would you mind testing the attached

Re: [dev] [ii] [PATCH] keep nick synchronized with server

2015-01-28 Thread Troy Sankey
On 2015-01-28 14:44:52 -0500, Nico Golde wrote: What I think may be better would be to only set nick after a successful NICK message was received from the network as Truls suggests. Would you mind testing the attached patch? Tested, works. Can we still make it log to the network channel,

Re: [dev] [ii] [PATCH] keep nick synchronized with server

2015-01-28 Thread Nico Golde
Hi, * Truls Becken truls.bec...@gmail.com [2015-01-27 08:57]: On Mon, Jan 26, 2015 at 3:23 AM, Troy Sankey sankey...@gmail.com wrote: If an error occurs changing nick (with /n) then it will become out of sync with the server. Here are some of the consequences: * ii will log outgoing

[dev] [ii] [PATCH] keep nick synchronized with server

2015-01-25 Thread Troy Sankey
Hi, If an error occurs changing nick (with /n) then it will become out of sync with the server. Here are some of the consequences: * ii will log outgoing messages with the new nick, but others will receive them from the old nick * private messaging breaks Conceivably, this issue is common on