[
https://issues.apache.org/jira/browse/THRIFT-3867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358089#comment-15358089
]
ASF GitHub Bot commented on THRIFT-3867:
Github user Jens-G commented on a diff in the pull
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1036#discussion_r69231154
--- Diff: doc/specs/thrift-binary-protocol-encoding.md ---
@@ -0,0 +1,467 @@
+Thrift Protocol Encoding for BinaryProtocol and CompactProtocol
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1036
Overall pretty neat. I still have a few complaints.
1. The document repeats a lot of stuff that can be found elsewhere, e.g. in
the Thrift Whitepaper. There is nothing per se wrong with
[
https://issues.apache.org/jira/browse/THRIFT-3867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357749#comment-15357749
]
ASF GitHub Bot commented on THRIFT-3867:
Github user Jens-G commented on a diff in the pull
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1036#discussion_r69198940
--- Diff: doc/specs/thrift-binary-protocol-encoding.md ---
@@ -0,0 +1,467 @@
+Thrift Protocol Encoding for BinaryProtocol and CompactProtocol
[
https://issues.apache.org/jira/browse/THRIFT-3867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357737#comment-15357737
]
ASF GitHub Bot commented on THRIFT-3867:
Github user Jens-G commented on a diff in the pull
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1036#discussion_r69198205
--- Diff: doc/specs/thrift-binary-protocol-encoding.md ---
@@ -0,0 +1,467 @@
+Thrift Protocol Encoding for BinaryProtocol and CompactProtocol
[
https://issues.apache.org/jira/browse/THRIFT-3867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357734#comment-15357734
]
ASF GitHub Bot commented on THRIFT-3867:
Github user Jens-G commented on a diff in the pull
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1036#discussion_r69197727
--- Diff: doc/specs/thrift-binary-protocol-encoding.md ---
@@ -0,0 +1,467 @@
+Thrift Protocol Encoding for BinaryProtocol and CompactProtocol
[
https://issues.apache.org/jira/browse/THRIFT-3867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357728#comment-15357728
]
ASF GitHub Bot commented on THRIFT-3867:
Github user Jens-G commented on a diff in the pull
[
https://issues.apache.org/jira/browse/THRIFT-3867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357723#comment-15357723
]
ASF GitHub Bot commented on THRIFT-3867:
Github user Jens-G commented on a diff in the pull
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1036#discussion_r69196978
--- Diff: doc/specs/thrift-binary-protocol-encoding.md ---
@@ -0,0 +1,467 @@
+Thrift Protocol Encoding for BinaryProtocol and CompactProtocol
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1036#discussion_r69196907
--- Diff: doc/specs/thrift-binary-protocol-encoding.md ---
@@ -0,0 +1,467 @@
+Thrift Protocol Encoding for BinaryProtocol and CompactProtocol
GitHub user edenhochbaum opened a pull request:
https://github.com/apache/thrift/pull/1037
nodejs client fails to import 'assert'
So when the connection fails, we just get an error about assert not being
defined (rather than details of the connection failure.)
You can merge this
Github user edenhochbaum closed the pull request at:
https://github.com/apache/thrift/pull/1035
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
15 matches
Mail list logo
