[jira] [Commented] (THRIFT-3773) Swift Library

2016-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15484987#comment-15484987 ] ASF GitHub Bot commented on THRIFT-3773: Github user apocolipse commented on the issue:

[GitHub] thrift issue #1084: THRIFT-3773 Swift 3 Native Library

2016-09-12 Thread apocolipse
Github user apocolipse commented on the issue: https://github.com/apache/thrift/pull/1084 @ChristopherRogers @fumoboy007 I implemented union support with enums, here's an example of generated code: ``` union TestUnion { 1: i32 data, 2: string message, 3: bool

[jira] [Commented] (THRIFT-3773) Swift Library

2016-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15484841#comment-15484841 ] ASF GitHub Bot commented on THRIFT-3773: Github user apocolipse commented on the issue:

[GitHub] thrift issue #1084: THRIFT-3773 Swift 3 Native Library

2016-09-12 Thread apocolipse
Github user apocolipse commented on the issue: https://github.com/apache/thrift/pull/1084 @nsuke I considered that when starting out, however the differences between Swift 2 and 3 are pretty dramatic that makes shared code minimal (i.e. everything in this library is Value typed,

[jira] [Commented] (THRIFT-3773) Swift Library

2016-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15484815#comment-15484815 ] ASF GitHub Bot commented on THRIFT-3773: Github user nsuke commented on the issue:

[GitHub] thrift issue #1084: THRIFT-3773 Swift 3 Native Library

2016-09-12 Thread nsuke
Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/1084 There's a substantial amount of code duplication with existing swift generator. Do you have any idea as to reducing them ? As I've never seen anyone advocating the current practice of "single

[GitHub] thrift issue #1039: THRIFT-2835 Add possibility to distribute generators sep...

2016-09-12 Thread nsuke
Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/1039 @dtmuller as you may have noticed I've squashed commits for merging in #368. If there's no concern I'll push them within a week or so. --- If your project is set up for it, you can reply to this

[jira] [Commented] (THRIFT-2835) Add possibility to distribute generators separately from thrift core, and load them dynamically

2016-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15484545#comment-15484545 ] ASF GitHub Bot commented on THRIFT-2835: Github user nsuke commented on the issue:

[jira] [Commented] (THRIFT-2835) Add possibility to distribute generators separately from thrift core, and load them dynamically

2016-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15483510#comment-15483510 ] ASF GitHub Bot commented on THRIFT-2835: Github user dtmuller commented on the issue:

[GitHub] thrift issue #1039: THRIFT-2835 Add possibility to distribute generators sep...

2016-09-12 Thread dtmuller
Github user dtmuller commented on the issue: https://github.com/apache/thrift/pull/1039 @nsuke Do you have a rough idea when this PR can be merged? If there is more work to do I can assist, please let me know... --- If your project is set up for it, you can reply to this email and

[jira] [Updated] (THRIFT-3924) Make C++ library build on SunOS

2016-09-12 Thread Guoguang Lan (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guoguang Lan updated THRIFT-3924: - Environment: 1.upgrade thrift from 0.9.0 to 0.9.2 2.SunOS 3./opt/SUNWspro/prod/include/CC/Cstd

[jira] [Commented] (THRIFT-3924) Make C++ library build on SunOS

2016-09-12 Thread Guoguang Lan (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15483310#comment-15483310 ] Guoguang Lan commented on THRIFT-3924: --

[jira] [Created] (THRIFT-3924) Make C++ library build on SunOS

2016-09-12 Thread Guoguang Lan (JIRA)
Guoguang Lan created THRIFT-3924: Summary: Make C++ library build on SunOS Key: THRIFT-3924 URL: https://issues.apache.org/jira/browse/THRIFT-3924 Project: Thrift Issue Type: Bug