[jira] [Commented] (THRIFT-3867) Specify BinaryProtocol and CompactProtocol

2016-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507642#comment-15507642 ] ASF GitHub Bot commented on THRIFT-3867: Github user Jens-G commented on the issue:

[GitHub] thrift issue #1036: THRIFT-3867 Specify BinaryProtocol and CompactProtocol

2016-09-20 Thread Jens-G
Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/1036 Thanks for the reminder. Actually, I like it. Too bad it's closed now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (THRIFT-3867) Specify BinaryProtocol and CompactProtocol

2016-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507602#comment-15507602 ] ASF GitHub Bot commented on THRIFT-3867: Github user Jens-G commented on the issue:

[GitHub] thrift issue #1036: THRIFT-3867 Specify BinaryProtocol and CompactProtocol

2016-09-20 Thread Jens-G
Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/1036 Why? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Closed] (THRIFT-1108) SSL support for the Ruby library

2016-09-20 Thread Jake Farrell (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-1108. Resolution: Fixed Fix Version/s: 0.10.0 Thanks for the update and tests, committed > SSL

[jira] [Updated] (THRIFT-1108) SSL support for the Ruby library

2016-09-20 Thread Jake Farrell (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell updated THRIFT-1108: - Assignee: Mansi > SSL support for the Ruby library > - > >

[jira] [Commented] (THRIFT-1108) SSL support for the Ruby library

2016-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507541#comment-15507541 ] ASF GitHub Bot commented on THRIFT-1108: Github user jfarrell closed the pull request at:

[jira] [Commented] (THRIFT-1108) SSL support for the Ruby library

2016-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507542#comment-15507542 ] ASF GitHub Bot commented on THRIFT-1108: Github user jfarrell commented on the issue:

[GitHub] thrift pull request #1091: THRIFT-1108: Adding SSL support for ruby

2016-09-20 Thread jfarrell
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/1091 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift issue #1091: THRIFT-1108: Adding SSL support for ruby

2016-09-20 Thread jfarrell
Github user jfarrell commented on the issue: https://github.com/apache/thrift/pull/1091 Thanks for the patch,Committed, 04e6f62 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Updated] (THRIFT-3932) C++ ThreadManager has a rare termination race

2016-09-20 Thread JIRA
[ https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Buğra Gedik updated THRIFT-3932: Description: {{ThreadManger::join}} calls {{stopImpl(true)}}, which in turn calls

[GitHub] thrift pull request #1092: THRIFT-948: Adding SSL support for php

2016-09-20 Thread jfarrell
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/1092 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Closed] (THRIFT-948) SSL socket support for PHP

2016-09-20 Thread Jake Farrell (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-948. --- Resolution: Fixed Fix Version/s: 0.10.0 Committed, thanks for the patch > SSL socket support

[GitHub] thrift issue #1092: THRIFT-948: Adding SSL support for php

2016-09-20 Thread jfarrell
Github user jfarrell commented on the issue: https://github.com/apache/thrift/pull/1092 commit 311c984 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[jira] [Commented] (THRIFT-948) SSL socket support for PHP

2016-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507212#comment-15507212 ] ASF GitHub Bot commented on THRIFT-948: --- Github user jfarrell commented on the issue:

[jira] [Commented] (THRIFT-948) SSL socket support for PHP

2016-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507213#comment-15507213 ] ASF GitHub Bot commented on THRIFT-948: --- Github user jfarrell closed the pull request at:

[jira] [Updated] (THRIFT-948) SSL socket support for PHP

2016-09-20 Thread Jake Farrell (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell updated THRIFT-948: Assignee: Mansi > SSL socket support for PHP > -- > > Key:

[jira] [Comment Edited] (THRIFT-3928) CPP generator doesn`t generate implementations of constructors, operators and setters for function helpers

2016-09-20 Thread Vadrot Romain (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506760#comment-15506760 ] Vadrot Romain edited comment on THRIFT-3928 at 9/20/16 2:56 PM: The

[jira] [Commented] (THRIFT-3928) CPP generator doesn`t generate implementations of constructors, operators and setters for function helpers

2016-09-20 Thread Vadrot Romain (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506760#comment-15506760 ] Vadrot Romain commented on THRIFT-3928: --- The proposed patch is a good start but is not complete as

[jira] [Commented] (THRIFT-948) SSL socket support for PHP

2016-09-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506631#comment-15506631 ] ASF GitHub Bot commented on THRIFT-948: --- GitHub user mansinahar opened a pull request:

[GitHub] thrift pull request #1092: THRIFT-948: Adding SSL support for php

2016-09-20 Thread mansinahar
GitHub user mansinahar opened a pull request: https://github.com/apache/thrift/pull/1092 THRIFT-948: Adding SSL support for php You can merge this pull request into a Git repository by running: $ git pull https://github.com/mansinahar/thrift thrift-php-ssl Alternatively you

[GitHub] thrift issue #1036: THRIFT-3867 Specify BinaryProtocol and CompactProtocol

2016-09-20 Thread erikvanoosten
Github user erikvanoosten commented on the issue: https://github.com/apache/thrift/pull/1036 Closing this due to lack of interest of repo owners. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] thrift pull request #1036: THRIFT-3867 Specify BinaryProtocol and CompactPro...

2016-09-20 Thread erikvanoosten
Github user erikvanoosten closed the pull request at: https://github.com/apache/thrift/pull/1036 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Updated] (THRIFT-3932) C++ ThreadManager has a rare termination race

2016-09-20 Thread JIRA
[ https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Buğra Gedik updated THRIFT-3932: Description: {{ThreadManger::join}} calls {{stopImpl(true)}}, which in turn calls

[jira] [Updated] (THRIFT-3932) C++ ThreadManager has a rare termination race

2016-09-20 Thread JIRA
[ https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Buğra Gedik updated THRIFT-3932: Description: {{ThreadManger::join}} calls {{stopImpl(true)}}, which in turn calls

[jira] [Updated] (THRIFT-3932) C++ ThreadManager has a rare termination race

2016-09-20 Thread JIRA
[ https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Buğra Gedik updated THRIFT-3932: Description: {{ThreadManger::join}} calls {{stopImpl(true)}}, which in term calls

[jira] [Updated] (THRIFT-3932) C++ ThreadManager has a rare termination race

2016-09-20 Thread JIRA
[ https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Buğra Gedik updated THRIFT-3932: Description: {{ThreadManger::join}} calls {{stopImpl(true)}}, which in term calls

[jira] [Created] (THRIFT-3932) C++ ThreadManager has a rare termination race

2016-09-20 Thread JIRA
Buğra Gedik created THRIFT-3932: --- Summary: C++ ThreadManager has a rare termination race Key: THRIFT-3932 URL: https://issues.apache.org/jira/browse/THRIFT-3932 Project: Thrift Issue Type: Bug

[jira] [Updated] (THRIFT-3925) Client service recieves string instead of buffer when using TCompactProtocol with node.js library.

2016-09-20 Thread Roman Poliakov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Poliakov updated THRIFT-3925: --- Description: Node.js implementation of TCompactProtocol instead of returning raw Buffer,

[jira] [Updated] (THRIFT-3932) C++ ThreadManager has a rare termination race

2016-09-20 Thread JIRA
[ https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Buğra Gedik updated THRIFT-3932: Attachment: thrift-patch > C++ ThreadManager has a rare termination race >

[jira] [Commented] (THRIFT-3925) Client service recieves string instead of buffer when using TCompactProtocol with node.js library.

2016-09-20 Thread Roman Poliakov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15505915#comment-15505915 ] Roman Poliakov commented on THRIFT-3925: Can this patch be applied? The version of library in npm