[jira] [Commented] (THRIFT-3941) WinXP version of thrift_poll() relies on undefined behavior by passing a destructed variable to select()

2016-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15545972#comment-15545972 ] ASF GitHub Bot commented on THRIFT-3941: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1107: THRIFT-3941 WinXP version of thrift_poll() relies on und...

2016-10-04 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1107 Looks good to me. :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] thrift pull request #1107: THRIFT-3941 WinXP version of thrift_poll() relies...

2016-10-04 Thread tpcwang
GitHub user tpcwang opened a pull request: https://github.com/apache/thrift/pull/1107 THRIFT-3941 WinXP version of thrift_poll() relies on undefined behavior by passing a destructed variable to select() You can merge this pull request into a Git repository by running: $ git

[jira] [Commented] (THRIFT-3941) WinXP version of thrift_poll() relies on undefined behavior by passing a destructed variable to select()

2016-10-04 Thread Ted Wang (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15545886#comment-15545886 ] Ted Wang commented on THRIFT-3941: -- In fact, Thrift specifically targets Windows XP for broadest

[jira] [Commented] (THRIFT-3941) WinXP version of thrift_poll() relies on undefined behavior by passing a destructed variable to select()

2016-10-04 Thread Ted Wang (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15545841#comment-15545841 ] Ted Wang commented on THRIFT-3941: -- I know, but any client code can still set Windows XP to be the

[jira] [Commented] (THRIFT-3941) WinXP version of thrift_poll() relies on undefined behavior by passing a destructed variable to select()

2016-10-04 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15545822#comment-15545822 ] Jens Geyer commented on THRIFT-3941: You know that WinXP is no longer supported (except for POS

[jira] [Created] (THRIFT-3941) WinXP version of thrift_poll() relies on undefined behavior by passing a destructed variable to select()

2016-10-04 Thread Ted Wang (JIRA)
Ted Wang created THRIFT-3941: Summary: WinXP version of thrift_poll() relies on undefined behavior by passing a destructed variable to select() Key: THRIFT-3941 URL: https://issues.apache.org/jira/browse/THRIFT-3941

[jira] [Comment Edited] (THRIFT-3939) VS2010 complains about incorrect exception handling mode during cmake build

2016-10-04 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15545420#comment-15545420 ] James E. King, III edited comment on THRIFT-3939 at 10/4/16 3:11 PM: -

[jira] [Commented] (THRIFT-3939) VS2010 complains about incorrect exception handling mode during cmake build

2016-10-04 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15545420#comment-15545420 ] James E. King, III commented on THRIFT-3939: So I think this means that the exception

[GitHub] thrift issue #1036: THRIFT-3867 Specify BinaryProtocol and CompactProtocol

2016-10-04 Thread erikvanoosten
Github user erikvanoosten commented on the issue: https://github.com/apache/thrift/pull/1036 The specification documents are up at https://erikvanoosten.github.io/thrift-missing-specification/. --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (THRIFT-3867) Specify BinaryProtocol and CompactProtocol

2016-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15544724#comment-15544724 ] ASF GitHub Bot commented on THRIFT-3867: Github user erikvanoosten commented on the issue: