[jira] [Commented] (THRIFT-3038) Use of volatile in cpp library

2016-11-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15660913#comment-15660913 ] ASF GitHub Bot commented on THRIFT-3038: GitHub user jeking3 opened a pull request:

[jira] [Updated] (THRIFT-3038) Use of volatile in cpp library

2016-11-12 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3038: --- Description: In the cpp library there are several member variables which are

[GitHub] thrift pull request #1129: THRIFT-3038 clean up remaining volatile issues; r...

2016-11-12 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1129 THRIFT-3038 clean up remaining volatile issues; remove unused NoStarveReadWriteMutex class This takes care of items 1, 3, and 6 in the PR description. You can merge this pull request into a Git

[jira] [Updated] (THRIFT-3038) Use of volatile in cpp library

2016-11-12 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3038: --- Priority: Minor (was: Trivial) > Use of volatile in cpp library >

[jira] [Updated] (THRIFT-3038) Use of volatile in cpp library

2016-11-12 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3038: --- Priority: Trivial (was: Major) > Use of volatile in cpp library >

[jira] [Updated] (THRIFT-3038) Use of volatile in cpp library

2016-11-12 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3038: --- Affects Version/s: 0.10.0 0.9.3 > Use of volatile in cpp

[jira] [Commented] (THRIFT-3773) Swift Library

2016-11-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15660346#comment-15660346 ] ASF GitHub Bot commented on THRIFT-3773: Github user fumoboy007 commented on the issue:

[GitHub] thrift issue #1084: THRIFT-3773 Swift 3 Native Library

2016-11-12 Thread fumoboy007
Github user fumoboy007 commented on the issue: https://github.com/apache/thrift/pull/1084 Woah, nice! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[jira] [Commented] (THRIFT-3773) Swift Library

2016-11-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15660337#comment-15660337 ] ASF GitHub Bot commented on THRIFT-3773: Github user apocolipse commented on the issue:

[GitHub] thrift issue #1084: THRIFT-3773 Swift 3 Native Library

2016-11-12 Thread apocolipse
Github user apocolipse commented on the issue: https://github.com/apache/thrift/pull/1084 Update: I've modified the generated Async clients to use a new `TAsyncResult` parameter for callbacks rather than Optional Return/Error tuples. Short version of why is that those

[jira] [Commented] (THRIFT-3873) Fix various compiler warnings when using VS2010

2016-11-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15660301#comment-15660301 ] ASF GitHub Bot commented on THRIFT-3873: GitHub user jeking3 opened a pull request:

[GitHub] thrift pull request #1128: THRIFT-3873: fix compiler warnings on windows wit...

2016-11-12 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1128 THRIFT-3873: fix compiler warnings on windows with VS2010 Also changed VERSION to THRIFT_VERSION to avoid conflicts with third party or OS headers. You can merge this pull request into a Git

[GitHub] thrift issue #1121: TTransport.py micro-optimization: don't call len(chunk) ...

2016-11-12 Thread Jens-G
Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/1121 Thanks! Could you also create a JIRA ticket according to our [contrib guidelines](http://thrift.apache.org/docs/HowToContribute)? --- If your project is set up for it, you can reply to this

[jira] [Commented] (THRIFT-3301) Java generated code uses imports that can lead to class name collisions with IDL defined types

2016-11-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15660284#comment-15660284 ] ASF GitHub Bot commented on THRIFT-3301: Github user Jens-G commented on a diff in the pull

[GitHub] thrift pull request #1120: THRIFT-3301: Naming collisions possible in genera...

2016-11-12 Thread Jens-G
Github user Jens-G commented on a diff in the pull request: https://github.com/apache/thrift/pull/1120#discussion_r87700206 --- Diff: test/JavaTypes.thrift --- @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[jira] [Updated] (THRIFT-3932) C++ ThreadManager has a rare termination race

2016-11-12 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3932: --- Description: {{ThreadManger::join}} calls {{stopImpl(true)}}, which in turn calls

[jira] [Updated] (THRIFT-3932) C++ ThreadManager has a rare termination race

2016-11-12 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3932: --- Description: {{ThreadManger::join}} calls {{stopImpl(true)}}, which in turn calls

[jira] [Commented] (THRIFT-3932) C++ ThreadManager has a rare termination race

2016-11-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15660226#comment-15660226 ] ASF GitHub Bot commented on THRIFT-3932: Github user asfgit closed the pull request at:

[jira] [Resolved] (THRIFT-3932) C++ ThreadManager has a rare termination race

2016-11-12 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-3932. Resolution: Fixed > C++ ThreadManager has a rare termination race >

[GitHub] thrift pull request #1103: THRIFT-3932: fixed ThreadManager concurrency issu...

2016-11-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1103 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Updated] (THRIFT-3947) sockaddr type isn't always large enough for the return of getsockname

2016-11-12 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3947: --- Labels: IPv6 (was: ) > sockaddr type isn't always large enough for the return of

[jira] [Updated] (THRIFT-3947) sockaddr type isn't always large enough for the return of getsockname

2016-11-12 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3947: --- Affects Version/s: 0.10.0 > sockaddr type isn't always large enough for the return

[jira] [Resolved] (THRIFT-3947) sockaddr type isn't always large enough for the return of getsockname

2016-11-12 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-3947. Resolution: Fixed Fix Version/s: 0.11.0 All of the C++ library calls to

[jira] [Commented] (THRIFT-3947) sockaddr type isn't always large enough for the return of getsockname

2016-11-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15660213#comment-15660213 ] ASF GitHub Bot commented on THRIFT-3947: Github user asfgit closed the pull request at:

[GitHub] thrift pull request #1127: THRIFT-3947 use sockaddr_storage with getsockname...

2016-11-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1127 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Updated] (THRIFT-3947) sockaddr type isn't always large enough for the return of getsockname

2016-11-12 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3947: --- Component/s: (was: C++ - Library) Lua - Library > sockaddr type