[GitHub] thrift issue #1223: THRIFT-4137 vptr @ compiler

Github user jbapple-cloudera commented on the issue: https://github.com/apache/thrift/pull/1223 @jeking3 It looks to me like this is failing in TravisCI at the UBSan test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] thrift pull request #1223: THRIFT-4137 vptr @ compiler

GitHub user Jens-G opened a pull request: https://github.com/apache/thrift/pull/1223 THRIFT-4137 vptr @ compiler You can merge this pull request into a Git repository by running: $ git pull https://github.com/Jens-G/thrift THRIFT-4137 Alternatively you can review and apply

[jira] [Commented] (THRIFT-4137) Fix remaining undefined behavior invalid vptr casts in Thrift Compiler

[ https://issues.apache.org/jira/browse/THRIFT-4137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942418#comment-15942418 ] ASF GitHub Bot commented on THRIFT-4137: GitHub user Jens-G opened a pull request:

[jira] [Created] (THRIFT-4138) Fix remaining undefined behavior invalid vptr casts in C++ library

Jens Geyer created THRIFT-4138: -- Summary: Fix remaining undefined behavior invalid vptr casts in C++ library Key: THRIFT-4138 URL: https://issues.apache.org/jira/browse/THRIFT-4138 Project: Thrift

[jira] [Created] (THRIFT-4137) Fix remaining undefined behavior invalid vptr casts in Thrift Compiler

Jens Geyer created THRIFT-4137: -- Summary: Fix remaining undefined behavior invalid vptr casts in Thrift Compiler Key: THRIFT-4137 URL: https://issues.apache.org/jira/browse/THRIFT-4137 Project: Thrift

[jira] [Commented] (THRIFT-4134) Fix remaining undefined behavior invalid vptr casts

[ https://issues.apache.org/jira/browse/THRIFT-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942397#comment-15942397 ] Jim Apple commented on THRIFT-4134: --- Correction: there is one use in

[jira] [Commented] (THRIFT-4134) Fix remaining undefined behavior invalid vptr casts

[ https://issues.apache.org/jira/browse/THRIFT-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942387#comment-15942387 ] Jim Apple commented on THRIFT-4134: --- Here are a few options to fix the boost error: 1. Write a

[jira] [Resolved] (THRIFT-4136) Align is_binary() method with is_string() to simplify those checks

[ https://issues.apache.org/jira/browse/THRIFT-4136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-4136. Resolution: Fixed Fix Version/s: 0.11.0 Committed. > Align is_binary() method with

[jira] [Commented] (THRIFT-4136) Align is_binary() method with is_string() to simplify those checks

[ https://issues.apache.org/jira/browse/THRIFT-4136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942370#comment-15942370 ] ASF GitHub Bot commented on THRIFT-4136: Github user asfgit closed the pull request at:

[GitHub] thrift pull request #1221: THRIFT-4136

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1221 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (THRIFT-4134) Fix remaining undefined behavior invalid vptr casts

[ https://issues.apache.org/jira/browse/THRIFT-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942359#comment-15942359 ] Jens Geyer commented on THRIFT-4134: {code} vptr for 'std::basic_stringbuf

[jira] [Updated] (THRIFT-4133) Flaky Dart build

[ https://issues.apache.org/jira/browse/THRIFT-4133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-4133: --- Priority: Major (was: Critical) > Flaky Dart build > > > Key:

[jira] [Commented] (THRIFT-4134) Fix remaining undefined behavior invalid vptr casts

[ https://issues.apache.org/jira/browse/THRIFT-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942329#comment-15942329 ] ASF GitHub Bot commented on THRIFT-4134: Github user Jens-G commented on the issue:

[GitHub] thrift issue #1222: THRIFT-4134-Fix-remaining-undefined-behavior-invalid.pat...

Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/1222 To be honest, my intention is to fix the actual problem, not to refactor the whole app. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] thrift issue #1222: THRIFT-4134-Fix-remaining-undefined-behavior-invalid.pat...

Github user jbapple-cloudera commented on the issue: https://github.com/apache/thrift/pull/1222 How about ``` void t_json_generator::write_type_spec(t_type* ttype) { ttype = ttype->get_true_type(); write_string(get_type_name(ttype)); if

[jira] [Commented] (THRIFT-4134) Fix remaining undefined behavior invalid vptr casts

[ https://issues.apache.org/jira/browse/THRIFT-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942320#comment-15942320 ] ASF GitHub Bot commented on THRIFT-4134: Github user jbapple-cloudera commented on the issue:

[jira] [Commented] (THRIFT-4134) Fix remaining undefined behavior invalid vptr casts

[ https://issues.apache.org/jira/browse/THRIFT-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942314#comment-15942314 ] ASF GitHub Bot commented on THRIFT-4134: Github user Jens-G commented on the issue:

[GitHub] thrift issue #1222: THRIFT-4134-Fix-remaining-undefined-behavior-invalid.pat...

Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/1222 No, the intention is to patch everything. A few things are still open, but I will update the PR until we have it all. --- If your project is set up for it, you can reply to this email and have your

[jira] [Commented] (THRIFT-4134) Fix remaining undefined behavior invalid vptr casts

[ https://issues.apache.org/jira/browse/THRIFT-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942311#comment-15942311 ] ASF GitHub Bot commented on THRIFT-4134: Github user jbapple-cloudera commented on a diff in the

[GitHub] thrift pull request #1222: THRIFT-4134-Fix-remaining-undefined-behavior-inva...

Github user jbapple-cloudera commented on a diff in the pull request: https://github.com/apache/thrift/pull/1222#discussion_r108063510 --- Diff: build/docker/scripts/ubsan.sh --- @@ -15,7 +15,7 @@ export CXX=clang++-3.8 # undefined casting, aka "vptr". # # TODO: fix

[jira] [Commented] (THRIFT-4134) Fix remaining undefined behavior invalid vptr casts

[ https://issues.apache.org/jira/browse/THRIFT-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942308#comment-15942308 ] ASF GitHub Bot commented on THRIFT-4134: Github user Jens-G commented on the issue:

[GitHub] thrift issue #1222: THRIFT-4134-Fix-remaining-undefined-behavior-invalid.pat...

Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/1222 ``` void t_json_generator::write_type_spec(t_type* ttype) { ttype = ttype->get_true_type(); write_string(get_type_name(ttype)); if (ttype->is_struct() ||

[jira] [Commented] (THRIFT-4134) Fix remaining undefined behavior invalid vptr casts

[ https://issues.apache.org/jira/browse/THRIFT-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942304#comment-15942304 ] ASF GitHub Bot commented on THRIFT-4134: Github user Jens-G commented on a diff in the pull

[GitHub] thrift pull request #1222: THRIFT-4134-Fix-remaining-undefined-behavior-inva...

Github user Jens-G commented on a diff in the pull request: https://github.com/apache/thrift/pull/1222#discussion_r108063013 --- Diff: build/docker/scripts/ubsan.sh --- @@ -15,7 +15,7 @@ export CXX=clang++-3.8 # undefined casting, aka "vptr". # # TODO: fix undefined

[jira] [Commented] (THRIFT-4134) Fix remaining undefined behavior invalid vptr casts

[ https://issues.apache.org/jira/browse/THRIFT-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942303#comment-15942303 ] ASF GitHub Bot commented on THRIFT-4134: Github user Jens-G commented on a diff in the pull

[GitHub] thrift pull request #1222: THRIFT-4134-Fix-remaining-undefined-behavior-inva...

Github user Jens-G commented on a diff in the pull request: https://github.com/apache/thrift/pull/1222#discussion_r108062987 --- Diff: compiler/cpp/src/thrift/generate/t_xml_generator.cc --- @@ -391,11 +391,16 @@ void t_xml_generator::write_type(t_type* ttype) { if (type ==

[jira] [Commented] (THRIFT-4134) Fix remaining undefined behavior invalid vptr casts

[ https://issues.apache.org/jira/browse/THRIFT-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942290#comment-15942290 ] ASF GitHub Bot commented on THRIFT-4134: Github user jbapple-cloudera commented on a diff in the

[jira] [Commented] (THRIFT-4134) Fix remaining undefined behavior invalid vptr casts

[ https://issues.apache.org/jira/browse/THRIFT-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942291#comment-15942291 ] ASF GitHub Bot commented on THRIFT-4134: Github user jbapple-cloudera commented on a diff in the

[jira] [Commented] (THRIFT-4134) Fix remaining undefined behavior invalid vptr casts

[ https://issues.apache.org/jira/browse/THRIFT-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942292#comment-15942292 ] ASF GitHub Bot commented on THRIFT-4134: Github user jbapple-cloudera commented on a diff in the

[GitHub] thrift pull request #1222: THRIFT-4134-Fix-remaining-undefined-behavior-inva...

Github user jbapple-cloudera commented on a diff in the pull request: https://github.com/apache/thrift/pull/1222#discussion_r108061946 --- Diff: compiler/cpp/src/thrift/generate/t_json_generator.cc --- @@ -273,10 +273,14 @@ void t_json_generator::write_type_spec(t_type* ttype) {

[GitHub] thrift pull request #1222: THRIFT-4134-Fix-remaining-undefined-behavior-inva...

Github user jbapple-cloudera commented on a diff in the pull request: https://github.com/apache/thrift/pull/1222#discussion_r108061961 --- Diff: compiler/cpp/src/thrift/generate/t_xml_generator.cc --- @@ -391,11 +391,16 @@ void t_xml_generator::write_type(t_type* ttype) { if

[GitHub] thrift pull request #1222: THRIFT-4134-Fix-remaining-undefined-behavior-inva...

Github user jbapple-cloudera commented on a diff in the pull request: https://github.com/apache/thrift/pull/1222#discussion_r108061917 --- Diff: build/docker/scripts/ubsan.sh --- @@ -15,7 +15,7 @@ export CXX=clang++-3.8 # undefined casting, aka "vptr". # # TODO: fix

[jira] [Updated] (THRIFT-4136) align is_binary() method with is_string()

[ https://issues.apache.org/jira/browse/THRIFT-4136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-4136: --- Summary: align is_binary() method with is_string() (was: align is_binary() function with all other

[jira] [Comment Edited] (THRIFT-4134) Fix remaining undefined behavior invalid vptr casts

[ https://issues.apache.org/jira/browse/THRIFT-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942288#comment-15942288 ] Jens Geyer edited comment on THRIFT-4134 at 3/26/17 2:18 PM: - Hi, I just

[jira] [Commented] (THRIFT-4134) Fix remaining undefined behavior invalid vptr casts

[ https://issues.apache.org/jira/browse/THRIFT-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942288#comment-15942288 ] Jens Geyer commented on THRIFT-4134: Hi, I just made two PRs where I tried to fix what I was able to

[jira] [Commented] (THRIFT-4134) Fix remaining undefined behavior invalid vptr casts

[ https://issues.apache.org/jira/browse/THRIFT-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942286#comment-15942286 ] ASF GitHub Bot commented on THRIFT-4134: GitHub user Jens-G opened a pull request:

[GitHub] thrift pull request #1222: THRIFT-4134-Fix-remaining-undefined-behavior-inva...

GitHub user Jens-G opened a pull request: https://github.com/apache/thrift/pull/1222 THRIFT-4134-Fix-remaining-undefined-behavior-invalid.patch You can merge this pull request into a Git repository by running: $ git pull https://github.com/Jens-G/thrift THRIFT-4134

[jira] [Commented] (THRIFT-4136) align is_binary() function with all other types

[ https://issues.apache.org/jira/browse/THRIFT-4136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942284#comment-15942284 ] ASF GitHub Bot commented on THRIFT-4136: GitHub user Jens-G opened a pull request:

[GitHub] thrift pull request #1221: THRIFT-4136

GitHub user Jens-G opened a pull request: https://github.com/apache/thrift/pull/1221 THRIFT-4136 You can merge this pull request into a Git repository by running: $ git pull https://github.com/Jens-G/thrift THRIFT-4136 Alternatively you can review and apply these changes as

[jira] [Updated] (THRIFT-4134) Fix remaining undefined behavior invalid vptr casts

[ https://issues.apache.org/jira/browse/THRIFT-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Apple updated THRIFT-4134: -- Attachment: thrift-vptr-travis.txt I have attached {{thrift-vptr-travis.log}}, which is the raw log

[jira] [Created] (THRIFT-4136) align is_binary() function with all other types

Jens Geyer created THRIFT-4136: -- Summary: align is_binary() function with all other types Key: THRIFT-4136 URL: https://issues.apache.org/jira/browse/THRIFT-4136 Project: Thrift Issue Type:

[jira] [Assigned] (THRIFT-4136) align is_binary() function with all other types

[ https://issues.apache.org/jira/browse/THRIFT-4136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reassigned THRIFT-4136: -- Assignee: Jens Geyer > align is_binary() function with all other types >

[jira] [Updated] (THRIFT-4136) align is_binary() function with all other types

[ https://issues.apache.org/jira/browse/THRIFT-4136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-4136: --- Component/s: (was: Haxe - Compiler) (was: D - Compiler)

[jira] [Commented] (THRIFT-4133) Flaky Dart build

[ https://issues.apache.org/jira/browse/THRIFT-4133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942276#comment-15942276 ] Jim Apple commented on THRIFT-4133: --- TravisCI seems to fail during this step more often than it does

[jira] [Issue Comment Deleted] (THRIFT-4134) Fix remaining undefined behavior invalid vptr casts

[ https://issues.apache.org/jira/browse/THRIFT-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-4134: --- Comment: was deleted (was: boost is not used in the compiler code. If it is used there, it is

[GitHub] thrift issue #1211: Fix use closed(freed) connections

Github user xiaosuo commented on the issue: https://github.com/apache/thrift/pull/1211 I think this patch doesn't introduce any inconsistency. And the correctness of the number of active processors deserves another separated patch. We'd better not mix fixes into a huge patch.

[jira] [Commented] (THRIFT-4134) Fix remaining undefined behavior invalid vptr casts

[ https://issues.apache.org/jira/browse/THRIFT-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942274#comment-15942274 ] Jens Geyer commented on THRIFT-4134: boost is not used in the compiler code. If it is used there, it

[jira] [Commented] (THRIFT-4133) Flaky Dart build

[ https://issues.apache.org/jira/browse/THRIFT-4133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942270#comment-15942270 ] Jens Geyer commented on THRIFT-4133: To me it seems as if the other end closed the connection. There

Travis throwing again

Hi folks, whoever has access to the Travis machines: The npm is throwing lots of errors causing “red” builds again: npm WARN npm npm does not support Node.js v0.10.25 npm WARN npm You should probably upgrade to a newer version of node as we npm WARN npm can't make any promises that npm will

[GitHub] thrift issue #1211: Fix use closed(freed) connections

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1211 If you have the fixes let's get them all in together. The current fix is not complete and causes counting errors, which lead to - I don't know... --- If your project is set up for it, you can

[jira] [Commented] (THRIFT-3773) Swift Library

[ https://issues.apache.org/jira/browse/THRIFT-3773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942260#comment-15942260 ] ASF GitHub Bot commented on THRIFT-3773: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1084: THRIFT-3773 Swift 3 Native Library

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1084 None that I know of. What you can do is: 1. Make sure language support is in the Dockerfile for the ubuntu and debian builds. 2. Look for CROSS_LANGS in the top level Makefile.am.