[jira] [Commented] (THRIFT-577) Factor BinaryProtocolAccelerated into separate components

2017-10-25 Thread Robert Lu (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220009#comment-16220009 ] Robert Lu commented on THRIFT-577: -- The fastbinary.c is already move to lib/py/src/ext/ by THRIFT-3612.

[jira] [Commented] (THRIFT-515) Having the same namespace in separate thrift files generates non-working code

2017-10-25 Thread Robert Lu (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219997#comment-16219997 ] Robert Lu commented on THRIFT-515: -- As discussed above, This is not a bug. Please close this. > Having

[GitHub] thrift pull request #1399: THRIFT-4370: build generated code before running ...

2017-10-25 Thread RobberPhex
Github user RobberPhex commented on a diff in the pull request: https://github.com/apache/thrift/pull/1399#discussion_r147048687 --- Diff: lib/py/setup.py --- @@ -22,7 +22,7 @@ import sys try: from setuptools import setup, Extension -except: +except

[jira] [Commented] (THRIFT-4370) Ubuntu Artful cppcheck and flake8 are more stringent and causing SCA build job failures

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219995#comment-16219995 ] ASF GitHub Bot commented on THRIFT-4370: Github user RobberPhex commented on a diff in the pull

[jira] [Commented] (THRIFT-2998) Node.js: Missing header from http request

2017-10-25 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219950#comment-16219950 ] James E. King, III commented on THRIFT-2998: I'm going to submit a 2nd pull request with this

[jira] [Assigned] (THRIFT-2998) Node.js: Missing header from http request

2017-10-25 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-2998: -- Assignee: James E. King, III > Node.js: Missing header from http request >

[jira] [Updated] (THRIFT-2998) Node.js: Missing header from http request

2017-10-25 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-2998: --- Priority: Minor (was: Major) > Node.js: Missing header from http request >

[GitHub] thrift issue #1261: Replace the use of Indirect Object Syntax calls to new()

2017-10-25 Thread djzort
Github user djzort commented on the issue: https://github.com/apache/thrift/pull/1261 I finally made a jira account, but i need a month to recover from the horrors ---

[jira] [Updated] (THRIFT-4372) Pipe write operations across a network are limited to 65,535 bytes per write.

2017-10-25 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-4372: --- Description: {quote}Pipe write operations across a network are limited to 65,535 bytes per write.

[jira] [Updated] (THRIFT-4372) Pipe write operations across a network are limited to 65,535 bytes per write.

2017-10-25 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-4372: --- Description: {quote}Pipe write operations across a network are limited to 65,535 bytes per write.

[jira] [Updated] (THRIFT-4372) Pipe write operations across a network are limited to 65,535 bytes per write.

2017-10-25 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-4372: --- Description: {quote}Pipe write operations across a network are limited to 65,535 bytes per write.

[jira] [Updated] (THRIFT-4372) Pipe write operations across a network are limited to 65,535 bytes per write.

2017-10-25 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-4372: --- Component/s: Delphi - Library > Pipe write operations across a network are limited to 65,535 bytes

[jira] [Commented] (THRIFT-2998) Node.js: Missing header from http request

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219510#comment-16219510 ] ASF GitHub Bot commented on THRIFT-2998: Github user jeking3 commented on the issue:

[GitHub] thrift issue #378: THRIFT-2998: Set Content-Type for HTTP request in Node.js...

2017-10-25 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/378 To properly test this fix I need to add http transport support to the nodejs cross programs, so I'll do that as part of the effort. ---

[jira] [Commented] (THRIFT-4372) Pipe write operations across a network are limited to 65,535 bytes per write.

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219478#comment-16219478 ] ASF GitHub Bot commented on THRIFT-4372: GitHub user Jens-G opened a pull request:

[GitHub] thrift pull request #1402: THRIFT-4372 Pipe write operations across a networ...

2017-10-25 Thread Jens-G
GitHub user Jens-G opened a pull request: https://github.com/apache/thrift/pull/1402 THRIFT-4372 Pipe write operations across a network are limited to 65,… …535 bytes per write Client: C# Patch: Jens Geyer You can merge this pull request into a Git repository by

[jira] [Updated] (THRIFT-4373) Extending Thrift class results in "Attempt serialize from non-Thrift object"

2017-10-25 Thread Josip Sokcevic (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josip Sokcevic updated THRIFT-4373: --- Attachment: 0001-THRIFT-4373-Derefer-PHP-zval-_TSPEC.patch > Extending Thrift class results

[jira] [Commented] (THRIFT-4373) Extending Thrift class results in "Attempt serialize from non-Thrift object"

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219452#comment-16219452 ] ASF GitHub Bot commented on THRIFT-4373: GitHub user sokac opened a pull request:

[GitHub] thrift pull request #1401: THRIFT-4373: Derefer PHP zval _TSPEC

2017-10-25 Thread sokac
GitHub user sokac opened a pull request: https://github.com/apache/thrift/pull/1401 THRIFT-4373: Derefer PHP zval _TSPEC You can merge this pull request into a Git repository by running: $ git pull https://github.com/sokac/thrift php Alternatively you can review and apply

[jira] [Created] (THRIFT-4373) Extending Thrift class results in "Attempt serialize from non-Thrift object"

2017-10-25 Thread Josip Sokcevic (JIRA)
Josip Sokcevic created THRIFT-4373: -- Summary: Extending Thrift class results in "Attempt serialize from non-Thrift object" Key: THRIFT-4373 URL: https://issues.apache.org/jira/browse/THRIFT-4373

[jira] [Commented] (THRIFT-4356) thrift_protocol call Transport cause Segmentation fault

2017-10-25 Thread Daniel Smith (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219292#comment-16219292 ] Daniel Smith commented on THRIFT-4356: -- Thanks much! Confirmed this fixes what I was seeing.

[jira] [Commented] (THRIFT-4356) thrift_protocol call Transport cause Segmentation fault

2017-10-25 Thread Robert Lu (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219284#comment-16219284 ] Robert Lu commented on THRIFT-4356: --- [~danielsmithsd] Thanks for your feedback, I submit a PR:

[jira] [Comment Edited] (THRIFT-4356) thrift_protocol call Transport cause Segmentation fault

2017-10-25 Thread Daniel Smith (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219118#comment-16219118 ] Daniel Smith edited comment on THRIFT-4356 at 10/25/17 6:54 PM: [~Robert

[GitHub] thrift pull request #1400: add stdc++ back

2017-10-25 Thread RobberPhex
GitHub user RobberPhex opened a pull request: https://github.com/apache/thrift/pull/1400 add stdc++ back at Linux x86, will cause errror: # php -d extension=./thrift_protocol.so -m PHP Warning: PHP Startup: Unable to load dynamic library

[jira] [Commented] (THRIFT-4356) thrift_protocol call Transport cause Segmentation fault

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219281#comment-16219281 ] ASF GitHub Bot commented on THRIFT-4356: GitHub user RobberPhex opened a pull request:

[jira] [Commented] (THRIFT-4207) Accelerated version of TBinaryProtocol allows invalid input to string fields.

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219265#comment-16219265 ] ASF GitHub Bot commented on THRIFT-4207: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1274: THRIFT-4207: Make sure Python Accelerated protocol does ...

2017-10-25 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1274 I pulled these changes into a sandbox and started the `ubuntu-xenial` docker image, and then ran `build/docker/scripts/autotools.sh` which is what Travis CI would do for one of the unit test jobs.

[jira] [Updated] (THRIFT-4372) Pipe write operations across a network are limited to 65,535 bytes per write.

2017-10-25 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-4372: --- Description: {quote}Pipe write operations across a network are limited to 65,535 bytes per write.

[jira] [Updated] (THRIFT-4372) Pipe write operations across a network are limited to 65,535 bytes per write.

2017-10-25 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-4372: --- Priority: Critical (was: Major) > Pipe write operations across a network are limited to 65,535

[jira] [Updated] (THRIFT-4372) Pipe write operations across a network are limited to 65,535 bytes per write.

2017-10-25 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-4372: --- Description: {quote}Pipe write operations across a network are limited to 65,535 bytes per write.

[jira] [Created] (THRIFT-4372) Pipe write operations across a network are limited to 65,535 bytes per write.

2017-10-25 Thread Jens Geyer (JIRA)
Jens Geyer created THRIFT-4372: -- Summary: Pipe write operations across a network are limited to 65,535 bytes per write. Key: THRIFT-4372 URL: https://issues.apache.org/jira/browse/THRIFT-4372 Project:

[jira] [Commented] (THRIFT-2998) Node.js: Missing header from http request

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219234#comment-16219234 ] ASF GitHub Bot commented on THRIFT-2998: Github user jeking3 commented on the issue:

[GitHub] thrift issue #378: THRIFT-2998: Set Content-Type for HTTP request in Node.js...

2017-10-25 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/378 @tstanev Thank you for putting in the time. The PR backlog on the project is getting better - there were over 100 PRs at the beginning of the year and we're down to 50, so every little bit helps.

[jira] [Commented] (THRIFT-4271) warning: 'register' storage class is deprecated

2017-10-25 Thread Robert Lu (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219228#comment-16219228 ] Robert Lu commented on THRIFT-4271: --- When you build thrift_prototcol php extension, after run phpize,

[jira] [Commented] (THRIFT-2998) Node.js: Missing header from http request

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219213#comment-16219213 ] ASF GitHub Bot commented on THRIFT-2998: Github user tstanev commented on the issue:

[GitHub] thrift issue #378: THRIFT-2998: Set Content-Type for HTTP request in Node.js...

2017-10-25 Thread tstanev
Github user tstanev commented on the issue: https://github.com/apache/thrift/pull/378 By the way -- it's been nearly three years and I have since switched to another way of doing things. You can close the PR if nobody else needs it. ---

[jira] [Commented] (THRIFT-2790) thrift -gen all => an option to generate all languages and features

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219211#comment-16219211 ] ASF GitHub Bot commented on THRIFT-2790: Github user Jens-G commented on the issue:

[GitHub] thrift issue #782: THRIFT-2790 thrift -gen all => an option to generate all ...

2017-10-25 Thread Jens-G
Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/782 This will not generate nodejs code, to name just one case. ---

[jira] [Commented] (THRIFT-2998) Node.js: Missing header from http request

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219207#comment-16219207 ] ASF GitHub Bot commented on THRIFT-2998: Github user tstanev commented on the issue:

[GitHub] thrift issue #378: THRIFT-2998: Set Content-Type for HTTP request in Node.js...

2017-10-25 Thread tstanev
Github user tstanev commented on the issue: https://github.com/apache/thrift/pull/378 It's rebased now. ---

[jira] [Assigned] (THRIFT-4207) Accelerated version of TBinaryProtocol allows invalid input to string fields.

2017-10-25 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-4207: -- Assignee: James E. King, III > Accelerated version of TBinaryProtocol allows

[jira] [Commented] (THRIFT-4207) Accelerated version of TBinaryProtocol allows invalid input to string fields.

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219201#comment-16219201 ] ASF GitHub Bot commented on THRIFT-4207: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1274: THRIFT-4207: Make sure Python Accelerated protocol does ...

2017-10-25 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1274 I'll pull the changes into my sandbox and run unit, cross, ubsan, and sca jobs. ---

[jira] [Commented] (THRIFT-4207) Accelerated version of TBinaryProtocol allows invalid input to string fields.

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219199#comment-16219199 ] ASF GitHub Bot commented on THRIFT-4207: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1274: THRIFT-4207: Make sure Python Accelerated protocol does ...

2017-10-25 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1274 Travis is experiencing an outage event w.r.t Docker Hub that started this morning. ---

[jira] [Commented] (THRIFT-4207) Accelerated version of TBinaryProtocol allows invalid input to string fields.

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219126#comment-16219126 ] ASF GitHub Bot commented on THRIFT-4207: Github user elprans commented on the issue:

[GitHub] thrift issue #1274: THRIFT-4207: Make sure Python Accelerated protocol does ...

2017-10-25 Thread elprans
Github user elprans commented on the issue: https://github.com/apache/thrift/pull/1274 Fixed, but travis seems to be unstable again. ---

[jira] [Commented] (THRIFT-4356) thrift_protocol call Transport cause Segmentation fault

2017-10-25 Thread Daniel Smith (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219118#comment-16219118 ] Daniel Smith commented on THRIFT-4356: -- [~Robert Lu] What version of PHP was this tested on? It

[GitHub] thrift issue #1318: Added async nonblocking ssl support in java client

2017-10-25 Thread RandyAbernethy
Github user RandyAbernethy commented on the issue: https://github.com/apache/thrift/pull/1318 I can get to this this weekend. ---

[jira] [Commented] (THRIFT-4362) Missing size-check can lead to huge memory allocation

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218845#comment-16218845 ] ASF GitHub Bot commented on THRIFT-4362: Github user jeking3 commented on the issue:

[jira] [Commented] (THRIFT-4362) Missing size-check can lead to huge memory allocation

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218838#comment-16218838 ] ASF GitHub Bot commented on THRIFT-4362: Github user ChristianCiach commented on the issue:

[GitHub] thrift issue #1398: THRIFT-4362 check "read length" in readStringBody(int)

2017-10-25 Thread ChristianCiach
Github user ChristianCiach commented on the issue: https://github.com/apache/thrift/pull/1398 So there won't be a version 0.9.4 or 0.10.1? ---

[jira] [Commented] (THRIFT-4187) Dart -> Rust Framed cross tests fail

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218816#comment-16218816 ] ASF GitHub Bot commented on THRIFT-4187: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1269: THRIFT-4187 Allow dart framed transport to read incomple...

2017-10-25 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1269 Don't worry, I'm just doing my usual "push things forward" bit. :) I got the backlog down to 52 open PRs, but that's still about 45 too many for my taste. ---

[jira] [Commented] (THRIFT-3676) Cocoa server does not emit exceptions

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218814#comment-16218814 ] ASF GitHub Bot commented on THRIFT-3676: Github user asfgit closed the pull request at:

[jira] [Commented] (THRIFT-2987) TProtocol should return NSString directly rather than by reference to appease ARC

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218808#comment-16218808 ] ASF GitHub Bot commented on THRIFT-2987: Github user asfgit closed the pull request at:

[jira] [Commented] (THRIFT-3539) Use self.process_* instead of Processor.process_* in generated processor code

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218810#comment-16218810 ] ASF GitHub Bot commented on THRIFT-3539: Github user asfgit closed the pull request at:

[jira] [Commented] (THRIFT-3405) Go THttpClient misuses http.Client objects

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218809#comment-16218809 ] ASF GitHub Bot commented on THRIFT-3405: Github user asfgit closed the pull request at:

[jira] [Commented] (THRIFT-3395) Cocoa compiler produces corrupt code when boxing enums inside map.

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218811#comment-16218811 ] ASF GitHub Bot commented on THRIFT-3395: Github user asfgit closed the pull request at:

[jira] [Commented] (THRIFT-3830) Add detail exception message between server-side and client-side

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218812#comment-16218812 ] ASF GitHub Bot commented on THRIFT-3830: Github user asfgit closed the pull request at:

[jira] [Commented] (THRIFT-3743) Java JSON protocol left in incorrect state when an exception is thrown during read or write operations

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218813#comment-16218813 ] ASF GitHub Bot commented on THRIFT-3743: Github user asfgit closed the pull request at:

[GitHub] thrift pull request #947: THRIFT-3743 Java JSON protocol left in incorrect s...

2017-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/947 ---

[GitHub] thrift pull request #657: Cocoa compiler: fixed incorrect boxing of enums in...

2017-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/657 ---

[GitHub] thrift pull request #896: THRIFT-3676

2017-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/896 ---

[GitHub] thrift pull request #1012: THRIFT-3830

2017-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1012 ---

[GitHub] thrift pull request #387: THRIFT-2987: returns message/struct/field names di...

2017-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/387 ---

[GitHub] thrift pull request #794: Update NodeClient.js

2017-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/794 ---

[GitHub] thrift pull request #701: THRIFT-3405

2017-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/701 ---

[GitHub] thrift pull request #1015: Update connection.js

2017-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1015 ---

[GitHub] thrift pull request #562: Thrift 3265--servers for pipe applications (stdin,...

2017-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/562 ---

[GitHub] thrift pull request #480: make generated js file strict mode for nodejs

2017-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/480 ---

[jira] [Commented] (THRIFT-4187) Dart -> Rust Framed cross tests fail

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218805#comment-16218805 ] ASF GitHub Bot commented on THRIFT-4187: Github user allengeorge commented on the issue:

[GitHub] thrift issue #1269: THRIFT-4187 Allow dart framed transport to read incomple...

2017-10-25 Thread allengeorge
Github user allengeorge commented on the issue: https://github.com/apache/thrift/pull/1269 Hi James - I’m really sorry for the delay; slammed at work. I’ll work on it this weekend. Again, super sorry about this From: James E.

[GitHub] thrift issue #1380: Support x64 build mode on Windows with DMD v2.076.0.

2017-10-25 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1380 Any news? ---

[GitHub] thrift issue #1318: Added async nonblocking ssl support in java client

2017-10-25 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1318 @dthaluru, @RandyAbernethy any updates? ---

[jira] [Commented] (THRIFT-4207) Accelerated version of TBinaryProtocol allows invalid input to string fields.

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218796#comment-16218796 ] ASF GitHub Bot commented on THRIFT-4207: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1311: Fix for constant assignments to optional fields in Go.

2017-10-25 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1311 @davinchia we've cleared out the CI build issues, so if you could squash your changes to one commit then rebase on master, then do a force push to refresh this pull request, it'll kick off a new

[jira] [Commented] (THRIFT-4187) Dart -> Rust Framed cross tests fail

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218794#comment-16218794 ] ASF GitHub Bot commented on THRIFT-4187: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1289: fix TypeError when a py3 str is passed to the function.

2017-10-25 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1289 Could you open a Jira ticker for this? https://thrift.apache.org/docs/HowToContribute Also could you rebase on master and refresh the PR so we get a clean build, now that CI is

[GitHub] thrift issue #1274: THRIFT-4207: Make sure Python Accelerated protocol does ...

2017-10-25 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1274 This had some errors and needs more work - please move it forward. ---

[GitHub] thrift issue #1269: THRIFT-4187 Allow dart framed transport to read incomple...

2017-10-25 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1269 @allengeorge if you add framed transport in dart to the cross test, that would test a lot... but it would not test error conditions such as this one. Just a reminder, this needs to move forward.

[GitHub] thrift issue #1261: Replace the use of Indirect Object Syntax calls to new()

2017-10-25 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1261 @djzort reminder we need a Jira THRIFT issue and squash and rebase on master. ---

[GitHub] thrift pull request #1141: support for timeout in node http connection

2017-10-25 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1141#discussion_r146879631 --- Diff: lib/nodejs/lib/thrift/http_connection.js --- @@ -214,6 +214,18 @@ HttpConnection.prototype.write = function(data) { var req = (self.https)

[jira] [Commented] (THRIFT-3773) Swift Library

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218782#comment-16218782 ] ASF GitHub Bot commented on THRIFT-3773: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1093: Add persistence patch

2017-10-25 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1093 @StachOverflow will you be moving this forward or should it be closed? ---

[jira] [Commented] (THRIFT-3916) Errors thrown from JavaScript client is strings and not errors

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218780#comment-16218780 ] ASF GitHub Bot commented on THRIFT-3916: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1084: THRIFT-3773 Swift 3 Native Library

2017-10-25 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1084 What needs to happen next to move this forward? ---

[GitHub] thrift issue #1075: THRIFT-3916 Throw proper errors from JS, not strings

2017-10-25 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1075 @SimenB if you are interested in resurrecting this let me know - rebase on current master and push to CI will run all our tests. ---

[jira] [Commented] (THRIFT-3876) haxe js/nodejs client

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218774#comment-16218774 ] ASF GitHub Bot commented on THRIFT-3876: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1058: Node.js: Set/unset client seqid for json_protocol and co...

2017-10-25 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1058 This change needs a Jira ticket; please see https://thrift.apache.org/docs/HowToContribute. Also if you can rebase on master and push that will kick a new CI build; CI needs to pass (or failures

[GitHub] thrift issue #1056: java: adding factories to the generated Java classes

2017-10-25 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1056 This needs to be rebased on the current master and resubmitted; we need a clean CI build before we can proceed. ---

[GitHub] thrift issue #1045: THRIFT-3876 haxe js/nodejs client

2017-10-25 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1045 So I agree that changes like this need representation in the cross test. It would be nice if folks could patch up any ill will and move this forward. ---

[GitHub] thrift issue #1038: replace 'binary' on the base types

2017-10-25 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1038 This needs a Jira item opened for it, and needs to be rebased and merge conflicts fixed. See; https://thrift.apache.org/docs/HowToContribute Thanks. ---

[GitHub] thrift issue #1003: passing exception back to handler for custom use cases

2017-10-25 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1003 @gonthe can you rebase on master? ---

[jira] [Commented] (THRIFT-3812) Option to prefix namespace to Swift type names

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218756#comment-16218756 ] ASF GitHub Bot commented on THRIFT-3812: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1002: THRIFT-3812 Add option to prefix namespace Swift type na...

2017-10-25 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1002 This hasn't been touched in over a year - what needs to be done? ---

[jira] [Commented] (THRIFT-3783) python code generator dose not handle struct dependent

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218752#comment-16218752 ] ASF GitHub Bot commented on THRIFT-3783: Github user jeking3 commented on the issue:

[GitHub] thrift issue #982: THRIFT-3783: python code generator dose not handle struct...

2017-10-25 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/982 Does this need further work or should it be closed? ---

[GitHub] thrift issue #979: THRIFT-3779 Qt Client Android and Windows QTcpSocket

2017-10-25 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/979 Folks who originally commented on this, please follow up. ---

[jira] [Commented] (THRIFT-3779) Qt Client Android and Windows QTcpSocket

2017-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218748#comment-16218748 ] ASF GitHub Bot commented on THRIFT-3779: Github user jeking3 commented on the issue:

  1   2   >