[jira] [Resolved] (THRIFT-2998) Node.js: Missing header from http request

2017-10-28 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-2998. Resolution: Fixed Fix Version/s: 0.11.0 Committed along with additional

[jira] [Commented] (THRIFT-2998) Node.js: Missing header from http request

2017-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223782#comment-16223782 ] ASF GitHub Bot commented on THRIFT-2998: Github user asfgit closed the pull request at:

[jira] [Commented] (THRIFT-2998) Node.js: Missing header from http request

2017-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223783#comment-16223783 ] ASF GitHub Bot commented on THRIFT-2998: Github user asfgit closed the pull request at:

[GitHub] thrift pull request #378: THRIFT-2998: Set Content-Type for HTTP request in ...

2017-10-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/378 ---

[GitHub] thrift pull request #1403: THRIFT-2998, combined #378 with enabling nodejs i...

2017-10-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1403 ---

[jira] [Commented] (THRIFT-4376) Coverity high impact issue resolution

2017-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223764#comment-16223764 ] ASF GitHub Bot commented on THRIFT-4376: GitHub user jeking3 opened a pull request:

[GitHub] thrift pull request #1405: THRIFT-4376: fix more high impact coverity defect...

2017-10-28 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1405 THRIFT-4376: fix more high impact coverity defects You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift coverity Alternatively you

[jira] [Commented] (THRIFT-4376) Coverity high impact issue resolution

2017-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223748#comment-16223748 ] ASF GitHub Bot commented on THRIFT-4376: Github user asfgit closed the pull request at:

[jira] [Commented] (THRIFT-4376) Coverity high impact issue resolution

2017-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223749#comment-16223749 ] ASF GitHub Bot commented on THRIFT-4376: Github user asfgit closed the pull request at:

[GitHub] thrift pull request #1404: THRIFT-4376: fix a few high impact coverity defec...

2017-10-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1404 ---

[GitHub] thrift pull request #1404: THRIFT-4376: fix a few high impact coverity defec...

2017-10-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1404 ---

[jira] [Commented] (THRIFT-4207) Accelerated version of TBinaryProtocol allows invalid input to string fields.

2017-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223665#comment-16223665 ] ASF GitHub Bot commented on THRIFT-4207: Github user elprans commented on a diff in the pull

[GitHub] thrift pull request #1274: THRIFT-4207: Make sure Python Accelerated protoco...

2017-10-28 Thread elprans
Github user elprans commented on a diff in the pull request: https://github.com/apache/thrift/pull/1274#discussion_r147559605 --- Diff: lib/py/src/ext/protocol.tcc --- @@ -419,18 +419,30 @@ bool ProtocolBase::encodeValue(PyObject* value, TType type, PyObject* type

[jira] [Commented] (THRIFT-4207) Accelerated version of TBinaryProtocol allows invalid input to string fields.

2017-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223664#comment-16223664 ] ASF GitHub Bot commented on THRIFT-4207: Github user elprans commented on a diff in the pull

[GitHub] thrift pull request #1274: THRIFT-4207: Make sure Python Accelerated protoco...

2017-10-28 Thread elprans
Github user elprans commented on a diff in the pull request: https://github.com/apache/thrift/pull/1274#discussion_r147559529 --- Diff: lib/py/src/protocol/TProtocol.py --- @@ -118,6 +118,8 @@ def writeDouble(self, dub): pass def writeString(self,

[GitHub] thrift pull request #1404: THRIFT-4376: fix a few high impact coverity defec...

2017-10-28 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1404 THRIFT-4376: fix a few high impact coverity defects: 1458947: memory leak in compiler 1458787: resource leak in c_glib led to discovery of assert() abuse 1459090: fix string.find result

[jira] [Commented] (THRIFT-4376) Coverity high impact issue resolution

2017-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223654#comment-16223654 ] ASF GitHub Bot commented on THRIFT-4376: GitHub user jeking3 opened a pull request:

[jira] [Created] (THRIFT-4376) Coverity high impact issue resolution

2017-10-28 Thread James E. King, III (JIRA)
James E. King, III created THRIFT-4376: -- Summary: Coverity high impact issue resolution Key: THRIFT-4376 URL: https://issues.apache.org/jira/browse/THRIFT-4376 Project: Thrift Issue

[GitHub] thrift pull request #1403: THRIFT-2998, combined #378 with enabling nodejs i...

2017-10-28 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1403 THRIFT-2998, combined #378 with enabling nodejs in make cross Yes, one little dlang warning fix slipped in there too. :) You can merge this pull request into a Git repository by running: $

[jira] [Commented] (THRIFT-2998) Node.js: Missing header from http request

2017-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223565#comment-16223565 ] ASF GitHub Bot commented on THRIFT-2998: GitHub user jeking3 opened a pull request:

[jira] [Commented] (THRIFT-3737) Improve TSocket isOpen() implementation to give more accurate connection status.

2017-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223558#comment-16223558 ] ASF GitHub Bot commented on THRIFT-3737: Github user jeking3 commented on the issue:

[GitHub] thrift issue #945: THRIFT-3737 Improve isOpen() to give accurate tcp connect...

2017-10-28 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/945 If that is the case and the change is no longer desired, we need to close this out somehow. ---

[jira] [Commented] (THRIFT-4207) Accelerated version of TBinaryProtocol allows invalid input to string fields.

2017-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223556#comment-16223556 ] ASF GitHub Bot commented on THRIFT-4207: Github user nsuke commented on a diff in the pull

[GitHub] thrift issue #1289: fix TypeError when a py3 str is passed to the function.

2017-10-28 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1289 @nsuke it sounds like you would recommend that we do not accept this fix, and have people do their own conversion before trying to add a string, to make sure it is a byte string (UTF-8 encoded).

[jira] [Commented] (THRIFT-4207) Accelerated version of TBinaryProtocol allows invalid input to string fields.

2017-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223555#comment-16223555 ] ASF GitHub Bot commented on THRIFT-4207: Github user nsuke commented on a diff in the pull

[GitHub] thrift pull request #1274: THRIFT-4207: Make sure Python Accelerated protoco...

2017-10-28 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1274#discussion_r147556105 --- Diff: lib/py/src/ext/protocol.tcc --- @@ -419,18 +419,30 @@ bool ProtocolBase::encodeValue(PyObject* value, TType type, PyObject* type case

[GitHub] thrift pull request #1274: THRIFT-4207: Make sure Python Accelerated protoco...

2017-10-28 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1274#discussion_r147555909 --- Diff: lib/py/src/protocol/TProtocol.py --- @@ -118,6 +118,8 @@ def writeDouble(self, dub): pass def writeString(self,

[jira] [Updated] (THRIFT-4308) D language docker images need demios for libevent and openssl fixed to re-enable make cross on dlang

2017-10-28 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4308: --- Summary: D language docker images need demios for libevent and openssl fixed to

[jira] [Updated] (THRIFT-4308) D language docker images need demios for libevent and openssl fixed

2017-10-28 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4308: --- Issue Type: Improvement (was: Bug) > D language docker images need demios for

[jira] [Updated] (THRIFT-4308) D language docker images need demios for libevent and openssl fixed

2017-10-28 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4308: --- Description: I had to disable the deimos hooks for libevent and openssl because they

[jira] [Commented] (THRIFT-3773) Swift Library

2017-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223541#comment-16223541 ] ASF GitHub Bot commented on THRIFT-3773: Github user nsuke commented on a diff in the pull

[jira] [Commented] (THRIFT-3773) Swift Library

2017-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223542#comment-16223542 ] ASF GitHub Bot commented on THRIFT-3773: Github user nsuke commented on a diff in the pull

[GitHub] thrift pull request #1084: THRIFT-3773 Swift 3 Native Library

2017-10-28 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1084#discussion_r147555627 --- Diff: compiler/cpp/src/thrift/generate/t_swift_generator.cc.old --- @@ -0,0 +1,3249 @@ +/* --- End diff -- Can you remove this one if

[GitHub] thrift pull request #1084: THRIFT-3773 Swift 3 Native Library

2017-10-28 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1084#discussion_r147555608 --- Diff: compiler/cpp/src/thrift/generate/t_swift_generator.cc --- @@ -95,19 +110,20 @@ class t_swift_generator : public t_oop_generator { void

[jira] [Commented] (THRIFT-3773) Swift Library

2017-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223540#comment-16223540 ] ASF GitHub Bot commented on THRIFT-3773: Github user nsuke commented on the issue:

[GitHub] thrift issue #1084: THRIFT-3773 Swift 3 Native Library

2017-10-28 Thread nsuke
Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/1084 This replaces current Swift2 generator/lib with new one which supports Swift3. The current one is still kept as option `swift:cocoa`, though. Swift 2 has been not usable with latest XCode for

[jira] [Commented] (THRIFT-3737) Improve TSocket isOpen() implementation to give more accurate connection status.

2017-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223539#comment-16223539 ] ASF GitHub Bot commented on THRIFT-3737: Github user nsuke commented on the issue:

[GitHub] thrift issue #945: THRIFT-3737 Improve isOpen() to give accurate tcp connect...

2017-10-28 Thread nsuke
Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/945 There's no real use case anymore. happybase does not use Apache Thrift any more. ---

[GitHub] thrift issue #1289: fix TypeError when a py3 str is passed to the function.

2017-10-28 Thread nsuke
Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/1289 It's more of a usability problem. The problem is that the user is passing a non-`byte` instance to `writeBinary`. It's basically the same error as when you pass str `'42'` (not integer `42`)

[jira] [Commented] (THRIFT-3779) Qt Client Android and Windows QTcpSocket

2017-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223533#comment-16223533 ] ASF GitHub Bot commented on THRIFT-3779: Github user nsuke commented on the issue:

[GitHub] thrift issue #979: THRIFT-3779 Qt Client Android and Windows QTcpSocket

2017-10-28 Thread nsuke
Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/979 This PR does the following * use `qmake` in addition to autotools and cmake to build C++ lib * introduce blocking variant of Qt based transport The motivation was to use blocking

[GitHub] thrift issue #1289: fix TypeError when a py3 str is passed to the function.

2017-10-28 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1289 Based on what I've read about py3 strings, and the fact that thrift strings are designated to be encoded as UTF8, this change seems correct. I'm not so sure about what happens on the other side

[jira] [Commented] (THRIFT-4207) Accelerated version of TBinaryProtocol allows invalid input to string fields.

2017-10-28 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223497#comment-16223497 ] James E. King, III commented on THRIFT-4207: Any idea if this is related to:

[jira] [Resolved] (THRIFT-4374) cannot load thrift_protocol due to undefined symbol: _ZTVN10__cxxabiv120__si_class_type_infoE

2017-10-28 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4374. Resolution: Fixed Fix Version/s: 0.11.0 > cannot load thrift_protocol due

[jira] [Resolved] (THRIFT-4026) TSSLSocket doesn't work with Python < 2.7.9

2017-10-28 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4026. Resolution: Fixed I am able to run the lib/py unit tests which includes ssl socket

[jira] [Resolved] (THRIFT-515) Having the same namespace in separate thrift files generates non-working code

2017-10-28 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-515. --- Resolution: Not A Problem Assignee: Jens Geyer Closed, by design- > Having the same namespace

[jira] [Closed] (THRIFT-515) Having the same namespace in separate thrift files generates non-working code

2017-10-28 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer closed THRIFT-515. - > Having the same namespace in separate thrift files generates non-working code >