[jira] [Commented] (THRIFT-4378) add set stopTimeoutUnit method to TThreadPoolServer

[ https://issues.apache.org/jira/browse/THRIFT-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226199#comment-16226199 ] ASF GitHub Bot commented on THRIFT-4378: Github user itegel commented on the issue:

[GitHub] thrift issue #1409: THRIFT-4378: add set method for stopTimeoutUnit in TThre...

Github user itegel commented on the issue: https://github.com/apache/thrift/pull/1409 I checked the tests, and find nothing to fix. For old version, it is hard coded the time unit to SECONDS and for default args.stopTimeoutUnit is set to TimeUnit.SECONDS. So it has not change the

[jira] [Commented] (THRIFT-4378) add set stopTimeoutUnit method to TThreadPoolServer

[ https://issues.apache.org/jira/browse/THRIFT-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226129#comment-16226129 ] ASF GitHub Bot commented on THRIFT-4378: Github user itegel commented on the issue:

[GitHub] thrift issue #1409: THRIFT-4378: add set method for stopTimeoutUnit in TThre...

Github user itegel commented on the issue: https://github.com/apache/thrift/pull/1409 Thank you! You are right ! It only works on line 218 and that is almost useless. I will try to fix what you suggested soon. ---

[jira] [Commented] (THRIFT-4379) Haxe "make check" requires "sleep 10" to complete

[ https://issues.apache.org/jira/browse/THRIFT-4379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226066#comment-16226066 ] Jens Geyer commented on THRIFT-4379: In theory we could add a server call to the ThriftTest API to

[jira] [Commented] (THRIFT-4377) haxe. socket handles leak in TSimpleServer

[ https://issues.apache.org/jira/browse/THRIFT-4377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16225576#comment-16225576 ] James E. King, III commented on THRIFT-4377: I committed the extra 2 commits that were

[jira] [Commented] (THRIFT-4377) haxe. socket handles leak in TSimpleServer

[ https://issues.apache.org/jira/browse/THRIFT-4377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16225577#comment-16225577 ] ASF GitHub Bot commented on THRIFT-4377: Github user asfgit closed the pull request at:

[jira] [Commented] (THRIFT-3773) Swift Library

[ https://issues.apache.org/jira/browse/THRIFT-3773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16225525#comment-16225525 ] ASF GitHub Bot commented on THRIFT-3773: Github user apocolipse commented on the issue:

[GitHub] thrift issue #1084: THRIFT-3773 Swift 3 Native Library

Github user apocolipse commented on the issue: https://github.com/apache/thrift/pull/1084 @nsuke requested cleanup completed ---

[jira] [Commented] (THRIFT-4379) Haxe "make check" requires "sleep 10" to complete

[ https://issues.apache.org/jira/browse/THRIFT-4379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16225499#comment-16225499 ] Oleksii Prudkyi commented on THRIFT-4379: - Hi, The sleep was added to ensure the server is

[jira] [Created] (THRIFT-4379) Haxe "make check" requires "sleep 10" to complete

James E. King, III created THRIFT-4379: -- Summary: Haxe "make check" requires "sleep 10" to complete Key: THRIFT-4379 URL: https://issues.apache.org/jira/browse/THRIFT-4379 Project: Thrift

[jira] [Commented] (THRIFT-4377) haxe. socket handles leak in TSimpleServer

[ https://issues.apache.org/jira/browse/THRIFT-4377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16225276#comment-16225276 ] ASF GitHub Bot commented on THRIFT-4377: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1407: THRIFT-4377: close socket after processing request

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1407 I wonder if this is why sleep 10 is needed between haxe tests and whether that could be improved now? I'll apply the other ones and see. :) ---

[jira] [Commented] (THRIFT-4377) haxe. socket handles leak in TSimpleServer

[ https://issues.apache.org/jira/browse/THRIFT-4377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16225147#comment-16225147 ] ASF GitHub Bot commented on THRIFT-4377: Github user oprudkyi commented on the issue:

[GitHub] thrift issue #1407: THRIFT-4377: close socket after processing request

Github user oprudkyi commented on the issue: https://github.com/apache/thrift/pull/1407 @jeking3 , Sorry, there was my fault - haxe php integration was broken by first commit and I added fixes ---

[jira] [Commented] (THRIFT-4366) upgrade thrift lib to 0.10 ,coredump at readMessageBegin

[ https://issues.apache.org/jira/browse/THRIFT-4366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224795#comment-16224795 ] xiaomingzhongguo commented on THRIFT-4366: -- i rollback to 0.93 ,it can work normal ,but i want

[jira] [Commented] (THRIFT-4377) haxe. socket handles leak in TSimpleServer

[ https://issues.apache.org/jira/browse/THRIFT-4377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224716#comment-16224716 ] ASF GitHub Bot commented on THRIFT-4377: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1407: THRIFT-4377: close socket after processing request

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1407 @Jens-G I see only one of the three commits here committed in master? ---

[jira] [Commented] (THRIFT-4378) add set stopTimeoutUnit method to TThreadPoolServer

[ https://issues.apache.org/jira/browse/THRIFT-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224714#comment-16224714 ] ASF GitHub Bot commented on THRIFT-4378: GitHub user itegel opened a pull request:

[GitHub] thrift pull request #1409: THRIFT-4378: add set method for stopTimeoutUnit i...

GitHub user itegel opened a pull request: https://github.com/apache/thrift/pull/1409 THRIFT-4378: add set method for stopTimeoutUnit in TThreadPoolServer java lib You can merge this pull request into a Git repository by running: $ git pull https://github.com/itegel/thrift

[jira] [Commented] (THRIFT-4378) add set stopTimeoutUnit method to TThreadPoolServer

[ https://issues.apache.org/jira/browse/THRIFT-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224656#comment-16224656 ] ASF GitHub Bot commented on THRIFT-4378: Github user itegel closed the pull request at:

[GitHub] thrift pull request #1408: THRIFT-4378: add stopTimeoutUnit set method

Github user itegel closed the pull request at: https://github.com/apache/thrift/pull/1408 ---

[GitHub] thrift pull request #1408: THRIFT-4378: add stopTimeoutUnit set method

GitHub user itegel opened a pull request: https://github.com/apache/thrift/pull/1408 THRIFT-4378: add stopTimeoutUnit set method add set method for stopTimeoutUnit to TThreadPoolServer, in java lib You can merge this pull request into a Git repository by running: $ git pull

[jira] [Commented] (THRIFT-4378) add set stopTimeoutUnit method to TThreadPoolServer

[ https://issues.apache.org/jira/browse/THRIFT-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224629#comment-16224629 ] ASF GitHub Bot commented on THRIFT-4378: GitHub user itegel opened a pull request:

[jira] [Created] (THRIFT-4378) add set stopTimeoutUnit method to TThreadPoolServer

itegel bao created THRIFT-4378: -- Summary: add set stopTimeoutUnit method to TThreadPoolServer Key: THRIFT-4378 URL: https://issues.apache.org/jira/browse/THRIFT-4378 Project: Thrift Issue Type: