Github user erikvanoosten commented on the issue:
https://github.com/apache/thrift/pull/1036
The specification documents are up at
https://erikvanoosten.github.io/thrift-missing-specification/.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user erikvanoosten commented on the issue:
https://github.com/apache/thrift/pull/1036
The feedback cycle took more then a month. This is too long for me. I do
not have the mental capacity to keep work in my head for that long.
Kind regards,
Erik
Github user erikvanoosten commented on the issue:
https://github.com/apache/thrift/pull/1036
Feel free to take it. I won't support it anymore though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user erikvanoosten commented on the issue:
https://github.com/apache/thrift/pull/1036
Closing this due to lack of interest of repo owners.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user erikvanoosten closed the pull request at:
https://github.com/apache/thrift/pull/1036
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user erikvanoosten commented on the issue:
https://github.com/apache/thrift/pull/1036
All, @Jens-G, this documentation is ready for another review. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user erikvanoosten commented on the issue:
https://github.com/apache/thrift/pull/1036
Note: last commit is still work in progress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user erikvanoosten commented on the issue:
https://github.com/apache/thrift/pull/1036
@Jens-G wrote:
> The Thrift compiler prevents the combination of oneway plus throws right
from the start since March 2003, any types other than void are disallowed since
THRIFT-2030.
Github user erikvanoosten commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1036#discussion_r69621679
--- Diff: doc/specs/thrift-binary-protocol-encoding.md ---
@@ -0,0 +1,467 @@
+Thrift Protocol Encoding for BinaryProtocol and CompactProtocol
Github user erikvanoosten commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1036#discussion_r69621170
--- Diff: doc/specs/thrift-binary-protocol-encoding.md ---
@@ -0,0 +1,467 @@
+Thrift Protocol Encoding for BinaryProtocol and CompactProtocol
Github user erikvanoosten commented on the issue:
https://github.com/apache/thrift/pull/1036
Thanks @Jens-G . That's all useful feedback. Next week I have time to work
on it further.
Regarding structure: it took me weeks to collect all this information and
create
GitHub user erikvanoosten opened a pull request:
https://github.com/apache/thrift/pull/1036
THRIFT-3867 Specify BinaryProtocol and CompactProtocol
First version of a specification of the binary protocol and compact
protocol. Please review and comment.
You can merge this pull
12 matches
Mail list logo
