[GitHub] thrift pull request #1524: THRIFT-4535: XML docs; code cleanup (tabs->spaces...

2018-04-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1524 ---

[GitHub] thrift pull request #1524: THRIFT-4535: XML docs; code cleanup (tabs->spaces...

2018-03-31 Thread cwe1ss
Github user cwe1ss commented on a diff in the pull request: https://github.com/apache/thrift/pull/1524#discussion_r178431239 --- Diff: lib/csharp/src/Protocol/TCompactProtocol.cs --- @@ -7,7 +7,7 @@ * "License"); you may not use this file except in compliance * with the

[GitHub] thrift pull request #1524: THRIFT-4535: XML docs; code cleanup (tabs->spaces...

2018-03-31 Thread Jens-G
Github user Jens-G commented on a diff in the pull request: https://github.com/apache/thrift/pull/1524#discussion_r178426941 --- Diff: lib/csharp/src/Protocol/TCompactProtocol.cs --- @@ -7,7 +7,7 @@ * "License"); you may not use this file except in compliance * with the

[GitHub] thrift pull request #1524: THRIFT-4535: XML docs; code cleanup (tabs->spaces...

2018-03-30 Thread cwe1ss
GitHub user cwe1ss opened a pull request: https://github.com/apache/thrift/pull/1524 THRIFT-4535: XML docs; code cleanup (tabs->spaces; String->string) As discussed in [THRIFT-4535](https://issues.apache.org/jira/browse/THRIFT-4535) we'd like to go back to just one .NET library